Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed fixes 1.13 #1495

Closed
wants to merge 46 commits into from
Closed

Proposed fixes 1.13 #1495

wants to merge 46 commits into from

Conversation

javiercantero
Copy link
Contributor

@javiercantero javiercantero commented Sep 26, 2016

This is a compilation of 19 pending pull requests by 18 contributors to
be applied to the lastest version of chrippa's develop branch (commit
ab80dbd on 2 Feb 2016) in order to fix 14 plugins of livestreamer. It
neither includes new code nor new plugins, only fixes to existing
plugins.

mindhalt and others added 30 commits September 26, 2016 17:11
- The validation changes in #1126 aren't strict enough, there are now
  more than 1 unexpected streams that we can't read, and they do not all
  contain the varnishUrl key.
Livestreamer wouldn't recognise the Periscope url, because the url schema has changed.
NRK has done some changes to their streaming services which broke the
plugin. Playlist URL is now fetched via an API call, whose URL is
embedded in the webpage.
Also removed unused _program_id regex.
- Make use of new API while keeping the old method as backup
use new api
@sbstp
Copy link
Contributor

sbstp commented Sep 29, 2016

@javiercantero could you open this PR in streamlink? We'd be happy to take those fixes.

@javiercantero
Copy link
Contributor Author

javiercantero commented Sep 29, 2016

@sbstp Seems that the GitHub interface doesn't allow me to create a PR from my repo to the streamlink repo.

Edit: the problem is that the streamlink repository is not listed as a fork of livestreamer. Have you guys pushed it directly from a local git repo instead of using the GH fork button?

@Erk-
Copy link

Erk- commented Sep 30, 2016

@javiercantero
Copy link
Contributor Author

@Erk- Finally I've done it by forking the streamlink repository and using the forked repo as a proxy.

But there is a serious divergence between the streamlink branch (based on chrippa's master branch) and mine (based on chrippa's develop branch). And try to merge these branches is going to be a PITA /cc @sbstp

@vadosnaprimer
Copy link

Can you post a build in case this will never be seen by the author?

@javiercantero
Copy link
Contributor Author

@vadosnaprimer A build like executables for Win/Mac? I can't, I don't use any of those environments.

@mjbcopland
Copy link

Running win32/build-with-bootstrap.sh produces the following build:

If you're not on Windows, I believe you should be able to build and install yourself using python setup.py install.

kapetanos added a commit to Flipnode-LLC/livestreamer that referenced this pull request Oct 20, 2016
kapetanos added a commit to Flipnode-LLC/livestreamer that referenced this pull request Oct 20, 2016
@Kiingy
Copy link

Kiingy commented Dec 6, 2016

Sorry for being a noob, but can anyone tell me how I install these fixes?

@Erk-
Copy link

Erk- commented Dec 6, 2016

@NuMs1 You should look at Streamlink which is a fork of livestreamer.

@javiercantero
Copy link
Contributor Author

javiercantero commented Dec 7, 2016

@NuMs1 If you are asking about using it in Windows, in the @mjbcopland's message just above your comment there is a build ready to install. But as @Erk- has pointed out, it's better if you use the new project Streamlink since it's maintained.

@msikma
Copy link

msikma commented Dec 17, 2016

Unfortunately vaughnlive is still broken, despite an effort to fix it. I'll try to have a look at it later. It claims the following:

[cli][info] Found matching plugin vaughnlive for URL <url>
error: Unable to validate response text: Minimum length is 3 but value is 1

edit: It seems that more research is needed to get an appropriate response from the server to fix this. It seems to make an appropriate call but then somewhere in the plugin it makes an HTTP call that has an empty body and response 200. That's where it breaks, since it expects a body with more required data.

edit 2: turns out it's a super quick fix. In src/livestreamer/plugins/vaughnlive.py:

  • change INFO_URL to "http://mvn.vaughnsoft.net/video/edge/mnt-{domain}_{channel}?{version}_{ms}-{ms}-{random}"
  • optionally, add one line to the _url_re to make it the following:
_url_re = re.compile("""
    http(s)?://(\w+\.)?
    (?P<domain>vaughnlive|breakers|instagib|vapers).tv
    (/embed/video)?
    /(?P<channel>[^/&?]+)
 """, re.VERBOSE)

This allows URLs from embeds to work as well.

This is a quick fix to get vaughnlive working again. The seem to continuously change the first few letters in minor ways to throw streaming software off.

@bozhodimitrov
Copy link

Request for closing this one. Seems to be a leftover.

@javiercantero
Copy link
Contributor Author

Ok. @int3l, closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment