Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab autocomplete, auto-quoting paths doesn't seem to work as in Clink 0.4.9 #33

Closed
tsimmons opened this issue Dec 21, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@tsimmons
Copy link

Not sure if this is by design or not, but one thing about the clink 0.4.9 I found immensely convenient was the tab autocomplete auto-quoting that seemed to happen but appears missing in your v1.1.11.

For example, while using 0.4.9, typing

C:\Users\username> cd \program

Followed by the TAB key results in the following change:

C:\Users\username> cd "\Program

Note the inserting the opening quote symbol. This now allows you to type a space character and hit TAB again to reveal paths that match.

However, using your v1.1.11 and typing

C:\Users\username> cd \program

Followed by the TAB key doesn't quote and typing space also doesn't autofill paths with spaces.

In addition, using your version and typing

C:\Users\username> cd \program(space)fi

Followed by the TAB key doesn't autofill matching paths.

Am I missing something?

@chrisant996 chrisant996 added the investigation needed Deeper investigation is needed label Dec 23, 2020
@chrisant996
Copy link
Owner

chrisant996 commented Dec 23, 2020

I see. menu-complete had a problem with too much quoting. Fixing that problem accidentally introduced this problem.

UPDATE: Oh, it turns out actually this is just how Readline works. git-bash behaves the same way. The difference is that Clink used to have two match completion systems and sometimes it used its own internal one, and sometimes it used Readline, but now Clink always uses Readline.

I'll do something about this. I agree that it would be much better (on Windows, at least) to insert a quote character when using complete if any of the matches may require a quote. Because on Windows you can't use \ (backslash, space) to quote spaces, so it's very cumbersome to massage the input so that completion can continue to work after typing a space -- whereas on *nix you'd just type \ and not need to quote it at all.

@chrisant996 chrisant996 added bug Something isn't working and removed investigation needed Deeper investigation is needed labels Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants