Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message with /e:off (again) #570

Closed
Gei0r opened this issue Mar 4, 2024 · 5 comments
Closed

Error message with /e:off (again) #570

Gei0r opened this issue Mar 4, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@Gei0r
Copy link

Gei0r commented Mar 4, 2024

Hi, thanks for fixing #569 so quickly. With the new version 1.6.6.87eebc, the command with /e:off is run sucessfully, however an error message is printed:

$ cmd.exe /e:off /c "echo a"
Das Sprungziel - eof wurde nicht gefunden.
a

"The jump destination - eof was not found"

@Gei0r
Copy link
Author

Gei0r commented Mar 4, 2024

Adding a line:

:eof

At the end of clink.bat seems to fix this.

@chrisant996
Copy link
Owner

Can I ask, what is the reason for turning off command extensions? It seems like a lot of things will break.

Anyway, I'll look into it. But I'm surprised that I didn't encounter that problem when I tested the first fix.

@Gei0r
Copy link
Author

Gei0r commented Mar 4, 2024

Can I ask, what is the reason for turning off command extensions? It seems like a lot of things will break.

Unfortunately I don't know. It's in some old codebase I inherited. The commit introducing this line is from 2006 and doesn't have a message or comment.

@chrisant996
Copy link
Owner

  • exit /b requires command extensions, even though that isn't documented anywhere.
  • cd /d requires command extensions.

I've updated Clink accordingly, but avoiding cd /d is a little messy and inconsistent in Clink (e.g. the user in #333 will have to update their custom script).

I've updated the clink-gizmos and clink-fzf repos accordingly as well to avoid cd /d.

@chrisant996 chrisant996 added the bug Something isn't working label Mar 4, 2024
@chrisant996
Copy link
Owner

Fixed by 8251455.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants