Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network architecture diagram does not match the implementation code #32

Open
virtualRooom opened this issue Jul 6, 2020 · 1 comment

Comments

@virtualRooom
Copy link

Hi chrischoy, @chrischoy

Nice work and thank you for sharing the code.

I have a question about the implementation of ResUNet2. In my opinion, the forward() function of ResUNet2 should look like:

def forward(self, x): 
   out_s1 = self.conv1(x) 
   out_s1 = self.norm1(out_s1) 
   out_s1 = MEF.relu(out_s1)
   out= self.block1(out_s1) 
   ...

As shown in the ResUNet architecture in the paper:
image

However, your implement of ResUNet2 feed output of residual block to 3D ConvTr, and activate feature map twice using ReLU(one in self.block, one in MEF.relu). Is there a problem here, or am I missing something?

FCGF/model/resunet.py

Lines 142 to 147 in 458549e

def forward(self, x):
out_s1 = self.conv1(x)
out_s1 = self.norm1(out_s1)
out_s1 = self.block1(out_s1)
out = MEF.relu(out_s1)

@chrischoy
Copy link
Owner

Yes, your first model was the one that I tried first and experimentally, I found that the current model works better.

The diagram might not match the implementation as we tried various models in the camera ready and used the one variation that worked best. Sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants