Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain degenerate stadia better #44

Closed
moorepants opened this issue Feb 9, 2015 · 4 comments · Fixed by #66
Closed

Explain degenerate stadia better #44

moorepants opened this issue Feb 9, 2015 · 4 comments · Fixed by #66
Assignees
@chrisdembia
Milestone
Version 2

Comments

@moorepants
Copy link
Collaborator

From reviewer 2:

"Degenerate Stadia": What are the manipulations? Please detail.
@moorepants moorepants modified the milestone: Version 2 Feb 9, 2015
@chrisdembia chrisdembia self-assigned this Feb 23, 2015
@chrisdembia
Copy link
Owner

When we were working on the manuscript, I was going to detail this calculation but I couldn't understand the code so I decided to leave the text vague...hehe. K i'll try to figure out the code again.

@chrisdembia chrisdembia mentioned this issue Mar 2, 2015
Merged
@chrisdembia
Copy link
Owner

This might take some time.

@moorepants
Copy link
Collaborator Author

Wasn't is that you throw an error if incompatible dimensions are given?

@chrisdembia chrisdembia mentioned this issue Mar 2, 2015
Merged
@chrisdembia
Copy link
Owner

Wasn't is that you throw an error if incompatible dimensions are given?

Yes, errors are thrown in this case. However, this issue is not about incompatible dimensions. It's about compatible dimensions that cause degenerate stadia, which are fine; they just cause divide-by-zero errors that can be avoided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisdembia chrisdembia

Labels
None yet
Projects
None yet
Milestone
Version 2
Development

Successfully merging a pull request may close this issue.

Give some description about degenerate stadia manipulations. chrisdembia/python-yeadon-paper
2 participants
@moorepants @chrisdembia