Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give some description about degenerate stadia manipulations. #66

Merged
merged 3 commits into from Mar 2, 2015

Conversation

chrisdembia
Copy link
Owner

Fixes #44.

stadia for a solid has zero thickness, the divide-by-zero issue is
removed by computing the mass properties for the stadium solid in which
the two stadia are swapped. However, this manipulation does not work if
both stadia have zero thickness; for this case, we refer you to the code.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this will fly.

Is the code some crazy stuff? Why isn't an error thrown?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay to have zero-thickness. For example, both stadia having zero thickness is a truncated cone. We should support that. So I don't think we should throw an error.

The description of the manipulations is here: https://github.com/chrisdembia/yeadon/blob/master/yeadon/solid.py#L397

I'd have to give a lot of background in the paper to actually describe the manipulation.

I'll clarify that the degeneracy is fine to have though.

divide-by-zero issue is removed by computing the mass properties for the
stadium solid in which the two stadia are swapped. However, this
manipulation does not work if both stadia have zero thickness; for this
case, we refer you to the code.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be: "for this case we compute the inertial properties of a truncated cone, see the code for details."?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that!

@chrisdembia
Copy link
Owner Author

Updated.

@moorepants
Copy link
Collaborator

+1

moorepants added a commit that referenced this pull request Mar 2, 2015
Give some description about degenerate stadia manipulations.
@moorepants moorepants merged commit c4ac4fe into master Mar 2, 2015
@chrisdembia chrisdembia deleted the issue-44 branch March 2, 2015 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain degenerate stadia better
2 participants