New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give some description about degenerate stadia manipulations. #66
Conversation
stadia for a solid has zero thickness, the divide-by-zero issue is | ||
removed by computing the mass properties for the stadium solid in which | ||
the two stadia are swapped. However, this manipulation does not work if | ||
both stadia have zero thickness; for this case, we refer you to the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this will fly.
Is the code some crazy stuff? Why isn't an error thrown?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's okay to have zero-thickness. For example, both stadia having zero thickness is a truncated cone. We should support that. So I don't think we should throw an error.
The description of the manipulations is here: https://github.com/chrisdembia/yeadon/blob/master/yeadon/solid.py#L397
I'd have to give a lot of background in the paper to actually describe the manipulation.
I'll clarify that the degeneracy is fine to have though.
divide-by-zero issue is removed by computing the mass properties for the | ||
stadium solid in which the two stadia are swapped. However, this | ||
manipulation does not work if both stadia have zero thickness; for this | ||
case, we refer you to the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be: "for this case we compute the inertial properties of a truncated cone, see the code for details."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that!
Updated. |
+1 |
Give some description about degenerate stadia manipulations.
Fixes #44.