Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github actions to new versions and runon Python 3.8+. #138

Merged
merged 9 commits into from
Jun 6, 2024

Conversation

moorepants
Copy link
Collaborator

No description provided.

@moorepants
Copy link
Collaborator Author

nosetests fails with Python 3.12:

Traceback (most recent call last):
  File "/home/runner/miniconda3/envs/yeadon-dev/bin/nosetests", line 6, in <module>
    from nose import run_exit
  File "/home/runner/miniconda3/envs/yeadon-dev/lib/python3.12/site-packages/nose/__init__.py", line 1, in <module>
    from nose.core import collector, main, run, run_exit, runmodule
  File "/home/runner/miniconda3/envs/yeadon-dev/lib/python3.12/site-packages/nose/core.py", line 12, in <module>
    from nose.loader import defaultTestLoader
  File "/home/runner/miniconda3/envs/yeadon-dev/lib/python3.12/site-packages/nose/loader.py", line 21, in <module>
    from nose.importer import Importer, add_path, remove_path
  File "/home/runner/miniconda3/envs/yeadon-dev/lib/python3.12/site-packages/nose/importer.py", line 12, in <module>
    from imp import find_module, load_module, acquire_lock, release_lock
ModuleNotFoundError: No module named 'imp'
Error: Process completed with exit code 1.

Should probably switch to pytest, since nose is dead.

@moorepants
Copy link
Collaborator Author

pytest errors:

(yeadon-dev) moorepants@nandi:yeadon(new-dep-versions)$ pytest yeadon
==================================================================================== test session starts =====================================================================================
platform linux -- Python 3.12.3, pytest-8.2.2, pluggy-1.5.0
rootdir: /home/moorepants/src/yeadon
collected 17 items / 2 errors                                                                                                                                                                

=========================================================================================== ERRORS ===========================================================================================
________________________________________________________________________ ERROR collecting yeadon/tests/test_human.py _________________________________________________________________________
ImportError while importing test module '/home/moorepants/src/yeadon/yeadon/tests/test_human.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../miniconda/envs/yeadon-dev/lib/python3.12/importlib/__init__.py:90: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
yeadon/tests/test_human.py:9: in <module>
    import nose
../../miniconda/envs/yeadon-dev/lib/python3.12/site-packages/nose/__init__.py:1: in <module>
    from nose.core import collector, main, run, run_exit, runmodule
../../miniconda/envs/yeadon-dev/lib/python3.12/site-packages/nose/core.py:12: in <module>
    from nose.loader import defaultTestLoader
../../miniconda/envs/yeadon-dev/lib/python3.12/site-packages/nose/loader.py:21: in <module>
    from nose.importer import Importer, add_path, remove_path
../../miniconda/envs/yeadon-dev/lib/python3.12/site-packages/nose/importer.py:12: in <module>
    from imp import find_module, load_module, acquire_lock, release_lock
E   ModuleNotFoundError: No module named 'imp'
________________________________________________________________________ ERROR collecting yeadon/tests/test_solid.py _________________________________________________________________________
../../miniconda/envs/yeadon-dev/lib/python3.12/site-packages/_pytest/runner.py:341: in from_call
    result: Optional[TResult] = func()
../../miniconda/envs/yeadon-dev/lib/python3.12/site-packages/_pytest/runner.py:389: in collect
    return list(collector.collect())
../../miniconda/envs/yeadon-dev/lib/python3.12/site-packages/_pytest/unittest.py:90: in collect
    self.session._fixturemanager.parsefactories(self.newinstance(), self.nodeid)
../../miniconda/envs/yeadon-dev/lib/python3.12/site-packages/_pytest/unittest.py:75: in newinstance
    return self.obj("runTest")
E   TypeError: StadiumSolidCheck.__init__() missing 5 required positional arguments: 'thick0', 'rad0', 'thick1', 'rad1', and 'height'
====================================================================================== warnings summary ======================================================================================
../../miniconda/envs/yeadon-dev/lib/python3.12/site-packages/nose/plugins/manager.py:418
  /home/moorepants/miniconda/envs/yeadon-dev/lib/python3.12/site-packages/nose/plugins/manager.py:418: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
    import pkg_resources

../../miniconda/envs/yeadon-dev/lib/python3.12/site-packages/pkg_resources/__init__.py:2825
  /home/moorepants/miniconda/envs/yeadon-dev/lib/python3.12/site-packages/pkg_resources/__init__.py:2825: DeprecationWarning: Deprecated call to `pkg_resources.declare_namespace('sphinxcontrib')`.
  Implementing implicit namespace packages (as specified in PEP 420) is preferred to `pkg_resources.declare_namespace`. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages
    declare_namespace(pkg)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================================================================== short test summary info ===================================================================================
ERROR yeadon/tests/test_human.py
ERROR yeadon/tests/test_solid.py::StadiumSolidCheck - TypeError: StadiumSolidCheck.__init__() missing 5 required positional arguments: 'thick0', 'rad0', 'thick1', 'rad1', and 'height'
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 2 errors during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
=============================================================================== 2 warnings, 2 errors in 0.81s ================================================================================

@moorepants moorepants merged commit 41eb414 into chrisdembia:master Jun 6, 2024
5 checks passed
@moorepants moorepants deleted the new-dep-versions branch June 6, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant