Only allow datejs to run once #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if datejs runs twice, then it executes the following twice
Date.prototype._toString = Date.prototype.toString
This can cause terrifying recursion that you will end up spending a full
day debugging.
chrisdew
added a commit
that referenced
this pull request
Jul 30, 2012
Only allow datejs to run once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If datejs runs twice, then it executes the following twice:
This can cause terrifying recursion that you will end up spending half a day debugging it. Only to realize the solution you spent hours implementing was incorrect and spend the rest of the day debugging.
If you could fix and publish to npm, that would just tickle me silly.
http://i.imgur.com/lFnRA.gif