Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.9.0b5 #12

Merged
merged 62 commits into from
Jul 18, 2019
Merged

Release v0.9.0b5 #12

merged 62 commits into from
Jul 18, 2019

Conversation

chrisjsewell
Copy link
Member

No description provided.

`Symmetrise3DStructure` now accepts a settings `Dict` containing the settings data. This is validated against a jsonschema.

- kind names can also now be reset
- add exit codes
- add addational tests
- update documentation
`to_aiida_type` was fixed for `Dict`, after the v1.0.0b3 release
- Change `include_calculation_intputs` - > `include_process_intputs`, and
 `include_calculation_outputs` - > `include_process_outputs`
- include link_pair in edge set, so that multiple (unique) links can exist between nodes
- add sublabel for Str, Bool and UpfData
- add global_edge_style
- color excepted processes red
…orkChain` (#9)

Before the calculations were running from `runcry17`, which is a bash script that copies the files to/from a temporary folder and changes the names of the files. This functionality should all be handled by other parts of the AiiDA machinery, so running from the base binary is more appropriate, and allows for more functionality.

Additionally:

- added restart functionality to `CryMainCalculation` (*via* a fort.9 in a remote folder)
- added checks and error codes for PbsPro messages to `_scheduler_stderr.txt` (e.g. walltime limit reached)
- allow SHRINK IS input to be a list ([IS1, IS2, IS3])
- added output of `TrajectoryData` of optimisation steps for `CryMainCalculation`
- added `CryMainBaseWorkChain` (a replica of `PwBaseWorkChain`  from `aiida-quanumespresso`)
- improved testing infrastructure
- updated documentation
All potentials should share the a common jsonschema

Also added reaxff tests, and initial implementation of fitting calculation
…alculation submission)

Then we don't have to rely on the external modules being there at calculation time.
Also change potential keys from `id1.id2` to `id1-id2` (since AiiDa doesn't allow attributes with '.'s)
- The input file is no streamed to `gulp` via stdin and outputs are captured from stdout and stderr.
- Single/Opt raw parser rewrote, to be inline with fitting parser
- Exit codes updated and added
- stderr file read and added to 'warnings' key of results
- added dump file to fitting output
- made calculation have data_regression checks
Re-work GULP calculations (and tests) and add `gulp.fitting`
Sometimes values can be output as *'s (presumably if they are too large)
also:

- sort output of basis sets (by element) in crystal INPUT file
- moved/re-computed doss/fermi raw test files
- added environmental variable to run test computations in non-tempdir
- doc string improvements
This builds and improves on the original ejplugins implementation:
making the parsing flow more easy to understand,
adding additional data parsing (some taken from tilde),
and restructuring the output json
@coveralls
Copy link

coveralls commented Jul 18, 2019

Pull Request Test Coverage Report for Build 583

  • 3985 of 4564 (87.31%) changed or added relevant lines in 94 files are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+3.5%) to 87.363%

Changes Missing Coverage Covered Lines Changed/Added Lines %
aiida_crystal17/calculations/cry_abstract.py 27 28 96.43%
aiida_crystal17/calculations/cry_fermi.py 25 26 96.15%
aiida_crystal17/cmndline/symmetry.py 3 4 75.0%
aiida_crystal17/gulp/calculations/gulp_abstract.py 13 14 92.86%
aiida_crystal17/gulp/potentials/common.py 15 16 93.75%
aiida_crystal17/tests/init.py 32 33 96.97%
aiida_crystal17/tests/test_calcfunctions/test_band_gap.py 64 65 98.46%
aiida_crystal17/tests/test_gulp/test_parsers/test_parse_main.py 26 27 96.3%
aiida_crystal17/tests/test_workflows/test_crystal_main.py 63 64 98.44%
aiida_crystal17/common/kpoints.py 13 15 86.67%
Files with Coverage Reduction New Missed Lines %
aiida_crystal17/data/basis_set.py 1 82.71%
aiida_crystal17/gulp/calculations/gulp_abstract.py 1 96.15%
aiida_crystal17/workflows/symmetrise_3d_struct.py 2 82.73%
aiida_crystal17/parsers/raw/main_out.py 4 86.99%
Totals Coverage Status
Change from base Build 454: 3.5%
Covered Lines: 6063
Relevant Lines: 6940

💛 - Coveralls

@chrisjsewell chrisjsewell merged commit 3a879a7 into master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants