-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Add support for Python 3.12 #41
⬆️ Add support for Python 3.12 #41
Conversation
The `distutils` package was removed. The implmentation of the `str2bool` function is copied over. The `pkg_resources` package was also removed and is replaced with `importlib.metadata`. This was finalized in Python 3.10 so for older version the backport `importlib-metadata` is installed.
f292c08
to
7882ded
Compare
The older version fails during install for newer versions of poetry.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix for the older python versions thanks!
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers!
Thanks @chrisjsewell would it be possible to make a release? |
The
distutils
package was removed. The implmentation of thestrtobool
function is copied over. Thepkg_resources
package was also removed and is replaced withimportlib.metadata
. This was finalized in Python 3.10 so for older version the backportimportlib-metadata
is installed.