Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Add support for Python 3.12 #41

Merged
merged 9 commits into from
Nov 12, 2023

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Oct 26, 2023

The distutils package was removed. The implmentation of the strtobool function is copied over. The pkg_resources package was also removed and is replaced with importlib.metadata. This was finalized in Python 3.10 so for older version the backport importlib-metadata is installed.

The `distutils` package was removed. The implmentation of the `str2bool`
function is copied over. The `pkg_resources` package was also removed
and is replaced with `importlib.metadata`. This was finalized in Python
3.10 so for older version the backport `importlib-metadata` is
installed.
Copy link
Owner

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix for the older python versions thanks!

@sphuber
Copy link
Contributor Author

sphuber commented Nov 12, 2023

Can you fix for the older python versions thanks!

Done

Copy link
Owner

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@chrisjsewell chrisjsewell changed the title Dependencies: Add support for Python 3.12 ⬆️ Add support for Python 3.12 Nov 12, 2023
@chrisjsewell chrisjsewell merged commit e69fcda into chrisjsewell:master Nov 12, 2023
10 checks passed
@sphuber sphuber deleted the feature/python-3.12 branch November 12, 2023 13:33
@sphuber
Copy link
Contributor Author

sphuber commented Nov 12, 2023

Thanks @chrisjsewell would it be possible to make a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants