fix: add numpy as a possible prefix
#31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously number_transformer.MathExpressionTransformer required the user to provide an operator string as `np.xxx` if they wanted to use an operator from NumPy. Using `numpy.xxx` would raise an AtrributeError. This commit fixes it, by adding support for the full name `numpy`.
Codecov Report
@@ Coverage Diff @@
## develop #31 +/- ##
===========================================
+ Coverage 99.17% 99.28% +0.11%
===========================================
Files 8 8
Lines 363 419 +56
===========================================
+ Hits 360 416 +56
Misses 3 3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
chrislemke
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously number_transformer.MathExpressionTransformer required the user to provide an operator string as
np.xxxif they wanted to use an operator from NumPy. Usingnumpy.xxxwould raise an AtrributeError. This commit fixes it, by adding support for the full namenumpy.