Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add new project logo #32

Merged
merged 4 commits into from
Jan 6, 2023
Merged

docs: add new project logo #32

merged 4 commits into from
Jan 6, 2023

Conversation

premsrii
Copy link
Collaborator

@premsrii premsrii commented Jan 6, 2023

No description provided.

@premsrii premsrii marked this pull request as ready for review January 6, 2023 15:02
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #32 (5d44c1f) into develop (5bd25f5) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop      #32      +/-   ##
===========================================
+ Coverage    99.17%   99.28%   +0.11%     
===========================================
  Files            8        8              
  Lines          363      419      +56     
===========================================
+ Hits           360      416      +56     
  Misses           3        3              
Impacted Files Coverage Δ
src/sk_transformers/base_transformer.py 100.00% <ø> (ø)
src/sk_transformers/datetime_transformer.py 100.00% <ø> (ø)
src/sk_transformers/encoder_transformer.py 100.00% <ø> (ø)
src/sk_transformers/utils.py 100.00% <ø> (ø)
src/sk_transformers/deep_transformer.py 100.00% <100.00%> (ø)
src/sk_transformers/generic_transformer.py 99.18% <100.00%> (ø)
src/sk_transformers/number_transformer.py 100.00% <100.00%> (ø)
src/sk_transformers/string_transformer.py 98.23% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Owner

@chrislemke chrislemke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor things:

  1. No need to call the new file icon_new. Just overwrite the other. We don't want to accumulate images in our project, right?
  2. Unfortunately the eyes of the new logo have also a transparent part. When the background is black it would look strange.
  3. Very nice idea! I like it!!!

@premsrii premsrii merged commit 93e277b into develop Jan 6, 2023
@premsrii premsrii deleted the new_icon branch January 6, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants