promote to go:embed instead of github.com/rakyll/statik #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bingoohuang
commented
Apr 27, 2021
bingoohuang
commented
- use go1.16 go:embed instead of github.com/rakyll/statik
- remove statik dependency
chrislusf
added a commit
that referenced
this pull request
Apr 27, 2021
chrislusf
added a commit
that referenced
this pull request
Apr 30, 2021
Need to revert because docker image build failed. The docker apk package only has go 1.15.
mirdhyn
pushed a commit
to ueni-ltd/seaweedfs
that referenced
this pull request
May 3, 2021
mirdhyn
pushed a commit
to ueni-ltd/seaweedfs
that referenced
this pull request
May 3, 2021
Need to revert because docker image build failed. The docker apk package only has go 1.15.
chrislusf
added a commit
that referenced
this pull request
May 10, 2021
This reverts commit d74cdf0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.