Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix class-based cluster representative sampling #88

Closed
atroyn opened this issue Nov 25, 2022 · 1 comment
Closed

Fix class-based cluster representative sampling #88

atroyn opened this issue Nov 25, 2022 · 1 comment
Assignees

Comments

@atroyn
Copy link
Contributor

atroyn commented Nov 25, 2022

#87 introduces the core algorithms, but representative sampling using class labels is currently broken.

This is probably because hnswlib filtering doesn't let us get a connected graph, and so ANN search fails. We should understand how / when this fails. There are possibly easy fixes, i.e. generating a separate index per dataset per class, or increasing the edge factor, but the real solution is to understand how to use hnsw properly in our context.

@atroyn atroyn self-assigned this Nov 25, 2022
@atroyn atroyn mentioned this issue Nov 25, 2022
4 tasks
@jeffchuber
Copy link
Contributor

Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants