generated from storybookjs/addon-kit
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor VisualTests
to allow selecting viewport + browser.
#18
Merged
tmeasday
merged 16 commits into
main
from
tom/ap-3385-allow-switching-viewport-browser-in-addon-panel
Jul 25, 2023
Merged
Refactor VisualTests
to allow selecting viewport + browser.
#18
tmeasday
merged 16 commits into
main
from
tom/ap-3385-allow-switching-viewport-browser-in-addon-panel
Jul 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also refactor how we pass tests into `SnapshotComparison` and add stories for `BuildInfo`
ndelangen
reviewed
Jul 24, 2023
ndelangen
reviewed
Jul 24, 2023
ndelangen
reviewed
Jul 24, 2023
ndelangen
reviewed
Jul 24, 2023
ndelangen
reviewed
Jul 24, 2023
ndelangen
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add stories for sub components and refactor how data is passed into them.
SnapshotComparison
takes a list of tests that correspond to a single storyuseTests
to maintain which is the selected test/comparisonViewport
+BrowserSelector
intoSnapshotComparison
BuildInfo
component now takes a proper build document rather than a smattering of fields.VisualTests
component is simpler as a result of the above.📦 Published PR as canary version:
0.0.7--canary.18.09f95cd.0
✨ Test out this PR locally via:
npm install @chromaui/addon-visual-tests@0.0.7--canary.18.09f95cd.0 # or yarn add @chromaui/addon-visual-tests@0.0.7--canary.18.09f95cd.0