Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor VisualTests to allow selecting viewport + browser. #18

Merged
merged 16 commits into from
Jul 25, 2023
Merged

Refactor VisualTests to allow selecting viewport + browser. #18

merged 16 commits into from
Jul 25, 2023

Commits on Jul 21, 2023

  1. Added stories for viewport and browser selectors

    @tmeasday
    tmeasday committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    6cc61ba View commit details
    Browse the repository at this point in the history

  2. Add stories for SnapshotComparison

    @tmeasday
    tmeasday committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    70459b8 View commit details
    Browse the repository at this point in the history

  3. Linting

    @tmeasday
    tmeasday committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    09395f0 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Lift state from viewport/browser selector 

    Also refactor how we pass tests into `SnapshotComparison` and add stories for `BuildInfo`
    @tmeasday
    tmeasday committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    58fd127 View commit details
    Browse the repository at this point in the history

  2. Update test setup

    @tmeasday
    tmeasday committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    2610878 View commit details
    Browse the repository at this point in the history

  3. Add tests for useTests

    @tmeasday
    tmeasday committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    dc4e532 View commit details
    Browse the repository at this point in the history

  4. Fix non-IN_PROGRESS in progress states

    @tmeasday
    tmeasday committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    00bf2f6 View commit details
    Browse the repository at this point in the history

  5. Fix linting

    @tmeasday
    tmeasday committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    57447b0 View commit details
    Browse the repository at this point in the history

  6. Add some types

    @tmeasday
    tmeasday committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    0353986 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Type refactor

    @tmeasday
    tmeasday committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    d6ef457 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into tom/ap-3385-allow-switching-viewport-browser… 

    …-in-addon-panel
    @tmeasday
    tmeasday committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    7b50676 View commit details
    Browse the repository at this point in the history

  3. Fix behaviour as per stories

    @tmeasday
    tmeasday committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    afdead5 View commit details
    Browse the repository at this point in the history

  4. Ensure we reset the useTests hook when we change story

    @tmeasday
    tmeasday committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    6bd90be View commit details
    Browse the repository at this point in the history

  5. Add comment explaining

    @tmeasday
    tmeasday committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    b7a6c61 View commit details
    Browse the repository at this point in the history

  6. Tweak some stories

    @tmeasday
    tmeasday committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    7a38143 View commit details
    Browse the repository at this point in the history

  7. Capture errors shouldn't be re-runnable

    @tmeasday
    tmeasday committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    09f95cd View commit details
    Browse the repository at this point in the history