Blink: Add search HTML element #100

Kaleidea · 2021-12-07T09:53:41Z

(cherry picked from commit 14b40e1) Bug: 1259292 Change-Id: I1da1c84f682e72fe6a188084185f137025a158a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3219418 Auto-Submit: bttk <bttk@chromium.org> Reviewed-by: Brandon Wylie <wylieb@chromium.org> Commit-Queue: bttk <bttk@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#930773} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222017 Cr-Commit-Position: refs/branch-heads/4664@{chromium#100} Cr-Branched-From: 24dc4ee-refs/heads/main@{#929512}

Merge approved in crbug.com/125350#c24 This CL makes the native color set visible if either macOS is running on versions higher than 10.14 or if we are in light mode. This fixes the case when secondary windows in Incognito which are running on macOS versions < 10.14 can result in dark text on dark background. (cherry picked from commit 31d821e) Bug: 1253530 Change-Id: I8e3b61a5751ad285d31c8e136c88701b8ed8f0e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3233101 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#939993} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3276612 Auto-Submit: Rohit Agarwal <roagarwal@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/branch-heads/4692@{chromium#100} Cr-Branched-From: 038cd96-refs/heads/main@{#938553}

…ncoder (cherry picked from commit 0fd0c9c) Bug: 1280086 Change-Id: I5b0a2a25ec494798e9c5d219e34559663ca72f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340250 Reviewed-by: Dan Sanders <sandersd@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#952034} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345490 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4758@{chromium#100} Cr-Branched-From: 4a2cf4b-refs/heads/main@{#950365}

When "dark-light-mode" flag is off, we should explicitly use light mode as default color mode, otherwise the ash::ColorProvider will still treat it as dark mode, which results in the dark color being displayed on the file picker/saver dialog. Demo: * when flag is off: * Chrome app mode: http://shortn/_zAnw45gYmr * SWA mode: http://shortn/_gH8ExZSTKW * when flag is on: * Chrome app mode: http://shortn/_Lwu47lzRES * SWA mode: http://shortn/_VZjUlHGKug (cherry picked from commit 4faf97f) Bug: 1291354 Test: deploy to chromeos-on-linux and visually inspect Test: unit_tests --gtest_filter=*SelectFileDialogExtension* Test: browser_tests --gtest_filter=*SelectFileDialogExtension* Change-Id: Ifa3966631b29892aad52250f09340c06e63a101c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3418619 Reviewed-by: Ben Reich <benreich@chromium.org> Commit-Queue: Wenbo Jie <wenbojie@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#963869} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3421451 Auto-Submit: Wenbo Jie <wenbojie@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4844@{chromium#100} Cr-Branched-From: 007241c-refs/heads/main@{#961656}

Bubble will be shown when the webcontent is active again. This is only applicable on Desktop since there is a page action icon and there is a reshow. (cherry picked from commit 1595120) Bug: 1299105 Change-Id: Ic841848622b8bd4e40f3d77fbf86530f771b4268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3475603 Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#974442} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3491308 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4896@{chromium#100} Cr-Branched-From: 1f63ff4-refs/heads/main@{#972766}

crrev.com/c/3556846 targeting MoveMigrator removed "Preferences" from the list of files to be copied thus CopyMigrator stopped copying "Preferences" to Lacros causing a regression. This patch makes CopyMigrator copy "Preferences" to fix the issue. (cherry picked from commit 4747ba5) Test: tast run lacros.Migrate.* Bug: 1316590 Change-Id: I932366d4ded08b7bbd054a8effabf34575f2d96a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3589435 Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#994023} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3601889 Cr-Commit-Position: refs/branch-heads/5005@{chromium#100} Cr-Branched-From: 5b4d945-refs/heads/main@{#992738}

A dummy notification should be removed from the Zenith dialog when the web page that's associated with the notification is closed or lost focus. This matches what Cast dialog is doing. This CL makes the PresentationRequestNotificationProducer own an observer to the WebContents, which hides the dummy notification when the WebContents is destroyed or lost focus. (cherry picked from commit 8f7f373) Bug: b/188594540, 1208264 Change-Id: Ia1c61f501136e1270069fb138db1d5deb00f741c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2906430 Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Muyao Xu <muyaoxu@google.com> Cr-Original-Commit-Position: refs/heads/master@{#885976} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2919660 Auto-Submit: Muyao Xu <muyaoxu@google.com> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/branch-heads/4515@{chromium#100} Cr-Branched-From: 488fc70-refs/heads/master@{#885287}

There's a known issue with DialogFragment where if the app is sent to the background and some OS settings are changed, such as enabling or disabling battery saver, or enabling or disabling dark theme, then when the app is brought to the foreground again, the DialogFragment gets recreated. This means that any custom initialization is not performed on the DialogFragment subclass. In this specific case, the Dialog owner needs to call init() on it. Without it, the scene coordinator is null when the app resumes from background, which causes a crash. This state cannot be recovered from, so the best course of action is to simply dismiss the dialog. This isn't so bad from the user's perspective because they had left the app already. Resuming the app will simply bring them back to the website they were browsing. (cherry picked from commit a6069dc) Bug: 1303469 Change-Id: If51d79893775acbbc230d15c20eaa8196e66bd62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3542794 Reviewed-by: Sophey Dong <sophey@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Original-Commit-Position: refs/heads/main@{#983923} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3547037 Auto-Submit: Guillaume Jenkins <gujen@google.com> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/branch-heads/4951@{chromium#100} Cr-Branched-From: 27de622-refs/heads/main@{#982481}

(cherry picked from commit 2cc35f4) Bug: 1317108 Change-Id: I58b50f82a4a9a2288279d4b8349ab73f4fd7229c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3645582 Reviewed-by: Gregory Guterman <guterman@google.com> Commit-Queue: Garrett Beaty <gbeaty@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1005016} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3654778 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Garrett Beaty <gbeaty@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5060@{chromium#100} Cr-Branched-From: b83393d-refs/heads/main@{#1002911}

https://chromium.googlesource.com/external/github.com/pytorch/cpuinfo.git/+log/b40bae277857..beb46ca03198 $ git log b40bae277..beb46ca03 --date=short --no-merges --format='%ad %ae %s' 2022-07-27 maratek Minor refactoring of iOS/Mac feature detection on ARM/ARM64 (#108) 2022-07-27 maratek Use full syntax for ADD_TEST CMake command (#107) 2022-07-27 maratek Detect Cortex-A710/-A510/-X2 cores (#109) 2022-07-26 kulin_seth Add support for Arm FHM (#102) 2022-07-25 kulinseth Use sysctls available in macOS 12 / iOS 15 for hardware feature support. (#100) 2022-07-18 keithbsmiley Add bazel support for iOS arm64 simulator (#105) 2022-07-15 kulinseth Add support for Arm I8MM (#103) 2022-07-12 kulinseth Add Arm BF16 support for Apple platforms (#104) 2022-07-12 maratek Cleanup detection of ARM BF16 extension (#98) 2022-07-12 kulinseth Update README.md to use 'macOS' and list support for Apple silicon (#99) 2022-07-07 nshulga [GHA] Add build workflow (#97) 2022-07-07 maratek Make clog compatible with Hexagon toolchain (#95) 2022-07-05 bion Always check for x86-ish with the same regex. (#93) 2022-07-05 91903944+gaborkertesz-linaro Enable win-arm64 (#82) 2022-07-04 91903944+gaborkertesz-linaro Update googlebenchmark to 1.6.1 (#86) 2022-06-17 petrhosek Define namespace prefixed alias for cpuinfo in the CMake build (#89) 2022-05-31 weiyiw Fix arm build when -Werror enabled (#91) Created with: roll-dep src/third_party/cpuinfo/src Bug: 1329774 Change-Id: I602d9631c5355ded521af4642df97cdca45cbaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3797219 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1030661}

Merge to release branch In certain cases WebContentsObserver::OnCookiesAccessed() can be called multiple times redundantly. Make CookieAccessFilter handle this by coalescing all consecutive cookie accesses for the same URL. Also add a UMA metric to count how often CookieAccessFilter::Filter() fails. (cherry picked from commit 533c4eb) Bug: 1335510 Change-Id: I4a06c97cd44711aa4e858e67479e4b958a31fee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3696174 Commit-Queue: Ryan Tarpine <rtarpine@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Ben Kelly <wanderview@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1014015} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3706780 Auto-Submit: Ryan Tarpine <rtarpine@chromium.org> Reviewed-by: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/branch-heads/5112@{chromium#100} Cr-Branched-From: b13d3fe-refs/heads/main@{#1012729}

(cherry picked from commit 0b13f88) Bug: 1347470 Change-Id: I87a223c81ee06f4921ef3cef78e2a1a83b9a2983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3788449 Reviewed-by: Xi Han <hanxi@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1028920} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3792525 Cr-Commit-Position: refs/branch-heads/5195@{chromium#100} Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}

Missing check for runtime flag (cherry picked from commit bc7c634) Bug: 1302630 Change-Id: Iac5f97766407f926be1721f952c5ffa304b7dd63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3846177 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1038141} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3852963 Auto-Submit: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/branch-heads/5249@{chromium#100} Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}

- Prompt QR Code action was not working because of resource not found exception. - We were generating resource id from the package name and drawable file name. It seems that due to resource minification, it was not able to get correct resource id from the given package name. - We are now simply passing resource id from the permission enum and then setting image drawable. (cherry picked from commit 7d967ca) Bug: 1366389 Bug: b/247725256 Change-Id: I784632a2969ddec5c23b2d4d52450b54095ea861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3907159 Commit-Queue: Vinit Solanki <solankivinit@google.com> Reviewed-by: Shashank Jain <jainshashank@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1049580} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3910209 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/5304@{chromium#100} Cr-Branched-From: 5d7b1fc-refs/heads/main@{#1047731}

(cherry picked from commit ddd2f3b) Bug: 1375309 Change-Id: Ib3b1881a0517f1587a5599875d63afea16798140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3956598 Reviewed-by: Alison Gale <agale@chromium.org> Commit-Queue: Eshwar Stalin <estalin@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1060050} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3964519 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5359@{chromium#100} Cr-Branched-From: 27d3765-refs/heads/main@{#1058933}

IsKeyboardShortcutsEnabled is backed by a Finch feature, but it can be queried very early in the launch sequence, even before Finch is initialized, or resources have been loaded. To that end, this CL does: - store the Finch value in NSUserDefaults for the next cold start (meaning that it can take up to 2 cold starts to get the feature enabled), similar to what is done with the FeedBackgroundRefresh Finch feature; - add the key commands strings to the list of strings available at startup. To have a cleaner list of such strings, I added dedicated IDS_IOS_KEYBOARD_xxx strings. (cherry picked from commit 4fb755b) Bug: 1381066 Change-Id: I32e4c66658a9213a50c738fb2d424bfe8fd3e694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4001640 Reviewed-by: Mark Cogan <marq@chromium.org> Auto-Submit: Louis Romero <lpromero@google.com> Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1071048} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4027919 Cr-Commit-Position: refs/branch-heads/5414@{chromium#100} Cr-Branched-From: 4417ee5-refs/heads/main@{#1070088}

Change-Id: I807b1ae488910cb0b599eb98998f8fab11a5f0de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4127204 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5481@{chromium#100} Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}

Add experimental web platform feature (runtime_enabled_features.json5): - `HTMLSearchElement` (not a class name) - `HTMLSearchElementIsForm` Register <search> element: - html_tag_names.json5 - generates HTMLElement constructor adapter (HTMLSearchConstructor()) for HTMLElementFactory::Create() Add native <search> element to parser: - Document::CreateRawElement() - constructs HTMLFormElement instead of HTMLElement when HTMLSearchElementIsFormEnabled() - HTMLTreeBuilder::ProcessStartTagForInBody() - HTMLTreeBuilder::ProcessStartTagForInTable() - HTMLTreeBuilder::ProcessEndTagForInBody() Add native <search> element to form: - HTMLFormElement::HTMLFormElement(const QualifiedName&, Document&) for HTMLElementFactory. - bool is_search_form_ - distinguishes between <form> and <search>. Disable <search> element form submission: - HTMLFormElement::ScheduleFormSubmission() returns after handling `method=dialog` if `action` attribute is unset. RTTI for HTMLFormElement: - noTypeHelpers: true (html_tag_names.json5) - virtual bool HTMLElement::IsHTMLFormElement() const - bool HTMLFormElement::IsHTMLFormElement() const final Custom RTTI type helpers (no longer generated due to noTypeHelpers:true): - DowncastTraits<HTMLFormElement>::AllowFrom(const HTMLElement&) - DowncastTraits<HTMLFormElement>::AllowFrom(const Node&) - template <> bool IsElementOfType<const HTMLFormElement>(const Node&) - template <> bool IsElementOfType<const HTMLFormElement>(const HTMLElement&)

- HTMLStackItem::IsSpecialNode() - replace_selection_command.cc::IsProhibitedParagraphChild()

Set <search> element accessibility role: - AXNodeObject::determineAccessibilityRoleUtil() Add <search> element to user agent stylesheet: - third_party/blink/renderer/core/html/resources/html.css

- document_statistics_collector.cc::CollectFeatures() - DocumentAllNameCollection::ElementMatches() - html_collection.cc::IsMatchingHTMLElement() - html_collection.cc::NameShouldBeVisibleInDocumentAll() - RelList::ValidateTokenValue()

Failing on some bots. (cherry picked from commit 73525c2) Bug: 1410635 Change-Id: I17bd630b89f7c054bf3f13554ff9e568d12500ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4198960 Reviewed-by: Theresa Sullivan <twellington@chromium.org> Commit-Queue: Theresa Sullivan <twellington@chromium.org> Auto-Submit: Lijin Shen <lazzzis@google.com> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1097696} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4215591 Reviewed-by: Lijin Shen <lazzzis@google.com> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Owners-Override: Hongchan Choi <hongchan@chromium.org> Auto-Submit: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/branch-heads/5563@{chromium#100} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}

…112.0.5615.8-r1 to 112-5563.31-1677502748-benchmark-112.0.5615.9-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-arm-chromium-beta Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I40cb4eee3e8c1b784fb0aef6917f4cbc97c47376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4299631 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5615@{chromium#100} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}

…2-benchmark-113.0.5635.0-r1 to 113-5615.29-1679919454-benchmark-113.0.5672.6-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-arm-exp-chromium-beta Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ia85a22f9897d828bf0e7c164978e67aadefb3f61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4381406 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5672@{chromium#100} Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}

This adds a callback to be invoked when the download stream ends in ReceiveMessagesExpress::OnComplete(). This will ultimately notify the WebRTC medium so that we can move on quickly rather than waiting on a timeout to fire. This change includes an uprev for Nearby Connections with the following CLs... cl/359161492: Add nearby-google3 comments to blocks which shouldn't appear in GitHub. cl/359631402: Completion callback for WebRtcSignalingMessenger. cl/359771717: Get data how many user dismiss half sheet actually pair the device. (cherry picked from commit 3241585) Fixed: 1165387 Change-Id: I7d44ee2b015af210f365c185e77e829b164f3dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2713883 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: James Vecore <vecore@google.com> Reviewed-by: Alex Gough <ajgo@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Original-Commit-Position: refs/heads/master@{#859140} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2733251 Cr-Commit-Position: refs/branch-heads/4430@{chromium#100} Cr-Branched-From: e5ce7dc-refs/heads/master@{#857950}

We shouldn't be crashing if migration fails, which may be due to corruption (cherry picked from commit d29e2a8) Fixed: 1423375 Change-Id: I56231e38b1829a0f9bb44c74a626acd615198a59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4491245 Auto-Submit: Austin Sullivan <asully@chromium.org> Commit-Queue: Dominic Battre <battre@chromium.org> Reviewed-by: Dominic Battre <battre@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1137323} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4496805 Commit-Queue: Austin Sullivan <asully@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5735@{chromium#100} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}

CupsProxyServiceManager is KeyedService and is created during profile loading. It creates CupsProxyServiceDelegateImpl when CupsProxyClient thinks underlying dbus service is available. CupsProxyServiceDelegateImpl reaches for primary user profile in it constructor. There is a race between profile finish loading and dbus service availability. When dbus availability is signaled earlier than profile loading, DumpWithoutCrashing in ProfileManager::GetPrimaryUserProfile would be hit. Since CupsProxyServiceManager is a KeyedService and knows the profile, we don't have to reach out to ProfileManager to get it. This CL does the following: - Create CupsProxyServiceManager only for the primary user profile; - Pass down Profile explicitly to CupsProxyServiceDelegateImpl; (cherry picked from commit 7e5575b) Bug: 1424583 Change-Id: I6033318eff3d76126fceaeb901b57f8794c723e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4634497 Reviewed-by: Paul Moy <pmoy@chromium.org> Reviewed-by: Benjamin Gordon <bmgordon@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1161308} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4646674 Auto-Submit: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Benjamin Gordon <bmgordon@chromium.org> Cr-Commit-Position: refs/branch-heads/5845@{chromium#100} Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}

Uploaded by https://ci.chromium.org/b/8779897116172530945 Change-Id: Ie9459e9e688944b0fe1870b2d2b0e52b82b049c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4572685 Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5790@{chromium#100} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}

…3 commits) https://chromium.googlesource.com/external/github.com/chromium/content_analysis_sdk.git/+log/93f5b9cfe950..3102cb8a514a $ git log 93f5b9cfe..8d5118720 --date=short --no-merges --format='%ad %ae %s' 2023-08-17 105299435+dominiquefc Fix switch statement from last change (#100) 2023-08-17 105299435+dominiquefc Add Reason enum to ContentAnalysisRequest (#99) 2023-08-04 105299435+dominiquefc Update "Ack:" logging whitespace (#98) 2023-08-04 105299435+dominiquefc initial (#97) Created with: roll-dep src/third_party/content_analysis_sdk/src Bug: b/232967266, b/285317584 Change-Id: I8d15321576b9a9b221de26a40cf8eb58e18097bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4791106 Auto-Submit: Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/main@{#1185151}

The old text "lists of saved passwords" might be confusing so it's rephrased in the new version. The message is also made more verbose for clarity. (cherry picked from commit 3db8726) Bug: 1471959 Change-Id: Idcb2fa3ae9856d7c3ff011225b3ea792094a9e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4769431 Commit-Queue: Ivana Žužić <izuzic@google.com> Reviewed-by: Ioana Pandele <ioanap@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1182515} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4774725 Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/branch-heads/5938@{chromium#100} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}

Change-Id: Ic66d677d9b085e67ac0ad39719e2faa3242d79bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4850935 Auto-Submit: Ben Mason <benmason@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5993@{chromium#100} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}

Implements a Snackbar that is shown when an auto-translation happens when using the Translate Message UI. The CTA on the Snackbar is to undo the translation and re-show the Translate Message UI. The Snackbar UI exists in the WindowAndroid context, unlike the Message UI which is attached to WebContents. To close the Auto- Translate Snackbar on page navigation or when the tab changes the WebContentsObserver implementation on ChromeTranslateClient is used. (cherry picked from commit 1a65620) Bug: 1462755 Change-Id: I10a4f2c8e97cebfab3f08603dbfa05b7249f68b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4889004 Reviewed-by: David Trainor <dtrainor@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Anthony Cui <cuianthony@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1204389} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4915590 Auto-Submit: Trevor Perrier <perrier@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6045@{chromium#100} Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}

This reverts commit e831131. Reason for revert: This CL breaks some tests. 1: https://ci.chromium.org/old/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/116710 2: https://ci.chromium.org/old/p/chromium/builders/ci/Linux%20CFI/26338 Original change's description: > [SHv2] Run PasswordStatusCheckService on browser startup > > This CL makes PasswordStatusCheckService be created at browser startup. > There were couple of different issues: > > 1) To handle ScopedObserver destruction, OnBulkCheckServiceShutDown is > added to both PasswordCheckDelegate and PasswordStatusCheckService. > As A result, whenever bulk leak service shut down, both stop observing > it. > > 2) Replaced is_update_credential_count_pending_ with > running_update_credential_count_ to control killing infra based on > the number of running checks. > > 3) Marked ServiceIsNULLWhileTesting is true to adapt the behavior of > AccountPasswordStore. AccountPasswordStoreFactory class also set > ServiceIsNULLWhileTesting to true. > > 4) Updated SafetyHubHandlerTest by creating a testing factory for > PasswordStatusCheckService. > > 5) Added RunUntilIdle to SingleClientNigoriWithWebApiTests to provide > enough time to PasswordStatusCheckService to shutdown infra. Otherwise, > there were a few dangling pointers in BulkLeakCheckServiceAdapter. > > 6) Handled profile_store being empty case in PasswordStatusCheckService > to prevent crashes when password store is not enabled. > > Bug: 1443466 > Change-Id: Ie2ef3397163118b96b7e86a97c2991f379bf3ee1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4926468 > Reviewed-by: Martin Šrámek <msramek@chromium.org> > Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1216875} (cherry picked from commit 7943294) Bug: 1443466 Change-Id: Iaaac2adcb61d4ebd0a551b82a414582e453f2c1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4996926 Owners-Override: Nancy Wang <nancylingwang@chromium.org> Auto-Submit: Nancy Wang <nancylingwang@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1218074} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4998527 Commit-Queue: Mahmoud Rashad <mmrashad@google.com> Reviewed-by: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/branch-heads/6099@{#100} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}

Roll Chrome Win32 PGO profile from chrome-win32-6167-1701971909-2fb9c6f96a6a6572919498001a4fce65a5f687a8.profdata to chrome-win32-6167-1701986234-aed8abc6a534297213dd509eab29c81511ea8815.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m121.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4197ca56dcdd3f5c871e20562ca626178b70aa26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5102111 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6167@{#100} Cr-Branched-From: 222e786-refs/heads/main@{#1233107}

…tation (cherry picked from commit 4c34034) Bug: b/321283425 Bug: 1521095 Change-Id: I49df075d904b24cc472f400c211888b4fe906ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5218259 Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Ian Wells <iwells@chromium.org> Commit-Queue: Basia Zimirska <basiaz@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1251077} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5237362 Auto-Submit: Basia Zimirska <basiaz@google.com> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/branch-heads/6261@{#100} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}

1. Use CODECAPI_AVEncVideoTemporalLayerCount to set number of temporal layers requested in config 2. Assign temporal index to outputs based on expected layer pattern 3. Add a GPU bot test (cherry picked from commit b6663a7) Bug: 1203743, 1248160 Change-Id: I21cd44618c7de0ba5502a5982cd952f073770721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3151523 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by: Chunbo Hua <chunbo.hua@intel.com> Reviewed-by: Dan Sanders <sandersd@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#921580} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3165875 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4638@{chromium#100} Cr-Branched-From: 159257c-refs/heads/main@{#920003}

The patch that causes the crash had assumed it would only be possible to get into the else-if block where the crash is happening only if we already had a `closest`, but that might not be true in two cases: 1. if we have a proximity strictness candidate snap container and we encounter a candidate at a distance equal to the proximity range of the snap container before we encounter one whose distance is less than the proximity range (if at all we do), or 2. somehow, a candidate has a distance equal to std::numeric_limits<float>::max() Either way, this patch prevents the crash by checking for std::nullopt and preserves the behavior of ignoring case 1 candidates. (cherry picked from commit e821ad3) Bug: 325562926 Change-Id: Ifa539cd490ac9493c27e4f6127929055d2664f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5303634 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: David Awogbemila <awogbemila@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1262737} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5318199 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Steve Kobes <skobes@chromium.org> Auto-Submit: David Awogbemila <awogbemila@chromium.org> Cr-Commit-Position: refs/branch-heads/6312@{#100} Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}

When the Create Shortcut dialog is opened, the cursor is at the start of the edit box and it is very hard to move the cursor elsewhere while TalkBack is on. The fix is to move the cursor to the end of the box as soon as we populate the edit box. (cherry picked from commit 975af11) Bug: 330450844 Change-Id: I3dfc7f533e51e2843c32f27f40fcc8d31171fb53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5381561 Reviewed-by: Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1275572} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5383370 Commit-Queue: Glenn Hartmann <hartmanng@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/branch-heads/6367@{#100} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}

Roll Chrome Win32 PGO profile from chrome-win32-6422-1713461400-00ffb89935cddaaddec9b85ee7f39b74cf6e17e3-e6bb4551127f21a46446ede42906bf9920002b4d.profdata to chrome-win32-6422-1713482626-2cd1bf3a5cc03018d5f41317bf3eb9b75321ea74-a6d9098628a0d2172b2c5a5f87bb5ddfb725f07e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m125.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Idd1f4abe6e6d62612544c131fb04d298ae68d428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5464675 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6422@{#100} Cr-Branched-From: 9012208-refs/heads/main@{#1287751}

This fixes VideoStreamEventRouter::SetVideoChannelStateObserver() so it overwrites the previous value if it is called a second time with the same screen-id. Without this fix, the previous value would be an invalidated weak-ptr to the previous video-stream. (cherry picked from commit f088dc3) Bug: 340606785 Change-Id: Ibd468cdfa6fc0253386f69437e6b12be9058dde6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5540215 Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by: Joe Downing <joedow@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1300960} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5544594 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Joe Downing <joedow@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#100} Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}

Screen recording: https://drive.google.com/file/d/1hOIzxBHS-sV6rXDTu20adeInxKI7iv4z/view?usp=sharing&resourcekey=0-fLHcSWcGRG7v2Oi0zJDrkg Previous behavior for reference: https://drive.google.com/file/d/10TKleLKv8tcJqFCRcSm7GHaatyOYKIme/view?usp=sharing&resourcekey=0-HuGTew7QV5ahvX6u5OmDog (cherry picked from commit b578d81) Fixed: 1197580 Bug: 1192488 Change-Id: I9fa9374aad7ea05012380f91dd29e4ac4decae0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2817541 Reviewed-by: Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#871450} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2827910 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4472@{chromium#100} Cr-Branched-From: 3d60439-refs/heads/master@{#870763}

…ing by default" This reverts commit b8c1a55. Reason for revert: We have seen reports of cluebts where enumerateDevices hangs which mught me related to this feature. Original change's description: > [VideoCapture] Enable MediaFoundationCameraUsageMonitoring by default > > Bug: 40946314 > Change-Id: I868ec99475b70e1c6c85efb0dfdb4913d243e9f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5588633 > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Tony Herre <toprice@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1309275} (cherry picked from commit 8dae5a3) Bug: 40946314, 346854735 Change-Id: Ie5d6aee85f5eef360311b0bd49100935d064af60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5625900 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1314431} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5626195 Reviewed-by: Markus Handell <handellm@google.com> Commit-Queue: Tony Herre <toprice@chromium.org> Cr-Commit-Position: refs/branch-heads/6533@{#100} Cr-Branched-From: 7e0b87e-refs/heads/main@{#1313161}

Kaleidea force-pushed the search-element branch 2 times, most recently from 7bd04c1 to 3cc0a88 Compare December 8, 2021 16:04

Kaleidea force-pushed the search-element branch from 3cc0a88 to e24c23e Compare December 8, 2021 19:02

Kaleidea mentioned this pull request Dec 20, 2021

Unaddressed code of conduct violations: censorship, suppression, rudeness whatwg/sg#186

Closed

Kaleidea force-pushed the search-element branch from e24c23e to a1496b4 Compare December 24, 2021 05:00

Kaleidea force-pushed the search-element branch 2 times, most recently from 9f13f59 to da946b9 Compare January 14, 2022 19:51

Kaleidea force-pushed the search-element branch 6 times, most recently from e64070c to fc3804d Compare March 7, 2023 02:20

Kaleidea force-pushed the search-element branch 3 times, most recently from 595cdf9 to 60d322e Compare March 7, 2023 03:08

Kaleidea added 5 commits March 7, 2023 19:46

Blink: Add <search> element - to parser, as paragraph closing tag

273c362

- HTMLStackItem::IsSpecialNode() - replace_selection_command.cc::IsProhibitedParagraphChild()

Blink: Add <search> element - ARIA landmark role, UA stylesheet

22b25c0

Set <search> element accessibility role: - AXNodeObject::determineAccessibilityRoleUtil() Add <search> element to user agent stylesheet: - third_party/blink/renderer/core/html/resources/html.css

Blink: Add <search> element - includes for RTTI

1db4f17

Kaleidea force-pushed the search-element branch from 60d322e to 1de032f Compare March 7, 2023 18:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Blink: Add search HTML element #100

Blink: Add search HTML element #100

Kaleidea commented Dec 7, 2021 •

edited

Loading

Blink: Add search HTML element #100

Are you sure you want to change the base?

Blink: Add search HTML element #100

Conversation

Kaleidea commented Dec 7, 2021 • edited Loading

Explainer

Specification draft

Browser support

Kaleidea commented Dec 7, 2021 •

edited

Loading