-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mr from chromium/chromium #108
Open
habbyge
wants to merge
24
commits into
chromium:master
Choose a base branch
from
habbyge:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrumpyOldTroll
pushed a commit
to GrumpyOldTroll/chromium
that referenced
this pull request
Mar 3, 2022
…fined https://crrev.com/c/3288995 have added code that hides 'Autocomplete searches and URLs' if pageVisibility is undefined. It turns out that pageVisibility is undefined for all non-Guest profiles on Desktop platforms (see https://crbug.com/1288911#c5). This CL fixes the issue by returning `true` from showSearchSuggestToggle_ in that case (which matches the Polymer behavior). (cherry picked from commit fb414b5) Bug: 1288911 Change-Id: Ic60088bb31757d0319f3850d83f02fe200517fc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3420288 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#964025} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3423872 Cr-Commit-Position: refs/branch-heads/4844@{chromium#108} Cr-Branched-From: 007241c-refs/heads/main@{#961656}
Damenly
pushed a commit
to openFyde/chromium
that referenced
this pull request
Mar 31, 2022
(cherry picked from commit 5d44fa5) Bug: 1230786 Change-Id: Ic853334cff3495e46ffff0fc4cb850a6117d6219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217837 Reviewed-by: Mike Wittman <wittman@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#930536} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221456 Auto-Submit: Annie Sullivan <sullivan@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/branch-heads/4664@{chromium#108} Cr-Branched-From: 24dc4ee-refs/heads/main@{#929512}
fujunwei
pushed a commit
to otcshare/chromium-src
that referenced
this pull request
May 4, 2022
Unexpire Sync.ModelTypeTimeUntilEncryptionKeyFound2* and extend Sync.ModelTypeUndecryptablePendingUpdatesDropped*. This will require a merge to M102. (cherry picked from commit 951dbf5) Fixed: 1301679, 1306168 Change-Id: Ia820e81c9b4c6a83d4910dd3fbd392cc2a7c922e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3599370 Commit-Queue: Victor Vianna <victorvianna@google.com> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by: Rushan Suleymanov <rushans@google.com> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Original-Commit-Position: refs/heads/main@{#994595} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3599194 Cr-Commit-Position: refs/branch-heads/5005@{chromium#108} Cr-Branched-From: 5b4d945-refs/heads/main@{#992738}
ashie
pushed a commit
to clear-code/chromium
that referenced
this pull request
May 10, 2022
Change-Id: If4ea5f910b6ce06f609f3a4a6d84bae8587adb95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2921924 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4515@{chromium#108} Cr-Branched-From: 488fc70-refs/heads/master@{#885287}
pkviet
pushed a commit
to pkviet/chromium
that referenced
this pull request
Jun 4, 2022
…t crash (cherry picked from commit a0c3f66) Bug: 1308791, 1283004 Change-Id: I041158ab9d2b48ff82c250489cd6ad31e7417171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3542549 Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#984263} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3548696 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/branch-heads/4951@{chromium#108} Cr-Branched-From: 27de622-refs/heads/main@{#982481}
pkviet
pushed a commit
to pkviet/chromium
that referenced
this pull request
Jun 6, 2022
where applicable for the Mac12 upgrades #BotUpQ22022 (cherry picked from commit 3e83ad9) Bug: 1323966 Change-Id: I5eb8fee6afa21885674febf2cb7862a40dbc0fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3645491 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by: Erik Staab <estaab@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1003261} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3651372 Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/branch-heads/5060@{chromium#108} Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
aarongable
pushed a commit
that referenced
this pull request
Jul 20, 2022
…ommits) https://chromium.googlesource.com/external/github.com/freetype/freetype2-testing.git/+log/fe2eddae6176..1ca0c99d25ae $ git log fe2eddae6..1ca0c99d2 --date=short --no-merges --format='%ad %ae %s' 2022-05-23 drott Track VisitedSet at top level before colrv1_start_glyph (#127) 2022-01-11 bungeman Unquote cc and cxx when executing. (#126) 2022-01-09 bungeman Quote more strings. (#125) 2022-01-09 bungeman Build bzip2 correctly. (#124) 2022-01-06 bungeman Use CC and CXX, check for clang version. (#123) 2022-01-06 bungeman Allow ubsan with asan or by itself. (#122) 2021-12-29 bungeman Remove CMAKE_x_COMPILER from libcxx build. (#119) 2021-12-24 bungeman Drop support for git <= 2.14. (#112) 2021-12-24 bungeman Make --rebuild work correctly again. (#111) 2021-12-24 bungeman Use sanitize-coverage=0 not no-sanitize-coverage (#115) 2021-12-24 bungeman Choose exactly one of the exclusive fuzzers (#117) 2021-12-24 bungeman Add missing quotes to libcxx.sh (#116) 2021-12-18 bungeman Add trace-pc-guard to no-sanitize-coverage. (#114) 2021-12-16 bungeman Add llvm-project for MemorySanitizer build. (#113) 2021-12-10 bungeman Add MemorySanitizer build option. (#110) 2021-11-09 drott Update corpus files for COLRv1 again (#109) 2021-11-01 drott Update corpus files for COLRv1 (#108) Created with: roll-dep src/third_party/freetype-testing/src Change-Id: I358febbaa1933d6d56ad655f62702d67e4a6c0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3777978 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/main@{#1026318}
aarongable
pushed a commit
that referenced
this pull request
Aug 2, 2022
https://chromium.googlesource.com/external/github.com/pytorch/cpuinfo.git/+log/b40bae277857..beb46ca03198 $ git log b40bae277..beb46ca03 --date=short --no-merges --format='%ad %ae %s' 2022-07-27 maratek Minor refactoring of iOS/Mac feature detection on ARM/ARM64 (#108) 2022-07-27 maratek Use full syntax for ADD_TEST CMake command (#107) 2022-07-27 maratek Detect Cortex-A710/-A510/-X2 cores (#109) 2022-07-26 kulin_seth Add support for Arm FHM (#102) 2022-07-25 kulinseth Use sysctls available in macOS 12 / iOS 15 for hardware feature support. (#100) 2022-07-18 keithbsmiley Add bazel support for iOS arm64 simulator (#105) 2022-07-15 kulinseth Add support for Arm I8MM (#103) 2022-07-12 kulinseth Add Arm BF16 support for Apple platforms (#104) 2022-07-12 maratek Cleanup detection of ARM BF16 extension (#98) 2022-07-12 kulinseth Update README.md to use 'macOS' and list support for Apple silicon (#99) 2022-07-07 nshulga [GHA] Add build workflow (#97) 2022-07-07 maratek Make clog compatible with Hexagon toolchain (#95) 2022-07-05 bion Always check for x86-ish with the same regex. (#93) 2022-07-05 91903944+gaborkertesz-linaro Enable win-arm64 (#82) 2022-07-04 91903944+gaborkertesz-linaro Update googlebenchmark to 1.6.1 (#86) 2022-06-17 petrhosek Define namespace prefixed alias for cpuinfo in the CMake build (#89) 2022-05-31 weiyiw Fix arm build when -Werror enabled (#91) Created with: roll-dep src/third_party/cpuinfo/src Bug: 1329774 Change-Id: I602d9631c5355ded521af4642df97cdca45cbaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3797219 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1030661}
darinwf
pushed a commit
to neevaco/chromium
that referenced
this pull request
Aug 10, 2022
Change-Id: I6c4550e02aa1f718969a2f1d0059ed74774142f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3710215 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5112@{chromium#108} Cr-Branched-From: b13d3fe-refs/heads/main@{#1012729}
MaoHan001
pushed a commit
to riscv-android-src/chromium
that referenced
this pull request
Jan 17, 2023
Uploaded by https://ci.chromium.org/b/8797274047320708833 Change-Id: I3285c392fc238818a7c40936dfdd90ae4556206c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4031154 Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5414@{chromium#108} Cr-Branched-From: 4417ee5-refs/heads/main@{#1070088}
wwwppp0801
pushed a commit
to wwwppp0801/chromium
that referenced
this pull request
Feb 13, 2023
…eviceDComp This CL implements SkiaOutputDeviceDComp::SwapBuffers via PostSubBuffer. We previously removed support for the normal SwapBuffers call in SkiaOutputDeviceDComp due to a false assumption that SupportsPostSubBuffer implies that PostSubBuffer will be unconditionally called. This is not the case, e.g. when --ui-disable-partial-swap is used. See: https://chromium-review.googlesource.com/c/chromium/src/+/4049631 (cherry picked from commit 66c304f) Bug: 1401660 Change-Id: I48d0cf88cc1d695af2699752e08fe5912bf548c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4114460 Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Michael Tang <tangm@microsoft.com> Auto-Submit: Michael Tang <tangm@microsoft.com> Cr-Original-Commit-Position: refs/heads/main@{#1084527} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119059 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/branch-heads/5481@{chromium#108} Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
chirayudesai
pushed a commit
to chirayudesai/chromium
that referenced
this pull request
Mar 7, 2023
We should allow insecure contexts to opt in, and want to make sure the type of trial is properly labeled. Bug: 1399319 Change-Id: Ia35e5c5a8e39af2152ef8e1b691959fad403b2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4215353 Reviewed-by: Mike Taylor <miketaylr@chromium.org> Commit-Queue: Ari Chivukula <arichiv@chromium.org> Cr-Commit-Position: refs/branch-heads/5563@{chromium#108} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
calyxos-gerrit
pushed a commit
to CalyxOS/chromium
that referenced
this pull request
Mar 31, 2023
(cherry picked from commit c9bca03) Bug: 1418392 Change-Id: I84bf2b77a2006519dd21e7b616b474ebdec65314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4296337 Auto-Submit: Yann Dago <ydago@chromium.org> Reviewed-by: Igor Ruvinov <igorruvinov@chromium.org> Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1110993} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4300412 Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/branch-heads/5615@{chromium#108} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
herocharge
pushed a commit
to vwvw/chromium
that referenced
this pull request
May 24, 2023
Sometimes Scenic was disconnecting WebEngine because the timestamps it was getting in Present() were out of order. Updated OutputPresenterFuchsia to guerantee that this never happens. (cherry picked from commit 068f3d0) Bug: 1181528 Change-Id: I434a0627af2f72a92f4d3518b8095a10b4a59b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2719485 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Emircan Uysaler <emircan@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#859100} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2733637 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4430@{chromium#108} Cr-Branched-From: e5ce7dc-refs/heads/master@{#857950}
l0hn
pushed a commit
to l0hn/chromium_test
that referenced
this pull request
Jun 9, 2023
With features::kOnBeginFrameAcks we would always bundle all frame acks with the following OnBeginFrame. In some case a frame can arrive late, close enough to the OnBeginFrame that we are waiting for the Ack. The Ack often arrives close to the OnBeginFrame. This introduces features::kOnBeginFrameAllowLateAcks which will allow these late Acks to be sent separately (cherry picked from commit f12c3bc) Bug: 1399880 Change-Id: I31a8c0bcaa6ed3782f8912e9015f289b89338382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4436069 Reviewed-by: Kyle Charbonneau <kylechar@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1136609} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4495064 Cr-Commit-Position: refs/branch-heads/5735@{chromium#108} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
msizanoen1
pushed a commit
to qtmlabs/chromium
that referenced
this pull request
Jun 27, 2023
resizeIconDrawable is called before layout in onMeasure and earlier. If the view is not laid out this can result in the matrix being wrong and the UI not drawing. Fix this by measured values instead when computing the matrix. (cherry picked from commit f4a45aa) Fixed: 1457218 Change-Id: I4acbdb290153e8c9ed2b66505e9ee11b9caa2f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4637202 Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Fred Mello <fredmello@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1161320} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4647528 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5845@{chromium#108} Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
aetota61
pushed a commit
to monkbrowser/monk-browser
that referenced
this pull request
Aug 2, 2023
…merged This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file go/crostc-bug. Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-beta Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie62af520bb07d87659f86ec256ee78e77ba57a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573283 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5790@{chromium#108} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
trflynn89
pushed a commit
to RebelBrowser/rebel
that referenced
this pull request
Oct 26, 2023
Change-Id: Ie8b475689506a6fffb761abcf21b88f8f02d0f8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4850878 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5993@{chromium#108} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
vuzix-jeff
pushed a commit
to Vuzix/chromium
that referenced
this pull request
Nov 3, 2023
Cherrypicks 3 CLs needed to complete the implementation of VideoFrame->WebGL direct upload via SharedImage. Each CL is uploaded as its own PS: PS1: [//media] Handle `use_visible_rect` in ConvertYUVVideoFrame() Handling is straightforward now that predecessor CLs have enabled ConvertYUVAMailboxesToRGB() to take in a sub-rect of the source image. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4905194 PS2: [//gpu] Add UpdateTextureBinding() to validating command decoder This function takes in a target, client texture ID, and texture. It updates the service-side bindings of any units for which `target` is currently bound to `client_id` to be bound to `texture`. The implementation parallels that of the same function in the passthrough command decoder. This function will be needed to implement glTexImage2DSharedImageCHROMIUM() in the validating decoder. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908251 PS3: [gpu] Implement glTexImage2DSharedImageCHROMIUM() in validating decoder The implementation parallels that of the passthrough decoder. It's necessary to add an UpdateTextureBinding() function to the validating decoder, whose implementation *also* parallels that in the passthrough decoder. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4905316 Bug: 1410164 Change-Id: Ibd80030cdfbca8c2348486059a512fe3db970ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4912781 Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/branch-heads/6045@{chromium#108} Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
Aikoyori
referenced
this pull request
in Pissandshittium/pissandshittium
Dec 8, 2023
Roll Chrome Win32 PGO profile from chrome-win32-6099-1698947397-a23bfacb40d8ee315895f2d2d17a18e30c4fb306.profdata to chrome-win32-6099-1698964636-51ba94b6fcf15703f0db0916447ddfaca2c937fc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m120.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I497ad5605f71a73cdcf82a3685638d6793dff7a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5003414 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6099@{#108} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable
pushed a commit
that referenced
this pull request
Jan 6, 2024
Roll Chrome Mac PGO profile from chrome-mac-6167-1701986234-4fea4a0e1bf0ebc02a1477706035bcc2f3a9f9a2.profdata to chrome-mac-6167-1702015141-e49067dac7d61585afdc085ce66e2cc8c3008be7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m121.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0f187a1768cbbd8fd1f2b5dab15f67998e38f10c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5102710 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6167@{#108} Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable
pushed a commit
that referenced
this pull request
Jan 26, 2024
It seems as though Java asserts are stripped out on official builds. This change thus moves a call that was happening inside of an assert (which had the side effect of continuing the requestSession call) to outside of it, while still asserting on the result returned from it. This unblocks launching an OpenXR session on official builds on Android. (cherry picked from commit dccd62a) Fixed: 1521427 Change-Id: Ic53170810e3ac81990101654704646f19c4e7c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5235006 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1251725} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5239153 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/branch-heads/6261@{#108} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
consp1racy
pushed a commit
to signageos/chromium-chromium
that referenced
this pull request
Feb 21, 2024
Change-Id: Id13238f92d2d551d77201a33c581b22a2ab5e953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3168754 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4638@{chromium#108} Cr-Branched-From: 159257c-refs/heads/main@{#920003}
aarongable
pushed a commit
that referenced
this pull request
Feb 23, 2024
Roll Chrome Linux PGO profile from chrome-linux-6312-1708687527-911b6f4739ced6b6798bc5821cb22345a75007d9-a9617b77756364b608dc8a90dfe63b5bb4a58e85.profdata to chrome-linux-6312-1708710741-13a5c4ebfdb146db58c46e5da0eb3548cdd9925c-a7ecbe03d221605901cf8047b1cd786f4a7d4127.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m123.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Icdbfa2b212df7253e89c0e1f10e84d7d0f9eb14b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5320720 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6312@{#108} Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
aarongable
pushed a commit
that referenced
this pull request
Mar 22, 2024
Roll Chrome Win64 PGO profile from chrome-win64-6367-1711043043-d0d3c1976257cf90626ecaceaae65f8189400672-97114d7ab7411108d343cff808845e04bcc53834.profdata to chrome-win64-6367-1711065560-5978041bdeecefdd9161066e65772972c82a3d86-b2496978030535ee291ced93a78cb9af70a84363.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m124.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0191616dbc6a1129b95366192d6764ee24a5be20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5386844 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6367@{#108} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
NaaeemMalik
pushed a commit
to SoftwarePrince/Egon-Chromium
that referenced
this pull request
Mar 22, 2024
Account for tab creation intents -Mark whether a tab was created on startup through an intent. -If so, treat the last tab in the model accordingly. -If the previously focused tab is not restored by the time the tab model is set in this case, then replace its placeholder later. (cherry picked from commit 5e1348a) Bug: 1467283, 1470159 Change-Id: Ia055d478a40dd052abdd15f8de1cb45482da4988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4757804 Commit-Queue: Neil Coronado <nemco@google.com> Reviewed-by: Theresa Sullivan <twellington@chromium.org> Reviewed-by: Sirisha Kavuluru <skavuluru@google.com> Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Cr-Original-Commit-Position: refs/heads/main@{#1181233} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4779018 Cr-Commit-Position: refs/branch-heads/5938@{chromium#108} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
aarongable
pushed a commit
that referenced
this pull request
Apr 19, 2024
Roll Chrome Win32 PGO profile from chrome-win32-6422-1713482626-2cd1bf3a5cc03018d5f41317bf3eb9b75321ea74-a6d9098628a0d2172b2c5a5f87bb5ddfb725f07e.profdata to chrome-win32-6422-1713500652-71bd421d99a664f5c589cf3b9c5714f6b9cd6757-08f3d170e450bede82a948baa72d698fbbbeecd6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m125.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ida713b0380a58d39d021a24511d1f18241c2532d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5466713 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6422@{#108} Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
aarongable
pushed a commit
that referenced
this pull request
May 16, 2024
crrev.com/c/5522379 switched the implementation of GetPageDescription() to checking actual page container fragments from layout, rather than recomputing style for the given page number. Then the fragments have to exist! If something triggers layout after initial pagination layout (which reports a page count that the API user ideally should be able to trust), and the number of pages shrinks in this second layout, there would no longer be as many fragments as expected, and there would be a crash. There already is a WPT test [1] for this, but due to different code paths when running WPT tests and when running the actual browser, this regression wasn't detected. Add a PrintRenderFrameHelperTest test for it as well this time. [1] css/css-page/crashtests/match-media-listener-shrink-content-print.html (cherry picked from commit 2d40d20) Bug: 340732144 Change-Id: Id0d2bda8e010bec36b3705361516c0e19bfb29fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5538177 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1301476} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5546417 Auto-Submit: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/branch-heads/6478@{#108} Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}
consp1racy
pushed a commit
to signageos/chromium-chromium
that referenced
this pull request
May 24, 2024
Adds device name tooltip to the Nearby Device, which appears as follows: 1. On chrome://nearby: https://screenshot.googleplex.com/4KJtxjiUCVFGoZ8 2. On share pop up: https://screenshot.googleplex.com/4GExCDQbyDRTWbN (cherry picked from commit 375cda3) Fixed: 1192730 Change-Id: Id341f8b365b8d4ecfd85d85a3fda5f116e1bfbc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2826610 Reviewed-by: James Vecore <vecore@google.com> Commit-Queue: Juliet Levesque <julietlevesque@google.com> Cr-Original-Commit-Position: refs/heads/master@{#872524} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2827270 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4472@{chromium#108} Cr-Branched-From: 3d60439-refs/heads/master@{#870763}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.