About the Android compilation problem of version 100.0.4854.0 and above #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think you need to make this change on https://chromium.org/ |
|
How infinity files? |
|
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d8f231c04c6e..57048a93cb98 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I755dbd191a5e65c4bbc720675fcf6ec5cfffe83f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3476507 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#973375}
Using wpt-import in Chromium 0583524. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md NOAUTOREVERT=true R=rubber-stamper@appspot.gserviceaccount.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel,linux-blink-rel Change-Id: I9da79c55eb27bb6926cc1638142ad2e159ec8f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3473592 Auto-Submit: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#973376}
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1645355933-f0031ed1faafab6b2f06000a0a78d99a036d9fae.profdata to chrome-mac-arm-main-1645378020-a09f4953c2b8437b16d751a10315880ab246d01c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I85ffcc4ea98db55234f3d6cf26f3e273221d83e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3476640 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#973377}
Roll Chrome Mac PGO profile from chrome-mac-main-1645355933-fbb1b4227f3c6ea71e10a72e318678691d7ce79b.profdata to chrome-mac-main-1645378020-f4fe0a248b4457f62e82ca4fc990f56da27d9963.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I95affd6abb7a18b08e999b456edf8969520ee9bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3476639 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#973378}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/57048a93cb98..d3ec45c6b0e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I9cfaa6292625736d64583af6ab060ba8b26d11d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3476638 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#973379}
Roll Chrome Win64 PGO profile from chrome-win64-main-1645368093-9f48ecd262c7677d4cd110e049fb5a80a627df0e.profdata to chrome-win64-main-1645378020-2b8960c6953eccc65fa1003afbf4ca4df4b2a739.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia5c89a9e148f27ae847a6ae001dc88357f8e76db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3476694 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#973380}
Change-Id: Ic3234d1eceb0764be6acbcc6686a0513673d11c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3473765 Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#973381}
This probably affects unit tests only, to prevent the root scroll node from limitting the bounds of PendingLayers to empty [1] and making the layer not drawing content. https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/compositing/pending_layer.cc;drc=4dbc2cdd81317159f1647f51c3b14ee476d4a4fc;l=98 Change-Id: I623318dd386926ce886f730e5489cf741c558cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3474494 Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#973382}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d3ec45c6b0e0..4bf14a1e7faa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I9b19f4731d8012061a8cfd8d485a02af5cb9fd5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3476680 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#973383}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4bf14a1e7faa..9581011ba7d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I34c7a5ac5aa84ff5762f32e66812d725a7662486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3473962 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#973384}
Bug: 242216 Change-Id: I3b7987205622412911740a66fcb3954cf1c48d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3476477 Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/main@{#973385}
Roll Chrome Win64 PGO profile from chrome-win64-main-1645378020-2b8960c6953eccc65fa1003afbf4ca4df4b2a739.profdata to chrome-win64-main-1645390530-4ab3ea369f0a408b04cd4408ded882b9124e6ed1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I943f37124d28a58ee6acfd8b18366461c37b5b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3476482 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#973386}
…issionManager implementations. Multiple implementations of CrashReportingPermissionManager.isUsageReportingPermittedByUser are created and consumed across our codebase. Given that metrics and crash reporting can be blocked via policy, we need a new API so consumers can know if it's safe to send reports. This CL creates the public endpoint isUsageReportingPermitted intended to replace usage of isUsageReportingPermittedByUser. To follow: - Usage of isUsageReportingPermitted in upstream. - Usage of isUsageReportingPermitted in downstream. Bug: 878558 Change-Id: Ia232bc862855927360f7b5d50ca834f1f1ed5f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3406565 Reviewed-by: Hazem Ashmawy <hazems@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Commit-Queue: Og Astorga <ogastorga@chromium.org> Cr-Commit-Position: refs/heads/main@{#973387}
The hard-coded file icon colors in C++ side should match the spec and be consistent with the colors defined in file_types.css. Instead of using the hard-coded google color there, we should utilize the cros_styles::ResolveColor() to keep consistency. Spec: http://shortn/_HEGUk16z6C Bug: 1293661 Change-Id: I1e9ba2740d9f476095faf8b3cd91d632533515d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3469740 Reviewed-by: David Black <dmblack@google.com> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Wenbo Jie <wenbojie@chromium.org> Cr-Commit-Position: refs/heads/main@{#973388}
When "switch view" button is activated by keyboard, the focus should stay on the button to keep consistent behaviour as other action buttons. Note: there are also other changes in the CL * Add a public method for FilesTooltip called showTooltip(), it will explicitly show tooltip for the current visible tooltip target. * Handle keyup/click event together to prevent infinite triggering for callback. "click" event will be triggered multiple times if users hold Enter/Space key down without releasing (demo: http://shortn/_Z1x7Cq1SfF), we need to have additional logic there to prevent it (demo: http://shortn/_QzY2THz20b) Demo: http://shortn/_NzAKaQfuHo Bug: 1221202 Test: deployed to DUT and visually inspect Test: browser_tests --gtest_filter="*FilesTooltip*" Change-Id: Ib1ab52ee7c54f253731611934d77163dc2df235b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3459366 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Wenbo Jie <wenbojie@chromium.org> Cr-Commit-Position: refs/heads/main@{#973389}
When the flag kAppServiceOnAppUpdateWithoutMojom is enabled, check the non mojom value to return whether the field value is changed. Modify unit tests to verify XXXChanged function. TODO: Replace the mojom functions in AppUpdate with the non mojom functions. BUG=1253250 Change-Id: Ic48ea9de3a2bafee8f3697dabab90dfd8d8c1731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3470894 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#973390}
The rest of the Chrome-side code for this was removed in https://crrev.com/c/3383837 but this was missed. Bug: 972835 Change-Id: Ide453089d56eb6e030c9c94e8a849c199cb1d25e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3473125 Auto-Submit: Timothy Loh <timloh@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/main@{#973391}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: Ib843917405281582a2b35d4e5ef59ad59a3d5b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3476734 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#973392}
There are two other QuickOffice extensions which we hadn't included when special-casing in App Service. These are required for various scenarios where the QO extension is installed manually. Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: 1298240, 1240018 Change-Id: I8dc4422defaa33e0314c835e676eef81130041ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3471234 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/main@{#973393}
Currently the pdf viewer opens in a Tab, but that tab will be an Ash browser. And the viewer is more than just a URL -- it needs to get a Blob resource from the opener -- so it can't open in a LacrOS browser. The fix is to use a popup. But if the untrusted context that hosts the app attempts to open a popup with a different top-frame origin, it gets a confusing banner in the popup saying ~chrome-untrusted is insecure. So, to fix that, the secure context opens the popup, which has another sandbox to actually read the blob; communicating between two chrome-untrusted://media-app origins. Bug: b/216020585 Change-Id: I08350fa9b052feedefa63c11f0c3ea37ea77a5e5 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3462613 Reviewed-by: Patti Lor <patricialor@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/main@{#973394}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9581011ba7d6..44e7f24ca00e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I0096f197d5b4a88ec67c2e3f4c634defc84c8073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3476642 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#973395}
This is a reland of 155b701 Lack of BASE_I18N_EXPORT was causing the component build to fail after submitting to CQ. This change addresses the issue. Original change's description: > Merge common areas of icudtl.dat in Lacros and Ash > > There are two copies of icudtl.dat in the ChromeOS system. > One is included in ash-chrome, and the other one in lacros-chrome. > These two revisions of the file are largely the same, even across > releases. However, both are loaded in RAM at the same time. > > This change causes Lacros to scan Ash's version of icudtl.dat > in search of overlapping pages. If they are found, it unmaps > them and maps them from Ash's file instead. This can save > up to ~11MB of memory in the best case. > > Test: Output the amount of merged bytes in the log to > verify that pages with the same content were merged. > Takes ~2.5ms on Eve to perform the merging with pre-computed hashes. > ~4.5ms without pre-computed hashes. > > Bug: 1253279 > Change-Id: If5374787b6a132ca85b2f8aefab57d7272154a3e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3397889 > Reviewed-by: Kyle Charbonneau <kylechar@chromium.org> > Commit-Queue: Andrea Orru <andreaorru@chromium.org> > Cr-Commit-Position: refs/heads/main@{#972204} Bug: 1253279 Change-Id: I5c767e9925dcb82711f53af32fa86c13717888a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3468881 Auto-Submit: Andrea Orru <andreaorru@chromium.org> Reviewed-by: Kyle Charbonneau <kylechar@chromium.org> Commit-Queue: Andrea Orru <andreaorru@chromium.org> Cr-Commit-Position: refs/heads/main@{#973396}
This reverts commit 5223679. Reason for revert: b/220627084 Original change's description: > Dlcservice Client Install DBus API > > Allow clients to call into the new Install DBus API for dlcservice > daemon. This will simplify future additions/deprecations to Install > method without creating/deprecating methods. > > BUG=218396905 > TEST=chromeos_unittests, chrome, deploy > > Change-Id: I97df96a4093989f8bba84038477efc8c39a26a43 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3466916 > Reviewed-by: Evan Liu <evliu@google.com> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Reviewed-by: Abigail Klein <abigailbklein@google.com> > Reviewed-by: Andrew Moylan <amoylan@chromium.org> > Reviewed-by: Timothy Loh <timloh@chromium.org> > Reviewed-by: Claudio M <claudiomagni@chromium.org> > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Nic Hollingum <hollingum@google.com> > Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> > Cr-Commit-Position: refs/heads/main@{#972712} Bug: 218396905 Change-Id: Iddc69098255dd9066fcc40dab1da4664fbd78514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3476156 Reviewed-by: Patrick Meiring <meiring@google.com> Reviewed-by: David Munro <davidmunro@google.com> Commit-Queue: David Munro <davidmunro@google.com> Owners-Override: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/main@{#973397}
This reverts commit ab48630. Reason for revert: Findit (https://goo.gl/kROfz5) identified this CL at revision ab48630 as the culprit for failures in the continuous build including: Sample Failed Build: https://ci.chromium.org/b/8821660673144766769 Sample Failed Step: compile If it is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?status=Available&comment=Datastore+key+for+the+culprit+entity%3A+chromium.googlesource.com%2Fchromium%2Fsrc%2Frefs%2Fheads%2Fmain%2Fab48630ade1ad3395fe37b0405412d35071f577e&labels=Test-Findit-Wrong&components=Tools%3ETest%3EFindIt&summary=Wrongly+blame+ab48630ade1ad3395fe37b0405412d35071f577e Original change's description: > Reland "Merge common areas of icudtl.dat in Lacros and Ash" > > This is a reland of 155b701 > > Lack of BASE_I18N_EXPORT was causing the component build to fail > after submitting to CQ. This change addresses the issue. > > Original change's description: > > Merge common areas of icudtl.dat in Lacros and Ash > > > > There are two copies of icudtl.dat in the ChromeOS system. > > One is included in ash-chrome, and the other one in lacros-chrome. > > These two revisions of the file are largely the same, even across > > releases. However, both are loaded in RAM at the same time. > > > > This change causes Lacros to scan Ash's version of icudtl.dat > > in search of overlapping pages. If they are found, it unmaps > > them and maps them from Ash's file instead. This can save > > up to ~11MB of memory in the best case. > > > > Test: Output the amount of merged bytes in the log to > > verify that pages with the same content were merged. > > Takes ~2.5ms on Eve to perform the merging with pre-computed hashes. > > ~4.5ms without pre-computed hashes. > > > > Bug: 1253279 > > Change-Id: If5374787b6a132ca85b2f8aefab57d7272154a3e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3397889 > > Reviewed-by: Kyle Charbonneau <kylechar@chromium.org> > > Commit-Queue: Andrea Orru <andreaorru@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#972204} > > Bug: 1253279 > Change-Id: I5c767e9925dcb82711f53af32fa86c13717888a2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3468881 > Auto-Submit: Andrea Orru <andreaorru@chromium.org> > Reviewed-by: Kyle Charbonneau <kylechar@chromium.org> > Commit-Queue: Andrea Orru <andreaorru@chromium.org> > Cr-Commit-Position: refs/heads/main@{#973396} Change-Id: If8cbadd8a1051bb475b5951d4e26a733690a1190 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1253279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3476469 Reviewed-by: Yuki Yamada <yukiy@chromium.org> Commit-Queue: Yuki Yamada <yukiy@chromium.org> Owners-Override: Yuki Yamada <yukiy@chromium.org> Cr-Commit-Position: refs/heads/main@{#973398}
Call OnAppUpdate when the non mojom App struct is updated if kAppServiceOnAppUpdateWithoutMojom is enabled. Call OnAppUpdate when the mojom App struct is updated if kAppServiceOnAppUpdateWithoutMojom is disabled. Modify unit tests to verify OnAppUpdate when kAppServiceOnAppUpdateWithoutMojom is enabled or disabled. BUG=1253250 Change-Id: Idf203bf26dd815ce6b22ea5931e480aecbddd85e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3474093 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#973399}
…lbars." This reverts commit 2d6e4f2. Reason for revert: This has made blink_web_tests fail on builder WebKit Linux Leak. First failure: https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20Leak/35616/overview Original change's description: > [Scroll Unif.] Touch dragging custom and non-composited scrollbars. > > Pre-unification, main thread scrollbar touch drags consumed "backwards" > gesture scroll events (as if the thumb were the scrolling content). > > This patch makes those drags run directly off of touch events, just like > touch drags of native composited scrollbars on the compositor thread. > There are three steps: > > (1) Paint a touch action rect over the scrollbar. This tells the > compositor to forward the touch events to the main thread. > > (2) When a touchstart on a scrollbar reaches PointerEventManager, call > SetTouchActionFromMain. This tells the browser to send us touchmove > events instead of gesture scroll events. > > (3) Handle the touch pointer events in blink::Scrollbar by calling > MoveThumb (and injecting the "proper" gesture scroll events). > > This patch is complex, but less invasive than alternatives: > > - Teaching the compositor thread to drag these is non-trivial since > cc::ScrollbarController assumes we have a scrollbar layer. > > - Giving blink::Scrollbar its backwards gesture events would break a > fundamental assumption of unification, that we never forward gesture > scroll events to the main thread. > > Bug: 1247438 > Change-Id: I859c1fec05165af9990ac51254f242beca3dcce3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3443880 > Reviewed-by: David Bokan <bokan@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Steve Kobes <skobes@chromium.org> > Cr-Commit-Position: refs/heads/main@{#973211} Bug: 1247438, 1299308 Change-Id: Id9cab63bf0888d026eacccb9f0b42cfa10d4e550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3473616 Commit-Queue: Yuki Yamada <yukiy@chromium.org> Owners-Override: Yuki Yamada <yukiy@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#973400}
ghost
closed this
GrumpyOldTroll
pushed a commit
to GrumpyOldTroll/chromium
that referenced
this pull request
Mar 3, 2022
This CL makes the card header a HTML h2 heading so that screen readers read it out as a heading. No visual or text change. (cherry picked from commit 87f4c69) Bug: 1215630,1291527 Change-Id: I4c4a9b47c1b8d9bc9d8e27648de8c3281e993f7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3420825 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Auto-Submit: Rainhard Findling <rainhard@chromium.org> Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Original-Commit-Position: refs/heads/main@{#964049} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3423756 Reviewed-by: Martin Šrámek <msramek@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/branch-heads/4844@{chromium#109} Cr-Branched-From: 007241c-refs/heads/main@{#961656}
Damenly
pushed a commit
to openFyde/chromium
that referenced
this pull request
Mar 31, 2022
Non locally installed web apps are synced web apps that have not had their web app specific features deployed (Windows/Mac/Linux only). This CL updates their App Service representation as kDisabledByUser and makes their effective scope empty so it doesn't get used by app service related functionality like "open in" for browser tabs. (cherry picked from commit 28e4328) Bug: 1252607, 1254110 Change-Id: I5f990b2718d27b473acc93812c1a1b486e3cbef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3180921 Reviewed-by: Maggie Cai <mxcai@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#930059} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221714 Reviewed-by: Alan Cutter <alancutter@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/branch-heads/4664@{chromium#109} Cr-Branched-From: 24dc4ee-refs/heads/main@{#929512}
fujunwei
pushed a commit
to otcshare/chromium-src
that referenced
this pull request
May 4, 2022
(cherry picked from commit 7364308) Bug: 1315559 Change-Id: Ife2ad4bc5f3216f19fdba204dd1aa4147418128a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3586428 Commit-Queue: Louis Romero <lpromero@chromium.org> Auto-Submit: Louis Romero <lpromero@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#994203} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3599424 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/5005@{chromium#109} Cr-Branched-From: 5b4d945-refs/heads/main@{#992738}
ashie
pushed a commit
to clear-code/chromium
that referenced
this pull request
May 10, 2022
This CL updates the PrivacySandboxSettings service to also record the appropriate user actions when adjusting the FLoC pref, or resetting the FLoC ID. This allows these actions to also be recorded on Android, which makes use of these functions for changing / resetting FLoC. This causes some duplication on Desktop, which previously separately recorded an action for resetting FLoC. This CL removes that, leaving desktop to rely on the service to record the action. (cherry picked from commit 5adc217) Bug: 1213040 Change-Id: I4fc6b253441f81903f83ab6e01e5ee8e5a4e9d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2910921 Reviewed-by: Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Original-Commit-Position: refs/heads/master@{#886288} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2919675 Auto-Submit: Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/branch-heads/4515@{chromium#109} Cr-Branched-From: 488fc70-refs/heads/master@{#885287}
pkviet
pushed a commit
to pkviet/chromium
that referenced
this pull request
Jun 4, 2022
Change-Id: I2de24e9660e5003860c0b8ef1e93ae38fb77b7fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3549136 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4951@{chromium#109} Cr-Branched-From: 27de622-refs/heads/main@{#982481}
pkviet
pushed a commit
to pkviet/chromium
that referenced
this pull request
Jun 6, 2022
Demo: https://drive.google.com/file/d/1m8d73WtJ5uBoFpBnA1GYlsYE9jYECMDh/view?usp=sharing&resourcekey=0-r2dQtB1tnFFP1_-7lFamJw (cherry picked from commit 347c902) Bug: 1325280 Change-Id: I5cc9b253b6e55f8a50c05a06ed95529519dddadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3641421 Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Alex Mitra <alexmitra@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1003178} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3654182 Auto-Submit: Alex Mitra <alexmitra@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/branch-heads/5060@{chromium#109} Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
aarongable
pushed a commit
that referenced
this pull request
Jul 20, 2022
…ommits) https://chromium.googlesource.com/external/github.com/freetype/freetype2-testing.git/+log/fe2eddae6176..1ca0c99d25ae $ git log fe2eddae6..1ca0c99d2 --date=short --no-merges --format='%ad %ae %s' 2022-05-23 drott Track VisitedSet at top level before colrv1_start_glyph (#127) 2022-01-11 bungeman Unquote cc and cxx when executing. (#126) 2022-01-09 bungeman Quote more strings. (#125) 2022-01-09 bungeman Build bzip2 correctly. (#124) 2022-01-06 bungeman Use CC and CXX, check for clang version. (#123) 2022-01-06 bungeman Allow ubsan with asan or by itself. (#122) 2021-12-29 bungeman Remove CMAKE_x_COMPILER from libcxx build. (#119) 2021-12-24 bungeman Drop support for git <= 2.14. (#112) 2021-12-24 bungeman Make --rebuild work correctly again. (#111) 2021-12-24 bungeman Use sanitize-coverage=0 not no-sanitize-coverage (#115) 2021-12-24 bungeman Choose exactly one of the exclusive fuzzers (#117) 2021-12-24 bungeman Add missing quotes to libcxx.sh (#116) 2021-12-18 bungeman Add trace-pc-guard to no-sanitize-coverage. (#114) 2021-12-16 bungeman Add llvm-project for MemorySanitizer build. (#113) 2021-12-10 bungeman Add MemorySanitizer build option. (#110) 2021-11-09 drott Update corpus files for COLRv1 again (#109) 2021-11-01 drott Update corpus files for COLRv1 (#108) Created with: roll-dep src/third_party/freetype-testing/src Change-Id: I358febbaa1933d6d56ad655f62702d67e4a6c0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3777978 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/main@{#1026318}
aarongable
pushed a commit
that referenced
this pull request
Aug 2, 2022
https://chromium.googlesource.com/external/github.com/pytorch/cpuinfo.git/+log/b40bae277857..beb46ca03198 $ git log b40bae277..beb46ca03 --date=short --no-merges --format='%ad %ae %s' 2022-07-27 maratek Minor refactoring of iOS/Mac feature detection on ARM/ARM64 (#108) 2022-07-27 maratek Use full syntax for ADD_TEST CMake command (#107) 2022-07-27 maratek Detect Cortex-A710/-A510/-X2 cores (#109) 2022-07-26 kulin_seth Add support for Arm FHM (#102) 2022-07-25 kulinseth Use sysctls available in macOS 12 / iOS 15 for hardware feature support. (#100) 2022-07-18 keithbsmiley Add bazel support for iOS arm64 simulator (#105) 2022-07-15 kulinseth Add support for Arm I8MM (#103) 2022-07-12 kulinseth Add Arm BF16 support for Apple platforms (#104) 2022-07-12 maratek Cleanup detection of ARM BF16 extension (#98) 2022-07-12 kulinseth Update README.md to use 'macOS' and list support for Apple silicon (#99) 2022-07-07 nshulga [GHA] Add build workflow (#97) 2022-07-07 maratek Make clog compatible with Hexagon toolchain (#95) 2022-07-05 bion Always check for x86-ish with the same regex. (#93) 2022-07-05 91903944+gaborkertesz-linaro Enable win-arm64 (#82) 2022-07-04 91903944+gaborkertesz-linaro Update googlebenchmark to 1.6.1 (#86) 2022-06-17 petrhosek Define namespace prefixed alias for cpuinfo in the CMake build (#89) 2022-05-31 weiyiw Fix arm build when -Werror enabled (#91) Created with: roll-dep src/third_party/cpuinfo/src Bug: 1329774 Change-Id: I602d9631c5355ded521af4642df97cdca45cbaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3797219 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1030661}
darinwf
pushed a commit
to neevaco/chromium
that referenced
this pull request
Aug 10, 2022
This CL will update cros image version for skylab tests. CROS_BOARD_LKGM is updated according to chromeos/CHROMEOS_LKGM; CROS_BOARD_DEV, CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha. If this CL caused regressions, please revert and pause the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org, yjt@google.com. R=rubber-stamper@appspot.gserviceaccount.com Requires-Testing: True Change-Id: I33064075344d968bca1311253c91f90b698142b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3708605 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5112@{chromium#109} Cr-Branched-From: b13d3fe-refs/heads/main@{#1012729}
MaoHan001
pushed a commit
to riscv-android-src/chromium
that referenced
this pull request
Jan 17, 2023
Screenshots (note matching widths): * https://screenshot.googleplex.com/6CcKhmWPWotzZB4 * https://screenshot.googleplex.com/AF4Z6g6BVyuK7K7 (cherry picked from commit 3b4a2e9) Bug: 1384648, 1385515 Change-Id: I1ee39ad1ff5025618fc9636e30603f4caadb73a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4028583 Reviewed-by: Roman Arora <romanarora@chromium.org> Commit-Queue: Yo Wakita <yowakita@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1071913} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4032528 Cr-Commit-Position: refs/branch-heads/5414@{chromium#109} Cr-Branched-From: 4417ee5-refs/heads/main@{#1070088}
wwwppp0801
pushed a commit
to wwwppp0801/chromium
that referenced
this pull request
Feb 13, 2023
In https://chromium-review.googlesource.com/c/chromium/src/+/4109928, we added support to store grid placement data on `NGGridLayoutData`. This was originally stored when `HasBlockFragmentation`. During review, this was moved to `InvolvedInBlockFragmentation`, but when `IsBreakInside` is false. This was supposed to be `IsBreakInside` is true. This didn't impact the test case or my original repro, so it seemed safe. However, now that the change has landed, I retested the live site and saw that it's still crashing. Moving the data storage under the true case for `IsBreakInside` fixes the live site. (cherry picked from commit 67934e0) Bug: 1399336 Change-Id: Ic702d2ae229ef23d582d75d98c0860be55e69ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4112318 Reviewed-by: Alison Maher <almaher@microsoft.com> Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Original-Commit-Position: refs/heads/main@{#1084467} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4131062 Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/branch-heads/5481@{chromium#109} Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
chirayudesai
pushed a commit
to chirayudesai/chromium
that referenced
this pull request
Mar 7, 2023
Change-Id: If45836c84e7d964b8f0d2b609e5b9e06e12c68bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4215459 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5563@{chromium#109} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
calyxos-gerrit
pushed a commit
to CalyxOS/chromium
that referenced
this pull request
Mar 31, 2023
…112.0.5615.8-r1 to 112-5599.0-1677494745-benchmark-112.0.5615.9-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium-beta Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I9cb2c7e0356ac436800d09b99c50eeedf2d2c074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4300315 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5615@{chromium#109} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
herocharge
pushed a commit
to vwvw/chromium
that referenced
this pull request
May 24, 2023
Prior to this CL the RenderFrameHostImpl and Document would manually compare the SiteForCookies against the frame origin using IsEquivalent(). This can leads to problem because IsEquivalent() and IsNull() are sensitive to the state of "Schemeful Same-Site". When "Schemeful Same-Site" is enabled IsNull() returns true if the SiteForCookie's schemefully_same flag is false (which occurs when the SiteForCookies is compared against a same registrable domain + different scheme origin). This leads to the IsEquivalent() returning false which finally leads to an empty (opaque) SiteForCookies being returned by RenderFrameHostImpl and Document. This empty SiteForCookies leads to the correct behavior only if every cookie is to be treated with "Schemeful Same-Site" behavior. If a cookie should instead be treated with legacy behavior (due to an enterprise policy), this cookie would not be accessible when it should be. This CL modifies this behavior to 1) Modify the computation to only return an empty SiteForCookies iff the registrable domains of the SiteForCookies and origin do not match. Mismatched schemes will only clear the schemefully_same flag. 1) Move frame origin computation into SiteForCookies to centralize the logic. Doing so allows legacy cookies to use the SiteForCookies even if it would otherwise be null due to "Schemeful Same-Site". (cherry picked from commit fa4d1a8) Bug: 1182414 Change-Id: I571119de6e4ead35e7bef7e7faf99c5e0b4e4299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2720902 Reviewed-by: Lily Chen <chlily@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#858382} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2733410 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Steven Bingler <bingler@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4430@{chromium#109} Cr-Branched-From: e5ce7dc-refs/heads/master@{#857950}
l0hn
pushed a commit
to l0hn/chromium_test
that referenced
this pull request
Jun 9, 2023
Context menu has a transparent layout occupying the whole screen. For partial width/height CCT to have the menu at the right position, window offset should also be taken into account. (cherry picked from commit f3bdd0d) Bug: 1440004 Change-Id: Ie079ee131414543c5d83249eb63ba8e6307d61b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4482049 Reviewed-by: Sinan Sahin <sinansahin@google.com> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1136679} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4496885 Cr-Commit-Position: refs/branch-heads/5735@{chromium#109} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
msizanoen1
pushed a commit
to qtmlabs/chromium
that referenced
this pull request
Jun 27, 2023
(cherry picked from commit 900a28b) Bug: 1456872 Change-Id: Ie6765521d676d5a0d4bb7580302c648f78840adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4637050 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Ankush Singh <ankushkush@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1161807} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4646274 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Krishna Govind <govind@chromium.org> Owners-Override: Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/5845@{chromium#109} Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
aetota61
pushed a commit
to monkbrowser/monk-browser
that referenced
this pull request
Aug 2, 2023
… than 360p. Manual HW vs SW quality testing has revealed that, to little surprise, the lowest resolutions provide inferior quality, especially if bitrate constrained. The HW encoders also don't like some resolutions due to divisibility, but today we already avoid e.g. 270p due to not being divisible by 4 so this already triggers SW for some HW encoders like MediaFoundationVideoEncodeAccelerator. But 180p and other resolutions suffer from bad quality. The breakeven point appears to be around 360p. This CL puts the "avoid < 360p HW" check in RTCVideoEncoder rather than on individual encoder implementations for two reasons: 1. This limits the logic to WebRTC meaning we don't break WebCodecs. 2. The quality issue appears to be similar on all implementations tested so far, power efficiency is less of a problem for lower resolutions anyway, and we don't have to duplicate this logic in multiple places. TESTED=See repro steps in https://crbug.com/1448816 as well as quality screenshots of before and after the fix: https://crbug.com/1448816#c3 (cherry picked from commit 629d58f) Bug: 1448816 Change-Id: Ibf41b815c788c475000206a4cfd6e13ffc419e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4562238 Reviewed-by: Ilya Nikolaevskiy <ilnik@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1149102} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4568339 Auto-Submit: Henrik Boström <hbos@chromium.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/branch-heads/5790@{chromium#109} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
trflynn89
pushed a commit
to RebelBrowser/rebel
that referenced
this pull request
Oct 26, 2023
…5-benchmark-118.0.5993.6-r1 to 118-5978.0-1693821895-benchmark-118.0.5993.8-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-arm-exp-chromium-beta Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I39d55d808c9caeed58ac29713abe3ec4757e0652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4855840 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5993@{chromium#109} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
vuzix-jeff
pushed a commit
to Vuzix/chromium
that referenced
this pull request
Nov 3, 2023
Roll Chrome Linux PGO profile from chrome-linux-6045-1696547102-b7f7db540d3aeda5e5a68b54a77da7256e8e6322.profdata to chrome-linux-6045-1696570439-96a47e5de72e661203c1e9f6c8c329d5998e66e1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m119.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1766b397a728052e6207cb772d0aaf598d60418d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4917189 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6045@{chromium#109} Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
Aikoyori
referenced
this pull request
in Pissandshittium/pissandshittium
Dec 8, 2023
Roll Chrome Win64 PGO profile from chrome-win64-6099-1698947397-3023c20c3f6a648c355f251f704e872c2b47f512.profdata to chrome-win64-6099-1698964636-360190d533149beba3d412ee497a26e3003fa1bc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m120.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia5f19a5b0b021109e7958277fdf447a1b3a667fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5003521 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6099@{#109} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable
pushed a commit
that referenced
this pull request
Jan 6, 2024
(cherry picked from commit 3e650bc) Fixed: 1508331,b/306365264 Change-Id: I507cbfbac26de1db41847e03b67a501ad2c61c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5071174 Auto-Submit: Samar Chehade-Lepleux <samarchehade@google.com> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Commit-Queue: Samar Chehade-Lepleux <samarchehade@google.com> Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1233509} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5099525 Reviewed-by: Jack Yammine <jyammine@google.com> Commit-Queue: Jack Yammine <jyammine@google.com> Cr-Commit-Position: refs/branch-heads/6167@{#109} Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable
pushed a commit
that referenced
this pull request
Jan 26, 2024
Yet again, as tip text is still being wrapped in too many lines. Dialog presentation with this update: screen/yeT3vDQ7Zbsh3LN (cherry picked from commit c210ae9) Bug: b:320489141, 1521480 Change-Id: I8710db3d95659b06c5f988bcf87af09243bc0cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5226768 Reviewed-by: Peter Williamson <petewil@chromium.org> Auto-Submit: Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1250636} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5239248 Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#109} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
consp1racy
pushed a commit
to signageos/chromium-chromium
that referenced
this pull request
Feb 21, 2024
This CL ensures that the max_x of the attached drag point for the TabDragController's attached_views_ does not drop below 0. This guards against the case where the width needed for attached_views_ exceeds the tab drag area width. In this case the attached_views_ will attach at the beginning of the tab strip and overflow in the tab strip as usual. (cherry picked from commit 254a638) Bug: 1250184 Change-Id: I3be447b696b639e0c083bbf36c5a95d07194f932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3166210 Reviewed-by: Connie Wan <connily@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#922289} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3166182 Reviewed-by: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/branch-heads/4638@{chromium#109} Cr-Branched-From: 159257c-refs/heads/main@{#920003}
aarongable
pushed a commit
that referenced
this pull request
Feb 23, 2024
Add exclusion criteria using android digital asset links (cherry picked from commit 83a6911) Bug: 326400698 Change-Id: Ie045c65cd2bd6d83491dc069a70ba16997730028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272350 Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Alex Kallam <aakallam@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Abhijith Nair <abhijithnair@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by: Ashley Newson <ashleynewson@chromium.org> Reviewed-by: Richard (Torne) Coles <torne@chromium.org> Reviewed-by: David Schinazi <dschinazi@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1264451} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5317640 Commit-Queue: Aashna Jena <aashnajena@google.com> Cr-Commit-Position: refs/branch-heads/6312@{#109} Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
aarongable
pushed a commit
that referenced
this pull request
Mar 22, 2024
Roll Chrome Win32 PGO profile from chrome-win32-6367-1711043043-405eb5015f76e5a0d82421071f52c46385113d03-97114d7ab7411108d343cff808845e04bcc53834.profdata to chrome-win32-6367-1711065560-6fc8ed06eaf2b1252356c33c66840cb3ca808392-b2496978030535ee291ced93a78cb9af70a84363.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m124.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0e84b1494af1d0e24dd4d19bef93506988d14785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5386845 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6367@{#109} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
NaaeemMalik
pushed a commit
to SoftwarePrince/Egon-Chromium
that referenced
this pull request
Mar 22, 2024
The custom with-shadow border color isn't really visible in dark mode, and it isn't necessary to use a different color than the standard one. The only distinction the "with shadows" version has is whether to draw a border at all, which is controlled separately than "what is the color". (cherry picked from commit 70be0a6) Bug: 1470006 Change-Id: I609a9da5d09249a13a0eaefab06b511a6d2291cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4760684 Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by: Elaine Chien <elainechien@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1181336} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4777062 Commit-Queue: Elaine Chien <elainechien@chromium.org> Cr-Commit-Position: refs/branch-heads/5938@{chromium#109} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
aarongable
pushed a commit
that referenced
this pull request
Apr 19, 2024
This method ensure that the error message is always displayed. Both the old and the new method are implemented using the other one. That allow chrome to build without and with the ios_internal commit linked below. The old method is removed in the last CL of this chain. This is part of the sequence: => crrev.com/c/5453457 * crrev.com/i/7188916 * crrev.com/c/5461616 (cherry picked from commit cac7d73) Bug: 325167488, 335405821 Change-Id: I8e632ba4e9ea75cf72164acac2ca7375ddc3d4f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5453457 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Arthur Milchior <arthurmilchior@chromium.org> Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1288149} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463943 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Samar Chehade-Lepleux <samarchehade@google.com> Commit-Queue: Samar Chehade-Lepleux <samarchehade@google.com> Cr-Commit-Position: refs/branch-heads/6422@{#109} Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
aarongable
pushed a commit
that referenced
this pull request
May 17, 2024
Change-Id: I18148dd7a5be09d2364416a1e300439668b9308b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5546937 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#109} Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}
consp1racy
pushed a commit
to signageos/chromium-chromium
that referenced
this pull request
May 24, 2024
Update network-list-item to show the network detail page if an activating or unavailable pSIM network is selected. (cherry picked from commit 70840b7) Fixed: 1196507 Change-Id: Ib9a01e319d8a15dc46cdb81f1d8689e079044b74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2824738 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Gordon Seto <gordonseto@google.com> Cr-Original-Commit-Position: refs/heads/master@{#872445} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2827759 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4472@{chromium#109} Cr-Branched-From: 3d60439-refs/heads/master@{#870763}
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 100.0.4854.0, there has been a problem that the Link fails to pass after Android compilation. The content is as follows: How to solve it?