Correction Inconsistent German translation of Clipboard Read Access c… #12

oussama789 · 2018-12-10T09:15:27Z

…hoices Bug: 905327

This CL is putting back the |AbortScenario| code to the previous state. Landed here: https://chromium-review.googlesource.com/c/chromium/src/+/1289672 The "if (is_tracing_)" is required to avoid calling the tracing controller when it's not instantiated. This is only happening in the unittest. [ RUN ] BackgroundTracingTest.SetupBackgroundTracingFieldTrial [184899:184899:1204/184233.049256:3597383076062:FATAL:tracing_controller_impl.cc(283)] Check failed: g_tracing_controller. #0 0x7fefd86edf5d base::debug::StackTrace::StackTrace() chromium#1 0x7fefd83ded3a base::debug::StackTrace::StackTrace() chromium#2 0x7fefd8450a4b logging::LogMessage::~LogMessage() chromium#3 0x7fefd461c1e1 content::TracingControllerImpl::GetInstance() chromium#4 0x7fefd460e198 content::BackgroundTracingManagerImpl::AbortScenario() chromium#5 0x55ec45d76fa2 BackgroundTracingTest::TearDown() chromium#6 0x55ec473ff12e _ZN7testing8internal12InvokeHelperIvNSt3__15tupleIJEEEE12InvokeMethodIN10extensions27ExtensionDownloaderDelegateEMS8_FvvEEEvPT_T0_RKS4_ chromium#7 0x55ec4846fc42 testing::internal::HandleExceptionsInMethodIfSupported<>() chromium#8 0x55ec4844f2f8 testing::Test::Run() chromium#9 0x55ec4844ff52 testing::TestInfo::Run() chromium#10 0x55ec48450e5f testing::TestCase::Run() chromium#11 0x55ec48464fcb testing::internal::UnitTestImpl::RunAllTests() chromium#12 0x55ec4847946e testing::internal::HandleSehExceptionsInMethodIfSupported<>() chromium#13 0x55ec48471472 testing::internal::HandleExceptionsInMethodIfSupported<>() chromium#14 0x55ec48464c07 testing::UnitTest::Run() chromium#15 0x55ec4aaa2bc1 RUN_ALL_TESTS() R=oysteine@chromium.org Change-Id: I9198c6db87a03daba5f75ece529f104ecbfe8609 Reviewed-on: https://chromium-review.googlesource.com/c/1361830 Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#614056}

This reverts commit a612879. Reason for revert: Suspect Failure single_process_mash_ash_unittests Failure ash_unittests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/16943 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8927839167159249024/+/steps/single_process_mash_ash_unittests/0/logs/LoginExpandedPublicAccountViewTest.ChangeMenuSelection/0 --- [ RUN ] LoginExpandedPublicAccountViewTest.ChangeMenuSelection Received signal 11 SEGV_MAPERR ffffe03f000008fe #0 0x5631a3caedbf base::debug::StackTrace::StackTrace() chromium#1 0x5631a3cae941 base::debug::(anonymous namespace)::StackDumpSignalHandler() chromium#2 0x7faa9920f330 <unknown> chromium#3 0x5631a3aafbbf ash::LoginBubble::~LoginBubble() chromium#4 0x5631a3ab806c ash::RightPaneView::~RightPaneView() chromium#5 0x5631a3ab810e ash::RightPaneView::~RightPaneView() chromium#6 0x5631a40385d4 views::View::~View() chromium#7 0x5631a3ab6df9 ash::LoginExpandedPublicAccountView::~LoginExpandedPublicAccountView() chromium#8 0x5631a40385d4 views::View::~View() chromium#9 0x5631a300afce ash::(anonymous namespace)::DragTestView::~DragTestView() chromium#10 0x5631a4039b42 views::View::DoRemoveChildView() chromium#11 0x5631a403a175 views::View::RemoveAllChildViews() chromium#12 0x5631a4043b81 views::internal::RootView::~RootView() chromium#13 0x5631a400ef0e views::MenuHostRootView::~MenuHostRootView() chromium#14 0x5631a404615f views::Widget::~Widget() chromium#15 0x5631a34d645e exo::(anonymous namespace)::ShellSurfaceWidget::~ShellSurfaceWidget() chromium#16 0x5631a30c36f0 ash::LoginTestBase::TearDown() Original change's description: > cros: Move most event/widget handling logic out of LoginBubble > > Changes made: > - Move the (keyboard/click/tap) event handling logic into a > LoginBubbleHandler class. > - Move the widget handling into LoginBaseBubbleView itself > > Bug: 912658 > Change-Id: Ia1a9bf4b8d847ef74ef1716e73dfe1b16b8d19b2 > Reviewed-on: https://chromium-review.googlesource.com/c/1366516 > Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614544} TBR=jdufault@chromium.org,qnnguyen@chromium.org Change-Id: Ia9b9059f24f6aa6a8551c5c6bc5c76caafe592df No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 912658 Reviewed-on: https://chromium-review.googlesource.com/c/1367070 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#614579}

This reverts commit 6240455. Reason for revert: This causes crashes when running telemetry on actual chromeos devices. I was specifically running on veyron-minnie. I don't know if this is the problem, but turning on DCHECKs shows this DCHECK hit: #0 0x0000085def4c base::debug::StackTrace::StackTrace() #1 0x000008564cc6 logging::LogMessage::~LogMessage() #2 0x000006cfadce arc::(anonymous namespace)::ArcTracingDataSource::StartTracingOnUI() #3 0x0000085f85ba base::debug::TaskAnnotator::RunTask() #4 0x00000856d6ee base::MessageLoopImpl::RunTask() #5 0x00000856db66 base::MessageLoopImpl::DoWork() #6 0x0000085f5a34 base::MessagePumpLibevent::Run() #7 0x00000856d364 base::MessageLoopImpl::Run() #8 0x00000858aed6 base::RunLoop::Run() #9 0x0000081eed22 ChromeBrowserMainParts::MainMessageLoopRun() #10 0x0000062a24a2 content::BrowserMainLoop::RunMainMessageLoopParts() #11 0x0000062a4234 content::BrowserMainRunnerImpl::Run() #12 0x00000629ffb0 content::BrowserMain() #13 0x0000081e4870 content::ContentMainRunnerImpl::RunServiceManager() #14 0x0000081e45dc content::ContentMainRunnerImpl::Run() #15 0x0000081e99c4 service_manager::Main() #16 0x0000081e3352 content::ContentMain() #17 0x0000056be61c ChromeMain #18 0x0000ab8ef0a2 __libc_start_main reverting your patch did in fact make things happy. Original change's description: > tracing: Port ARC tracing agent to perfetto > > Adds a new DataSource for the ARC++ system tracing agent. > Each ArcTracingBridge registers with the data source and keeps track of > its state, so that the data source can coordinate tracing between all > the bridges. > > TBR=oysteine@google.com > > Test: Manually capture a trace with and without perfetto backend. > Bug: 900603 > Change-Id: Ieb29bcb65de9f4802965a30844e9f76af55db1f3 > Reviewed-on: https://chromium-review.googlesource.com/c/1360736 > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615483} TBR=yusukes@chromium.org,hidehiko@chromium.org,oysteine@chromium.org,tsepez@chromium.org,eseckler@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 900603 Change-Id: I723711488acdbe5c59cd6a70f1443c631b77d9b7 Reviewed-on: https://chromium-review.googlesource.com/c/1374796 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#616138}

This CL adds a histogram to track which of three possible interactions were used to change the current page in the tab grid. Bug: 879487 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I35d6cb289b4c9fb8418e8d40f356bf914ae5d302 Reviewed-on: https://chromium-review.googlesource.com/1193948 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#587974}(cherry picked from commit f35d6bb) Reviewed-on: https://chromium-review.googlesource.com/1201858 Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{chromium#12} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}

This reverts commit cd7ff35637bfee1e51260aa0b8eae3c18a1d3d90. Reason for revert: the CL seems to break Linux ChromiumOS MSan Tests https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/10621 Test 'ChromeVoxLibLouisTest.checkAllTables' completed with the following status(es): 'TIMEOUT','TIMEOUT','TIMEOUT','TIMEOUT' Test 'ChromeVoxLibLouisTest.checkAllTables' had the following logs when run: ================================================================================ [ RUN ] ChromeVoxLibLouisTest.checkAllTables [1147:1147:0107/160655.775671:WARNING:chrome_browser_main_chromeos.cc(552)] Running as stub user with profile dir: test-user [1147:1147:0107/160656.293572:WARNING:easy_unlock_service_regular.cc(438)] EasyUnlockServiceRegular::IsInLegacyHostMode: DeviceSyncClient not ready. Returning false. [1147:1147:0107/160656.382735:INFO:remote_commands_service.cc(38)] Fetching remote commands. [1147:1147:0107/160656.383082:WARNING:remote_commands_service.cc(40)] Client is not registered. [1147:1147:0107/160656.383205:INFO:remote_commands_invalidator.cc(32)] Initialize RemoteCommandsInvalidator. [1147:1147:0107/160656.383284:INFO:remote_commands_invalidator.cc(57)] Starting RemoteCommandsInvalidator. [1147:1147:0107/160656.383603:INFO:remote_commands_invalidator.cc(123)] RemoteCommandsInvalidator ReloadPolicyData. [1147:1147:0107/160656.390919:INFO:remote_commands_invalidator.cc(167)] Unregister RemoteCommandsInvalidator. [1147:1147:0107/160656.579130:WARNING:wallpaper_controller_client.cc(358)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances. [1147:1147:0107/160657.596893:ERROR:gpu_interface_provider.cc(87)] Not implemented reached in virtual void content::GpuInterfaceProvider::RegisterOzoneGpuInterfaces(service_manager::BinderRegistry *) [1147:1147:0107/160658.079601:ERROR:remote_text_input_client.cc(144)] Not implemented reached in virtual void RemoteTextInputClient::OnInputMethodChanged() [1147:1147:0107/160658.079713:ERROR:remote_text_input_client.cc(101)] Not implemented reached in virtual ui::TextInputClient::FocusReason RemoteTextInputClient::GetFocusReason() const [1147:1147:0107/160658.079772:ERROR:remote_text_input_client.cc(185)] Not implemented reached in virtual bool RemoteTextInputClient::ShouldDoLearning() [1147:1147:0107/160658.079873:ERROR:remote_text_input_client.cc(95)] Not implemented reached in virtual bool RemoteTextInputClient::HasCompositionText() const [1147:1147:0107/160658.079929:ERROR:remote_text_input_client.cc(107)] Not implemented reached in virtual bool RemoteTextInputClient::GetTextRange(gfx::Range *) const ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [1147:1351:0107/160658.449133:ERROR:alsa_util.cc(204)] PcmOpen: default,No such file or directory ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [1147:1351:0107/160658.450019:ERROR:alsa_util.cc(204)] PcmOpen: plug:default,No such file or directory [1147:1147:0107/160701.411856:INFO:CONSOLE(1071)] "Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1071) [1147:1333:0107/160714.779443:ERROR:component_loader.cc(92)] Can't load /usr/share/chromeos-assets/speech_synthesis/patts/manifest.json: Manifest file is missing or unreadable [1147:1333:0107/160714.779806:ERROR:component_loader.cc(92)] Can't load /usr/share/chromeos-assets/speech_synthesis/espeak-ng/manifest.json: Manifest file is missing or unreadable [1147:1147:0107/160714.791455:ERROR:prefs_util.cc(601)] Cros settings pref not found: cros.display_rotation_default [1147:1147:0107/160719.628821:INFO:CONSOLE(963)] "Speak (Q) category=nav "Address and search bar"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963) [1147:1147:0107/160719.683004:INFO:CONSOLE(963)] "Speak (Q) category=nav "about:blank"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963) [1147:1147:0107/160719.731180:INFO:CONSOLE(963)] "Speak (Q) category=nav "Edit text, URL entry"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963) [1147:1147:0107/160719.819361:INFO:CONSOLE(963)] "Speak (Q) category=nav "about:blank - Chromium - Petals, window"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963) [1147:1147:0107/160719.852972:INFO:CONSOLE(963)] "Speak (Q) category=nav "Press up or down arrow for auto completions."", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963) [1147:1147:0107/160719.901464:INFO:CONSOLE(963)] "Speak (Q) category=nav "Type to auto complete."", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963) [1147:1334:0107/160812.728048:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.733817:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.735773:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.742939:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.744209:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.745276:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.752755:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.753947:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.755288:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.756316:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.757937:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.768173:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.769308:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.771299:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.772389:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.773525:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.774980:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.776155:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.790374:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.791636:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.792742:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.793870:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.794927:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.796357:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.797399:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.798426:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.799433:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.800470:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.801525:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.820688:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.821839:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.822877:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.823949:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.825004:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.826056:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.827080:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.828187:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.829293:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.830341:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.831416:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.832571:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.833633:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1334:0107/160812.834801:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [1147:1147:0107/160818.079331:INFO:CONSOLE(963)] "Speak (Q) "ChromeVox spoken feedback is ready"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963) [1147:1147:0107/160818.303430:INFO:CONSOLE(7817)] "Running TestCase ChromeVoxLibLouisTest.checkAllTables", source: file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs (7817) [1147:1147:0107/160818.306002:INFO:CONSOLE(7043)] "ReferenceError: axs is not defined at ChromeVoxLibLouisTest.get accessibilityAuditConfig [as accessibilityAuditConfig] (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:6704:44) at ChromeVoxLibLouisTest.setUp (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:6845:10) at TestCase.setUp (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:6997:20) at TestCase.run (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:7039:12) at RUN_TEST_F (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:7818:19) at file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:7579:18 at runTestFunction (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:7656:35) at runTest (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:7630:16) at file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:8914:1", source: file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs (7043) [1147:1147:0107/160819.627083:INFO:CONSOLE(1266)] "Injecting into 2", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1266) [1147:1147:0107/160821.151328:INFO:CONSOLE(1827)] "ChromeVox waiting for background page: about:blank. Will try again in 100ms", source: chrome-extension://chromevox/chromeVoxChromePageScript.js (1827) [1:1:0107/160821.338681:WARNING:logging_native_handler.cc(71)] Got textChanged event on unknown node: 2; this: 1 [1147:1147:0107/160823.558360:INFO:CONSOLE(2315)] "got inlen!15", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/braille/liblouis_wasm.js (2315) BrowserTestBase received signal: Terminated. Backtrace: #0 0x56353de537b1 in __interceptor_backtrace /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:4050:13 #1 0x563553b2f28a in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:820:41 #2 0x5635558f1388 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:100:5 #3 0x56353de7b9a9 in SignalHandler(int) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:992:3 #4 0x7fbea64d7cb0 in killpg ??:? #5 0x7fbea64d7cb0 in ?? ??:0 #6 0x7fbea659f6d3 in epoll_wait ??:0:0 #7 0x56353de3c8c4 in __interceptor_epoll_wait /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:859:13 #8 0x563557b380a9 in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8 #9 0x563557b2b2ab in event_base_loop ./../../base/third_party/libevent/event.c:512:9 #10 0x563553b868c9 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9 #11 0x5635539187b0 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14 #12 0x5635559118f9 in content::DOMMessageQueue::WaitForMessage(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*) ./../../content/public/test/browser_test_utils.cc:2214:14 #13 0x5635559025dd in content::(anonymous namespace)::ExecuteScriptHelper(content::RenderFrameHost*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool, int, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >*) ./../../content/public/test/browser_test_utils.cc:197:26 #14 0x563555901092 in content::ExecuteScriptAndExtractString(content::ToRenderFrameHost const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*) ./../../content/public/test/browser_test_utils.cc:1241:10 #15 0x56355317b334 in extensions::browsertest_util::ExecuteScriptInBackgroundPage(content::BrowserContext*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, extensions::browsertest_util::ScriptUserActivation) ./../../extensions/browser/browsertest_util.cc:30:15 #16 0x5635537a2624 in ExtensionJSBrowserTest::RunJavascriptTestF(bool, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) ./../../chrome/test/base/extension_js_browser_test.cc:51:7 #17 0x5635531d00b4 in ChromeVoxLibLouisTest_checkAllTables_Test::RunTestOnMainThread() ./gen/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test-gen.cc:35:3 #18 0x5635558edc11 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:462:5 #19 0x563553f3f2e8 in Run ./../../base/callback.h:129:12 #20 0x563553f3f2e8 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1794:0 #21 0x563553f3adf6 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1182:18 #22 0x563544c76faa in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:668:32 #23 0x56354a56555a in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:984:13 #24 0x56354bd1fdcd in Run ./../../base/callback.h:129:12 #25 0x56354bd1fdcd in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:0 #26 0x56354a55e48a in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:918:25 #27 0x56354a5700bb in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) ./../../content/browser/browser_main_runner_impl.cc:144:15 #28 0x56354a553eca in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:43:32 #29 0x5635523ecea0 in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:545:10 #30 0x5635523ecea0 in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:954:0 #31 0x5635523ebb29 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:868:12 #32 0x56355db3aa61 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:461:29 #33 0x5635523e394f in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 #34 0x5635558ebc71 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:349:3 #35 0x563553d7b385 in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:284:20 #36 0x563546763769 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #37 0x563546763769 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2517:0 #38 0x563546767cde in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2703:11 #39 0x563546769a3a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2825:28 #40 0x5635467a056a in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5227:43 #41 0x56354679edd9 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #42 0x56354679edd9 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:4835:0 #43 0x563553df217b in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2369:46 #44 0x563553df217b in base::TestSuite::Run() ./../../base/test/test_suite.cc:294:0 #45 0x56355377857d in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:71:21 #46 0x5635559a0163 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:647:31 #47 0x563553779c0d in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:184:10 #48 0x563553778331 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10 #49 0x7fbea64c2f45 in __libc_start_main ??:0:0 #50 0x56353de1627a in _start ??:0:0 [ RUN ] ChromeVoxLibLouisTest.checkAllTables [2562:2562:0107/162500.711425:WARNING:chrome_browser_main_chromeos.cc(552)] Running as stub user with profile dir: test-user [2562:2562:0107/162501.159210:WARNING:easy_unlock_service_regular.cc(438)] EasyUnlockServiceRegular::IsInLegacyHostMode: DeviceSyncClient not ready. Returning false. [2562:2562:0107/162501.242559:INFO:remote_commands_service.cc(38)] Fetching remote commands. [2562:2562:0107/162501.242759:WARNING:remote_commands_service.cc(40)] Client is not registered. [2562:2562:0107/162501.242928:INFO:remote_commands_invalidator.cc(32)] Initialize RemoteCommandsInvalidator. [2562:2562:0107/162501.243067:INFO:remote_commands_invalidator.cc(57)] Starting RemoteCommandsInvalidator. [2562:2562:0107/162501.243179:INFO:remote_commands_invalidator.cc(123)] RemoteCommandsInvalidator ReloadPolicyData. [2562:2562:0107/162501.243282:INFO:remote_commands_invalidator.cc(167)] Unregister RemoteCommandsInvalidator. [2562:2562:0107/162501.321464:WARNING:wallpaper_controller_client.cc(358)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances. [2562:2562:0107/162501.849934:ERROR:gpu_interface_provider.cc(87)] Not implemented reached in virtual void content::GpuInterfaceProvider::RegisterOzoneGpuInterfaces(service_manager::BinderRegistry *) [2562:2562:0107/162502.174377:ERROR:remote_text_input_client.cc(144)] Not implemented reached in virtual void RemoteTextInputClient::OnInputMethodChanged() [2562:2562:0107/162502.174458:ERROR:remote_text_input_client.cc(101)] Not implemented reached in virtual ui::TextInputClient::FocusReason RemoteTextInputClient::GetFocusReason() const [2562:2562:0107/162502.174493:ERROR:remote_text_input_client.cc(185)] Not implemented reached in virtual bool RemoteTextInputClient::ShouldDoLearning() [2562:2562:0107/162502.174578:ERROR:remote_text_input_client.cc(95)] Not implemented reached in virtual bool RemoteTextInputClient::HasCompositionText() const [2562:2562:0107/162502.174612:ERROR:remote_text_input_client.cc(107)] Not implemented reached in virtual bool RemoteTextInputClient::GetTextRange(gfx::Range *) const ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [2562:2591:0107/162502.414602:ERROR:alsa_util.cc(204)] PcmOpen: default,No such file or directory ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [2562:2591:0107/162502.415346:ERROR:alsa_util.cc(204)] PcmOpen: plug:default,No such file or directory [2562:2562:0107/162504.313775:INFO:CONSOLE(1071)] "Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1071) [2562:2575:0107/162514.740684:ERROR:component_loader.cc(92)] Can't load /usr/share/chromeos-assets/speech_synthesis/patts/manifest.json: Manifest file is missing or unreadable [2562:2575:0107/162514.740902:ERROR:component_loader.cc(92)] Can't load /usr/share/chromeos-assets/speech_synthesis/espeak-ng/manifest.json: Manifest file is missing or unreadable [2562:2562:0107/162514.751286:ERROR:prefs_util.cc(601)] Cros settings pref not found: cros.display_rotation_default [2562:2562:0107/162517.980813:INFO:CONSOLE(963)] "Speak (Q) category=nav "Address and search bar"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963) [2562:2562:0107/162518.009846:INFO:CONSOLE(963)] "Speak (Q) category=nav "about:blank"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963) [2562:2562:0107/162518.035858:INFO:CONSOLE(963)] "Speak (Q) category=nav "Edit text, URL entry"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963) [2562:2562:0107/162518.089674:INFO:CONSOLE(963)] "Speak (Q) category=nav "about:blank - Chromium - Agent X, window"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963) [2562:2562:0107/162518.117860:INFO:CONSOLE(963)] "Speak (Q) category=nav "Press up or down arrow for auto completions."", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963) [2562:2562:0107/162518.145602:INFO:CONSOLE(963)] "Speak (Q) category=nav "Type to auto complete."", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963) [2562:2578:0107/162557.607476:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.610170:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.612492:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.614876:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.617148:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.621231:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.623745:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.625903:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.627990:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.630001:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.632124:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.634487:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.636608:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.638795:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.641341:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.643386:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.645705:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.647889:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.650372:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.652676:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.656201:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.657152:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.660622:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.662900:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.665673:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.667871:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.670720:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.671629:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.675400:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.676295:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.679462:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.680296:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.683914:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.685698:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.687744:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.689811:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.691897:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.693936:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.696050:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.698066:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.699969:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.702551:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2578:0107/162557.704756:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2562:2562:0107/162600.837617:INFO:CONSOLE(963)] "Speak (Q) "ChromeVox spoken feedback is ready"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963) [2562:2562:0107/162601.037587:INFO:CONSOLE(7817)] "Running TestCase ChromeVoxLibLouisTest.checkAllTables", source: file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs (7817) [2562:2562:0107/162601.040023:INFO:CONSOLE(7043)] "ReferenceError: axs is not defined at ChromeVoxLibLouisTest.get accessibilityAuditConfig [as accessibilityAuditConfig] (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:6704:44) at ChromeVoxLibLouisTest.setUp (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:6845:10) at TestCase.setUp (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:6997:20) at TestCase.run (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:7039:12) at RUN_TEST_F (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:7818:19) at file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:7579:18 at runTestFunction (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:7656:35) at runTest (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:7630:16) at file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:8914:1", source: file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs (7043) [2562:2562:0107/162601.757382:INFO:CONSOLE(1266)] "Injecting into 2", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1266) [2562:2562:0107/162602.637842:INFO:CONSOLE(1827)] "ChromeVox waiting for background page: about:blank. Will try again in 100ms", source: chrome-extension://chromevox/chromeVoxChromePageScript.js (1827) [1:1:0107/162602.784849:WARNING:logging_native_handler.cc(71)] Got textChanged event on unknown node: 2; this: 1 [2562:2562:0107/162604.746881:INFO:CONSOLE(2315)] "got inlen!15", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/braille/liblouis_wasm.js (2315) BrowserTestBase received signal: Terminated. Backtrace: #0 0x563c392227b1 in __interceptor_backtrace /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:4050:13 #1 0x563c4eefe28a in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:820:41 #2 0x563c50cc0388 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:100:5 #3 0x563c3924a9a9 in SignalHandler(int) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:992:3 #4 0x7fb6ff9d9cb0 in killpg ??:? #5 0x7fb6ff9d9cb0 in ?? ??:0 #6 0x7fb6ffaa16d3 in epoll_wait ??:0:0 #7 0x563c3920b8c4 in __interceptor_epoll_wait /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:859:13 #8 0x563c52f070a9 in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8 #9 0x563c52efa2ab in event_base_loop ./../../base/third_party/libevent/event.c:512:9 #10 0x563c4ef558c9 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9 #11 0x563c4ece77b0 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14 #12 0x563c50ce08f9 in content::DOMMessageQueue::WaitForMessage(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*) ./../../content/public/test/browser_test_utils.cc:2214:14 #13 0x563c50cd15dd in content::(anonymous namespace)::ExecuteScriptHelper(content::RenderFrameHost*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool, int, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >*) ./../../content/public/test/browser_test_utils.cc:197:26 #14 0x563c50cd0092 in content::ExecuteScriptAndExtractString(content::ToRenderFrameHost const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*) ./../../content/public/test/browser_test_utils.cc:1241:10 #15 0x563c4e54a334 in extensions::browsertest_util::ExecuteScriptInBackgroundPage(content::BrowserContext*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, extensions::browsertest_util::ScriptUserActivation) ./../../extensions/browser/browsertest_util.cc:30:15 #16 0x563c4eb71624 in ExtensionJSBrowserTest::RunJavascriptTestF(bool, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) ./../../chrome/test/base/extension_js_browser_test.cc:51:7 #17 0x563c4e59f0b4 in ChromeVoxLibLouisTest_checkAllTables_Test::RunTestOnMainThread() ./gen/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test-gen.cc:35:3 #18 0x563c50cbcc11 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:462:5 #19 0x563c4f30e2e8 in Run ./../../base/callback.h:129:12 #20 0x563c4f30e2e8 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1794:0 #21 0x563c4f309df6 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1182:18 #22 0x563c40045faa in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:668:32 #23 0x563c4593455a in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:984:13 #24 0x563c470eedcd in Run ./../../base/callback.h:129:12 #25 0x563c470eedcd in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:0 #26 0x563c4592d48a in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:918:25 #27 0x563c4593f0bb in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) ./../../content/browser/browser_main_runner_impl.cc:144:15 #28 0x563c45922eca in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:43:32 #29 0x563c4d7bbea0 in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:545:10 #30 0x563c4d7bbea0 in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:954:0 #31 0x563c4d7bab29 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:868:12 #32 0x563c58f09a61 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:461:29 #33 0x563c4d7b294f in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 #34 0x563c50cbac71 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:349:3 #35 0x563c4f14a385 in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:284:20 #36 0x563c41b32769 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #37 0x563c41b32769 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2517:0 #38 0x563c41b36cde in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2703:11 #39 0x563c41b38a3a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2825:28 #40 0x563c41b6f56a in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5227:43 #41 0x563c41b6ddd9 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #42 0x563c41b6ddd9 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:4835:0 #43 0x563c4f1c117b in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2369:46 #44 0x563c4f1c117b in base::TestSuite::Run() ./../../base/test/test_suite.cc:294:0 #45 0x563c4eb4757d in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:71:21 #46 0x563c50d6f163 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:647:31 #47 0x563c4eb48c0d in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:184:10 #48 0x563c4eb47331 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10 #49 0x7fb6ff9c4f45 in __libc_start_main ??:0:0 #50 0x563c391e527a in _start ??:0:0 [ RUN ] ChromeVoxLibLouisTest.checkAllTables [2719:2719:0107/162830.826996:WARNING:chrome_browser_main_chromeos.cc(552)] Running as stub user with profile dir: test-user [2719:2719:0107/162831.284405:WARNING:easy_unlock_service_regular.cc(438)] EasyUnlockServiceRegular::IsInLegacyHostMode: DeviceSyncClient not ready. Returning false. [2719:2719:0107/162831.383916:INFO:remote_commands_service.cc(38)] Fetching remote commands. [2719:2719:0107/162831.384162:WARNING:remote_commands_service.cc(40)] Client is not registered. [2719:2719:0107/162831.384283:INFO:remote_commands_invalidator.cc(32)] Initialize RemoteCommandsInvalidator. [2719:2719:0107/162831.384380:INFO:remote_commands_invalidator.cc(57)] Starting RemoteCommandsInvalidator. [2719:2719:0107/162831.384479:INFO:remote_commands_invalidator.cc(123)] RemoteCommandsInvalidator ReloadPolicyData. [2719:2719:0107/162831.384566:INFO:remote_commands_invalidator.cc(167)] Unregister RemoteCommandsInvalidator. [2719:2719:0107/162831.472302:WARNING:wallpaper_controller_client.cc(358)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances. [2719:2719:0107/162832.061600:ERROR:gpu_interface_provider.cc(87)] Not implemented reached in virtual void content::GpuInterfaceProvider::RegisterOzoneGpuInterfaces(service_manager::BinderRegistry *) [2719:2719:0107/162832.392289:ERROR:remote_text_input_client.cc(144)] Not implemented reached in virtual void RemoteTextInputClient::OnInputMethodChanged() [2719:2719:0107/162832.392380:ERROR:remote_text_input_client.cc(101)] Not implemented reached in virtual ui::TextInputClient::FocusReason RemoteTextInputClient::GetFocusReason() const [2719:2719:0107/162832.392420:ERROR:remote_text_input_client.cc(185)] Not implemented reached in virtual bool RemoteTextInputClient::ShouldDoLearning() [2719:2719:0107/162832.392494:ERROR:remote_text_input_client.cc(95)] Not implemented reached in virtual bool RemoteTextInputClient::HasCompositionText() const [2719:2719:0107/162832.392531:ERROR:remote_text_input_client.cc(107)] Not implemented reached in virtual bool RemoteTextInputClient::GetTextRange(gfx::Range *) const ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [2719:2748:0107/162832.670090:ERROR:alsa_util.cc(204)] PcmOpen: default,No such file or directory ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [2719:2748:0107/162832.670855:ERROR:alsa_util.cc(204)] PcmOpen: plug:default,No such file or directory [2719:2719:0107/162834.560324:INFO:CONSOLE(1071)] "Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1071) [2719:2734:0107/162844.602132:ERROR:component_loader.cc(92)] Can't load /usr/share/chromeos-assets/speech_synthesis/patts/manifest.json: Manifest file is missing or unreadable [2719:2734:0107/162844.602339:ERROR:component_loader.cc(92)] Can't load /usr/share/chromeos-assets/speech_synthesis/espeak-ng/manifest.json: Manifest file is missing or unreadable [2719:2719:0107/162844.609207:ERROR:prefs_util.cc(601)] Cros settings pref not found: cros.display_rotation_default [2719:2719:0107/162847.921856:INFO:CONSOLE(963)] "Speak (Q) category=nav "Address and search bar"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963) [2719:2719:0107/162847.951836:INFO:CONSOLE(963)] "Speak (Q) category=nav "about:blank"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963) [2719:2719:0107/162847.979341:INFO:CONSOLE(963)] "Speak (Q) category=nav "Edit text, URL entry"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963) [2719:2719:0107/162848.035028:INFO:CONSOLE(963)] "Speak (Q) category=nav "about:blank - Chromium - Petals, window"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963) [2719:2719:0107/162848.063344:INFO:CONSOLE(963)] "Speak (Q) category=nav "Press up or down arrow for auto completions."", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963) [2719:2719:0107/162848.091846:INFO:CONSOLE(963)] "Speak (Q) category=nav "Type to auto complete."", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963) [2719:2735:0107/162927.703289:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.706244:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.708838:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.711110:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.712002:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.715187:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.717351:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.719685:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.722436:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.723272:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.726550:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.728809:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.729575:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.733161:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.734327:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.735152:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.739102:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.739940:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.740662:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.744956:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.745755:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.746620:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.751749:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.752720:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.753466:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.754366:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.759807:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.760670:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.761401:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.762128:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.767509:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.768346:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.769061:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.769752:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.774814:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.775624:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.776421:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.777179:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.782531:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.783309:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.784010:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.784757:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2735:0107/162927.788710:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/ [2719:2719:0107/162931.476566:INFO:CONSOLE(963)] "Speak (Q) "ChromeVox spoken feedback is ready"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963) [2719:2719:0107/162931.678028:INFO:CONSOLE(7817)] "Running TestCase ChromeVoxLibLouisTest.checkAllTables", source: file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs (7817) [2719:2719:0107/162931.680158:INFO:CONSOLE(7043)] "ReferenceError: axs is not defined at ChromeVoxLibLouisTest.get accessibilityAuditConfig [as accessibilityAuditConfig] (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:6704:44) at ChromeVoxLibLouisTest.setUp (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:6845:10) at TestCase.setUp (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:6997:20) at TestCase.run (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:7039:12) at RUN_TEST_F (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:7818:19) at file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:7579:18 at runTestFunction (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:7656:35) at runTest (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:7630:16) at file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:8914:1", source: file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs (7043) [2719:2719:0107/162932.701492:INFO:CONSOLE(1266)] "Injecting into 2", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1266) [2719:2719:0107/162933.650524:INFO:CONSOLE(1827)] "ChromeVox waiting for background page: about:blank. Will try again in 100ms", source: chrome-extension://chromevox/chromeVoxChromePageScript.js (1827) [1:1:0107/162933.746499:WARNING:logging_native_handler.cc(71)] Got textChanged event on unknown node: 2; this: 1 [2719:2719:0107/162935.305957:INFO:CONSOLE(2315)] "got inlen!15", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/braille/liblouis_wasm.js (2315) BrowserTestBase received signal: Terminated. Backtrace: #0 0x563d5c5867b1 in __interceptor_backtrace /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:4050:13 #1 0x563d7226228a in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:820:41 #2 0x563d74024388 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:100:5 #3 0x563d5c5ae9a9 in SignalHandler(int) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:992:3 #4 0x7fa8c068fcb0 in killpg ??:? #5 0x7fa8c068fcb0 in ?? ??:0 #6 0x7fa8c07576d3 in epoll_wait ??:0:0 #7 0x563d5c56f8c4 in __interceptor_epoll_wait /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:859:13 #8 0x563d7626b0a9 in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8 #9 0x563d7625e2ab in event_base_loop ./../../base/third_party/libevent/event.c:512:9 #10 0x563d722b98c9 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9 #11 0x563d7204b7b0 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14 #12 0x563d740448f9 in content::DOMMessageQueue::WaitForMessage(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*) ./../../content/public/test/browser_test_utils.cc:2214:14 #13 0x563d740355dd in content::(anonymous namespace)::ExecuteScriptHelper(content::RenderFrameHost*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool, int, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >*) ./../../content/public/test/browser_test_utils.cc:197:26 #14 0x563d74034092 in content::ExecuteScriptAndExtractString(content::ToRenderFrameHost const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*) ./../../content/public/test/browser_test_utils.cc:1241:10 #15 0x563d718ae334 in extensions::browsertest_util::ExecuteScriptInBackgroundPage(content::BrowserContext*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, extensions::browsertest_util::ScriptUserActivation) ./../../extensions/browser/browsertest_util.cc:30:15 #16 0x563d71ed5624 in ExtensionJSBrowserTest::RunJavascriptTestF(bool, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) ./../../chrome/test/base/extension_js_browser_test.cc:51:7 #17 0x563d719030b4 in ChromeVoxLibLouisTest_checkAllTables_Test::RunTestOnMainThread() ./gen/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test-gen.cc:35:3 #18 0x563d74020c11 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:462:5 #19 0x563d726722e8 in Run ./../../base/callback.h:129:12 #20 0x563d726722e8 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1794:0 #21 0x563d7266ddf6 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1182:18 #22 0x563d633a9faa in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:668:32 #23 0x563d68c9855a in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:984:13 #24 0x563d6a452dcd in Run ./../../base/callback.h:129:12 #25 0x563d6a452dcd in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:0 #26 0x563d68c9148a in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:918:25 #27 0x563d68ca30bb in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) ./../../content/browser/browser_main_runner_impl.cc:144:15 #28 0x563d68c86eca in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:43:32 #29 0x563d70b1fea0 in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:545:10 #30 0x563d70b1fea0 in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:954:0 #31 0x563d70b1eb29 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:868:12 #32 0x563d7c26da61 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:461:29 #33 0x563d70b1694f in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 #34 0x563d7401ec71 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:349:3 #35 0x563d724ae385 in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:284:20 #36 0x563d64e96769 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #37 0x563d64e96769 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2517:0 #38 0x563d64e9acde in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2703:11 #39 0x563d64e9ca3a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2825:28 #40 0x563d64ed356a in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5227:43 #41 0x563d64ed1dd9 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #42 0x563d64ed1dd9 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:4835:0 #43 0x563d7252517b in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2369:46 #44 0x563d7252517b in base::TestSuite::Run() ./../../base/test/test_suite.cc:294:0 #45 0x563d71eab57d in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:71:21 #46 0x563d740d3163 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:647:31 #47 0x563d71eacc0d in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:184:10 #48 0x563d71eab331 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10 #49 0x7fa8c067af45 in __libc_start_main ??:0:0 #50 0x563d5c54927a in _start ??:0:0 [ RUN ] ChromeVoxLibLouisTest.checkAllTables [2858:2858:0107/163201.161170:WARNING:chrome_browser_main_chromeos.cc(552)] Running as stub user with profile dir: test-user [2858:2858:0107/163201.655645:WARNING:easy_unlock_service_regular.cc(438)] EasyUnlockServiceRegular::IsInLegacyHostMode: DeviceSyncClient not ready. Returning false. [2858:2858:0107/163201.757406:INFO:remote_commands_service.cc(38)] Fetching remote commands. [2858:2858:0107/163201.757570:WARNING:remote_commands_service.cc(40)] Client is not registered. [2858:2858:0107/163201.757654:INFO:remote_commands_invalidator.cc(32)] Initialize RemoteCommandsInvalidator. [2858:2858:0107/163201.757712:INFO:remote_commands_invalidator.cc(57)] Starting RemoteCommandsInvalidator. [2858:2858:0107/163201.757769:INFO:remote_commands_invalidator.cc(123)] RemoteCommandsInvalidator ReloadPolicyData. [2858:2858:0107/163201.757830:INFO:remote_commands_invalidator.cc(167)] Unregister RemoteCommandsInvalidator. [2858:2858:0107/163201.848445:WARNING:wallpaper_controller_client.cc(358)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances. [2858:2858:0107/163202.429117:ERROR:gpu_interface_provider.cc(87)] Not implemented reached in virtual void content::GpuInterfaceProvider::RegisterOzoneGpuInterfaces(service_manager::BinderRegistry *) [2858:2858:0107/163202.819964:ERROR:remote_text_input_client.cc(144)] Not implemented reached in virtual void RemoteTextInputClient::OnInputMethodChanged() [2858:2858:0107/163202.820040:ERROR:remote_text_input_client.cc(101)] Not implemented reached in virtual ui::TextInputClient::FocusReason RemoteTextInputClient::GetFocusReason() const [2858:2858:0107/163202.820075:ERROR:remote_text_input_client.cc(185)] Not implemented reached in virtual bool RemoteTextInputClient::ShouldDoLearning() [2858:2858:0107/163202.820155:ERROR:remote_text_input_client.cc(95)] Not implemented reached in virtual bool RemoteTextInputClient::HasCompositionText() const [2858:2858:0107/163202.820188:ERROR:remote_text_input_client.cc(107)] Not implemented reached in virtual bool RemoteTextInputClient::GetTextRange(gfx::Range *) const ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [2858:2887:0107/163203.046686:ERROR:alsa_util.cc(204)] PcmOpen: default,No such file or directory ALSA lib …

This CL is fixing the cause of the flakiness of this unittest: BackgroundTracingManagerBrowserTest.NoWhitelistedArgsStripped We believe the flakiness was caused by the possibility of start/stop tracing twice. We added a dump of stackframe when the tracing observer call |OnTraceLogEnabled| and we realized that on linux it's called twice. The stackframes are below. Calling sites are: 1) content::BackgroundTracingManagerImpl::SetActiveScenario() 2) content::BackgroundTracingManagerImpl::OnFinalizeComplete() The call 1) is the expected one in the unittest since it's the one starting tracing. The call 2) is caused by the config not being correctly disable with the call to |DisableScenarioWhenIdle|. BackgroundTracingManager::GetInstance()->WhenIdle( base::Bind(&DisableScenarioWhenIdle)); A snippet of code can be found below that shows why |config_| needs to be resetted to avoid multiple start/stop tracing. #2 0x561c34813aee content::(anonymous namespace)::TestTracingHelper::OnTraceLogEnabled() #3 0x7f9254ddff30 base::trace_event::TraceLog::SetEnabled() #4 0x7f925057686c content::BackgroundTracingManagerImpl::StartTracing() #5 0x7f9250574b1e content::BackgroundTracingManagerImpl::StartTracingIfConfigNeedsIt() #6 0x7f9250574752 content::BackgroundTracingManagerImpl::SetActiveScenario() #7 0x561c347f221a content::BackgroundTracingManagerBrowserTest_NoWhitelistedArgsStripped_Test::RunTestOnMainThread() #8 0x561c35d391dd content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #9 0x561c33f88f0d _ZN4base8internal13FunctorTraitsIMN7content41GenerateMHTMLAndExitRendererMessageFilterEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_ #10 0x561c33f88e84 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content41GenerateMHTMLAndExitRendererMessageFilterEFvvEJPS5_EEEvOT_DpOT0_ #11 0x561c33f88e35 _ZN4base8internal7InvokerINS0_9BindStateIMN7content41GenerateMHTMLAndExitRendererMessageFilterEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #12 0x561c34164f9c _ZN4base8internal7InvokerINS0_9BindStateIMNS_12MockCallbackINS_17RepeatingCallbackIFvvEEEEEFvvEJNS0_17UnretainedWrapperIS7_EEEEES5_E3RunEPNS0_13BindStateBaseE #13 0x561c33e2827d _ZNKR4base17RepeatingCallbackIFvvEE3RunEv #14 0x561c35fb418d content::ShellBrowserMainParts::PreMainMessageLoopRun() #15 0x7f924f65fb32 content::BrowserMainLoop::PreMainMessageLoopRun() #2 0x561c34813aee content::(anonymous namespace)::TestTracingHelper::OnTraceLogEnabled() #3 0x7f9254ddff30 base::trace_event::TraceLog::SetEnabled() #4 0x7f925057686c content::BackgroundTracingManagerImpl::StartTracing() #5 0x7f9250574b1e content::BackgroundTracingManagerImpl::StartTracingIfConfigNeedsIt() #6 0x7f9250579062 content::BackgroundTracingManagerImpl::OnFinalizeComplete() #7 0x7f924f17f715 _ZN4base8internal13FunctorTraitsIMN4mojo8internal24CallbackWithDeleteHelperIFvbEEEFvbEvE6InvokeIS8_PS6_JbEEEvT_OT0_DpOT1_ #8 0x7f924f17f66f _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN4mojo8internal24CallbackWithDeleteHelperIFvbEEEFvbEJPS8_bEEEvOT_DpOT0_ void BackgroundTracingManagerImpl::OnFinalizeComplete(bool success) { [...] if (!idle_callback_.is_null()) idle_callback_.Run(); bool is_allowed_begin = !delegate_ || (config_ && delegate_->IsAllowedToBeginBackgroundScenario( *config_.get(), requires_anonymized_data_)) [...] // NOTE: config_ must be empty to avoid starting tracing if (is_allowed_begin) { StartTracingIfConfigNeedsIt(); } else { AbortScenario(); } B=639706,795803 R=oysteine@chromium.org Change-Id: I5495b542615633c62a3451a75a668866b18592b0 Reviewed-on: https://chromium-review.googlesource.com/c/1341134 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#622024}

This reverts commit b9e3249. Reason for revert: breaks MSAN base_unittests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests/14315 [ RUN ] TimezoneTest.CountryCodeForTimezones ==12431==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x55bd41fbd0c1 in icu_63::TZEnumeration::snext(UErrorCode&) ./../../third_party/icu/source/i18n/timezone.cpp:931:31 #1 0x55bd3e8c9c45 in base::(anonymous namespace)::TimezoneTest_CountryCodeForTimezones_Test::TestBody() ./../../base/i18n/timezone_unittest.cc:20:58 #2 0x55bd414ee9a0 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #3 0x55bd414ee9a0 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2522:0 #4 0x55bd414f24d3 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2703:11 #5 0x55bd414f40e9 in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2825:28 #6 0x55bd4152e9d9 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5227:43 #7 0x55bd4152d2c8 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #8 0x55bd4152d2c8 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:4835:0 #9 0x55bd41b8f42a in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2369:46 #10 0x55bd41b8f42a in base::TestSuite::Run() ./../../base/test/test_suite.cc:294:0 #11 0x55bd41bb9d49 in Run ./../../base/callback.h:99:12 #12 0x55bd41bb9d49 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:225:0 #13 0x55bd41bb94a7 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) ./../../base/test/launcher/unit_test_launcher.cc:575:10 #14 0x55bd41b522a8 in main ./../../base/test/run_all_base_unittests.cc:12:10 #15 0x7f1906a7ef44 in __libc_start_main ??:0:0 #16 0x55bd3dc8d029 in _start ??:0:0 Original change's description: > Make timezone unittest less dependent on environment > > Instead of only testing the current default timezone, test all > timezones. > > Noticed this while looking into crbug.com/920094 > > Bug: none > Change-Id: Ida24c063cefb384037fc77c3673ff2d73ab7354f > Reviewed-on: https://chromium-review.googlesource.com/c/1407437 > Reviewed-by: Jungshik Shin <jshin@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#622505} TBR=thestig@chromium.org,estade@chromium.org,jshin@chromium.org Change-Id: I86d37bbe6749f3f8a5b81bf3967755e43f441161 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/1409815 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#622600}

This reverts commit 9b90992. Reason for revert: Suspect: causes extensions_unittests failures on LinuxTests(dbg)(1). https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/78307 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8921108554761775344/+/steps/extensions_unittests/0/logs/GinPortTest.TestJSDisconnect__status_CRASH_/0 --- [ RUN ] GinPortTest.TestJSDisconnect # Fatal error in ../../v8/src/base/atomic-utils.h, line 181 # Debug check failed: old >= amount (12874 vs. 13036). # # # #FailureMessage Object: 0x7ffe772cb570#0 0x7fcc15c67441 base::debug::CollectStackTrace() #4 0x7fcbf34d4a98 V8_Fatal() #5 0x7fcbf34d4805 v8::base::(anonymous namespace)::DefaultDcheckHandler() #6 0x7fcc05ae9b34 v8::internal::Heap::FinalizeExternalString() #7 0x7fcc05af3c0e v8::internal::Heap::ExternalStringTable::TearDown() #8 0x7fcc05af37ed v8::internal::Heap::TearDown() #9 0x7fcc05c1e90b v8::internal::Isolate::Deinit() #10 0x7fcc05c1e595 v8::internal::Isolate::Delete() #11 0x7fcc05184d38 gin::IsolateHolder::~IsolateHolder() #12 0x5635a0f5381b std::__Cr::default_delete<>::operator()() #13 0x5635a0f5375f std::__Cr::unique_ptr<>::reset() #14 0x5635a193afd5 extensions::APIBindingTest::TearDown() #15 0x56359fcf3ddf extensions::(anonymous namespace)::GinPortTest::TearDown() #16 0x56359fd693ee testing::internal::HandleSehExceptionsInMethodIfSupported<>() --- Original change's description: > Update V8 to version 7.4.196. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/fee9be7a..9f489e34 > > Please follow these instructions for assigning/CC'ing issues: > https://github.com/v8/v8/wiki/Triaging%20issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: I2422c4d7e92bb63dba87b15567bde4a108536222 > Reviewed-on: https://chromium-review.googlesource.com/c/1477512 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#633211} TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I23bea79ec5187e545b0604b1f4706152e2aa037a No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1477147 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#633217}

…her CI." This reverts commit 94a6b71. Reason for revert: Causes CaptivePortal browser tests to fail on non_network_service_browser_tests https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/11306 [2373:2373:0311/193039.746186:FATAL:cert_status_flags.cc(103)] Check failed: false. #0 0x7f3a3fba0851 base::debug::CollectStackTrace() #1 0x7f3a3fa01f8d base::debug::StackTrace::StackTrace() #2 0x7f3a3fa01f45 base::debug::StackTrace::StackTrace() #3 0x7f3a3fa3da17 logging::LogMessage::~LogMessage() #4 0x7f3a3ec695f8 net::MapCertStatusToNetError() #5 0x55c7467624ea SSLErrorNavigationThrottle::QueueShowInterstitial() #6 0x55c74676244d SSLErrorNavigationThrottle::WillFailRequest() #7 0x7f3a384b7d20 content::(anonymous namespace)::ExecuteNavigationEvent() #8 0x7f3a384b71f8 content::NavigationThrottleRunner::ProcessInternal() #9 0x7f3a384b6f67 content::NavigationThrottleRunner::ProcessNavigationEvent() #10 0x7f3a384a00b7 content::NavigationHandleImpl::WillFailRequest() #11 0x7f3a384ad0c2 content::NavigationRequest::OnRequestFailedInternal() #12 0x7f3a384b230b content::NavigationRequest::OnRequestFailed() #13 0x7f3a3862da3d content::NavigationURLLoaderImpl::OnComplete() #14 0x7f3a37fa7257 base::internal::FunctorTraits<>::Invoke<>() Original change's description: > Fix SSL committed interstitials bugs when interacting with other CI. > > The following bugs appeared when SB interstitials were being converted > to committed interstitials: > > -SSLErrorNavigationThrottle will not respect the cert whitelist when > WillFailRequest is triggered by other interstitials. This CL adds a > check. > > -DidStartResourceResponse is called on SSLManager on all network > errors, which are treated as valid SSL by the manager and cause cert > exceptions to be cleared, this also happened prior to CI, but became > obvious with Safe Browsing tests. This CL fixes this by only calling > DidStartResourceResponse on net::OK. > > Bug: 869894 > Change-Id: Ia1ce4a3130bf03ef7686ff2149a9ed49fb20c81b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504052 > Commit-Queue: Carlos IL <carlosil@chromium.org> > Reviewed-by: Emily Stark <estark@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#639748} TBR=jam@chromium.org,estark@chromium.org,carlosil@chromium.org Change-Id: I4b16aa2ad17994953ca5fc0c0ca0e4aea1d03d4f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 869894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517312 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#639804}

…her CI." This reverts commit d4ee8e8. Reason for revert: Fixed broken tests. Original change's description: > Revert "Fix SSL committed interstitials bugs when interacting with other CI." > > This reverts commit 94a6b71. > > Reason for revert: Causes CaptivePortal browser tests to fail on non_network_service_browser_tests > > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/11306 > > [2373:2373:0311/193039.746186:FATAL:cert_status_flags.cc(103)] Check failed: false. > #0 0x7f3a3fba0851 base::debug::CollectStackTrace() > #1 0x7f3a3fa01f8d base::debug::StackTrace::StackTrace() > #2 0x7f3a3fa01f45 base::debug::StackTrace::StackTrace() > #3 0x7f3a3fa3da17 logging::LogMessage::~LogMessage() > #4 0x7f3a3ec695f8 net::MapCertStatusToNetError() > #5 0x55c7467624ea SSLErrorNavigationThrottle::QueueShowInterstitial() > #6 0x55c74676244d SSLErrorNavigationThrottle::WillFailRequest() > #7 0x7f3a384b7d20 content::(anonymous namespace)::ExecuteNavigationEvent() > #8 0x7f3a384b71f8 content::NavigationThrottleRunner::ProcessInternal() > #9 0x7f3a384b6f67 content::NavigationThrottleRunner::ProcessNavigationEvent() > #10 0x7f3a384a00b7 content::NavigationHandleImpl::WillFailRequest() > #11 0x7f3a384ad0c2 content::NavigationRequest::OnRequestFailedInternal() > #12 0x7f3a384b230b content::NavigationRequest::OnRequestFailed() > #13 0x7f3a3862da3d content::NavigationURLLoaderImpl::OnComplete() > #14 0x7f3a37fa7257 base::internal::FunctorTraits<>::Invoke<>() > > Original change's description: > > Fix SSL committed interstitials bugs when interacting with other CI. > > > > The following bugs appeared when SB interstitials were being converted > > to committed interstitials: > > > > -SSLErrorNavigationThrottle will not respect the cert whitelist when > > WillFailRequest is triggered by other interstitials. This CL adds a > > check. > > > > -DidStartResourceResponse is called on SSLManager on all network > > errors, which are treated as valid SSL by the manager and cause cert > > exceptions to be cleared, this also happened prior to CI, but became > > obvious with Safe Browsing tests. This CL fixes this by only calling > > DidStartResourceResponse on net::OK. > > > > Bug: 869894 > > Change-Id: Ia1ce4a3130bf03ef7686ff2149a9ed49fb20c81b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504052 > > Commit-Queue: Carlos IL <carlosil@chromium.org> > > Reviewed-by: Emily Stark <estark@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#639748} > > TBR=jam@chromium.org,estark@chromium.org,carlosil@chromium.org > > Change-Id: I4b16aa2ad17994953ca5fc0c0ca0e4aea1d03d4f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 869894 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517312 > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#639804} TBR=jam@chromium.org,estark@chromium.org,ortuno@chromium.org,carlosil@chromium.org Change-Id: Ief647bc8b816714bc26c0e06ed1462ddb3ade665 Bug: 869894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518057 Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Carlos IL <carlosil@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#640054}

Recently, a best-effort task queue responsible for renderer memory purges was introduced to MainThreadSchedulerImpl. Note that when the scheduler is backgrounded, a memory purge is queued with a random (between 1 and 4 minutes) delay. This interferes with the timing of tests in MainThreadMetricsHelperUnittest. In order to ensure the test works as expected, memory purging is disabled using a ScopedFeatureList. The failure log is included below. [ RUN ] MainThreadMetricsHelperTest.Metrics_PerQueueType [29553:29553:0323/080000.150787:13204898911:FATAL:thread_load_tracker.cc(81)] Check failed: time_ <= now (151000000 bogo-microseconds vs. 150000000 bogo-microseconds) #0 0x7f243f4ac8d1 base::debug::CollectStackTrace() #1 0x7f243f2f38dd base::debug::StackTrace::StackTrace() #2 0x7f243f2f3895 base::debug::StackTrace::StackTrace() #3 0x7f243f3335d3 logging::LogMessage::~LogMessage() #4 0x7f24405e0158 blink::scheduler::ThreadLoadTracker::Advance() #5 0x7f24405e05cb blink::scheduler::ThreadLoadTracker::RecordTaskTime() #6 0x7f2440603cfa blink::scheduler::MainThreadMetricsHelper::RecordTaskMetrics() #7 0x5563bb768664 blink::scheduler::MainThreadMetricsHelperTest::RunTask() #8 0x5563bb765306 blink::scheduler::MainThreadMetricsHelperTest_Metrics_PerQueueType_Test::TestBody() #9 0x5563bac6faae testing::internal::HandleSehExceptionsInMethodIfSupported<>() #10 0x5563bac69422 testing::internal::HandleExceptionsInMethodIfSupported<>() #11 0x5563bac5c6e3 testing::Test::Run() #12 0x5563bac5cdd2 testing::TestInfo::Run() #13 0x5563bac5d2f3 testing::TestSuite::Run() #14 0x5563bac64f24 testing::internal::UnitTestImpl::RunAllTests() #15 0x5563bac6fb3e testing::internal::HandleSehExceptionsInMethodIfSupported<>() #16 0x5563bac6a512 testing::internal::HandleExceptionsInMethodIfSupported<>() #17 0x5563bac64c47 testing::UnitTest::Run() #18 0x5563bb9714e1 RUN_ALL_TESTS() #19 0x5563bb96fb52 base::TestSuite::Run() #20 0x5563bac3ec95 (anonymous namespace)::runTestSuite() #21 0x5563bab77f72 base::internal::FunctorTraits<>::Invoke<>() #22 0x5563bab77f32 base::internal::InvokeHelper<>::MakeItSo<>() #23 0x5563bac3ee17 _ZN4base8internal7InvokerINS0_9BindStateIPFiPNS_9TestSuiteEEJNS0_17UnretainedWrapperIS3_EEEEEFivEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEiOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #24 0x5563bac3edbe base::internal::Invoker<>::RunOnce() #25 0x5563bb97804e _ZNO4base12OnceCallbackIFivEE3RunEv #26 0x5563bb9742ad base::(anonymous namespace)::LaunchUnitTestsInternal() #27 0x5563bb974115 base::LaunchUnitTests() #28 0x5563bac3ebf4 main #29 0x7f242e1dbf45 __libc_start_main #30 0x5563ba71302a _start Change-Id: I436abac9c6d6ef791ae17e898d6ffaf66e0e6a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538002 Commit-Queue: Aditya Keerthi <adityakeerthi@google.com> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#643837}

Enable Kiosk mode and toggle on ChromeVox (Ctrl+Alt+Z): #0 0x56034507af89 base::debug::CollectStackTrace() #1 0x560344fe2393 base::debug::StackTrace::StackTrace() #2 0x56034507ab11 base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7f48543a10c0 <unknown> #4 0x560346530090 aura::Window::GetRootWindow() #5 0x560347537eda ash::AccessibilityPanelLayoutManager::SetPanelBounds() #6 0x56034387325b ash::mojom::AccessibilityControllerStubDispatch::Accept() #7 0x5603450d0a2e mojo::internal::MultiplexRouter::ProcessIncomingMessage() #8 0x5603450d02c5 mojo::internal::MultiplexRouter::Accept() #9 0x5603450c9e8d mojo::Connector::DispatchMessage() #10 0x5603450ca79e mojo::Connector::ReadAllAvailableMessages() #11 0x5603450dd02e mojo::SimpleWatcher::OnHandleReady() #12 0x56034502a838 base::TaskAnnotator::RunTask() #13 0x560345039bbb base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #14 0x5603450399d7 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoSomeWork() #15 0x56034508f419 base::MessagePumpLibevent::Run() #16 0x56034503a227 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #17 0x56034501587d base::RunLoop::Run() Change-Id: I93c4b9965f0f4bf9aa360049c00c2546f70477fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542571 Reviewed-by: Anastasia Helfinstein <anastasi@google.com> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#645505}

This reverts commit 586ad03. Reason for revert: This seems to be the source of a bunch of msan failures on the chromeos bot. Here's one such failure: Uninitialized bytes in __msan_check_mem_is_initialized at offset 0 inside [0x71a000001800, 1444) ==31849==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x5644faae6979 in cc::PaintImageBuilder::TakePaintImage() ./../../cc/paint/paint_image_builder.cc:86:7 #1 0x5644faae0a9e in cc::PaintImage::CreateFromBitmap(SkBitmap) ./../../cc/paint/paint_image.cc:101:8 #2 0x5644f957c742 in gfx::ImageSkiaRep::ImageSkiaRep(SkBitmap const&, float) ./../../ui/gfx/image/image_skia_rep_default.cc:34:18 #3 0x5644f954f283 in gfx::ImageSkia::CreateFrom1xBitmap(SkBitmap const&) ./../../ui/gfx/image/image_skia.cc:339:20 #4 0x5644f7777610 in ash::MediaNotificationItem::MediaControllerImageChanged(media_session::mojom::MediaSessionImageType, SkBitmap const&) ./../../ash/media/media_notification_item.cc:113:23 #5 0x5644f3d4dc56 in ash::MediaNotificationViewTest_UpdateIconFromItem_Test::TestBody() ./../../ash/media/media_notification_view_unittest.cc:661:14 #6 0x5644f714acf0 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #7 0x5644f714acf0 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2499:0 #8 0x5644f714e81c in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2675:11 #9 0x5644f7150449 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2805:28 #10 0x5644f718b4f9 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5243:44 #11 0x5644f7189b48 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #12 0x5644f7189b48 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:4845:0 #13 0x5644f837c46a in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2469:46 #14 0x5644f837c46a in base::TestSuite::Run() ./../../base/test/test_suite.cc:316:0 #15 0x5644f8385785 in Run ./../../base/callback.h:97:12 #16 0x5644f8385785 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:225:0 #17 0x5644f8384f17 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) ./../../base/test/launcher/unit_test_launcher.cc:575:10 #18 0x5644f497124d in main ./../../ash/test/ash_unittests.cc:24:10 #19 0x7f4c19b6ef44 in __libc_start_main ??:0:0 #20 0x5644f2b94029 in _start ??:0:0 This is from https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8917603702301191776/+/steps/non_single_process_mash_ash_unittests/0/logs/Deterministic_failure:_MediaNotificationViewTest.UpdateIconFromItem__status_CRASH_/0 Original change's description: > cc: Add some msan initialization checks for images. > > The memory cc gets for images (both bitmaps and generator backed) is > expected to be initialized by the embedder before passing to skia during > raster. Add some asserts to validate this so the source of bugs can be > identified easily when the expectation is not met. > > R=enne@chromium.org > > Bug: 926219 > Change-Id: I3354a69555956f4d28b888483baef7195d5771a1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546669 > Commit-Queue: Khushal <khushalsagar@chromium.org> > Commit-Queue: enne <enne@chromium.org> > Auto-Submit: Khushal <khushalsagar@chromium.org> > Reviewed-by: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#646003} TBR=enne@chromium.org,khushalsagar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 926219 Change-Id: Ia12e5ecc348e4ff8d563d22abb925c423043efa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548557 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#646798}

…ect outdated server This enables Initial Enrollment by default for official builds. Also, this adds functionality to detect a server which does not support Initial Enrollment by comparing against a maximal expected modulus value. TBR=pmarko@chromium.org (cherry picked from commit 83a6b57) Bug: 839353 Test: unit_tests --gtest_filter=AutoEnrollmentClient* Change-Id: I1b64ab2875c7317dc92c74276173e27b1c58bbe2 Reviewed-on: https://chromium-review.googlesource.com/1073309 Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#562143} Reviewed-on: https://chromium-review.googlesource.com/1075272 Reviewed-by: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{chromium#12} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}

…iner https://chromium-review.googlesource.com/c/chromium/src/+/1091497 removed an item from the app menu that never appeared on Mac. Unfortunately, even though the item was never *displayed*, it appears to have factored into NSMenu's calculation for what its max size should be. When the item was removed, the max size is no longer able to account for multiple rows in the browser action overflow container, so all rows but the last are clipped. This change removes and readds the extension overflow container when it's finished sizing itself to prompt the menu to reevaluate its height. We can't do this before we add the item to the menu because the menu's width factors into the overflow container's size calculation. It seems like there should be a less awkward way to do this, but I can't find it. Bug: 862005 Change-Id: Ib17ed810855041226786b16ca94f0a60d88dc892 Reviewed-on: https://chromium-review.googlesource.com/1145133 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#576905}(cherry picked from commit 8634192) Reviewed-on: https://chromium-review.googlesource.com/1146780 Reviewed-by: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{chromium#12} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}

Previously HeartbeatSender logs a bunch of stuff like sequence ID and signature, which are not very useful now and spams the log. This CL reduces the verbosity of the log to just log JID and FTL ID. (cherry picked from commit c7496f1) Bug: 969199 Change-Id: Id32e1aaab611793a0943eb359bec7439343d45d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639365 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#665352} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639966 Reviewed-by: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/branch-heads/3809@{chromium#12} Cr-Branched-From: d82dec1-refs/heads/master@{#665002}

There was a race around |g_use_in_memory_db_for_testing| : [ RUN ] NonRecordingSiteDataCacheTest.EndToEnd ================== WARNING: ThreadSanitizer: data race (pid=1484) Write of size 1 at 0x55e6654d29d0 by main thread: #0 ~AutoReset base/auto_reset.h:40:25 (unit_tests+0x42d690c) #1 operator() buildtools/third_party/libc++/trunk/include/memory:2338 (unit_tests+0x42d690c) #2 reset buildtools/third_party/libc++/trunk/include/memory:2651 (unit_tests+0x42d690c) #3 ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2605 (unit_tests+0x42d690c) #4 performance_manager::(anonymous namespace)::NonRecordingSiteDataCacheTest::~NonRecordingSiteDataCacheTest() chrome/browser/performance_manager/persistence/site_data/non_recording_site_data_cache_unittest.cc:30 (unit_tests+0x42d690c) #5 performance_manager::NonRecordingSiteDataCacheTest_EndToEnd_Test::~NonRecordingSiteDataCacheTest_EndToEnd_Test() chrome/browser/performance_manager/persistence/site_data/non_recording_site_data_cache_unittest.cc:66:1 (unit_tests+0x42d65d9) #6 HandleExceptionsInMethodIfSupported<testing::Test, void> third_party/googletest/src/googletest/src/gtest.cc (unit_tests+0x65f041e) #7 testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2704 (unit_tests+0x65f041e) #8 testing::TestSuite::Run() third_party/googletest/src/googletest/src/gtest.cc:2828:28 (unit_tests+0x65f0ef6) #9 testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5285:44 (unit_tests+0x6603366) #10 HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/src/googletest/src/gtest.cc (unit_tests+0x6602859) #11 testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:4873 (unit_tests+0x6602859) #12 RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2453:46 (unit_tests+0x9dd5692) #13 base::TestSuite::Run() base/test/test_suite.cc:316 (unit_tests+0x9dd5692) #14 content::UnitTestTestSuite::Run() content/public/test/unittest_test_suite.cc:103:23 (unit_tests+0x9ee213f) #15 Invoke<int (content::UnitTestTestSuite::*)(), content::UnitTestTestSuite *> base/bind_internal.h:499:12 (unit_tests+0x9dc3168) #16 MakeItSo<int (content::UnitTestTestSuite::*const &)(), content::UnitTestTestSuite *> base/bind_internal.h:599 (unit_tests+0x9dc3168) #17 RunImpl<int (content::UnitTestTestSuite::*const &)(), const std::__1::tuple<base::internal::UnretainedWrapper<content::UnitTestTestSuite> > &, 0> base/bind_internal.h:672 (unit_tests+0x9dc3168) #18 base::internal::Invoker<base::internal::BindState<int (content::UnitTestTestSuite::*)(), base::internal::UnretainedWrapper<content::UnitTestTestSuite> >, int ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:654 (unit_tests+0x9dc3168) #19 Run base/callback.h:97:12 (unit_tests+0x9ddf24b) #20 base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:158 (unit_tests+0x9ddf24b) #21 base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:494:10 (unit_tests+0x9ddf0b0) #22 main chrome/test/base/run_all_unittests.cc:35:10 (unit_tests+0x9dc3099) Previous read of size 1 at 0x55e6654d29d0 by thread T18: #0 performance_manager::LevelDBSiteDataStore::AsyncHelper::OpenOrCreateDatabaseImpl() chrome/browser/performance_manager/persistence/site_data/leveldb_site_data_store.cc:374:7 (unit_tests+0xb3e7762) #1 performance_manager::LevelDBSiteDataStore::AsyncHelper::OpenOrCreateDatabase() chrome/browser/performance_manager/persistence/site_data/leveldb_site_data_store.cc:195:30 (unit_tests+0xb3e7394) #2 Invoke<void (performance_manager::LevelDBSiteDataStore::AsyncHelper::*)(), performance_manager::LevelDBSiteDataStore::AsyncHelper *> base/bind_internal.h:499:12 (unit_tests+0xb3e9608) #3 MakeItSo<void (performance_manager::LevelDBSiteDataStore::AsyncHelper::*)(), performance_manager::LevelDBSiteDataStore::AsyncHelper *> base/bind_internal.h:599 (unit_tests+0xb3e9608) #4 RunImpl<void (performance_manager::LevelDBSiteDataStore::AsyncHelper::*)(), std::__1::tuple<base::internal::UnretainedWrapper<performance_manager::LevelDBSiteDataStore::AsyncHelper> >, 0> base/bind_internal.h:672 (unit_tests+0xb3e9608) #5 base::internal::Invoker<base::internal::BindState<void (performance_manager::LevelDBSiteDataStore::AsyncHelper::*)(), base::internal::UnretainedWrapper<performance_manager::LevelDBSiteDataStore::AsyncHelper> >, void ()>::RunOnce(base::internal::BindStateBase*) base/bind_internal.h:641 (unit_tests+0xb3e9608) #6 Run base/callback.h:97:12 (unit_tests+0xacb91d5) #7 base::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/task/common/task_annotator.cc:142 (unit_tests+0xacb91d5) #8 base::internal::TaskTracker::RunBlockShutdown(base::internal::Task*) base/task/thread_pool/task_tracker.cc:773:19 (unit_tests+0xacdde01) #9 RunTaskWithShutdownBehavior base/task/thread_pool/task_tracker.cc:788:7 (unit_tests+0xacdd825) #10 base::internal::TaskTracker::RunOrSkipTask(base::internal::Task, base::internal::TaskSource*, base::TaskTraits const&, bool) base/task/thread_pool/task_tracker.cc:617 (unit_tests+0xacdd825) #11 base::internal::TaskTrackerPosix::RunOrSkipTask(base::internal::Task, base::internal::TaskSource*, base::TaskTraits const&, bool) base/task/thread_pool/task_tracker_posix.cc:24:16 (unit_tests+0xad5bfc4) #12 base::test::ScopedTaskEnvironment::TestTaskTracker::RunOrSkipTask(base::internal::Task, base::internal::TaskSource*, base::TaskTraits const&, bool) base/test/scoped_task_environment.cc:663:46 (unit_tests+0x9dd0a08) #13 base::internal::TaskTracker::RunAndPopNextTask(base::internal::RegisteredTaskSource) base/task/thread_pool/task_tracker.cc:479:5 (unit_tests+0xacdd119) #14 base::internal::WorkerThread::RunWorker() base/task/thread_pool/worker_thread.cc:320:34 (unit_tests+0xacf08cd) #15 base::internal::WorkerThread::RunPooledWorker() base/task/thread_pool/worker_thread.cc:222:3 (unit_tests+0xacf0561) #16 base::internal::WorkerThread::ThreadMain() base/task/thread_pool/worker_thread.cc:201:7 (unit_tests+0xacf03cf) #17 base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:81:13 (unit_tests+0xad5cbb4) Location is global 'performance_manager::(anonymous namespace)::g_use_in_memory_db_for_testing' of size 1 at 0x55e6654d29d0 (unit_tests+0x0000132b39d0) Thread T18 'ThreadPoolForeg' (tid=1837, running) created by main thread at: #0 pthread_create /b/swarming/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:989:3 (unit_tests+0x3bd013b) #1 base::(anonymous namespace)::CreateThread(unsigned long, bool, base::PlatformThread::Delegate*, base::PlatformThreadHandle*, base::ThreadPriority) base/threading/platform_thread_posix.cc:120:13 (unit_tests+0xad5c5c7) #2 base::PlatformThread::CreateWithPriority(unsigned long, base::PlatformThread::Delegate*, base::PlatformThreadHandle*, base::ThreadPriority) base/threading/platform_thread_posix.cc:246:10 (unit_tests+0xad5c4c5) #3 base::internal::WorkerThread::Start(base::WorkerThreadObserver*) base/task/thread_pool/worker_thread.cc:68:3 (unit_tests+0xaceff6d) #4 operator() base/task/thread_pool/thread_group_impl.cc:185:15 (unit_tests+0xace7e06) #5 ForEachWorker<(lambda at ../../base/task/thread_pool/thread_group_impl.cc:184:37)> base/task/thread_pool/thread_group_impl.cc:150 (unit_tests+0xace7e06) #6 base::internal::ThreadGroupImpl::ScopedWorkersExecutor::FlushImpl() base/task/thread_pool/thread_group_impl.cc:184 (unit_tests+0xace7e06) #7 base::internal::ThreadGroupImpl::ScopedWorkersExecutor::~ScopedWorkersExecutor() base/task/thread_pool/thread_group_impl.cc:103:30 (unit_tests+0xace47f4) #8 base::internal::ThreadGroupImpl::Start(int, int, base::TimeDelta, scoped_refptr<base::TaskRunner>, base::WorkerThreadObserver*, base::internal::ThreadGroup::WorkerEnvironment, base::Optional<base::TimeDelta>) base/task/thread_pool/thread_group_impl.cc:425:1 (unit_tests+0xace4799) #9 base::internal::ThreadPoolImpl::Start(base::ThreadPoolInstance::InitParams const&, base::WorkerThreadObserver*) base/task/thread_pool/thread_pool_impl.cc:197:11 (unit_tests+0xace0133) #10 base::test::ScopedTaskEnvironment::InitializeThreadPool() base/test/scoped_task_environment.cc:391:30 (unit_tests+0x9dcf8fc) #11 base::test::ScopedTaskEnvironment::ScopedTaskEnvironment(base::test::ScopedTaskEnvironment::MainThreadType, base::test::ScopedTaskEnvironment::ThreadPoolExecutionMode, base::test::ScopedTaskEnvironment::NowSource, base::test::ScopedTaskEnvironment::ThreadingMode, bool, base::trait_helpers::NotATraitTag) base/test/scoped_task_environment.cc:348:5 (unit_tests+0x9dcf2bc) #12 base::test::ScopedTaskEnvironment::ScopedTaskEnvironment<base::test::ScopedTaskEnvironment::SubclassCreatesDefaultTaskRunner, base::test::ScopedTaskEnvironment::MainThreadType, void>(base::test::ScopedTaskEnvironment::SubclassCreatesDefaultTaskRunner, base::test::ScopedTaskEnvironment::MainThreadType) base/test/scoped_task_environment.h:161:9 (unit_tests+0x3c4e2f0) #13 content::TestBrowserThreadBundle::TestBrowserThreadBundle<void>() content/public/test/test_browser_thread_bundle.h:131:13 (unit_tests+0x3c4e287) #14 performance_manager::(anonymous namespace)::NonRecordingSiteDataCacheTest::NonRecordingSiteDataCacheTest() chrome/browser/performance_manager/persistence/site_data/non_recording_site_data_cache_unittest.cc:23:3 (unit_tests+0x42d6a76) #15 NonRecordingSiteDataCacheTest_EndToEnd_Test chrome/browser/performance_manager/persistence/site_data/non_recording_site_data_cache_unittest.cc:66:1 (unit_tests+0x42d69d4) #16 testing::internal::TestFactoryImpl<performance_manager::NonRecordingSiteDataCacheTest_EndToEnd_Test>::CreateTest() third_party/googletest/src/googletest/include/gtest/internal/gtest-internal.h:460 (unit_tests+0x42d69d4) #17 HandleExceptionsInMethodIfSupported<testing::internal::TestFactoryBase, testing::Test *> third_party/googletest/src/googletest/src/gtest.cc (unit_tests+0x65f01df) #18 testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2688 (unit_tests+0x65f01df) #19 testing::TestSuite::Run() third_party/googletest/src/googletest/src/gtest.cc:2828:28 (unit_tests+0x65f0ef6) #20 testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5285:44 (unit_tests+0x6603366) #21 HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/src/googletest/src/gtest.cc (unit_tests+0x6602859) #22 testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:4873 (unit_tests+0x6602859) #23 RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2453:46 (unit_tests+0x9dd5692) #24 base::TestSuite::Run() base/test/test_suite.cc:316 (unit_tests+0x9dd5692) #25 content::UnitTestTestSuite::Run() content/public/test/unittest_test_suite.cc:103:23 (unit_tests+0x9ee213f) #26 Invoke<int (content::UnitTestTestSuite::*)(), content::UnitTestTestSuite *> base/bind_internal.h:499:12 (unit_tests+0x9dc3168) #27 MakeItSo<int (content::UnitTestTestSuite::*const &)(), content::UnitTestTestSuite *> base/bind_internal.h:599 (unit_tests+0x9dc3168) #28 RunImpl<int (content::UnitTestTestSuite::*const &)(), const std::__1::tuple<base::internal::UnretainedWrapper<content::UnitTestTestSuite> > &, 0> base/bind_internal.h:672 (unit_tests+0x9dc3168) #29 base::internal::Invoker<base::internal::BindState<int (content::UnitTestTestSuite::*)(), base::internal::UnretainedWrapper<content::UnitTestTestSuite> >, int ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:654 (unit_tests+0x9dc3168) #30 Run base/callback.h:97:12 (unit_tests+0x9ddf24b) #31 base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:158 (unit_tests+0x9ddf24b) #32 base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:494:10 (unit_tests+0x9ddf0b0) #33 main chrome/test/base/run_all_unittests.cc:35:10 (unit_tests+0x9dc3099) The problem is that opening the DB (in LevelDBSiteDataStore::AsyncHelper::OpenOrCreateDatabaseImpl) is done asynchronously, and by the time we get there the AutoReset might have been destroyed. Waiting for the DB to be initialized fixes this. This reverts commit b7310e3. Bug: 961336 Change-Id: Ia7d9367b10857837340358d7a516c26b87d0cebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682668 Reviewed-by: Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#676639}

This reverts commit a2103b5. Reason for revert: Only Fido Cl before failures in FidoGetAssertionHandlerTest.* started: https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/55166 Log: [ RUN ] FidoGetAssertionHandlerTest.SuccessWithOnlyInternalTransportAllowed ================================================================= ==86183==ERROR: AddressSanitizer: requested allocation size 0xbebebe00bebebe00 (0xbebebe00bebece00 after adjustments for alignment, red zones etc.) exceeds maximum supported size of 0x10000000000 (thread T0) #0 0x113961c0d in __sanitizer_mz_malloc ??:0:0 #1 0x7fff63b001bc in malloc_zone_malloc ??:0:0 #2 0x7fff3ba12b7b in __CFStringDecodeByteStream3 ??:0:0 #3 0x7fff3b9ee8a5 in __CFStringCreateImmutableFunnel3 ??:0:0 #4 0x7fff3b9fc50c in CFStringCreateWithBytes ??:0:0 #5 0x10a49f7ee in base::SysUTF8ToNSString(base::BasicStringPiece<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >) ??:0:0 #6 0x10ab34881 in device::fido::mac::FindCredentialsImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::set<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > >, std::__1::allocator<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > > const&, LAContext*) ??:0:0 #7 0x10ab34496 in device::fido::mac::FindCredentialsInKeychain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::set<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > >, std::__1::allocator<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > > const&, LAContext*) ??:0:0 #8 0x10ab1988a in device::fido::mac::TouchIdAuthenticator::HasCredentialForGetAssertionRequest(device::CtapGetAssertionRequest const&) ??:0:0 #9 0x10aa6c35b in device::GetAssertionRequestHandler::AuthenticatorAdded(device::FidoDiscoveryBase*, device::FidoAuthenticator*) ??:0:0 #10 0x10aa57795 in device::FidoDeviceDiscovery::AddDevice(std::__1::unique_ptr<device::FidoDevice, std::__1::default_delete<device::FidoDevice> >) ??:0:0 #11 0x103f5dd56 in device::FidoGetAssertionHandlerTest_SuccessWithOnlyInternalTransportAllowed_Test::TestBody() ??:0:0 #12 0x10438ec30 in testing::Test::Run() ??:0:0 #13 0x10439139a in testing::TestInfo::Run() ??:0:0 #14 0x104392a26 in testing::TestSuite::Run() ??:0:0 #15 0x1043c0236 in testing::internal::UnitTestImpl::RunAllTests() ??:0:0 #16 0x1043bee1c in testing::UnitTest::Run() ??:0:0 #17 0x10a6fc90a in base::TestSuite::Run() ??:0:0 #18 0x10a738fa1 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) ??:0:0 #19 0x10a738b48 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) ??:0:0 #20 0x1040af3cc in main ??:0:0 #21 0x7fff63957014 in start ??:0:0 ==86183==HINT: if you don't care about these errors you may set allocator_may_return_null=1 SUMMARY: AddressSanitizer: allocation-size-too-big (/b/s/w/ir/out/Release/libclang_rt.asan_osx_dynamic.dylib:x86_64+0x43c0d) ==86183==ABORTING Original change's description: > [webauthn] Refactor Platform Discovery > > This change moves the platform discovery logic from AuthenticatorCommon > into TouchIdDiscovery, which is injected directly into > FidoRequestHandlerBase. This streamlines the device discovery process > for platform authenticators and allows testing them through the virtual > authenticator environment. > > Additionally, this change uncovered a bug on BLE device tests: they > were relying on FidoRequestHandlerBase::notify_observer_callback > never being called because SetPlatformAuthenticator wasn't called. > > Bug: 981399 > Change-Id: Ic0b508c701447fb6228fd2fb8a44b4132370f330 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699947 > Commit-Queue: Avi Drissman <avi@chromium.org> > Auto-Submit: Nina Satragno <nsatragno@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Martin Kreichgauer <martinkr@google.com> > Cr-Commit-Position: refs/heads/master@{#680857} TBR=avi@chromium.org,nsatragno@chromium.org,martinkr@google.com Change-Id: If6a20f444449936aa0fe24f7e0bd1536f9cc3989 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 981399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720237 Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#681218}

This reverts commit 1b08fa8. Reason for revert: suspect causing unit_tests failure on linux-chromeos-dbg. https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/13673 deterministic failures: ArcAppLauncherForDefaultAppTest.AppIconUpdated/0 ArcAppLauncherForDefaultAppTest.AppIconUpdated/1 ... E.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8906357365557383728/+/steps/unit_tests/0/logs/Deterministic_failure:_ArcAppLauncherForDefaultAppTest.AppIconUpdated__x2f_0__status_CRASH_/0 [ RUN ] ArcAppLauncherForDefaultAppTest.AppIconUpdated/0 Received signal 11 <unknown> 000000000000 #9 0x7f40f3cfd40b base::ThreadCheckerImpl::CalledOnValidThread() #10 0x5611fbac0319 arc::internal::ConnectionNotifier::RemoveObserver() #11 0x5611f8ea55e9 arc::ConnectionHolder<>::RemoveObserver() #12 0x5611ff697745 apps::ArcApps::~ArcApps() #13 0x5611ff69786c apps::ArcApps::~ArcApps() ... #22 0x7f40e9d8e740 KeyedServiceFactory::Disassociate() #23 0x7f40e9d8e834 KeyedServiceFactory::ContextDestroyed() #24 0x7f40de6a3503 BrowserContextKeyedServiceFactory::BrowserContextDestroyed() #25 0x7f40de6a3677 BrowserContextKeyedServiceFactory::ContextDestroyed() #26 0x7f40e9d8b145 DependencyManager::DestroyFactoriesInOrder() #27 0x7f40e9d8b1f5 DependencyManager::PerformInterlockedTwoPhaseShutdown() #28 0x5611fe3b3fc3 TestingProfile::~TestingProfile() #29 0x5611fe3b43cc TestingProfile::~TestingProfile() ... Original change's description: > Flip the AppServiceAsh feature default to enabled > > BUG=826982 > BUG=989789 > > Change-Id: I49bd3793bf9fcfc89726fd2f7df690421996e0fd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728411 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Nigel Tao <nigeltao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683064} TBR=dominickn@chromium.org,nigeltao@chromium.org Change-Id: Iec931954750b6a58d2274c6479507e99efd2467a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 826982, 989789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731091 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#683108}

This reverts commit 536bae0. Reason for revert: unit_tests failure fixed by crrev.com/c/1732110 Original change's description: > Revert "Flip the AppServiceAsh feature default to enabled" > > This reverts commit 1b08fa8. > > Reason for revert: suspect causing unit_tests failure on linux-chromeos-dbg. > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/13673 > deterministic failures: > ArcAppLauncherForDefaultAppTest.AppIconUpdated/0 > ArcAppLauncherForDefaultAppTest.AppIconUpdated/1 > ... > E.g. > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8906357365557383728/+/steps/unit_tests/0/logs/Deterministic_failure:_ArcAppLauncherForDefaultAppTest.AppIconUpdated__x2f_0__status_CRASH_/0 > [ RUN ] ArcAppLauncherForDefaultAppTest.AppIconUpdated/0 > Received signal 11 <unknown> 000000000000 > #9 0x7f40f3cfd40b base::ThreadCheckerImpl::CalledOnValidThread() > #10 0x5611fbac0319 arc::internal::ConnectionNotifier::RemoveObserver() > #11 0x5611f8ea55e9 arc::ConnectionHolder<>::RemoveObserver() > #12 0x5611ff697745 apps::ArcApps::~ArcApps() > #13 0x5611ff69786c apps::ArcApps::~ArcApps() > ... > #22 0x7f40e9d8e740 KeyedServiceFactory::Disassociate() > #23 0x7f40e9d8e834 KeyedServiceFactory::ContextDestroyed() > #24 0x7f40de6a3503 BrowserContextKeyedServiceFactory::BrowserContextDestroyed() > #25 0x7f40de6a3677 BrowserContextKeyedServiceFactory::ContextDestroyed() > #26 0x7f40e9d8b145 DependencyManager::DestroyFactoriesInOrder() > #27 0x7f40e9d8b1f5 DependencyManager::PerformInterlockedTwoPhaseShutdown() > #28 0x5611fe3b3fc3 TestingProfile::~TestingProfile() > #29 0x5611fe3b43cc TestingProfile::~TestingProfile() > ... > > Original change's description: > > Flip the AppServiceAsh feature default to enabled > > > > BUG=826982 > > BUG=989789 > > > > Change-Id: I49bd3793bf9fcfc89726fd2f7df690421996e0fd > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728411 > > Reviewed-by: Dominick Ng <dominickn@chromium.org> > > Commit-Queue: Nigel Tao <nigeltao@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#683064} > > TBR=dominickn@chromium.org,nigeltao@chromium.org > > Change-Id: Iec931954750b6a58d2274c6479507e99efd2467a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 826982, 989789 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731091 > Reviewed-by: Takashi Sakamoto <tasak@google.com> > Commit-Queue: Takashi Sakamoto <tasak@google.com> > Cr-Commit-Position: refs/heads/master@{#683108} TBR=tasak@google.com,dominickn@chromium.org,nigeltao@chromium.org Change-Id: I0f8e2a335011012df144a02cf75fe943f6196171 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 826982, 989789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731373 Reviewed-by: Nigel Tao <nigeltao@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#683488}

…en mode. Upon entering the fullscreen/locked-fullscreen while the chromeVox panel is working, You can see an empty bar in the top of the screen. 1. The fullscreen rect y dimension starts after the height of the chromeVox panel, and as we don't want the chromeVox panel to be displayed, its height should be removed from the calculations. UPDATE: This issue got fixed by another colleague. So I added a unittest, and removed two workarounds were added to fix this issue in the locked-fullscreen mode. (one was to disable chromevox panel upon starting the lockedscreen mode, and the other was to hide the vox panel specifically for the locked fullscreen mode) When a window is set to fullscreen screen_util::GetFullscreenWindowBoundsInParent & AccessibilityPanelLayoutManager::UpdateWindowBounds() are called twice with this stacktraces order: [23272:23272:0723/164119.757770:ERROR:screen_util.cc(47)] ayaaa #0 0x0000081162bc base::debug::CollectStackTrace() #1 0x0000080a6c88 base::debug::StackTrace::StackTrace() #2 0x000009a8b57c ash::screen_util::GetFullscreenWindowBoundsInParent() #3 0x000009b93e62 ash::wm::DefaultState::UpdateBoundsFromState() #4 0x000009b93da4 ash::wm::DefaultState::EnterToNextState() #5 0x000009b93c2e ash::wm::DefaultState::HandleTransitionEvents() #6 0x000009b92e3e ash::wm::WindowState::OnWindowPropertyChanged() #7 0x000008d085f6 aura::Window::AfterPropertyChange() #8 0x0000082c62fc ui::PropertyHandler::SetPropertyInternal() #9 0x000008d0324c ui::PropertyHandler::SetProperty<>() #10 0x000009268956 views::Widget::SetFullscreen() #11 0x00000a088c28 BrowserView::ProcessFullscreen() #12 0x000009f48638 FullscreenController::EnterFullscreenModeInternal() #13 0x000009f47c98 FullscreenController::ToggleFullscreenModeInternal() #14 0x000009f47bba FullscreenController::ToggleBrowserFullscreenMode() #15 0x00000a0b45a8 (anonymous namespace)::BrowserWindowStateDelegate::ToggleFullscreen() #16 0x000009b93fc0 ash::wm::ToggleFullScreen() #17 0x000009b9177e ash::wm::WindowState::OnWMEvent() #18 0x000009a153ca ash::accelerators::ToggleFullscreen() #19 0x000009a13f72 ash::(anonymous namespace)::HandleToggleFullscreen() #20 0x000009a12332 ash::AcceleratorControllerImpl::AcceleratorPressed() #21 0x000009253988 ui::AcceleratorManager::Process() #22 0x000009ac225a ash::PreTargetAcceleratorHandler::ProcessAccelerator() .... #80 0x0000eae970a2 __libc_start_main [23272:23272:0723/164121.271202:ERROR:accessibility_panel_layout_manager.cc(103)] ayaaa #0 0x0000081162bc base::debug::CollectStackTrace() #1 0x0000080a6c88 base::debug::StackTrace::StackTrace() #2 0x000009a190fa ash::AccessibilityPanelLayoutManager::UpdateWindowBounds() #3 0x0000099ebd12 display::DisplayManager::NotifyMetricsChanged() #4 0x0000099ebf5a display::DisplayManager::UpdateWorkAreaOfDisplay() #5 0x000009a33610 ash::WindowTreeHostManager::UpdateWorkAreaOfDisplayNearestWindow() #6 0x000009a94ec6 ash::ShelfLayoutManager::UpdateBoundsAndOpacity() #7 0x000009a93680 ash::ShelfLayoutManager::SetState() #8 0x000009a932be ash::ShelfLayoutManager::UpdateVisibilityState() #9 0x000009b96428 ash::WorkspaceLayoutManager::SetChildBounds() #10 0x000009b8f6e4 ash::wm::SetBoundsInScreen() #11 0x000009276346 views::NativeWidgetAura::SetBounds() #12 0x000009225b72 views::BubbleDialogDelegateView::SizeToContents() #13 0x000009269980 views::Widget::OnNativeWidgetMove() #14 0x000009276cd4 views::NativeWidgetAura::OnBoundsChanged() #15 0x00000a0b4332 BrowserFrameAsh::OnBoundsChanged() #16 0x000008d0978c aura::Window::OnLayerBoundsChanged() #17 0x000008d19a6e ui::Layer::SetBoundsFromAnimation() #18 0x000008d0730c aura::Window::SetBoundsInternal() #19 0x000009b929a6 ash::wm::WindowState::SetBoundsDirect() #20 0x000009b93f0e ash::wm::DefaultState::UpdateBoundsFromState() #21 0x000009b93da4 ash::wm::DefaultState::EnterToNextState() #22 0x000009b93c2e ash::wm::DefaultState::HandleTransitionEvents() #23 0x000009b92e3e ash::wm::WindowState::OnWindowPropertyChanged() #24 0x000008d085f6 aura::Window::AfterPropertyChange() #25 0x0000082c62fc ui::PropertyHandler::SetPropertyInternal() #26 0x000008d0324c ui::PropertyHandler::SetProperty<>() #27 0x000009268956 views::Widget::SetFullscreen() #28 0x00000a088c28 BrowserView::ProcessFullscreen() #29 0x000009f48638 FullscreenController::EnterFullscreenModeInternal() #30 0x000009f47c98 FullscreenController::ToggleFullscreenModeInternal() #31 0x000009f47bba FullscreenController::ToggleBrowserFullscreenMode() #32 0x00000a0b45a8 (anonymous namespace)::BrowserWindowStateDelegate::ToggleFullscreen() #33 0x000009b93fc0 ash::wm::ToggleFullScreen() #34 0x000009b9177e ash::wm::WindowState::OnWMEvent() #35 0x000009a153ca ash::accelerators::ToggleFullscreen() #36 0x000009a13f72 ash::(anonymous namespace)::HandleToggleFullscreen() #37 0x000009a12332 ash::AcceleratorControllerImpl::AcceleratorPressed() #38 0x000009253988 ui::AcceleratorManager::Process() #39 0x000009ac225a ash::PreTargetAcceleratorHandler::ProcessAccelerator() #40 0x000009ab4ebe wm::AcceleratorFilter::OnKeyEvent() .... #97 0x0000eae970a2 __libc_start_main [23272:23272:0723/164123.029099:ERROR:screen_util.cc(47)] ayaaa #0 0x0000081162bc base::debug::CollectStackTrace() #1 0x0000080a6c88 base::debug::StackTrace::StackTrace() #2 0x000009a8b57c ash::screen_util::GetFullscreenWindowBoundsInParent() #3 0x000009b93764 ash::wm::DefaultState::SetMaximizedOrFullscreenBounds() #4 0x000009b9367a ash::wm::DefaultState::HandleWorkspaceEvents() #5 0x000009b5ac5e ash::wm::BaseState::OnWMEvent() #6 0x000009b9177e ash::wm::WindowState::OnWMEvent() #7 0x000009b968e6 ash::WorkspaceLayoutManager::AdjustAllWindowsBoundsForWorkAreaChange() #8 0x000009b96af8 ash::WorkspaceLayoutManager::OnDisplayMetricsChanged() #9 0x0000099ebd12 display::DisplayManager::NotifyMetricsChanged() #10 0x0000099ebf5a display::DisplayManager::UpdateWorkAreaOfDisplay() #11 0x000009a33610 ash::WindowTreeHostManager::UpdateWorkAreaOfDisplayNearestWindow() #12 0x000009a94ec6 ash::ShelfLayoutManager::UpdateBoundsAndOpacity() #13 0x000009a93680 ash::ShelfLayoutManager::SetState() #14 0x000009a932be ash::ShelfLayoutManager::UpdateVisibilityState() #15 0x000009b96428 ash::WorkspaceLayoutManager::SetChildBounds() #16 0x000009b8f6e4 ash::wm::SetBoundsInScreen() #17 0x000009276346 views::NativeWidgetAura::SetBounds() #18 0x000009225b72 views::BubbleDialogDelegateView::SizeToContents() #19 0x000009269980 views::Widget::OnNativeWidgetMove() #20 0x000009276cd4 views::NativeWidgetAura::OnBoundsChanged() #21 0x00000a0b4332 BrowserFrameAsh::OnBoundsChanged() #22 0x000008d0978c aura::Window::OnLayerBoundsChanged() #23 0x000008d19a6e ui::Layer::SetBoundsFromAnimation() #24 0x000008d0730c aura::Window::SetBoundsInternal() #25 0x000009b929a6 ash::wm::WindowState::SetBoundsDirect() #26 0x000009b93f0e ash::wm::DefaultState::UpdateBoundsFromState() #27 0x000009b93da4 ash::wm::DefaultState::EnterToNextState() #28 0x000009b93c2e ash::wm::DefaultState::HandleTransitionEvents() #29 0x000009b92e3e ash::wm::WindowState::OnWindowPropertyChanged() #30 0x000008d085f6 aura::Window::AfterPropertyChange() #31 0x0000082c62fc ui::PropertyHandler::SetPropertyInternal() #32 0x000008d0324c ui::PropertyHandler::SetProperty<>() #33 0x000009268956 views::Widget::SetFullscreen() #34 0x00000a088c28 BrowserView::ProcessFullscreen() #35 0x000009f48638 FullscreenController::EnterFullscreenModeInternal() #36 0x000009f47c98 FullscreenController::ToggleFullscreenModeInternal() #37 0x000009f47bba FullscreenController::ToggleBrowserFullscreenMode() #38 0x00000a0b45a8 (anonymous namespace)::BrowserWindowStateDelegate::ToggleFullscreen() #39 0x000009b93fc0 ash::wm::ToggleFullScreen() #40 0x000009b9177e ash::wm::WindowState::OnWMEvent() #41 0x000009a153ca ash::accelerators::ToggleFullscreen() #42 0x000009a13f72 ash::(anonymous namespace)::HandleToggleFullscreen() #43 0x000009a12332 ash::AcceleratorControllerImpl::AcceleratorPressed() #44 0x000009253988 ui::AcceleratorManager::Process() #45 0x000009ac225a ash::PreTargetAcceleratorHandler::ProcessAccelerator() #46 0x000009ab4ebe wm::AcceleratorFilter::OnKeyEvent() .... #103 0x0000eae970a2 __libc_start_main [23272:23272:0723/164124.932334:ERROR:accessibility_panel_layout_manager.cc(103)] ayaaa #0 0x0000081162bc base::debug::CollectStackTrace() #1 0x0000080a6c88 base::debug::StackTrace::StackTrace() #2 0x000009a190fa ash::AccessibilityPanelLayoutManager::UpdateWindowBounds() #3 0x000009ab0dea ash::Shell::NotifyFullscreenStateChanged() #4 0x000009b96a4c ash::WorkspaceLayoutManager::OnPostWindowStateTypeChange() #5 0x000009b92738 ash::wm::WindowState::NotifyPostStateTypeChange() #6 0x000009b93ddc ash::wm::DefaultState::EnterToNextState() #7 0x000009b93c2e ash::wm::DefaultState::HandleTransitionEvents() #8 0x000009b92e3e ash::wm::WindowState::OnWindowPropertyChanged() #9 0x000008d085f6 aura::Window::AfterPropertyChange() #10 0x0000082c62fc ui::PropertyHandler::SetPropertyInternal() #11 0x000008d0324c ui::PropertyHandler::SetProperty<>() #12 0x000009268956 views::Widget::SetFullscreen() #13 0x00000a088c28 BrowserView::ProcessFullscreen() #14 0x000009f48638 FullscreenController::EnterFullscreenModeInternal() #15 0x000009f47c98 FullscreenController::ToggleFullscreenModeInternal() #16 0x000009f47bba FullscreenController::ToggleBrowserFullscreenMode() #17 0x00000a0b45a8 (anonymous namespace)::BrowserWindowStateDelegate::ToggleFullscreen() #18 0x000009b93fc0 ash::wm::ToggleFullScreen() #19 0x000009b9177e ash::wm::WindowState::OnWMEvent() #20 0x000009a153ca ash::accelerators::ToggleFullscreen() #21 0x000009a13f72 ash::(anonymous namespace)::HandleToggleFullscreen() #22 0x000009a12332 ash::AcceleratorControllerImpl::AcceleratorPressed() #23 0x000009253988 ui::AcceleratorManager::Process() #24 0x000009ac225a ash::PreTargetAcceleratorHandler::ProcessAccelerator() #25 0x000009ab4ebe wm::AcceleratorFilter::OnKeyEvent() ... #82 0x0000eae970a2 __libc_start_main Bug: 945794,959786 Change-Id: If04f70f2c71563e9660c18ca942ef4b798ebcd3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702312 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Aga Wronska <agawronska@chromium.org> Reviewed-by: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#683631}

…fullscreen mode." This reverts commit 8d9e0bc. Reason for revert: ScreenUtilTest.FullscreenWindowBoundsWithChromeVox is crashing linux-chromeos-dbg. Example build: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/13699 Crash log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8906215673747190784/+/steps/ash_unittests/0/logs/Deterministic_failure:_ScreenUtilTest.FullscreenWindowBoundsWithChromeVox__status_CRASH_/0 Original change's description: > [Locked Fullscreen] Fix the vox panel inconsistency with the fullscreen mode. > > > Upon entering the fullscreen/locked-fullscreen while the chromeVox panel is working, You can see an empty bar in the top of the screen. > 1. The fullscreen rect y dimension starts after the height of the chromeVox panel, and as we don't want the chromeVox panel to be displayed, its height should be removed from the calculations. > > UPDATE: This issue got fixed by another colleague. > So I added a unittest, and removed two workarounds were added to fix this issue in the locked-fullscreen mode. > (one was to disable chromevox panel upon starting the lockedscreen mode, and the other was to hide the vox panel specifically for the locked fullscreen mode) > > When a window is set to fullscreen screen_util::GetFullscreenWindowBoundsInParent & AccessibilityPanelLayoutManager::UpdateWindowBounds() are called twice with this stacktraces order: > > [23272:23272:0723/164119.757770:ERROR:screen_util.cc(47)] ayaaa #0 0x0000081162bc base::debug::CollectStackTrace() > #1 0x0000080a6c88 base::debug::StackTrace::StackTrace() > #2 0x000009a8b57c ash::screen_util::GetFullscreenWindowBoundsInParent() > #3 0x000009b93e62 ash::wm::DefaultState::UpdateBoundsFromState() > #4 0x000009b93da4 ash::wm::DefaultState::EnterToNextState() > #5 0x000009b93c2e ash::wm::DefaultState::HandleTransitionEvents() > #6 0x000009b92e3e ash::wm::WindowState::OnWindowPropertyChanged() > #7 0x000008d085f6 aura::Window::AfterPropertyChange() > #8 0x0000082c62fc ui::PropertyHandler::SetPropertyInternal() > #9 0x000008d0324c ui::PropertyHandler::SetProperty<>() > #10 0x000009268956 views::Widget::SetFullscreen() > #11 0x00000a088c28 BrowserView::ProcessFullscreen() > #12 0x000009f48638 FullscreenController::EnterFullscreenModeInternal() > #13 0x000009f47c98 FullscreenController::ToggleFullscreenModeInternal() > #14 0x000009f47bba FullscreenController::ToggleBrowserFullscreenMode() > #15 0x00000a0b45a8 (anonymous namespace)::BrowserWindowStateDelegate::ToggleFullscreen() > #16 0x000009b93fc0 ash::wm::ToggleFullScreen() > #17 0x000009b9177e ash::wm::WindowState::OnWMEvent() > #18 0x000009a153ca ash::accelerators::ToggleFullscreen() > #19 0x000009a13f72 ash::(anonymous namespace)::HandleToggleFullscreen() > #20 0x000009a12332 ash::AcceleratorControllerImpl::AcceleratorPressed() > #21 0x000009253988 ui::AcceleratorManager::Process() > #22 0x000009ac225a ash::PreTargetAcceleratorHandler::ProcessAccelerator() > .... > #80 0x0000eae970a2 __libc_start_main > > [23272:23272:0723/164121.271202:ERROR:accessibility_panel_layout_manager.cc(103)] ayaaa #0 0x0000081162bc base::debug::CollectStackTrace() > #1 0x0000080a6c88 base::debug::StackTrace::StackTrace() > #2 0x000009a190fa ash::AccessibilityPanelLayoutManager::UpdateWindowBounds() > #3 0x0000099ebd12 display::DisplayManager::NotifyMetricsChanged() > #4 0x0000099ebf5a display::DisplayManager::UpdateWorkAreaOfDisplay() > #5 0x000009a33610 ash::WindowTreeHostManager::UpdateWorkAreaOfDisplayNearestWindow() > #6 0x000009a94ec6 ash::ShelfLayoutManager::UpdateBoundsAndOpacity() > #7 0x000009a93680 ash::ShelfLayoutManager::SetState() > #8 0x000009a932be ash::ShelfLayoutManager::UpdateVisibilityState() > #9 0x000009b96428 ash::WorkspaceLayoutManager::SetChildBounds() > #10 0x000009b8f6e4 ash::wm::SetBoundsInScreen() > #11 0x000009276346 views::NativeWidgetAura::SetBounds() > #12 0x000009225b72 views::BubbleDialogDelegateView::SizeToContents() > #13 0x000009269980 views::Widget::OnNativeWidgetMove() > #14 0x000009276cd4 views::NativeWidgetAura::OnBoundsChanged() > #15 0x00000a0b4332 BrowserFrameAsh::OnBoundsChanged() > #16 0x000008d0978c aura::Window::OnLayerBoundsChanged() > #17 0x000008d19a6e ui::Layer::SetBoundsFromAnimation() > #18 0x000008d0730c aura::Window::SetBoundsInternal() > #19 0x000009b929a6 ash::wm::WindowState::SetBoundsDirect() > #20 0x000009b93f0e ash::wm::DefaultState::UpdateBoundsFromState() > #21 0x000009b93da4 ash::wm::DefaultState::EnterToNextState() > #22 0x000009b93c2e ash::wm::DefaultState::HandleTransitionEvents() > #23 0x000009b92e3e ash::wm::WindowState::OnWindowPropertyChanged() > #24 0x000008d085f6 aura::Window::AfterPropertyChange() > #25 0x0000082c62fc ui::PropertyHandler::SetPropertyInternal() > #26 0x000008d0324c ui::PropertyHandler::SetProperty<>() > #27 0x000009268956 views::Widget::SetFullscreen() > #28 0x00000a088c28 BrowserView::ProcessFullscreen() > #29 0x000009f48638 FullscreenController::EnterFullscreenModeInternal() > #30 0x000009f47c98 FullscreenController::ToggleFullscreenModeInternal() > #31 0x000009f47bba FullscreenController::ToggleBrowserFullscreenMode() > #32 0x00000a0b45a8 (anonymous namespace)::BrowserWindowStateDelegate::ToggleFullscreen() > #33 0x000009b93fc0 ash::wm::ToggleFullScreen() > #34 0x000009b9177e ash::wm::WindowState::OnWMEvent() > #35 0x000009a153ca ash::accelerators::ToggleFullscreen() > #36 0x000009a13f72 ash::(anonymous namespace)::HandleToggleFullscreen() > #37 0x000009a12332 ash::AcceleratorControllerImpl::AcceleratorPressed() > #38 0x000009253988 ui::AcceleratorManager::Process() > #39 0x000009ac225a ash::PreTargetAcceleratorHandler::ProcessAccelerator() > #40 0x000009ab4ebe wm::AcceleratorFilter::OnKeyEvent() > .... > #97 0x0000eae970a2 __libc_start_main > > [23272:23272:0723/164123.029099:ERROR:screen_util.cc(47)] ayaaa #0 0x0000081162bc base::debug::CollectStackTrace() > #1 0x0000080a6c88 base::debug::StackTrace::StackTrace() > #2 0x000009a8b57c ash::screen_util::GetFullscreenWindowBoundsInParent() > #3 0x000009b93764 ash::wm::DefaultState::SetMaximizedOrFullscreenBounds() > #4 0x000009b9367a ash::wm::DefaultState::HandleWorkspaceEvents() > #5 0x000009b5ac5e ash::wm::BaseState::OnWMEvent() > #6 0x000009b9177e ash::wm::WindowState::OnWMEvent() > #7 0x000009b968e6 ash::WorkspaceLayoutManager::AdjustAllWindowsBoundsForWorkAreaChange() > #8 0x000009b96af8 ash::WorkspaceLayoutManager::OnDisplayMetricsChanged() > #9 0x0000099ebd12 display::DisplayManager::NotifyMetricsChanged() > #10 0x0000099ebf5a display::DisplayManager::UpdateWorkAreaOfDisplay() > #11 0x000009a33610 ash::WindowTreeHostManager::UpdateWorkAreaOfDisplayNearestWindow() > #12 0x000009a94ec6 ash::ShelfLayoutManager::UpdateBoundsAndOpacity() > #13 0x000009a93680 ash::ShelfLayoutManager::SetState() > #14 0x000009a932be ash::ShelfLayoutManager::UpdateVisibilityState() > #15 0x000009b96428 ash::WorkspaceLayoutManager::SetChildBounds() > #16 0x000009b8f6e4 ash::wm::SetBoundsInScreen() > #17 0x000009276346 views::NativeWidgetAura::SetBounds() > #18 0x000009225b72 views::BubbleDialogDelegateView::SizeToContents() > #19 0x000009269980 views::Widget::OnNativeWidgetMove() > #20 0x000009276cd4 views::NativeWidgetAura::OnBoundsChanged() > #21 0x00000a0b4332 BrowserFrameAsh::OnBoundsChanged() > #22 0x000008d0978c aura::Window::OnLayerBoundsChanged() > #23 0x000008d19a6e ui::Layer::SetBoundsFromAnimation() > #24 0x000008d0730c aura::Window::SetBoundsInternal() > #25 0x000009b929a6 ash::wm::WindowState::SetBoundsDirect() > #26 0x000009b93f0e ash::wm::DefaultState::UpdateBoundsFromState() > #27 0x000009b93da4 ash::wm::DefaultState::EnterToNextState() > #28 0x000009b93c2e ash::wm::DefaultState::HandleTransitionEvents() > #29 0x000009b92e3e ash::wm::WindowState::OnWindowPropertyChanged() > #30 0x000008d085f6 aura::Window::AfterPropertyChange() > #31 0x0000082c62fc ui::PropertyHandler::SetPropertyInternal() > #32 0x000008d0324c ui::PropertyHandler::SetProperty<>() > #33 0x000009268956 views::Widget::SetFullscreen() > #34 0x00000a088c28 BrowserView::ProcessFullscreen() > #35 0x000009f48638 FullscreenController::EnterFullscreenModeInternal() > #36 0x000009f47c98 FullscreenController::ToggleFullscreenModeInternal() > #37 0x000009f47bba FullscreenController::ToggleBrowserFullscreenMode() > #38 0x00000a0b45a8 (anonymous namespace)::BrowserWindowStateDelegate::ToggleFullscreen() > #39 0x000009b93fc0 ash::wm::ToggleFullScreen() > #40 0x000009b9177e ash::wm::WindowState::OnWMEvent() > #41 0x000009a153ca ash::accelerators::ToggleFullscreen() > #42 0x000009a13f72 ash::(anonymous namespace)::HandleToggleFullscreen() > #43 0x000009a12332 ash::AcceleratorControllerImpl::AcceleratorPressed() > #44 0x000009253988 ui::AcceleratorManager::Process() > #45 0x000009ac225a ash::PreTargetAcceleratorHandler::ProcessAccelerator() > #46 0x000009ab4ebe wm::AcceleratorFilter::OnKeyEvent() > .... > #103 0x0000eae970a2 __libc_start_main > > [23272:23272:0723/164124.932334:ERROR:accessibility_panel_layout_manager.cc(103)] ayaaa #0 0x0000081162bc base::debug::CollectStackTrace() > #1 0x0000080a6c88 base::debug::StackTrace::StackTrace() > #2 0x000009a190fa ash::AccessibilityPanelLayoutManager::UpdateWindowBounds() > #3 0x000009ab0dea ash::Shell::NotifyFullscreenStateChanged() > #4 0x000009b96a4c ash::WorkspaceLayoutManager::OnPostWindowStateTypeChange() > #5 0x000009b92738 ash::wm::WindowState::NotifyPostStateTypeChange() > #6 0x000009b93ddc ash::wm::DefaultState::EnterToNextState() > #7 0x000009b93c2e ash::wm::DefaultState::HandleTransitionEvents() > #8 0x000009b92e3e ash::wm::WindowState::OnWindowPropertyChanged() > #9 0x000008d085f6 aura::Window::AfterPropertyChange() > #10 0x0000082c62fc ui::PropertyHandler::SetPropertyInternal() > #11 0x000008d0324c ui::PropertyHandler::SetProperty<>() > #12 0x000009268956 views::Widget::SetFullscreen() > #13 0x00000a088c28 BrowserView::ProcessFullscreen() > #14 0x000009f48638 FullscreenController::EnterFullscreenModeInternal() > #15 0x000009f47c98 FullscreenController::ToggleFullscreenModeInternal() > #16 0x000009f47bba FullscreenController::ToggleBrowserFullscreenMode() > #17 0x00000a0b45a8 (anonymous namespace)::BrowserWindowStateDelegate::ToggleFullscreen() > #18 0x000009b93fc0 ash::wm::ToggleFullScreen() > #19 0x000009b9177e ash::wm::WindowState::OnWMEvent() > #20 0x000009a153ca ash::accelerators::ToggleFullscreen() > #21 0x000009a13f72 ash::(anonymous namespace)::HandleToggleFullscreen() > #22 0x000009a12332 ash::AcceleratorControllerImpl::AcceleratorPressed() > #23 0x000009253988 ui::AcceleratorManager::Process() > #24 0x000009ac225a ash::PreTargetAcceleratorHandler::ProcessAccelerator() > #25 0x000009ab4ebe wm::AcceleratorFilter::OnKeyEvent() > ... > #82 0x0000eae970a2 __libc_start_main > > Bug: 945794,959786 > Change-Id: If04f70f2c71563e9660c18ca942ef4b798ebcd3a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702312 > Commit-Queue: Aya Elsayed <ayaelattar@google.com> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Reviewed-by: Ivan Šandrk <isandrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683631} TBR=oshima@chromium.org,dtseng@chromium.org,isandrk@chromium.org,agawronska@chromium.org,ayaelattar@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 945794, 959786 Change-Id: Iff0e849ffbba12b8a36079c2ba484e9285d75780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735720 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#683888}

…iew mode."" This reverts commit f00acd8. Reason for revert: crbug.com/863795 Original change's description: > Reland "overview: Hide title bars before animating into overview mode." > > This is a reland of a663e7f > > The original cl causes some flaky tests with stack trace: > > [16202:16202:0709/211202.910243:FATAL:single_thread_proxy.cc(237)] Check failed: task_runner_provider_->IsMainThread(). > #0 0x7f9b36f8672d base::debug::StackTrace::StackTrace() > chromium#1 0x7f9b36c9d3fc base::debug::StackTrace::StackTrace() > chromium#2 0x7f9b36d06dfd logging::LogMessage::~LogMessage() > chromium#3 0x7f9b2b5692e8 cc::SingleThreadProxy::SetNeedsCommit() > chromium#4 0x7f9b2b45ecef cc::LayerTreeHost::SetNeedsCommit() > chromium#5 0x7f9b2b467426 cc::LayerTreeHost::SetMutatorsNeedCommit() > chromium#6 0x7f9b0fd29981 cc::AnimationHost::SetNeedsCommit() > chromium#7 0x7f9b0fd1962d cc::Animation::SetNeedsCommit() > chromium#8 0x7f9b0fd41151 cc::KeyframeEffect::KeyframeModelAdded() > chromium#9 0x7f9b0fd44e6c cc::KeyframeEffect::AddKeyframeModel() > chromium#10 0x7f9b0fd17fbc cc::Animation::AddKeyframeModelForKeyframeEffect() > chromium#11 0x7f9b0fd71a6d cc::SingleKeyframeEffectAnimation::AddKeyframeModel() > chromium#12 0x7f9b28c83a95 ui::LayerAnimator::AddThreadedAnimation() > chromium#13 0x7f9b28c7498e ui::(anonymous namespace)::ThreadedLayerAnimationElement::RequestEffectiveStart() > chromium#14 0x7f9b28c71113 ui::LayerAnimationElement::Start() > chromium#15 0x7f9b28c7cbe3 ui::LayerAnimationSequence::Start() > chromium#16 0x7f9b28c84287 ui::LayerAnimator::StartSequenceImmediately() > chromium#17 0x7f9b28c81251 ui::LayerAnimator::StartAnimation() > chromium#18 0x7f9b28c80eb6 ui::LayerAnimator::SetTransform() > chromium#19 0x7f9b28c6122e ui::Layer::SetTransform() > chromium#20 0x7f9b28ded831 aura::Window::SetTransform() > chromium#21 0x7f9b22b732df ash::ScopedTransformOverviewWindow::SetTransform() > chromium#22 0x7f9b22b73f69 ash::ScopedTransformOverviewWindow::OnCompositingStarted() > chromium#23 0x7f9b28c4d734 ui::Compositor::DidSubmitCompositorFrame() > chromium#24 0x7f9b2b56cd05 cc::SingleThreadProxy::DoComposite() > chromium#25 0x7f9b2b56e835 cc::SingleThreadProxy::ScheduledActionDrawIfPossible() > chromium#26 0x7f9b2b3736fd cc::Scheduler::DrawIfPossible() > chromium#27 0x7f9b2b36dbdc cc::Scheduler::ProcessScheduledActions() > chromium#28 0x7f9b2b36d5fd cc::Scheduler::OnBeginImplFrameDeadline() > > This cl makes that test skip waiting for composit when entering overview, like the tests > in ash. > > Original change's description: > > overview: Hide title bars before animating into overview mode. > > > > The title bars should not visible while animating overview mode. This cl > > hides the title bar if needed and waits until the next paint before > > animating the windows. This will hide the title bar as expected while > > keeping the benefits of DeferPaint. > > > > Test: manual > > Bug: 843851 > > Change-Id: I99cf7ca39fd1ae14314ac406abd0fec999e2c024 > > Reviewed-on: https://chromium-review.googlesource.com/1112774 > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > > Reviewed-by: Tao Wu <wutao@chromium.org> > > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#573552} > > TBR=oshima@chromium.org > > Bug: 843851 > Change-Id: I3a538250d5f6d42d6c73e218445080af533b54dc > Reviewed-on: https://chromium-review.googlesource.com/1131874 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574209} TBR=msw@chromium.org,oshima@chromium.org,sammiequon@chromium.org,wutao@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 843851 Change-Id: Ib2744c7f677be40004b70a714cebe0a337f7c60b Reviewed-on: https://chromium-review.googlesource.com/1142304 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#576250}

…fullscreen mode." This is a reland of 8d9e0bc Original change's description: > [Locked Fullscreen] Fix the vox panel inconsistency with the fullscreen mode. > > > Upon entering the fullscreen/locked-fullscreen while the chromeVox panel is working, You can see an empty bar in the top of the screen. > 1. The fullscreen rect y dimension starts after the height of the chromeVox panel, and as we don't want the chromeVox panel to be displayed, its height should be removed from the calculations. > > UPDATE: This issue got fixed by another colleague. > So I added a unittest, and removed two workarounds were added to fix this issue in the locked-fullscreen mode. > (one was to disable chromevox panel upon starting the lockedscreen mode, and the other was to hide the vox panel specifically for the locked fullscreen mode) > > When a window is set to fullscreen screen_util::GetFullscreenWindowBoundsInParent & AccessibilityPanelLayoutManager::UpdateWindowBounds() are called twice with this stacktraces order: > > [23272:23272:0723/164119.757770:ERROR:screen_util.cc(47)] ayaaa #0 0x0000081162bc base::debug::CollectStackTrace() > #1 0x0000080a6c88 base::debug::StackTrace::StackTrace() > #2 0x000009a8b57c ash::screen_util::GetFullscreenWindowBoundsInParent() > #3 0x000009b93e62 ash::wm::DefaultState::UpdateBoundsFromState() > #4 0x000009b93da4 ash::wm::DefaultState::EnterToNextState() > #5 0x000009b93c2e ash::wm::DefaultState::HandleTransitionEvents() > #6 0x000009b92e3e ash::wm::WindowState::OnWindowPropertyChanged() > #7 0x000008d085f6 aura::Window::AfterPropertyChange() > #8 0x0000082c62fc ui::PropertyHandler::SetPropertyInternal() > #9 0x000008d0324c ui::PropertyHandler::SetProperty<>() > #10 0x000009268956 views::Widget::SetFullscreen() > #11 0x00000a088c28 BrowserView::ProcessFullscreen() > #12 0x000009f48638 FullscreenController::EnterFullscreenModeInternal() > #13 0x000009f47c98 FullscreenController::ToggleFullscreenModeInternal() > #14 0x000009f47bba FullscreenController::ToggleBrowserFullscreenMode() > #15 0x00000a0b45a8 (anonymous namespace)::BrowserWindowStateDelegate::ToggleFullscreen() > #16 0x000009b93fc0 ash::wm::ToggleFullScreen() > #17 0x000009b9177e ash::wm::WindowState::OnWMEvent() > #18 0x000009a153ca ash::accelerators::ToggleFullscreen() > #19 0x000009a13f72 ash::(anonymous namespace)::HandleToggleFullscreen() > #20 0x000009a12332 ash::AcceleratorControllerImpl::AcceleratorPressed() > #21 0x000009253988 ui::AcceleratorManager::Process() > #22 0x000009ac225a ash::PreTargetAcceleratorHandler::ProcessAccelerator() > .... > #80 0x0000eae970a2 __libc_start_main > > [23272:23272:0723/164121.271202:ERROR:accessibility_panel_layout_manager.cc(103)] ayaaa #0 0x0000081162bc base::debug::CollectStackTrace() > #1 0x0000080a6c88 base::debug::StackTrace::StackTrace() > #2 0x000009a190fa ash::AccessibilityPanelLayoutManager::UpdateWindowBounds() > #3 0x0000099ebd12 display::DisplayManager::NotifyMetricsChanged() > #4 0x0000099ebf5a display::DisplayManager::UpdateWorkAreaOfDisplay() > #5 0x000009a33610 ash::WindowTreeHostManager::UpdateWorkAreaOfDisplayNearestWindow() > #6 0x000009a94ec6 ash::ShelfLayoutManager::UpdateBoundsAndOpacity() > #7 0x000009a93680 ash::ShelfLayoutManager::SetState() > #8 0x000009a932be ash::ShelfLayoutManager::UpdateVisibilityState() > #9 0x000009b96428 ash::WorkspaceLayoutManager::SetChildBounds() > #10 0x000009b8f6e4 ash::wm::SetBoundsInScreen() > #11 0x000009276346 views::NativeWidgetAura::SetBounds() > #12 0x000009225b72 views::BubbleDialogDelegateView::SizeToContents() > #13 0x000009269980 views::Widget::OnNativeWidgetMove() > #14 0x000009276cd4 views::NativeWidgetAura::OnBoundsChanged() > #15 0x00000a0b4332 BrowserFrameAsh::OnBoundsChanged() > #16 0x000008d0978c aura::Window::OnLayerBoundsChanged() > #17 0x000008d19a6e ui::Layer::SetBoundsFromAnimation() > #18 0x000008d0730c aura::Window::SetBoundsInternal() > #19 0x000009b929a6 ash::wm::WindowState::SetBoundsDirect() > #20 0x000009b93f0e ash::wm::DefaultState::UpdateBoundsFromState() > #21 0x000009b93da4 ash::wm::DefaultState::EnterToNextState() > #22 0x000009b93c2e ash::wm::DefaultState::HandleTransitionEvents() > #23 0x000009b92e3e ash::wm::WindowState::OnWindowPropertyChanged() > #24 0x000008d085f6 aura::Window::AfterPropertyChange() > #25 0x0000082c62fc ui::PropertyHandler::SetPropertyInternal() > #26 0x000008d0324c ui::PropertyHandler::SetProperty<>() > #27 0x000009268956 views::Widget::SetFullscreen() > #28 0x00000a088c28 BrowserView::ProcessFullscreen() > #29 0x000009f48638 FullscreenController::EnterFullscreenModeInternal() > #30 0x000009f47c98 FullscreenController::ToggleFullscreenModeInternal() > #31 0x000009f47bba FullscreenController::ToggleBrowserFullscreenMode() > #32 0x00000a0b45a8 (anonymous namespace)::BrowserWindowStateDelegate::ToggleFullscreen() > #33 0x000009b93fc0 ash::wm::ToggleFullScreen() > #34 0x000009b9177e ash::wm::WindowState::OnWMEvent() > #35 0x000009a153ca ash::accelerators::ToggleFullscreen() > #36 0x000009a13f72 ash::(anonymous namespace)::HandleToggleFullscreen() > #37 0x000009a12332 ash::AcceleratorControllerImpl::AcceleratorPressed() > #38 0x000009253988 ui::AcceleratorManager::Process() > #39 0x000009ac225a ash::PreTargetAcceleratorHandler::ProcessAccelerator() > #40 0x000009ab4ebe wm::AcceleratorFilter::OnKeyEvent() > .... > #97 0x0000eae970a2 __libc_start_main > > [23272:23272:0723/164123.029099:ERROR:screen_util.cc(47)] ayaaa #0 0x0000081162bc base::debug::CollectStackTrace() > #1 0x0000080a6c88 base::debug::StackTrace::StackTrace() > #2 0x000009a8b57c ash::screen_util::GetFullscreenWindowBoundsInParent() > #3 0x000009b93764 ash::wm::DefaultState::SetMaximizedOrFullscreenBounds() > #4 0x000009b9367a ash::wm::DefaultState::HandleWorkspaceEvents() > #5 0x000009b5ac5e ash::wm::BaseState::OnWMEvent() > #6 0x000009b9177e ash::wm::WindowState::OnWMEvent() > #7 0x000009b968e6 ash::WorkspaceLayoutManager::AdjustAllWindowsBoundsForWorkAreaChange() > #8 0x000009b96af8 ash::WorkspaceLayoutManager::OnDisplayMetricsChanged() > #9 0x0000099ebd12 display::DisplayManager::NotifyMetricsChanged() > #10 0x0000099ebf5a display::DisplayManager::UpdateWorkAreaOfDisplay() > #11 0x000009a33610 ash::WindowTreeHostManager::UpdateWorkAreaOfDisplayNearestWindow() > #12 0x000009a94ec6 ash::ShelfLayoutManager::UpdateBoundsAndOpacity() > #13 0x000009a93680 ash::ShelfLayoutManager::SetState() > #14 0x000009a932be ash::ShelfLayoutManager::UpdateVisibilityState() > #15 0x000009b96428 ash::WorkspaceLayoutManager::SetChildBounds() > #16 0x000009b8f6e4 ash::wm::SetBoundsInScreen() > #17 0x000009276346 views::NativeWidgetAura::SetBounds() > #18 0x000009225b72 views::BubbleDialogDelegateView::SizeToContents() > #19 0x000009269980 views::Widget::OnNativeWidgetMove() > #20 0x000009276cd4 views::NativeWidgetAura::OnBoundsChanged() > #21 0x00000a0b4332 BrowserFrameAsh::OnBoundsChanged() > #22 0x000008d0978c aura::Window::OnLayerBoundsChanged() > #23 0x000008d19a6e ui::Layer::SetBoundsFromAnimation() > #24 0x000008d0730c aura::Window::SetBoundsInternal() > #25 0x000009b929a6 ash::wm::WindowState::SetBoundsDirect() > #26 0x000009b93f0e ash::wm::DefaultState::UpdateBoundsFromState() > #27 0x000009b93da4 ash::wm::DefaultState::EnterToNextState() > #28 0x000009b93c2e ash::wm::DefaultState::HandleTransitionEvents() > #29 0x000009b92e3e ash::wm::WindowState::OnWindowPropertyChanged() > #30 0x000008d085f6 aura::Window::AfterPropertyChange() > #31 0x0000082c62fc ui::PropertyHandler::SetPropertyInternal() > #32 0x000008d0324c ui::PropertyHandler::SetProperty<>() > #33 0x000009268956 views::Widget::SetFullscreen() > #34 0x00000a088c28 BrowserView::ProcessFullscreen() > #35 0x000009f48638 FullscreenController::EnterFullscreenModeInternal() > #36 0x000009f47c98 FullscreenController::ToggleFullscreenModeInternal() > #37 0x000009f47bba FullscreenController::ToggleBrowserFullscreenMode() > #38 0x00000a0b45a8 (anonymous namespace)::BrowserWindowStateDelegate::ToggleFullscreen() > #39 0x000009b93fc0 ash::wm::ToggleFullScreen() > #40 0x000009b9177e ash::wm::WindowState::OnWMEvent() > #41 0x000009a153ca ash::accelerators::ToggleFullscreen() > #42 0x000009a13f72 ash::(anonymous namespace)::HandleToggleFullscreen() > #43 0x000009a12332 ash::AcceleratorControllerImpl::AcceleratorPressed() > #44 0x000009253988 ui::AcceleratorManager::Process() > #45 0x000009ac225a ash::PreTargetAcceleratorHandler::ProcessAccelerator() > #46 0x000009ab4ebe wm::AcceleratorFilter::OnKeyEvent() > .... > #103 0x0000eae970a2 __libc_start_main > > [23272:23272:0723/164124.932334:ERROR:accessibility_panel_layout_manager.cc(103)] ayaaa #0 0x0000081162bc base::debug::CollectStackTrace() > #1 0x0000080a6c88 base::debug::StackTrace::StackTrace() > #2 0x000009a190fa ash::AccessibilityPanelLayoutManager::UpdateWindowBounds() > #3 0x000009ab0dea ash::Shell::NotifyFullscreenStateChanged() > #4 0x000009b96a4c ash::WorkspaceLayoutManager::OnPostWindowStateTypeChange() > #5 0x000009b92738 ash::wm::WindowState::NotifyPostStateTypeChange() > #6 0x000009b93ddc ash::wm::DefaultState::EnterToNextState() > #7 0x000009b93c2e ash::wm::DefaultState::HandleTransitionEvents() > #8 0x000009b92e3e ash::wm::WindowState::OnWindowPropertyChanged() > #9 0x000008d085f6 aura::Window::AfterPropertyChange() > #10 0x0000082c62fc ui::PropertyHandler::SetPropertyInternal() > #11 0x000008d0324c ui::PropertyHandler::SetProperty<>() > #12 0x000009268956 views::Widget::SetFullscreen() > #13 0x00000a088c28 BrowserView::ProcessFullscreen() > #14 0x000009f48638 FullscreenController::EnterFullscreenModeInternal() > #15 0x000009f47c98 FullscreenController::ToggleFullscreenModeInternal() > #16 0x000009f47bba FullscreenController::ToggleBrowserFullscreenMode() > #17 0x00000a0b45a8 (anonymous namespace)::BrowserWindowStateDelegate::ToggleFullscreen() > #18 0x000009b93fc0 ash::wm::ToggleFullScreen() > #19 0x000009b9177e ash::wm::WindowState::OnWMEvent() > #20 0x000009a153ca ash::accelerators::ToggleFullscreen() > #21 0x000009a13f72 ash::(anonymous namespace)::HandleToggleFullscreen() > #22 0x000009a12332 ash::AcceleratorControllerImpl::AcceleratorPressed() > #23 0x000009253988 ui::AcceleratorManager::Process() > #24 0x000009ac225a ash::PreTargetAcceleratorHandler::ProcessAccelerator() > #25 0x000009ab4ebe wm::AcceleratorFilter::OnKeyEvent() > ... > #82 0x0000eae970a2 __libc_start_main > > Bug: 945794,959786 > Change-Id: If04f70f2c71563e9660c18ca942ef4b798ebcd3a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702312 > Commit-Queue: Aya Elsayed <ayaelattar@google.com> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Reviewed-by: Ivan Šandrk <isandrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683631} TBR=ayaelattar@google.com Bug: 945794, 959786 Change-Id: Ia0b5e750f2b0682e256aa3b1ffd78df9b5667a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744411 Reviewed-by: Ivan Šandrk <isandrk@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#692461}

After crrev.com/c/1573306, network service checks if unauthorized special headers does not exist in the list that bypasses the CORS protocol checks. At this moment, 'Purpose: prefetch' header is not standardized, and we need to rely on that list. To make this exempt mechanism work, embedders need to set the cors_exempt_header to create NetworkContexts. This patch adds cors_exempt_header support to headless. (cherry picked from commit ea83edc) Bug: 984463 Change-Id: I05d2867ae9e035967cfbe06ce2abda716df9fab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715200 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#681596} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724209 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/branch-heads/3865@{chromium#12} Cr-Branched-From: 0cdcc61-refs/heads/master@{#681094}

This reverts commit de35a09. Reason for revert: Failing on all platforms. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=WelcomeA11y.WelcomeFlow_color_contrast https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/27248 [18374:18374:0923/204432.097393:ERROR:CONSOLE(49)] "Mocha test failed: WelcomeFlow_color_contrast Landing Page Error: the string "Found 1 accessibility violations." was thrown, throw an Error :) ", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (49) [18374:18374:0923/204432.101101:ERROR:web_ui_test_handler.cc(72)] Test Errors: 1/1 tests had failed assertions. [18374:18374:0923/204432.101355:ERROR:web_ui_browser_test.cc(546)] CONDITION FAILURE: encountered javascript console error(s): [18374:18374:0923/204432.101376:ERROR:web_ui_browser_test.cc(548)] JS ERROR: '[18374:18374:0923/204432.097393:ERROR:CONSOLE(49)] "Mocha test failed: WelcomeFlow_color_contrast Landing Page Error: the string "Found 1 accessibility violations." was thrown, throw an Error :) ", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (49) ' [18374:18374:0923/204432.101390:ERROR:web_ui_browser_test.cc(550)] JS call assumed failed, because JS console error(s) found. gen/chrome/test/data/webui/welcome/a11y_tests-gen.cc:285: Failure Value of: RunJavascriptTestF( true, "WelcomeA11y", "WelcomeFlow_color_contrast") Actual: false Expected: true Stack trace: #0 0x55ebe3920b5f StackTraceGetter::CurrentStackTrace() #1 0x55ebe392955c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #2 0x55ebe3928ea9 testing::internal::AssertHelper::operator=() #3 0x55ebe36c24dd WelcomeA11y_WelcomeFlow_color_contrast_Test::RunTestOnMainThread() #4 0x55ebe60b131e content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #5 0x55ebe5cae39c ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #6 0x55ebe5cad1ad ChromeBrowserMainParts::PreMainMessageLoopRun() #7 0x55ebe438318f content::BrowserMainLoop::PreMainMessageLoopRun() #8 0x55ebe4779607 content::StartupTaskRunner::RunAllTasksNow() #9 0x55ebe4381e42 content::BrowserMainLoop::CreateStartupTasks() #10 0x55ebe4384bf2 content::BrowserMainRunnerImpl::Initialize() #11 0x55ebe438041f content::BrowserMain() #12 0x55ebe5873245 content::ContentMainRunnerImpl::RunServiceManager() #13 0x55ebe5872d76 content::ContentMainRunnerImpl::Run() #14 0x55ebe7a2e8dd service_manager::Main() #15 0x55ebe4c9c511 content::ContentMain() #16 0x55ebe60b0dc6 content::BrowserTestBase::SetUp() Original change's description: > Reland Update axe-core to v3.3.2 > > This change updates the version of axe-core to the latest released > version. As part of picking up the latest version, the following > additional changes were made: > > 1) axe-core removed the 'href-no-hash' rule, so that been removed > from the test list. > > 2) Several 'link-in-text-block' tests started failing with > axe-core v3.0.2 (and later). These tests do pass in v3.0.1, but > are disabled as part of this change. > - CrManagementA11yTest.SimpleTest_link_in_text_block > - CrManagementA11yTestWithExtension. > ExtensionSection_link_in_text_block > - CrostiniAccessibilityTest.CROSTINI_link_in_text_block > - CrExtensionsA11yTest.NoExtensions_link_in_text_block > - MultideviceA11yTest.MULTIDEVICE_link_in_text_block > - MultideviceFeaturesA11yTest. > MULTIDEVICE_FEATURES_ACCESSIBILITY_link_in_text_block > > 3) One 'heading-order' test started failing in v3.0.0 (and later). > This tests does pass in V2.4.2, but is disabled as part of this > change. > - CrExtensionsA11yTestWithMultipleExensions. > WithExtensions_heading_order > > 4) Several DevTools a11y tests were failing. This change either > updates the baseline or excludes the rule depending upon the > test/rule itself. > - http/tests/devtools/a11y-axe-core/basic-a11y-test.js > - http/tests/devtools/a11y-axe-core/console-a11y-test.js > - http/tests/devtools/a11y-axe-core/memory/heap-profiler-a11y-test.js > - http/tests/devtools/a11y-axe-core/sources/dom-breakpoints-pane-a11y-test.js > > I spent some time investigating the test failures, and it looks > like axe-core is highlighting legitimate product issues. > > Change-Id: I0ef08cdace91250936f83705fb3cd0fbb35bed4b > Bug: 984817 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809407 > Commit-Queue: Mike Jackson <mjackson@microsoft.com> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699166} TBR=aboxhall@chromium.org,hcarmona@chromium.org,yangguo@chromium.org,mjackson@microsoft.com,tvanderlippe@chromium.org Change-Id: I6e74d1ddeec80407fc057dd07c95c492d7e6679f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 984817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819284 Reviewed-by: Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#699191}

Break function execution when DOM exception is thrown

ICU parsing (grapheme) will be used by the TextItemize and need to be initialized. Running: crash-3e6400c066a0fc4e1652349294b22b87b9b9dd35 [1030/172842.831069:FATAL:break_iterator.cc(77)] Check failed: false. ubrk_open failed for type 2 with error 2 ================================================================= ==211878==ERROR: AddressSanitizer: ABRT on unknown address 0x2e61100033ba6 (pc 0x7f158a533cfb bp 0x7ffebc185cf0 sp 0x7ffebc185a90 T0) SCARINESS: 10 (signal) #0 0x7f158a533cfa in raise (/lib/x86_64-linux-gnu/libc.so.6+0x36cfa) #1 0x7f1594f60153 in base::debug::BreakDebugger() base/debug/debugger_posix.cc:331:3 #2 0x7f1594628d0d in logging::LogMessage::~LogMessage() base/logging.cc:956:7 #3 0x7f158c07b6ab in base::i18n::BreakIterator::Init() base/i18n/break_iterator.cc:77:7 #4 0x7f1595809bdd in gfx::RenderText::GetLineBreaks() ui/gfx/render_text.cc:1302:29 #5 0x7f1595889e82 in gfx::RenderTextHarfBuzz::EnsureLayout() ui/gfx/render_text_harfbuzz.cc:1758:24 #6 0x7f15957f9105 in gfx::RenderText::Draw(gfx::Canvas*) ui/gfx/render_text.cc:869:3 #7 0x5619787fc3e0 in LLVMFuzzerTestOneInput ui/gfx/render_text_api_fuzzer.cc:198:22 #8 0x5619788a14eb in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) third_party/libFuzzer/src/FuzzerLoop.cpp:553:15 #9 0x561978849dfc in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) third_party/libFuzzer/src/FuzzerDriver.cpp:292:6 #10 0x561978851a25 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) third_party/libFuzzer/src/FuzzerDriver.cpp:775:9 #11 0x5619788cb358 in main third_party/libFuzzer/src/FuzzerMain.cpp:19:10 #12 0x7f158a52052a in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x23 Bug: 1019913 Change-Id: I47a84779eb259b10471c345e7e93f214d644b74d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893354 Reviewed-by: Abhishek Arya <inferno@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#711295}

Change-Id: I130b933937d019f308cd5a97fee42024bad54bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5191308 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6241@{#12} Cr-Branched-From: f2c8067-refs/heads/main@{#1245833}

Change-Id: I3d61c4e4ee8076f9a0a3ab6ec3906d263783be5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5202371 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6252@{#12} Cr-Branched-From: 087dd7f-refs/heads/main@{#1247442}

When the kAppServiceStorage flag is enabled, AppService blocks the app publishers creating until it's ready, after reading from the AppStorage file. This affects some tests, e.g. NetworkConfigurationUpdaterAshTest.*. Those tests crash because no data path for the profile: Received signal 11 SEGV_MAPERR 000000000017 ... #9 0x7fb71a1fe827 base::FilePath::Append() #10 0x7fb72e112a6c ash::BrowserContextHelper::GetBrowserContextPathByUserIdHash() #11 0x556a750dbf21 ash::ProfileHelperImpl::GetUserByProfile() #12 0x556a750db807 ash::ProfileHelper::IsPrimaryProfile() #13 0x556a834e83a3 NearbySharingServiceFactory::IsNearbyShareSupportedForBrowserContext() #14 0x556a8295719c NotificationDisplayServiceImpl::NotificationDisplayServiceImpl() #15 0x556a82956ce9 std::__Cr::make_unique<>() ... #19 0x7fb6fcef560c BrowserContextKeyedServiceFactory::GetServiceForBrowserContext() #20 0x556a82956b52 NotificationDisplayServiceFactory::GetForProfile() #21 0x556a7305f5be apps::ExtensionAppsChromeOs::Initialize() #22 0x556a730aa83b apps::PublisherHost::Initialize() #23 0x556a730aa68c apps::PublisherHost::PublisherHost() The reason should because of FakeUserManager. Actually the fake user manager is created in TestingProfile, so we don't need to build a new one, and we can get the user manager directly with: user_manager::UserManager::Get() Modify the test setup process to get the user manager directly, and remove `user_manager_` in the test code, as that has been moved to TestProfile. BUG=1385932, b:307623506 Change-Id: I5873858d5e18ca6196bc5b83ed38d87e1f18ae14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5188272 Reviewed-by: Anqing Zhao <anqing@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#1248444}

...triggers entry doom and thus ends up running the operation queue in the wrong spot of creation (and entry op) completion handler. This can among other things result in this madness: #6 disk_cache::SimpleEntryImpl::CloseInternal() #7 disk_cache::SimpleEntryImpl::RunNextOperationIfNeeded() #8 SimpleEntryImpl::ScopedOperationRunner::~ScopedOperationRunner() #9 disk_cache::SimpleEntryImpl::WriteDataInternal() #10 disk_cache::SimpleEntryImpl::RunNextOperationIfNeeded() #11 SimpleEntryImpl::ScopedOperationRunner::~ScopedOperationRunner() #12 disk_cache::SimpleEntryImpl::WriteDataInternal() #13 disk_cache::SimpleEntryImpl::RunNextOperationIfNeeded() #14 disk_cache::SimpleEntryImpl::DoomEntry() #15 disk_cache::SimpleBackendImpl::DoomEntryFromHash() #16 disk_cache::SimpleBackendImpl::DoomEntries() #17 disk_cache::SimpleIndex::StartEvictionIfNeeded() #18 disk_cache::SimpleIndex::UpdateEntrySize() #19 disk_cache::SimpleEntryImpl::UpdateDataFromEntryStat() #20 disk_cache::SimpleEntryImpl::CreationOperationComplete() (namespace elided twice to avoid wrapping). ... which means we end up at the in_results = nullptr line near the bottom of CreationOperationComplete with null `synchronous_entry_`(!) (and a dangling in_results->sync_entry, where one would expect the two to be aliases). I *think* we won't actually deliver a callback from this state since we likely needed to be in optimistic path to got thus far, but I am not certain. Similarly, when this sort of thing happens from within read/write ops, it could potentially cause callbacks to be delivered in wrong order if the queued op ends up being a stream 0 operation, which can be executed without a round trip to a worker thread. Change-Id: Iac8058f0d18225677e361c6cdddf92d28fb4833f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5054619 Reviewed-by: Adam Rice <ricea@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/main@{#1248862}

Change-Id: I6badc3ff8a435692eefdd0e54eff8ba0842bfe12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5214246 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6256@{#12} Cr-Branched-From: 4cc21c9-refs/heads/main@{#1248731}

Bug: 1519904 Change-Id: Ia608fad9c683c694d374851398bb8bbe7c429181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5216470 Owners-Override: Ben Mason <benmason@chromium.org> Reviewed-by: Richard (Torne) Coles <torne@chromium.org> Cr-Commit-Position: refs/branch-heads/6169@{#12} Cr-Branched-From: 5bfff79-refs/heads/main@{#1233911}

…only Bug: 1518333,1501655 Change-Id: I4dff982fdd1d03844c6ecfe2fdc8058d24b41143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5230198 Reviewed-by: Mark Schillaci <mschillaci@google.com> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/branch-heads/6261@{#12} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}

Return null database client when UKM is disabled. This case is already needed to be handled by the callers. (cherry picked from commit 3ab926e) Bug: 1521401, b/322178680 Change-Id: I394a92c4560875017aaa99f39e239f59e1b1fbe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5234752 Reviewed-by: Roman Arora <romanarora@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1251776} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5235066 Owners-Override: Srinivas Sista <srinivassista@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6262@{#12} Cr-Branched-From: be51b44-refs/heads/main@{#1251193}

`createApp` was failing, since the apps were not registered with the updater. As a workaround, the apps are now pre-registered in the legacy ondemand server. (cherry picked from commit a102ec5) Fixed: 1521156 Change-Id: Ib36f536267ca8eb4ee21c298be75ce6ec1287a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5230620 Auto-Submit: S Ganesh <ganesh@chromium.org> Commit-Queue: S Ganesh <ganesh@chromium.org> Reviewed-by: Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1251162} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5236457 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/branch-heads/6253@{#12} Cr-Branched-From: b99fcea-refs/heads/main@{#1247893}

When XuCameraService uses IpPeripheralServiceClient to send dbus commands to IpPeripheralService, it must use the UI thread. (https://chromium.googlesource.com/chromiumos/docs/+/HEAD/dbus_in_chrome.md#using-system-daemons_d_bus-services) Without this change, on M108, gdb showed that we were crashing in `ObjectProxy::CallMethodWithErrorResponse' on `bus_->AssertOnOriginThread();` at https://source.chromium.org/chromium/chromium/src/+/main:dbus/object_proxy.cc;l=169 BUG=b:284299455 TESTED=Endeavour on R108-15183.82.41 and Falcon camera on 1.5.17 (cherry picked from commit 30d8453) Change-Id: I7fc001b329e8ad4ecbe4fa263d2ef5f5a27aeea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4859064 Commit-Queue: Richard Yeh <rcy@google.com> Owners-Override: Richard Yeh <rcy@google.com> Reviewed-by: Kyle Williams <kdgwill@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/5359_179@{#37} Cr-Original-Branched-From: 296508e-refs/branch-heads/5359@{#1312} Cr-Original-Branched-From: 27d3765-refs/heads/main@{#1058933} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4968498 Auto-Submit: Richard Yeh <rcy@google.com> Cr-Commit-Position: refs/branch-heads/5735_289@{#12} Cr-Branched-From: e2157fd-refs/branch-heads/5735@{#1538} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}

Change-Id: Ibfdadff58b257f25d763066ff10c66f402c69579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5301555 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6300@{#12} Cr-Branched-From: 01aa8ab-refs/heads/main@{#1260023}

Commits rolled: https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/909b6cc799a7..5f1169e98726 Generated by: go/bbid/8755540622040655601 Change-Id: I4c63b4b81b339e31fa2267b4e555979f1c7fe760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5311394 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6312@{#12} Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}

Commits rolled: https://webrtc.googlesource.com/src.git/+log/b0cc68e61205..3a064b0fa461 Generated by: go/bbid/8754353728488879105 Change-Id: Idd2ae6a63f70f91273ef3fc589f1e806cf306590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5342675 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6099_225@{#12} Cr-Branched-From: 6d3cc0d-refs/branch-heads/6099@{#1762} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}

This CL will update lacros version in //chrome/LACROS_QA_QUALIFIED_VERSION. This file will be used in Upreving the RootFS-Lacros in the CROS image. If this CL caused regressions, please revert and pause the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-qa-qualified-tracking-roller Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org. R=rubber-stamper@appspot.gserviceaccount.com Change-Id: I1a18cb2d9227dbe3067f8fa836080b60607b9d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5370558 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com <lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6356@{#12} Cr-Branched-From: bc9ea55-refs/heads/main@{#1272107}

Change-Id: Ic7ac3253698b3fb9b0c34cce512eea611004343c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5380900 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6367@{#12} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}

Change-Id: I4ed97f4793ca40cde4ff4f1c17595c7cef799203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4767657 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5938@{chromium#12} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}

Change-Id: If6b496d628c9a7a3a2c95b135742ceb229c8900c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4867531 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5938_62@{chromium#12} Cr-Branched-From: 25a7172-refs/branch-heads/5938@{#1146} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}

This reverts commit 6f447d5. Reason for revert: Crashes on ChromeOS as soon as I touch the device's touchpad 2024-03-26T00:58:16.588106Z FATAL chrome[5433:5496]: [sequence_checker.cc(21)] Check failed: checker.CalledOnValidSequence(&bound_at). #0 0x56f06aa34da2 base::debug::CollectStackTrace() #1 0x56f06aa19ba2 base::debug::StackTrace::StackTrace() #2 0x56f06a934073 logging::LogMessage::Flush() #3 0x56f063de6fcd logging::LogMessage::~LogMessage() #4 0x56f06a92053c logging::(anonymous namespace)::DCheckLogMessage::~DCheckLogMessage() #5 0x56f06a9205ae logging::(anonymous namespace)::DCheckLogMessage::~DCheckLogMessage() #6 0x56f063dc2ba6 logging::CheckError::~CheckError() #7 0x56f063de9d22 base::ScopedValidateSequenceChecker::ScopedValidateSequenceChecker() #8 0x56f063de4706 base::ObserverList<>::begin() #9 0x56f06bfa75eb ui::CursorController::SetCursorLocation() #10 0x56f0646d9be5 ui::DrmCursor::SetCursorLocationLocked() #11 0x56f0646da6bf ui::DrmCursor::MoveCursor() #12 0x56f06bfd76e6 ui::GestureInterpreterLibevdevCros::OnGestureMove() Original change's description: > Mark WeakLinkNode sequence checking expensive > > This makes for-each-node sequence checking expensive (which seems > redundant). As a compromise we do non-"expensive" sequence checking in > ObserverList::begin(), which should provide the same level of protection > unless iterators are passed between sequences, which would be one heck > of a thing to try to do. > > This accounts for about 60% of sequence checking in a profile I did way > back. I have not profiled to see how much sequence checking remains with > the sequence checking moved to begin() nor do I know the average > ObserverList size. Let's try it out. > > In the same profile (though I don't remember what I profiled) sequence > checking accounted for 1.2% of cycles. Hopefully this explains some of > the performance gap between a DCHECK and regular Canary build. > > Bug: 40241607 > Change-Id: Id80d3363771e05e6f38c1432ae66b4c352acf8b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5319909 > Reviewed-by: François Degros <fdegros@chromium.org> > Commit-Queue: Peter Boström <pbos@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1277148} Bug: 40241607 Change-Id: I8e11a7d796ba10a38453dff336f46e3aba04ab97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5394849 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: François Degros <fdegros@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/main@{#1278133}

This reverts behaviour that was introduced in crrev.com/c/5353357 (cherry picked from commit d5147af) Bug: 40058879,330360331,330210939 Change-Id: I1b111b568661f806d87bedbb40e055d69a8c1e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5392481 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by: Saifuddin Hitawala <hitawala@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1277904} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5402441 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Krishna Govind <govind@chromium.org> Owners-Override: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/6379@{#12} Cr-Branched-From: e5b4774-refs/heads/main@{#1277564}

While investigating a black stripe that appears on the right border of a lacros window while it is been resized horizontally from the opposite border (left), it was figured that depending on the values of the window `origin`, `size` and `scale factor`, the black line was appearing or hidden. A continuous interactive window resize is the perfect scenario to replicate the bug intermittently, and give users the impression of a flashing black line. As an easy way to illustrate the issue, lets assume a lacros window with the following bounds in DIPS, `330,0 596x664`, and a device scale factor of `1.62574` - these values can replicate the problem of the vertical stripe appearing even without triggering a window resize. For instance, this bounds in DIPS becomes `536,0 970x1080` in pixels using DesktopWindowTreeHostPlatform::ConvertRectToPixels(). 1.1) During the window creation, the `ui::Compositor` instance gets its scale factor and size set in pixels. It happens when `Compositor::SetScaleAndSize()` is called. This is the stracktrace: ```` #1 0x592718b9d713 base::debug::StackTrace::StackTrace() #2 0x5927205f4655 ui::Compositor::SetScaleAndSize() #3 0x5927205eac3e aura::WindowTreeHost::UpdateCompositorScaleAndSize() #4 0x5927205ec714 aura::WindowTreeHost::OnHostResizedInPixels() #5 0x592721d2dc2e aura::WindowTreeHostPlatform::OnBoundsChanged() #6 0x592721d2cc40 views::DesktopWindowTreeHostLacros::OnBoundsChanged() #7 0x592721d2e1b9 aura::WindowTreeHostPlatform::OnStateUpdate() #8 0x592719b83731 ui::WaylandWindow::MaybeApplyLatestStateRequest() #9 0x592719b83074 ui::WaylandWindow::RequestState() #10 0x592719b7e189 ui::WaylandWindow::SetWindowScale() #11 0x592719b7d985 ui::WaylandWindow::UpdateWindowScale() #12 0x592719b789ad ui::WaylandToplevelWindow::UpdateWindowScale() #13 0x592719b77f15 ui::WaylandToplevelWindow::Show() #14 0x592721d3139d views::DesktopWindowTreeHostPlatform::Show() #15 0x592721d18b24 views::DesktopNativeWidgetAura::Show() #16 0x592721cd0a7c views::Widget::Show() #17 0x592724d06ffb BrowserView::Show() (...) ```` In practice, `aura::WindowTreeHostPlatform::OnBoundsChanged()` (frame #4) calls out to `WaylandWindow::GetBoundsInPixels()`, that translates `330,0 596x664` in DIPS to `536,0 970x1080` in pixels - see the method below. Ultimately, only the size is set to the ui::Compositor instance, ie `970x1080`. ```` void WindowTreeHostPlatform::OnBoundsChanged(const BoundsChange& change) { (...) float current_scale = compositor()->device_scale_factor(); float new_scale = ui::GetScaleFactorForNativeView(window()); auto weak_ref = GetWeakPtr(); auto new_size = GetBoundsInPixels().size(); <------ ````` 1.2) Meanwhile, `cc::Layer` instances for the window are also being created. During the layer tree creation, the layers' bounds are all set in DIPs. For instance, the root layer is created with an origin of `0,0` and bounds `596x664`, eg: ```` 2024-03-11T18:42:45.387311Z WARNING chrome[29500:29500]: [layer.cc(390)] #0 0x59271e998ce2 base::debug::CollectStackTrace() #1 0x592718b9d713 base::debug::StackTrace::StackTrace() #2 0x592725cc29d7 cc::Layer::SetBounds() #3 0x592725e2ee96 ui::Layer::SetBoundsFromAnimation() #4 0x5927265c0177 ui::LayerAnimator::SetBounds() #5 0x5927205d8fe0 aura::Window::SetBoundsInternal() #6 0x5927205d8f67 aura::Window::SetBounds() #7 0x5927205ea78e aura::WindowTreeHost::UpdateRootWindowSize() #8 0x5927205ea6df aura::WindowTreeHost::InitHost() #9 0x592721d30b36 views::DesktopWindowTreeHostPlatform::Init() #10 0x592721d16336 views::DesktopNativeWidgetAura::InitNativeWidget() #11 0x592725142c44 DesktopBrowserFrameAura::InitNativeWidget() #12 0x592721ccdd41 views::Widget::Init() #13 0x592724cf68af BrowserFrame::InitBrowserFrame() #14 0x592724db9f30 BrowserWindow::CreateBrowserWindow() #15 0x592724951ce0 Browser::Browser() #16 0x5927249511c6 Browser::Create() (...) ```` The layers' bounds get translated at places like `draw_property_utils.cc` `ComputeLocalRectInTargetSpace()`, with MathUtils::MapXXX() functions. In practice, `596x664` translates to `968.942x1079.49`, and finally gets rounded to `969x1080`. Hence, we have a root ui::Compositor size of 970x1080 and a root cc:Layer bounds of 969x1080. Using the visual debugger tool attached to lacros, one can see that all window-wide tiles's width are 969 [1]. OTOH, with the visual debugger tool attached to ash/chrome, we can see that the width the the root surface (lacros) is 970 [2]. This 1px different creates a "punch role" effect in the lacros window, and user sees whatever is underneath it rendered [3]. In the case of this bug, what the user sees is a trailing 1px wide line part of the so called "resize shadow". The user sees it through this unintentionally "punch hole" explained above. This CL changes the way PlatformWindowDelegate::State::size_px variable gets set in WaylandWindow::RequestState(), translating only its size from DIPs to pixels. This way we match how this variable is used in ui::Compositor level and cc::Layers et al (tiles, quads, overlayers, etc). As a way to illustrate the problem, see video [4]. It forcibly paints the 1px lacros root layer transparent buffer red with viz_debugger, so one can clearly see it "flashing" due to the rounding error being fixed here. [1] https://issues.chromium.org/u/0/action/issues/40876438/attachments/54873934 [2] https://issues.chromium.org/u/0/action/issues/40876438/attachments/54878944 [3] https://issues.chromium.org/u/0/action/issues/40876438/attachments/54873933 [4] https://issues.chromium.org/action/issues/40876438/attachments/54936907 Bug: 40876438 Change-Id: Id36476d41e7a2c90f8a44337731a4cfad93e6a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5384752 Reviewed-by: Maksim Sisov <msisov@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/main@{#1281135}

This reverts commit fe5ffc2. Reason for revert: Reland with CursorController changed to use std::vector too. Original change's description: > Revert "Mark WeakLinkNode sequence checking expensive" > > This reverts commit 6f447d5. > > Reason for revert: Crashes on ChromeOS as soon as I touch the > device's touchpad > > 2024-03-26T00:58:16.588106Z FATAL chrome[5433:5496]: [sequence_checker.cc(21)] Check failed: checker.CalledOnValidSequence(&bound_at). > #0 0x56f06aa34da2 base::debug::CollectStackTrace() > #1 0x56f06aa19ba2 base::debug::StackTrace::StackTrace() > #2 0x56f06a934073 logging::LogMessage::Flush() > #3 0x56f063de6fcd logging::LogMessage::~LogMessage() > #4 0x56f06a92053c logging::(anonymous namespace)::DCheckLogMessage::~DCheckLogMessage() > #5 0x56f06a9205ae logging::(anonymous namespace)::DCheckLogMessage::~DCheckLogMessage() > #6 0x56f063dc2ba6 logging::CheckError::~CheckError() > #7 0x56f063de9d22 base::ScopedValidateSequenceChecker::ScopedValidateSequenceChecker() > #8 0x56f063de4706 base::ObserverList<>::begin() > #9 0x56f06bfa75eb ui::CursorController::SetCursorLocation() > #10 0x56f0646d9be5 ui::DrmCursor::SetCursorLocationLocked() > #11 0x56f0646da6bf ui::DrmCursor::MoveCursor() > #12 0x56f06bfd76e6 ui::GestureInterpreterLibevdevCros::OnGestureMove() > > > Original change's description: > > Mark WeakLinkNode sequence checking expensive > > > > This makes for-each-node sequence checking expensive (which seems > > redundant). As a compromise we do non-"expensive" sequence checking in > > ObserverList::begin(), which should provide the same level of protection > > unless iterators are passed between sequences, which would be one heck > > of a thing to try to do. > > > > This accounts for about 60% of sequence checking in a profile I did way > > back. I have not profiled to see how much sequence checking remains with > > the sequence checking moved to begin() nor do I know the average > > ObserverList size. Let's try it out. > > > > In the same profile (though I don't remember what I profiled) sequence > > checking accounted for 1.2% of cycles. Hopefully this explains some of > > the performance gap between a DCHECK and regular Canary build. > > > > Bug: 40241607 > > Change-Id: Id80d3363771e05e6f38c1432ae66b4c352acf8b8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5319909 > > Reviewed-by: François Degros <fdegros@chromium.org> > > Commit-Queue: Peter Boström <pbos@chromium.org> > > Reviewed-by: danakj <danakj@chromium.org> > > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > > Reviewed-by: Colin Blundell <blundell@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1277148} > > Bug: 40241607 > Change-Id: I8e11a7d796ba10a38453dff336f46e3aba04ab97 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5394849 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: François Degros <fdegros@chromium.org> > Commit-Queue: François Degros <fdegros@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1278133} Bug: 40241607 Change-Id: I7aedf2194f8cc17a56ffa79c1824e33a7072c1f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406313 Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Michael Spang <spang@chromium.org> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by: François Degros <fdegros@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/main@{#1281466}

This is part of the work to get cast on starboard building out of chromium. See go/moving-cwr-to-chromium for more information on the high-level goal. This is the crash that occurs without this CL: FATAL:event_factory_evdev.cc(247)] Check failed: user_input_task_runner_. #0 0x5643c4c23ed2 base::debug::CollectStackTrace() [../../base/debug/stack_trace_posix.cc:1039:7] #1 0x5643c4c0dc62 base::debug::StackTrace::StackTrace() [../../base/debug/stack_trace.cc:229:20] #2 0x5643c4b15369 logging::LogMessage::Flush() [../../base/logging.cc:703:29] #3 0x5643c4b1524d logging::LogMessage::~LogMessage() [../../base/logging.cc:694:3] #4 0x5643c4afb6bf logging::(anonymous namespace)::DCheckLogMessage::~DCheckLogMessage() [../../base/check.cc:166:3] #5 0x5643c4afb71e logging::(anonymous namespace)::DCheckLogMessage::~DCheckLogMessage() [../../base/check.cc:161:32] #6 0x5643c4afb173 logging::CheckError::~CheckError() [../../third_party/libc++/src/include/__memory/unique_ptr.h:67:5] #7 0x5643c611fca5 ui::EventFactoryEvdev::Init() [../../ui/events/ozone/evdev/event_factory_evdev.cc:247:3] #8 0x5643c5f275f7 ui::PlatformEventSource::AddPlatformEventDispatcher() [../../ui/events/platform/platform_event_source.cc:54:3] #9 0x5643c11edb81 ui::(anonymous namespace)::OzonePlatformCast::CreatePlatformWindow() [../../third_party/libc++/src/include/__memory/unique_ptr.h:620:30] #10 0x5643c67cf017 aura::WindowTreeHostPlatform::CreatePlatformWindow() [../../ui/aura/window_tree_host_platform.cc:222:44] #11 0x5643c67cef76 aura::WindowTreeHostPlatform::CreateAndSetPlatformWindow() [../../ui/aura/window_tree_host_platform.cc:93:22] #12 0x5643c67cef2a aura::WindowTreeHostPlatform::WindowTreeHostPlatform() [../../ui/aura/window_tree_host_platform.cc:71:3] #13 0x5643c24eb8d1 chromecast::CastWindowTreeHostAura::CastWindowTreeHostAura() [../../chromecast/graphics/cast_window_tree_host_aura.cc:17:7] #14 0x5643c24e937e chromecast::CastWindowManagerAura::Setup() [../../third_party/libc++/src/include/__memory/unique_ptr.h:620:30] #15 0x5643c24a324d chromecast::shell::CastBrowserMainParts::PreMainMessageLoopRun() [../../chromecast/browser/cast_browser_main_parts.cc:627:20] Bug: b/333571227 Change-Id: I7fd21eec0708282fc14d1b6dd578032ba06187c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5439606 Reviewed-by: Luke Halliwell <halliwell@chromium.org> Reviewed-by: Yuchen Liu <yucliu@chromium.org> Commit-Queue: Antonio Rivera <antoniori@google.com> Cr-Commit-Position: refs/heads/main@{#1285202}

This reverts commit 9b3c873. Reason for revert: https://crbug.com/335171119 Original change's description: > Filter files in the file picker for strict type conformance. > > Fixed: 41275486 > Change-Id: I77605e1b0727afdb1ba8e4c3dc54c7f3d89920b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5448139 > Reviewed-by: Leonard Grey <lgrey@chromium.org> > Auto-Submit: Avi Drissman <avi@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1286553} (cherry picked from commit ff7a1f4) Change-Id: I2d7cbe4da4f13f578441d06a1e8d329a3c89996d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5457475 Commit-Queue: Avi Drissman <avi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Leonard Grey <lgrey@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1288067} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5458778 Owners-Override: Prudhvikumar Bommana <pbommana@google.com> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/branch-heads/6422@{#12} Cr-Branched-From: 9012208-refs/heads/main@{#1287751}

This reverts commit 81b6e3d. Reason for revert: Breaks AutotestPrivateApiTest.AutotestPrivate on linux-chromeos-rel https://ci.chromium.org/ui/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel Sample failure: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-rel/75905/overview I think this is the relevant part of the stack trace: ../../content/public/test/no_renderer_crashes_assertion.cc:102: Failure Failed Unexpected termination of a renderer process; status: 3, exit_code: 139 Stack trace: #0 0x563e8b77c0da content::NoRendererCrashesAssertion::RenderProcessExited() #1 0x563e8967d8c4 content::RenderProcessHostImpl::ProcessDied() #2 0x563e8967d72c content::RenderProcessHostImpl::OnChannelError() #3 0x563e8ae3ecb5 base::TaskAnnotator::RunTaskImpl() #4 0x563e8ae583dd base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #5 0x563e8ae57e60 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #6 0x563e8ae58845 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #7 0x563e8aec2fef base::MessagePumpEpoll::Run() #8 0x563e8ae58bb2 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #9 0x563e8ae1e7fd base::RunLoop::Run() #10 0x563e91a0c6c9 extensions::ResultCatcher::GetNextResult() #11 0x563e8ad7fcf6 extensions::ExtensionApiTest::RunExtensionTest() #12 0x563e8ad7f999 extensions::ExtensionApiTest::RunExtensionTest() #13 0x563e854402ed extensions::AutotestPrivateApiTest::RunAutotestPrivateExtensionTest() Original change's description: > Get WrapperTypeInfo via ScriptWrappable > > as opposed to using a dedicated internal field for that. > > Bug: 328117814 > Change-Id: I01f9aff3ad8a41fafbd2655d23f076a0f76fdc57 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5455405 > Reviewed-by: Nate Chapin <japhet@chromium.org> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1288405} Bug: 328117814 Change-Id: Id0ad5b6bcab7a99cf31d551df00928708dd93465 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5459075 Reviewed-by: Jiacheng Guo <gjc@google.com> Auto-Submit: Timothy Loh <timloh@chromium.org> Commit-Queue: Jiacheng Guo <gjc@google.com> Owners-Override: Timothy Loh <timloh@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1288546}

This reverts commit 81b6e3d. Reason for revert: Breaks AutotestPrivateApiTest.AutotestPrivate on linux-chromeos-rel https://ci.chromium.org/ui/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel Sample failure: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-rel/75905/overview I think this is the relevant part of the stack trace: ../../content/public/test/no_renderer_crashes_assertion.cc:102: Failure Failed Unexpected termination of a renderer process; status: 3, exit_code: 139 Stack trace: #0 0x563e8b77c0da content::NoRendererCrashesAssertion::RenderProcessExited() #1 0x563e8967d8c4 content::RenderProcessHostImpl::ProcessDied() #2 0x563e8967d72c content::RenderProcessHostImpl::OnChannelError() #3 0x563e8ae3ecb5 base::TaskAnnotator::RunTaskImpl() #4 0x563e8ae583dd base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #5 0x563e8ae57e60 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #6 0x563e8ae58845 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #7 0x563e8aec2fef base::MessagePumpEpoll::Run() #8 0x563e8ae58bb2 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #9 0x563e8ae1e7fd base::RunLoop::Run() #10 0x563e91a0c6c9 extensions::ResultCatcher::GetNextResult() #11 0x563e8ad7fcf6 extensions::ExtensionApiTest::RunExtensionTest() #12 0x563e8ad7f999 extensions::ExtensionApiTest::RunExtensionTest() #13 0x563e854402ed extensions::AutotestPrivateApiTest::RunAutotestPrivateExtensionTest() Original change's description: > Get WrapperTypeInfo via ScriptWrappable > > as opposed to using a dedicated internal field for that. > > Bug: 328117814 > Change-Id: I01f9aff3ad8a41fafbd2655d23f076a0f76fdc57 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5455405 > Reviewed-by: Nate Chapin <japhet@chromium.org> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1288405} (cherry picked from commit c07cbfe) Bug: 328117814 Change-Id: Id0ad5b6bcab7a99cf31d551df00928708dd93465 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5459075 Reviewed-by: Jiacheng Guo <gjc@google.com> Auto-Submit: Timothy Loh <timloh@chromium.org> Commit-Queue: Jiacheng Guo <gjc@google.com> Owners-Override: Timothy Loh <timloh@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Original-Commit-Position: refs/heads/main@{#1288546} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5460725 Owners-Override: Srinivas Sista <srinivassista@chromium.org> Auto-Submit: Srinivas Sista <srinivassista@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6423@{#4} Cr-Branched-From: 38a6280-refs/heads/main@{#1288419}

This reverts commit c07cbfe. Reason for revert: relanding with tests and fixes Original change's description: > Revert "Get WrapperTypeInfo via ScriptWrappable" > > This reverts commit 81b6e3d. > > Reason for revert: Breaks AutotestPrivateApiTest.AutotestPrivate on linux-chromeos-rel > > https://ci.chromium.org/ui/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel > Sample failure: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-rel/75905/overview > > I think this is the relevant part of the stack trace: > > ../../content/public/test/no_renderer_crashes_assertion.cc:102: Failure > Failed > Unexpected termination of a renderer process; status: 3, exit_code: 139 > Stack trace: > #0 0x563e8b77c0da content::NoRendererCrashesAssertion::RenderProcessExited() > #1 0x563e8967d8c4 content::RenderProcessHostImpl::ProcessDied() > #2 0x563e8967d72c content::RenderProcessHostImpl::OnChannelError() > #3 0x563e8ae3ecb5 base::TaskAnnotator::RunTaskImpl() > #4 0x563e8ae583dd base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() > #5 0x563e8ae57e60 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #6 0x563e8ae58845 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #7 0x563e8aec2fef base::MessagePumpEpoll::Run() > #8 0x563e8ae58bb2 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() > #9 0x563e8ae1e7fd base::RunLoop::Run() > #10 0x563e91a0c6c9 extensions::ResultCatcher::GetNextResult() > #11 0x563e8ad7fcf6 extensions::ExtensionApiTest::RunExtensionTest() > #12 0x563e8ad7f999 extensions::ExtensionApiTest::RunExtensionTest() > #13 0x563e854402ed extensions::AutotestPrivateApiTest::RunAutotestPrivateExtensionTest() > > Original change's description: > > Get WrapperTypeInfo via ScriptWrappable > > > > as opposed to using a dedicated internal field for that. > > > > Bug: 328117814 > > Change-Id: I01f9aff3ad8a41fafbd2655d23f076a0f76fdc57 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5455405 > > Reviewed-by: Nate Chapin <japhet@chromium.org> > > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1288405} > > Bug: 328117814 > Change-Id: Id0ad5b6bcab7a99cf31d551df00928708dd93465 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5459075 > Reviewed-by: Jiacheng Guo <gjc@google.com> > Auto-Submit: Timothy Loh <timloh@chromium.org> > Commit-Queue: Jiacheng Guo <gjc@google.com> > Owners-Override: Timothy Loh <timloh@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1288546} Bug: 328117814 Change-Id: Icc69d23b24b71adc9332e3a01c91f336506c035f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5466905 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#1290020}

Example builder failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/119860/overview. crash log for renderer (pid <unknown>): STDOUT: <empty> STDERR: [840814:1:0419/092311.735189:FATAL:ax_object.cc(3129)] Check failed: !IsDetached(). STDERR: #0 0x7f57ed36492c base::debug::CollectStackTrace() [../../base/debug/stack_trace_posix.cc:1039:7] STDERR: #1 0x7f57ed316545 base::debug::StackTrace::StackTrace() [../../base/debug/stack_trace.cc:236:20] STDERR: #2 0x7f57ed3164d5 base::debug::StackTrace::StackTrace() [../../base/debug/stack_trace.cc:231:28] STDERR: #3 0x7f57ed0349bf logging::LogMessage::Flush() [../../base/logging.cc:710:29] STDERR: #4 0x7f57ed0348e7 logging::LogMessage::~LogMessage() [../../base/logging.cc:698:3] STDERR: #5 0x7f57ecfdbfc5 logging::(anonymous namespace)::DCheckLogMessage::~DCheckLogMessage() [../../base/check.cc:166:3] STDERR: #6 0x7f57ecfdbfe9 logging::(anonymous namespace)::DCheckLogMessage::~DCheckLogMessage() [../../base/check.cc:161:32] STDERR: #7 0x7f57ecfdcdcc std::__Cr::default_delete<>::operator()() [../../third_party/libc++/src/include/__memory/unique_ptr.h:67:5] STDERR: #8 0x7f57ecfdc32a std::__Cr::unique_ptr<>::reset() [../../third_party/libc++/src/include/__memory/unique_ptr.h:278:7] STDERR: #9 0x7f57ecfdb90d logging::CheckError::~CheckError() [../../base/check.cc:349:16] STDERR: #10 0x7f57bb3ae68b blink::AXObject::IsIncludedInTree() [../../third_party/blink/renderer/modules/accessibility/ax_object.cc:3129:3] STDERR: #11 0x7f57bb3a43a4 blink::AXObject::ToString() [../../third_party/blink/renderer/modules/accessibility/ax_object.cc:8108:30] STDERR: #12 0x7f57bb3a2a52 blink::AXObject::Detach() [../../third_party/blink/renderer/modules/accessibility/ax_object.cc:782:35] STDERR: #13 0x7f57bb3556e6 blink::AXNodeObject::Detach() [../../third_party/blink/renderer/modules/accessibility/ax_node_object.cc:2377:13] STDERR: #14 0x7f57bb3ec319 blink::AXObjectCacheImpl::Remove() .... Bug: 40933623 Change-Id: Ic447ade12398f7666c4f6f4def61c2e3723feb43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5466669 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Liviu Tinta <liviutinta@chromium.org> Auto-Submit: Liviu Tinta <liviutinta@chromium.org> Owners-Override: Liviu Tinta <liviutinta@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1290248}

This reverts commit 6578c4f. Reason for revert: Offending DCHECK was fixed and removed with https://crrev.com/c/5464203. Tests can probably be re-enabled. Original change's description: > [Gardener] Disable tests failing !IsDetached check > > Example builder failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/119860/overview. > > crash log for renderer (pid <unknown>): > STDOUT: <empty> > STDERR: [840814:1:0419/092311.735189:FATAL:ax_object.cc(3129)] Check failed: !IsDetached(). > STDERR: #0 0x7f57ed36492c base::debug::CollectStackTrace() [../../base/debug/stack_trace_posix.cc:1039:7] > STDERR: #1 0x7f57ed316545 base::debug::StackTrace::StackTrace() [../../base/debug/stack_trace.cc:236:20] > STDERR: #2 0x7f57ed3164d5 base::debug::StackTrace::StackTrace() [../../base/debug/stack_trace.cc:231:28] > STDERR: #3 0x7f57ed0349bf logging::LogMessage::Flush() [../../base/logging.cc:710:29] > STDERR: #4 0x7f57ed0348e7 logging::LogMessage::~LogMessage() [../../base/logging.cc:698:3] > STDERR: #5 0x7f57ecfdbfc5 logging::(anonymous namespace)::DCheckLogMessage::~DCheckLogMessage() [../../base/check.cc:166:3] > STDERR: #6 0x7f57ecfdbfe9 logging::(anonymous namespace)::DCheckLogMessage::~DCheckLogMessage() [../../base/check.cc:161:32] > STDERR: #7 0x7f57ecfdcdcc std::__Cr::default_delete<>::operator()() [../../third_party/libc++/src/include/__memory/unique_ptr.h:67:5] > STDERR: #8 0x7f57ecfdc32a std::__Cr::unique_ptr<>::reset() [../../third_party/libc++/src/include/__memory/unique_ptr.h:278:7] > STDERR: #9 0x7f57ecfdb90d logging::CheckError::~CheckError() [../../base/check.cc:349:16] > STDERR: #10 0x7f57bb3ae68b blink::AXObject::IsIncludedInTree() [../../third_party/blink/renderer/modules/accessibility/ax_object.cc:3129:3] > STDERR: #11 0x7f57bb3a43a4 blink::AXObject::ToString() [../../third_party/blink/renderer/modules/accessibility/ax_object.cc:8108:30] > STDERR: #12 0x7f57bb3a2a52 blink::AXObject::Detach() [../../third_party/blink/renderer/modules/accessibility/ax_object.cc:782:35] > STDERR: #13 0x7f57bb3556e6 blink::AXNodeObject::Detach() [../../third_party/blink/renderer/modules/accessibility/ax_node_object.cc:2377:13] > STDERR: #14 0x7f57bb3ec319 blink::AXObjectCacheImpl::Remove() > .... > > Bug: 40933623 > Change-Id: Ic447ade12398f7666c4f6f4def61c2e3723feb43 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5466669 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Liviu Tinta <liviutinta@chromium.org> > Auto-Submit: Liviu Tinta <liviutinta@chromium.org> > Owners-Override: Liviu Tinta <liviutinta@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1290248} Bug: 40933623 Change-Id: Ib77c888c8c8a1209a18ddd93f7c07d17c50a04a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5465688 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#1290555}

Change-Id: I5ac18717faceb7e7299403e16ab1342d7582edd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5512784 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6452@{#12} Cr-Branched-From: dc6e5f1-refs/heads/main@{#1294836}

Roll src/v8 from c6b8b43c3042 to 81c2d9b9b7db Commits rolled: https://chromium.googlesource.com/v8/v8.git/+log/c6b8b43c3042..81c2d9b9b7db Generated by: http://go/bbid/8748318134432839409 Change-Id: Ic16cacb3f87f2816e14289132d5906b814ba974e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526819 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6367_159@{#12} Cr-Branched-From: 5016b4f-refs/branch-heads/6367@{#1101} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}

Correction Inconsistent German translation of Clipboard Read Access c…

725eccd

…hoices Bug: 905327

aarongable closed this May 28, 2019

fujunwei referenced this pull request in otcshare/chromium-src Sep 24, 2019

Merge pull request #12 from sunlin-link/webml2

9a86dfe

Break function execution when DOM exception is thrown

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Correction Inconsistent German translation of Clipboard Read Access c… #12

Correction Inconsistent German translation of Clipboard Read Access c… #12

oussama789 commented Dec 10, 2018

Correction Inconsistent German translation of Clipboard Read Access c… #12

Correction Inconsistent German translation of Clipboard Read Access c… #12

Conversation

oussama789 commented Dec 10, 2018