updated some strings for taste #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
freespeech4ever
pushed a commit
to freespeech4ever/chromium
that referenced
this pull request
Feb 23, 2020
This table contains field identifiers and autofill types that corresponds that were leaned from user actions. In the subsequent CLs this will be used for storing information whether particular form is username form for username first flow. TBR=dvadym@chromium.org (cherry picked from commit 5e0db9f) Bug: 959776 Change-Id: If13482fa719638f6552f0e942a65c4731cccf3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865150 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#706923} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872068 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/branch-heads/3945@{chromium#43} Cr-Branched-From: e4635ff-refs/heads/master@{#706915}
pdigennaro
pushed a commit
to washezium/washezium
that referenced
this pull request
Feb 29, 2020
(cherry picked from commit 404f632) Bug: 1029066, 1019469 Change-Id: Ib9379b4b9db880a87b0b66ffa7e6473a3dc05a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953575 Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#722475} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960513 Reviewed-by: James Robinson <jamesr@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: James Robinson <jamesr@chromium.org> Cr-Commit-Position: refs/branch-heads/3987@{chromium#43} Cr-Branched-From: c4e8da9-refs/heads/master@{#722274}
blueboxd
referenced
this pull request
in blueboxd/chromium-legacy
Mar 11, 2020
This reverts commit 64465df. Reason for revert: Speculative revert to fix use-of-uninitialized member flake / crash; see https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8886180914914709040/+/steps/browser_tests/0/logs/Deterministic_failure:_PublicSessionOobeTestImpl__x2f_PublicSessionOobeTest.NoTermsOfService__x2f_4__status_CRASH_/0 ==18002==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x5640af44e1e6 in ui::AnimationMetricsRecorder::OnAnimationEnd(base::Optional<int>, float) ./../../ui/compositor/animation_metrics_recorder.cc:64:14 #1 0x5640af4e4b37 in ui::LayerAnimationElement::ProgressToEnd(ui::LayerAnimationDelegate*) ./../../ui/compositor/layer_animation_element.cc:669:34 #2 0x5640af4fbb95 in ui::LayerAnimationSequence::ProgressToEnd(ui::LayerAnimationDelegate*) ./../../ui/compositor/layer_animation_sequence.cc:147:35 #3 0x5640af513c54 in ProgressAnimationToEnd ./../../ui/compositor/layer_animator.cc:476:13 #4 0x5640af513c54 in ui::LayerAnimator::FinishAnimation(ui::LayerAnimationSequence*, bool) ./../../ui/compositor/layer_animator.cc:622:5 #5 0x5640af519c6d in ui::LayerAnimator::StopAnimatingInternal(bool) ./../../ui/compositor/layer_animator.cc:533:5 #6 0x5640af489c93 in StopAnimating ./../../ui/compositor/layer_animator.h:198:26 #7 0x5640af489c93 in ui::Layer::CompleteAllAnimations() ./../../ui/compositor/layer.cc:1128:12 #8 0x5640af3c6ff1 in aura::Window::~Window() ./../../ui/aura/window.cc:124:14 #9 0x5640af3ca7ac in aura::Window::~Window() ./../../ui/aura/window.cc:119:19 #10 0x5640a9a51655 in views::NativeWidgetAura::~NativeWidgetAura() ./../../ui/views/widget/native_widget_aura.cc:0:0 #11 0x5640a9a51b9c in views::NativeWidgetAura::~NativeWidgetAura() ./../../ui/views/widget/native_widget_aura.cc:1054:39 #12 0x5640a99ba714 in views::Widget::~Widget() ./../../ui/views/widget/widget.cc:185:5 #13 0x5640b72c7e39 in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:354:1 #14 0x5640b72c7f9c in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:350:33 #15 0x5640b7319b53 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 #16 0x5640b7319b53 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 #17 0x5640b7319b53 in ash::Shelf::ShutdownShelfWidget() ./../../ash/shelf/shelf.cc:377:19 #18 0x5640b724c95f in ash::RootWindowController::CloseChildWindows() ./../../ash/root_window_controller.cc:659:11 #19 0x5640b741f9c5 in ash::Shell::CloseAllRootWindowChildWindows() ./../../ash/shell.cc:1269:19 #20 0x5640b741532a in ash::Shell::~Shell() ./../../ash/shell.cc:720:3 #21 0x5640b741fd3c in ash::Shell::~Shell() ./../../ash/shell.cc:589:17 #22 0x5640b9be4d75 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 #23 0x5640b9be4d75 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 #24 0x5640b9be4d75 in ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() ./../../chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc:245:19 #25 0x5640a5abe85d in ChromeBrowserMainParts::PostMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1721:29 #26 0x564094a9d525 in chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:1136:32 #27 0x56409b175e3f in content::BrowserMainLoop::ShutdownThreadsAndCleanUp() ./../../content/browser/browser_main_loop.cc:1095:13 #28 0x56409b17ea9a in content::BrowserMainRunnerImpl::Shutdown() ./../../content/browser/browser_main_runner_impl.cc:178:17 #29 0x56409b165bd4 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:49:16 #30 0x5640a3b3284b in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:529:10 #31 0x5640a3b3284b in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:978:10 #32 0x5640a3b311b2 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:878:12 #33 0x5640b1028f28 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:455:29 #34 0x56409f705fd0 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 #35 0x5640a762696a in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:513:3 chromium#36 0x5640a53fb49d in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:299:20 #37 0x5640960c6b50 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #38 0x5640960c6b50 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2663:3 chromium#39 0x5640960cb24d in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2845:11 #40 0x5640960cd5f9 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2977:28 #41 0x564096106f6e in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5518:44 chromium#42 0x5640961053fd in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10 #43 0x5640961053fd in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5105:10 #44 0x5640a5902835 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2472:46 #45 0x5640a5902835 in base::TestSuite::Run() ./../../base/test/test_suite.cc:458:16 #46 0x5640a5393dd1 in BrowserTestSuiteRunnerChromeOS::RunTestSuite(int, char**) ./../../chrome/test/base/browser_tests_main_chromeos.cc:37:23 #47 0x5640a773a27e in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:375:31 #48 0x5640a5394f45 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:246:10 #49 0x5640a5393bb8 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:52:10 #50 0x7f194b36282f in __libc_start_main /build/glibc-LK5gWL/glibc-2.23/csu/../csu/libc-start.c:291:0 #51 0x56408b4293c9 in _start ??:0:0 Uninitialized value was created by a heap deallocation #0 0x56408b497790 in operator delete(void*) /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/msan/msan_new_delete.cpp:74:44 #1 0x5640b72c7d74 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 #2 0x5640b72c7d74 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 #3 0x5640b72c7d74 in ~unique_ptr ./../../buildtools/third_party/libc++/trunk/include/memory:2587:19 #4 0x5640b72c7d74 in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:354:1 #5 0x5640b72c7f9c in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:350:33 #6 0x5640b7319b53 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 #7 0x5640b7319b53 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 #8 0x5640b7319b53 in ash::Shelf::ShutdownShelfWidget() ./../../ash/shelf/shelf.cc:377:19 #9 0x5640b724c95f in ash::RootWindowController::CloseChildWindows() ./../../ash/root_window_controller.cc:659:11 #10 0x5640b741f9c5 in ash::Shell::CloseAllRootWindowChildWindows() ./../../ash/shell.cc:1269:19 #11 0x5640b741532a in ash::Shell::~Shell() ./../../ash/shell.cc:720:3 #12 0x5640b741fd3c in ash::Shell::~Shell() ./../../ash/shell.cc:589:17 #13 0x5640b9be4d75 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 #14 0x5640b9be4d75 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 #15 0x5640b9be4d75 in ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() ./../../chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc:245:19 #16 0x5640a5abe85d in ChromeBrowserMainParts::PostMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1721:29 #17 0x564094a9d525 in chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:1136:32 #18 0x56409b175e3f in content::BrowserMainLoop::ShutdownThreadsAndCleanUp() ./../../content/browser/browser_main_loop.cc:1095:13 #19 0x56409b17ea9a in content::BrowserMainRunnerImpl::Shutdown() ./../../content/browser/browser_main_runner_impl.cc:178:17 #20 0x56409b165bd4 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:49:16 #21 0x5640a3b3284b in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:529:10 #22 0x5640a3b3284b in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:978:10 #23 0x5640a3b311b2 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:878:12 #24 0x5640b1028f28 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:455:29 #25 0x56409f705fd0 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 #26 0x5640a762696a in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:513:3 #27 0x5640a53fb49d in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:299:20 Original change's description: > Cros: Report metrics for the animation of traslucent background > > This animation happens during transition between hotseat states. > > Bug: 1058609 > Change-Id: Iff1f81625e6de2bf6dc6dcfee09225c4d16cc53e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088641 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Manu Cornet <manucornet@chromium.org> > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Commit-Queue: Ana Salazar <anasalazar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748806} TBR=rkaplow@chromium.org,newcomer@chromium.org,manucornet@chromium.org,anasalazar@chromium.org Change-Id: I28dfaa49cae6e27801975a2863c013b9f9a5edca No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1058609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097507 Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#749146}
blueboxd
referenced
this pull request
in blueboxd/chromium-legacy
Mar 11, 2020
This reverts commit 9fcd754. Reason for revert: breaks compile (bad merge) Original change's description: > Revert "Cros: Report metrics for the animation of traslucent background" > > This reverts commit 64465df. > > Reason for revert: Speculative revert to fix use-of-uninitialized member flake / crash; see https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8886180914914709040/+/steps/browser_tests/0/logs/Deterministic_failure:_PublicSessionOobeTestImpl__x2f_PublicSessionOobeTest.NoTermsOfService__x2f_4__status_CRASH_/0 > > ==18002==WARNING: MemorySanitizer: use-of-uninitialized-value > #0 0x5640af44e1e6 in ui::AnimationMetricsRecorder::OnAnimationEnd(base::Optional<int>, float) ./../../ui/compositor/animation_metrics_recorder.cc:64:14 > #1 0x5640af4e4b37 in ui::LayerAnimationElement::ProgressToEnd(ui::LayerAnimationDelegate*) ./../../ui/compositor/layer_animation_element.cc:669:34 > #2 0x5640af4fbb95 in ui::LayerAnimationSequence::ProgressToEnd(ui::LayerAnimationDelegate*) ./../../ui/compositor/layer_animation_sequence.cc:147:35 > #3 0x5640af513c54 in ProgressAnimationToEnd ./../../ui/compositor/layer_animator.cc:476:13 > #4 0x5640af513c54 in ui::LayerAnimator::FinishAnimation(ui::LayerAnimationSequence*, bool) ./../../ui/compositor/layer_animator.cc:622:5 > #5 0x5640af519c6d in ui::LayerAnimator::StopAnimatingInternal(bool) ./../../ui/compositor/layer_animator.cc:533:5 > #6 0x5640af489c93 in StopAnimating ./../../ui/compositor/layer_animator.h:198:26 > #7 0x5640af489c93 in ui::Layer::CompleteAllAnimations() ./../../ui/compositor/layer.cc:1128:12 > #8 0x5640af3c6ff1 in aura::Window::~Window() ./../../ui/aura/window.cc:124:14 > #9 0x5640af3ca7ac in aura::Window::~Window() ./../../ui/aura/window.cc:119:19 > #10 0x5640a9a51655 in views::NativeWidgetAura::~NativeWidgetAura() ./../../ui/views/widget/native_widget_aura.cc:0:0 > #11 0x5640a9a51b9c in views::NativeWidgetAura::~NativeWidgetAura() ./../../ui/views/widget/native_widget_aura.cc:1054:39 > #12 0x5640a99ba714 in views::Widget::~Widget() ./../../ui/views/widget/widget.cc:185:5 > #13 0x5640b72c7e39 in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:354:1 > #14 0x5640b72c7f9c in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:350:33 > #15 0x5640b7319b53 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 > #16 0x5640b7319b53 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 > #17 0x5640b7319b53 in ash::Shelf::ShutdownShelfWidget() ./../../ash/shelf/shelf.cc:377:19 > #18 0x5640b724c95f in ash::RootWindowController::CloseChildWindows() ./../../ash/root_window_controller.cc:659:11 > #19 0x5640b741f9c5 in ash::Shell::CloseAllRootWindowChildWindows() ./../../ash/shell.cc:1269:19 > #20 0x5640b741532a in ash::Shell::~Shell() ./../../ash/shell.cc:720:3 > #21 0x5640b741fd3c in ash::Shell::~Shell() ./../../ash/shell.cc:589:17 > #22 0x5640b9be4d75 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 > #23 0x5640b9be4d75 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 > #24 0x5640b9be4d75 in ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() ./../../chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc:245:19 > #25 0x5640a5abe85d in ChromeBrowserMainParts::PostMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1721:29 > #26 0x564094a9d525 in chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:1136:32 > #27 0x56409b175e3f in content::BrowserMainLoop::ShutdownThreadsAndCleanUp() ./../../content/browser/browser_main_loop.cc:1095:13 > #28 0x56409b17ea9a in content::BrowserMainRunnerImpl::Shutdown() ./../../content/browser/browser_main_runner_impl.cc:178:17 > #29 0x56409b165bd4 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:49:16 > #30 0x5640a3b3284b in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:529:10 > #31 0x5640a3b3284b in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:978:10 > #32 0x5640a3b311b2 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:878:12 > #33 0x5640b1028f28 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:455:29 > #34 0x56409f705fd0 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 > #35 0x5640a762696a in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:513:3 > chromium#36 0x5640a53fb49d in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:299:20 > #37 0x5640960c6b50 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 > #38 0x5640960c6b50 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2663:3 > chromium#39 0x5640960cb24d in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2845:11 > #40 0x5640960cd5f9 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2977:28 > #41 0x564096106f6e in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5518:44 > chromium#42 0x5640961053fd in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10 > #43 0x5640961053fd in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5105:10 > #44 0x5640a5902835 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2472:46 > #45 0x5640a5902835 in base::TestSuite::Run() ./../../base/test/test_suite.cc:458:16 > #46 0x5640a5393dd1 in BrowserTestSuiteRunnerChromeOS::RunTestSuite(int, char**) ./../../chrome/test/base/browser_tests_main_chromeos.cc:37:23 > #47 0x5640a773a27e in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:375:31 > #48 0x5640a5394f45 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:246:10 > #49 0x5640a5393bb8 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:52:10 > #50 0x7f194b36282f in __libc_start_main /build/glibc-LK5gWL/glibc-2.23/csu/../csu/libc-start.c:291:0 > #51 0x56408b4293c9 in _start ??:0:0 > > Uninitialized value was created by a heap deallocation > #0 0x56408b497790 in operator delete(void*) /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/msan/msan_new_delete.cpp:74:44 > #1 0x5640b72c7d74 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 > #2 0x5640b72c7d74 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 > #3 0x5640b72c7d74 in ~unique_ptr ./../../buildtools/third_party/libc++/trunk/include/memory:2587:19 > #4 0x5640b72c7d74 in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:354:1 > #5 0x5640b72c7f9c in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:350:33 > #6 0x5640b7319b53 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 > #7 0x5640b7319b53 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 > #8 0x5640b7319b53 in ash::Shelf::ShutdownShelfWidget() ./../../ash/shelf/shelf.cc:377:19 > #9 0x5640b724c95f in ash::RootWindowController::CloseChildWindows() ./../../ash/root_window_controller.cc:659:11 > #10 0x5640b741f9c5 in ash::Shell::CloseAllRootWindowChildWindows() ./../../ash/shell.cc:1269:19 > #11 0x5640b741532a in ash::Shell::~Shell() ./../../ash/shell.cc:720:3 > #12 0x5640b741fd3c in ash::Shell::~Shell() ./../../ash/shell.cc:589:17 > #13 0x5640b9be4d75 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 > #14 0x5640b9be4d75 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 > #15 0x5640b9be4d75 in ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() ./../../chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc:245:19 > #16 0x5640a5abe85d in ChromeBrowserMainParts::PostMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1721:29 > #17 0x564094a9d525 in chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:1136:32 > #18 0x56409b175e3f in content::BrowserMainLoop::ShutdownThreadsAndCleanUp() ./../../content/browser/browser_main_loop.cc:1095:13 > #19 0x56409b17ea9a in content::BrowserMainRunnerImpl::Shutdown() ./../../content/browser/browser_main_runner_impl.cc:178:17 > #20 0x56409b165bd4 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:49:16 > #21 0x5640a3b3284b in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:529:10 > #22 0x5640a3b3284b in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:978:10 > #23 0x5640a3b311b2 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:878:12 > #24 0x5640b1028f28 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:455:29 > #25 0x56409f705fd0 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 > #26 0x5640a762696a in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:513:3 > #27 0x5640a53fb49d in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:299:20 > > Original change's description: > > Cros: Report metrics for the animation of traslucent background > > > > This animation happens during transition between hotseat states. > > > > Bug: 1058609 > > Change-Id: Iff1f81625e6de2bf6dc6dcfee09225c4d16cc53e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088641 > > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > > Reviewed-by: Manu Cornet <manucornet@chromium.org> > > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > > Commit-Queue: Ana Salazar <anasalazar@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#748806} > > TBR=rkaplow@chromium.org,newcomer@chromium.org,manucornet@chromium.org,anasalazar@chromium.org > > Change-Id: I28dfaa49cae6e27801975a2863c013b9f9a5edca > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1058609 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097507 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749146} TBR=rkaplow@chromium.org,waffles@chromium.org,newcomer@chromium.org,manucornet@chromium.org,anasalazar@chromium.org Change-Id: I9eb448a6d4ea88624c9535a30cdfa519fc431d50 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1058609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097508 Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#749151}
blueboxd
referenced
this pull request
in blueboxd/chromium-legacy
Mar 11, 2020
…background"" This is a reland of 9fcd754 Original change's description: > Revert "Cros: Report metrics for the animation of traslucent background" > > This reverts commit 64465df. > > Reason for revert: Speculative revert to fix use-of-uninitialized member flake / crash; see https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8886180914914709040/+/steps/browser_tests/0/logs/Deterministic_failure:_PublicSessionOobeTestImpl__x2f_PublicSessionOobeTest.NoTermsOfService__x2f_4__status_CRASH_/0 > > ==18002==WARNING: MemorySanitizer: use-of-uninitialized-value > #0 0x5640af44e1e6 in ui::AnimationMetricsRecorder::OnAnimationEnd(base::Optional<int>, float) ./../../ui/compositor/animation_metrics_recorder.cc:64:14 > #1 0x5640af4e4b37 in ui::LayerAnimationElement::ProgressToEnd(ui::LayerAnimationDelegate*) ./../../ui/compositor/layer_animation_element.cc:669:34 > #2 0x5640af4fbb95 in ui::LayerAnimationSequence::ProgressToEnd(ui::LayerAnimationDelegate*) ./../../ui/compositor/layer_animation_sequence.cc:147:35 > #3 0x5640af513c54 in ProgressAnimationToEnd ./../../ui/compositor/layer_animator.cc:476:13 > #4 0x5640af513c54 in ui::LayerAnimator::FinishAnimation(ui::LayerAnimationSequence*, bool) ./../../ui/compositor/layer_animator.cc:622:5 > #5 0x5640af519c6d in ui::LayerAnimator::StopAnimatingInternal(bool) ./../../ui/compositor/layer_animator.cc:533:5 > #6 0x5640af489c93 in StopAnimating ./../../ui/compositor/layer_animator.h:198:26 > #7 0x5640af489c93 in ui::Layer::CompleteAllAnimations() ./../../ui/compositor/layer.cc:1128:12 > #8 0x5640af3c6ff1 in aura::Window::~Window() ./../../ui/aura/window.cc:124:14 > #9 0x5640af3ca7ac in aura::Window::~Window() ./../../ui/aura/window.cc:119:19 > #10 0x5640a9a51655 in views::NativeWidgetAura::~NativeWidgetAura() ./../../ui/views/widget/native_widget_aura.cc:0:0 > #11 0x5640a9a51b9c in views::NativeWidgetAura::~NativeWidgetAura() ./../../ui/views/widget/native_widget_aura.cc:1054:39 > #12 0x5640a99ba714 in views::Widget::~Widget() ./../../ui/views/widget/widget.cc:185:5 > #13 0x5640b72c7e39 in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:354:1 > #14 0x5640b72c7f9c in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:350:33 > #15 0x5640b7319b53 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 > #16 0x5640b7319b53 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 > #17 0x5640b7319b53 in ash::Shelf::ShutdownShelfWidget() ./../../ash/shelf/shelf.cc:377:19 > #18 0x5640b724c95f in ash::RootWindowController::CloseChildWindows() ./../../ash/root_window_controller.cc:659:11 > #19 0x5640b741f9c5 in ash::Shell::CloseAllRootWindowChildWindows() ./../../ash/shell.cc:1269:19 > #20 0x5640b741532a in ash::Shell::~Shell() ./../../ash/shell.cc:720:3 > #21 0x5640b741fd3c in ash::Shell::~Shell() ./../../ash/shell.cc:589:17 > #22 0x5640b9be4d75 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 > #23 0x5640b9be4d75 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 > #24 0x5640b9be4d75 in ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() ./../../chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc:245:19 > #25 0x5640a5abe85d in ChromeBrowserMainParts::PostMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1721:29 > #26 0x564094a9d525 in chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:1136:32 > #27 0x56409b175e3f in content::BrowserMainLoop::ShutdownThreadsAndCleanUp() ./../../content/browser/browser_main_loop.cc:1095:13 > #28 0x56409b17ea9a in content::BrowserMainRunnerImpl::Shutdown() ./../../content/browser/browser_main_runner_impl.cc:178:17 > #29 0x56409b165bd4 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:49:16 > #30 0x5640a3b3284b in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:529:10 > #31 0x5640a3b3284b in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:978:10 > #32 0x5640a3b311b2 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:878:12 > #33 0x5640b1028f28 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:455:29 > #34 0x56409f705fd0 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 > #35 0x5640a762696a in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:513:3 > chromium#36 0x5640a53fb49d in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:299:20 > #37 0x5640960c6b50 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 > #38 0x5640960c6b50 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2663:3 > chromium#39 0x5640960cb24d in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2845:11 > #40 0x5640960cd5f9 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2977:28 > #41 0x564096106f6e in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5518:44 > chromium#42 0x5640961053fd in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10 > #43 0x5640961053fd in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5105:10 > #44 0x5640a5902835 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2472:46 > #45 0x5640a5902835 in base::TestSuite::Run() ./../../base/test/test_suite.cc:458:16 > #46 0x5640a5393dd1 in BrowserTestSuiteRunnerChromeOS::RunTestSuite(int, char**) ./../../chrome/test/base/browser_tests_main_chromeos.cc:37:23 > #47 0x5640a773a27e in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:375:31 > #48 0x5640a5394f45 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:246:10 > #49 0x5640a5393bb8 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:52:10 > #50 0x7f194b36282f in __libc_start_main /build/glibc-LK5gWL/glibc-2.23/csu/../csu/libc-start.c:291:0 > #51 0x56408b4293c9 in _start ??:0:0 > > Uninitialized value was created by a heap deallocation > #0 0x56408b497790 in operator delete(void*) /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/msan/msan_new_delete.cpp:74:44 > #1 0x5640b72c7d74 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 > #2 0x5640b72c7d74 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 > #3 0x5640b72c7d74 in ~unique_ptr ./../../buildtools/third_party/libc++/trunk/include/memory:2587:19 > #4 0x5640b72c7d74 in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:354:1 > #5 0x5640b72c7f9c in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:350:33 > #6 0x5640b7319b53 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 > #7 0x5640b7319b53 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 > #8 0x5640b7319b53 in ash::Shelf::ShutdownShelfWidget() ./../../ash/shelf/shelf.cc:377:19 > #9 0x5640b724c95f in ash::RootWindowController::CloseChildWindows() ./../../ash/root_window_controller.cc:659:11 > #10 0x5640b741f9c5 in ash::Shell::CloseAllRootWindowChildWindows() ./../../ash/shell.cc:1269:19 > #11 0x5640b741532a in ash::Shell::~Shell() ./../../ash/shell.cc:720:3 > #12 0x5640b741fd3c in ash::Shell::~Shell() ./../../ash/shell.cc:589:17 > #13 0x5640b9be4d75 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 > #14 0x5640b9be4d75 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 > #15 0x5640b9be4d75 in ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() ./../../chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc:245:19 > #16 0x5640a5abe85d in ChromeBrowserMainParts::PostMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1721:29 > #17 0x564094a9d525 in chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:1136:32 > #18 0x56409b175e3f in content::BrowserMainLoop::ShutdownThreadsAndCleanUp() ./../../content/browser/browser_main_loop.cc:1095:13 > #19 0x56409b17ea9a in content::BrowserMainRunnerImpl::Shutdown() ./../../content/browser/browser_main_runner_impl.cc:178:17 > #20 0x56409b165bd4 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:49:16 > #21 0x5640a3b3284b in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:529:10 > #22 0x5640a3b3284b in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:978:10 > #23 0x5640a3b311b2 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:878:12 > #24 0x5640b1028f28 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:455:29 > #25 0x56409f705fd0 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 > #26 0x5640a762696a in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:513:3 > #27 0x5640a53fb49d in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:299:20 > > Original change's description: > > Cros: Report metrics for the animation of traslucent background > > > > This animation happens during transition between hotseat states. > > > > Bug: 1058609 > > Change-Id: Iff1f81625e6de2bf6dc6dcfee09225c4d16cc53e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088641 > > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > > Reviewed-by: Manu Cornet <manucornet@chromium.org> > > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > > Commit-Queue: Ana Salazar <anasalazar@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#748806} > > TBR=rkaplow@chromium.org,newcomer@chromium.org,manucornet@chromium.org,anasalazar@chromium.org > > Change-Id: I28dfaa49cae6e27801975a2863c013b9f9a5edca > Bug: 1058609 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097507 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749146} TBR=rkaplow@chromium.org,newcomer@chromium.org,manucornet@chromium.org,anasalazar@chromium.org Bug: 1058609 Change-Id: Id247b5b669d149031543336702585c6e2bbccd50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097509 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#749239}
blueboxd
referenced
this pull request
in blueboxd/chromium-legacy
Mar 31, 2020
Fixed by adding a WeakPtrFactory to SpeechMonitor so all posted task callbacks don't run if we destroy SpeechMonitor previously.
Failure in asan:
READ of size 8 at 0x7f8dc614c068 thread T0 (browser_tests)
#0 0x559e511d3be4 in time_since_epoch ./../../buildtools/third_party/libc++/trunk/include/chrono:1383:103
#1 0x559e511d3be4 in operator-<std::__1::chrono::steady_clock, std::__1::chrono::duration<long long, std::__1::ratio<1, 1000000000> >, std::__1::chrono::duration<long long, std::__1::ratio<1, 1000000000> > > ./../../buildtools/third_party/libc++/trunk/include/chrono:1564:45
#2 0x559e511d3be4 in CalculateUtteranceDelayMS ./../../chrome/browser/chromeos/accessibility/speech_monitor.cc:93:15
#3 0x559e511d3be4 in chromeos::SpeechMonitor::MaybePrintExpectations() ./../../chrome/browser/chromeos/accessibility/speech_monitor.cc:230:7
#4 0x559e5edf6c45 in Run ./../../base/callback.h:98:12
#5 0x559e5edf6c45 in base::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/task/common/task_annotator.cc:142:33
#6 0x559e5ee2dfe8 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*, bool*) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:324:23
#7 0x559e5ee2d93a in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoSomeWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:248:7
#8 0x559e5ef7c9d6 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:208:55
#9 0x559e5ee2f188 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:429:12
#10 0x559e5eda978d in base::RunLoop::Run() ./../../base/run_loop.cc:124:14
#11 0x559e5ecac5eb in RunUntilBrowserProcessQuits ./../../chrome/test/base/in_process_browser_test.cc:362:38
#12 0x559e5ecac5eb in InProcessBrowserTest::QuitBrowsers() ./../../chrome/test/base/in_process_browser_test.cc:584:3
#13 0x559e5ecac2f7 in InProcessBrowserTest::PostRunTestOnMainThread() ./../../chrome/test/base/in_process_browser_test.cc:559:3
#14 0x559e601dc870 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:699:3
#15 0x559e5f0c5e8f in Run ./../../base/callback.h:98:12
#16 0x559e5f0c5e8f in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1640:38
#17 0x559e5f0c3bdb in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1043:18
#18 0x559e5324fc2f in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:597:32
#19 0x559e57b9c078 in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:1020:13
#20 0x559e58ab7d34 in Run ./../../base/callback.h:98:12
#21 0x559e58ab7d34 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:29
#22 0x559e57b993a4 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:929:25
#23 0x559e57ba10ce in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) ./../../content/browser/browser_main_runner_impl.cc:129:15
#24 0x559e57b94ae5 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:43:32
#25 0x559e5d885212 in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:529:10
#26 0x559e5d885212 in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:978:10
#27 0x559e5d8844d8 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:878:12
#28 0x559e667f3da4 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:457:29
#29 0x559e5ab9eec2 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10
#30 0x559e601da293 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:513:3
#31 0x559e5eca7ca9 in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:303:20
#32 0x559e5220cb97 in HotseatShelfAppBrowserTest::SetUp() ./../../chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc:2274:26
#33 0x559e540b8f08 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
#34 0x559e540b8f08 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2663:3
#35 0x559e540bb736 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2845:11
chromium#36 0x559e540bcc76 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2977:28
#37 0x559e540e3716 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5518:44
#38 0x559e540e23f3 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
chromium#39 0x559e540e23f3 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5105:10
#40 0x559e5efb6539 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2472:46
#41 0x559e5efb6539 in base::TestSuite::Run() ./../../base/test/test_suite.cc:458:16
chromium#42 0x559e5ec63f38 in BrowserTestSuiteRunnerChromeOS::RunTestSuite(int, char**) ./../../chrome/test/base/browser_tests_main_chromeos.cc:37:23
#43 0x559e6029ce29 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:375:31
#44 0x559e5ec651cb in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:247:10
#45 0x559e5ec63d69 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:52:10
#46 0x7f8dc93aabba in __libc_start_main /build/glibc-QG9qOO/glibc-2.29/csu/../csu/libc-start.c:308:16
Address 0x7f8dc614c068 is located in stack of thread T0 (browser_tests) at offset 104 in frame
#0 0x559e625d8a0f in base::circular_deque<mojo::Message>::DestructRange(unsigned long, unsigned long) ./../../base/containers/circular_deque.h:998:0
Original change
https://chromium-review.googlesource.com/c/chromium/src/+/2124701
TBR=nancylingwang@chromium.org, dmazzoni@chromium.org
Fixed: 1065746
Test: ran tests against asan, debug, and release
Change-Id: Ie3b245933969ffe182962e017515e4cf656ef05b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128027
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754701}
pdigennaro
pushed a commit
to washezium/washezium
that referenced
this pull request
May 3, 2020
The crash is because DirectRenderer schedules a primary plane as overlay, however the previous submitted frame has been released due to reshaping. To fix it, we need to make sure to redraw the whole frame if reshape is requested. (cherry picked from commit 8cccbcd) Bug: 1044678,1048149 Change-Id: Id978fbce86a6481e976828ccea51abf883ac642f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030627 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#737895} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037831 Reviewed-by: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/branch-heads/4044@{chromium#43} Cr-Branched-From: a6d9daf-refs/heads/master@{#737173}
blueboxd
referenced
this pull request
in blueboxd/chromium-legacy
May 23, 2020
This reverts commit 9cca480. Reason for revert: <INSERT REASONING HERE> See flakey failures https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTwsSBUZsYWtlIkRjaHJvbWl1bUBicm93c2VyX3Rlc3RzQENocm9tZVZveEJyYWlsbGVUYWJsZVRlc3QudGVzdEdldFVuY29udHJhY3RlZAw [7369:7369:0522/203957.919406:FATAL:chrome_extensions_browser_client.cc(148)] Check failed: context. #0 0x55cfe9dfc549 base::debug::CollectStackTrace() #1 0x55cfe9d09be3 base::debug::StackTrace::StackTrace() #2 0x55cfe9d20d7f logging::LogMessage::~LogMessage() #3 0x55cfe9d2156e logging::LogMessage::~LogMessage() #4 0x55cfed7b0e42 extensions::ChromeExtensionsBrowserClient::GetOriginalContext() #5 0x55cfed58f4c3 BrowserContextKeyedServiceFactory::GetContextToUse() #6 0x55cfebd733c3 KeyedServiceFactory::GetServiceForContext() #7 0x55cfea38f279 extensions::TtsExtensionEventHandler::OnTtsEvent() #8 0x55cfe73698c8 content::TtsUtteranceImpl::OnTtsEvent() #9 0x55cfe7365120 content::TtsControllerImpl::ClearUtteranceQueue() #10 0x55cfe7365f03 content::TtsControllerImpl::StopInternal() #11 0x55cfe7367071 content::TtsControllerImpl::OnBrowserContextDestroyed() #12 0x55cfe6d1d18c content::BrowserContext::~BrowserContext() #13 0x55cfea0f813f ProfileImpl::~ProfileImpl() #14 0x55cfea0f816e ProfileImpl::~ProfileImpl() #15 0x55cfea0f1f72 ProfileDestroyer::DestroyRegularProfileNow() #16 0x55cfea0f1d00 ProfileDestroyer::DestroyProfileWhenAppropriate() #17 0x55cfea1137e8 std::__1::unique_ptr<>::~unique_ptr() #18 0x55cfea114ee3 std::__1::__tree<>::destroy() #19 0x55cfea11473b ProfileManager::~ProfileManager() #20 0x55cfea10bfae ProfileManager::~ProfileManager() #21 0x55cfe9eac15a BrowserProcessImpl::StartTearDown() #22 0x55cfe9eaab2a ChromeBrowserMainParts::PostMainMessageLoopRun() #23 0x55cfe51c9e74 chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() #24 0x55cfe6d41ccf content::BrowserMainLoop::ShutdownThreadsAndCleanUp() #25 0x55cfe6d43b6d content::BrowserMainRunnerImpl::Shutdown() #26 0x55cfe6d3eb02 content::BrowserMain() #27 0x55cfe97ac717 content::ContentMainRunnerImpl::RunServiceManager() #28 0x55cfe97ac2cf content::ContentMainRunnerImpl::Run() #29 0x55cfec99806a service_manager::Main() #30 0x55cfe7f60444 content::ContentMain() #31 0x55cfea5622a4 content::BrowserTestBase::SetUp() #32 0x55cfe9cf633b InProcessBrowserTest::SetUp() #33 0x55cfe579858e testing::Test::Run() #34 0x55cfe5799948 testing::TestInfo::Run() #35 0x55cfe579a5e7 testing::TestSuite::Run() chromium#36 0x55cfe57aa747 testing::internal::UnitTestImpl::RunAllTests() #37 0x55cfe57aa179 testing::UnitTest::Run() #38 0x55cfe9e477e2 base::TestSuite::Run() chromium#39 0x55cfe9cdf0e7 BrowserTestSuiteRunnerChromeOS::RunTestSuite() #40 0x55cfea5a72f4 content::LaunchTests() #41 0x55cfe9cdf494 LaunchChromeTests() chromium#42 0x55cfe9cdf032 main #43 0x7f421a16f830 __libc_start_main #44 0x55cfe29b442a _start Fixed: Fixed: 1085878, 1085877 Fixed: 1085878, 1085877 Original change's description: > Fix UAF in TtsPlatformImpl if a BrowserContext is deleted. > > Bug: 1081350 > Change-Id: I2b1824abefbd7fc3e8ce1c0cb433896161bab4e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211123 > Reviewed-by: David Tseng <dtseng@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771222} TBR=dmazzoni@chromium.org,dtseng@chromium.org,jam@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1081350 Change-Id: I88ec7e523fbe56845b8480b112535b2f8e18a520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213553 Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#771379}
bigben0123
pushed a commit
to bigben0123/chromium
that referenced
this pull request
Jun 28, 2020
This fixes a UAF when closing a tab while there is a SharingDialog open. (cherry picked from commit fd7196a) Bug: 1000934 Change-Id: Ie8f6e52626ee834bc72acfe318c5a28aafe27635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789150 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by: Alex Chau <alexchau@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#694682} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796242 Cr-Commit-Position: refs/branch-heads/3904@{chromium#43} Cr-Branched-From: 675968a-refs/heads/master@{#693954}
pdigennaro
pushed a commit
to washezium/washezium
that referenced
this pull request
Jul 19, 2020
This reverts commit 1630782. Reason for revert: crashes in tests on Mac Release (Intel) - see attached bug for information Bug: 1082966, 1083148 Original change's description: > Metal: Run test shaders on a ThreadPriority::DISPLAY thread > > The Metal test shaders are compiled in a function that comes from > a PostTask. There is currently no path through which a PostTask > will end up running on a ThreadPriority::DISPLAY thread. > > Change the Metal test code to create a ThreadPriority::DISPLAY > thread and do its work there. A separate change is making that > correspond to a pthread priority of 50. > > Of note is that Metal's callback to Chrome comes from a Metal-created > thread which has priority 31. > > Also change the default test shader to be a Compile instead of a > Link (the Link tests have not been completed). > > Bug: 974219 > Change-Id: Ieb5ab0748b3aa255ee7dd3348870ddf812caa682 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200357 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: ccameron <ccameron@chromium.org> > Cr-Commit-Position: refs/heads/master@{#768962} TBR=avi@chromium.org, ccameron@chromium.org, dfried@google.com (cherry picked from commit 736e31b) Change-Id: I852346697048fc916711ea60dd050b646a53705c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 974219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203257 Reviewed-by: Dana Fried <dfried@google.com> Cr-Original-Commit-Position: refs/heads/master@{#768986} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207795 Reviewed-by: ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/branch-heads/4147@{chromium#43} Cr-Branched-From: 1630782-refs/heads/master@{#768962}
blueboxd
referenced
this pull request
in blueboxd/chromium-legacy
Jul 29, 2020
The change https://chromium-review.googlesource.com/c/chromium/src/+/1980612 explicitly unloads various component extensions deemed to be risky. Unfortunately, the hash for ChromeVox (which was supposed to not be risky) was *wrong*, so it was being unloaded mysteriously. Test: obtain the hash for ChromeVox (extension id mdn....), via logging and print the hex hash. Verify after correcting the hash in profile_helper.cc, on-device, doing things like clicking the "Add Person" button doesn't unloads ChromeVox. Fixed: 1094031 Issue details: On the login screen, invoke the "Add Person" button. result: ChromeVox is unloaded i.e. #2 0x57e72acd8634 content::RenderFrameHostImpl::~RenderFrameHostImpl() #3 0x57e72acd8520 content::RenderFrameHostImpl::~RenderFrameHostImpl() #4 0x57e72b0bb120 content::RenderFrameHostManager::~RenderFrameHostManager() #5 0x57e72acd2449 content::FrameTreeNode::~FrameTreeNode() #6 0x57e72bffe68d content::FrameTree::~FrameTree() #7 0x57e72c20defa content::WebContentsImpl::~WebContentsImpl() #8 0x57e72c20e928 content::WebContentsImpl::~WebContentsImpl() #9 0x57e72c3d2490 extensions::ExtensionHost::~ExtensionHost() #10 0x57e72c3d253c extensions::ExtensionHost::~ExtensionHost() #11 0x57e72c40f857 extensions::ProcessManager::CloseBackgroundHost() #12 0x57e72c40fabe extensions::ProcessManager::OnExtensionUnloaded() #13 0x57e72c3ea211 extensions::ExtensionRegistry::TriggerOnUnloaded() #14 0x57e72c3e8f3a extensions::ExtensionRegistrar::DeactivateExtension() #15 0x57e72c3e8be7 extensions::ExtensionRegistrar::RemoveExtension() #16 0x57e72f781d0b extensions::ExtensionService::RemoveComponentExtension() #17 0x57e72f761c47 extensions::ComponentLoader::Remove() #18 0x57e72cb46908 chromeos::ProfileHelperImpl::ClearSigninProfile() #19 0x57e7304c57c1 chromeos::GaiaScreenHandler::StartClearingCookies() #20 0x57e7304c58dc chromeos::GaiaScreenHandler::ShowGaiaAsync() #21 0x57e72ca0362b chromeos::LoginDisplayHostCommon::ShowGaiaDialogCommon() #22 0x57e72ca04686 chromeos::LoginDisplayHostMojo::ShowGaiaDialog() #23 0x57e72fbfd2ef ash::LoginShelfView::ButtonPressed() #24 0x57e72f27480c views::ButtonController::OnKeyPressed() #25 0x57e72f2c2624 views::View::OnKeyEvent() #26 0x57e72f266a3b ui::ScopedTargetHandler::OnEvent() #27 0x57e72e80f1fc ui::EventDispatcherDelegate::DispatchEvent() #28 0x57e72ebb32d6 ui::EventProcessor::OnEventFromSource() #29 0x57e72e80fd89 ui::EventSource::SendEventToSinkFromRewriter() #30 0x57e72f2cf9e0 views::Widget::OnKeyEvent() #31 0x57e72e80f1fc ui::EventDispatcherDelegate::DispatchEvent() #32 0x57e72ebb32d6 ui::EventProcessor::OnEventFromSource() #33 0x57e72ebb9387 aura::WindowTreeHost::DispatchKeyEventPostIME() #34 0x57e72e8381c3 ui::InputMethodBase::DispatchKeyEventPostIME() #35 0x57e72e85f4fd ui::InputMethodChromeOS::ProcessUnfilteredKeyPressEvent() chromium#36 0x57e72e85f24c ui::InputMethodChromeOS::DispatchKeyEvent() #37 0x57e72ebb217f aura::WindowEventDispatcher::PreDispatchKeyEvent() #38 0x57e72ebb1a28 aura::WindowEventDispatcher::PreDispatchEvent() chromium#39 0x57e72e80eedd ui::EventDispatcherDelegate::DispatchEvent() #40 0x57e72ebb32d6 ui::EventProcessor::OnEventFromSource() #41 0x57e72e80fece ui::EventSource::EventRewriterContinuationImpl::SendEvent() chromium#42 0x57e72c649a27 ui::EventRewriterChromeOS::RewriteKeyEventInContext() #43 0x57e72c6492fe ui::EventRewriterChromeOS::RewriteEvent() #44 0x57e72e80fea0 ui::EventSource::EventRewriterContinuationImpl::SendEvent() #45 0x57e72fb88588 ash::KeyboardDrivenEventRewriter::RewriteEvent() #46 0x57e72e80fea0 ui::EventSource::EventRewriterContinuationImpl::SendEvent() #47 0x57e72fb88e9b ash::SpokenFeedbackEventRewriter::RewriteEvent() #48 0x57e72e80fea0 ui::EventSource::EventRewriterContinuationImpl::SendEvent() #49 0x57e72fbec429 ash::TouchExplorationController::RewriteEvent() #50 0x57e72e80fea0 ui::EventSource::EventRewriterContinuationImpl::SendEvent() #51 0x57e72fb5e078 ash::AutoclickDragEventRewriter::RewriteEvent() #52 0x57e72e80fea0 ui::EventSource::EventRewriterContinuationImpl::SendEvent() #53 0x57e72fbdf76b ash::MagnificationController::RewriteEvent() #54 0x57e72e80fd68 ui::EventSource::SendEventToSinkFromRewriter() #55 0x57e72fb9bb93 aura::WindowTreeHostPlatform::DispatchEvent() #56 0x57e72fb9d8dc ash::AshWindowTreeHostPlatform::DispatchEvent() Change-Id: Ibead7896cecddcb3da8bb4a553137f65700248f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324108 Reviewed-by: Anastasia Helfinstein <anastasi@google.com> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#792662}
EwanRoycroft
pushed a commit
to bbc/chromium
that referenced
this pull request
Nov 2, 2020
Adds a new In Product Help bubble that suggests that the user should enable access to page content in order to improve translations. This includes handling of the IPH, but not any triggering of the IPH or noting that the expected user response event has occurred. Following instructions here: https://chromium.googlesource.com/chromium/src/+/refs/heads/master/docs/translation_screenshots.md BUG=1120080 (cherry picked from commit de06e2c) Change-Id: Ib929b40d9b0954bfba5ed80ba02d3913ec30f1f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368472 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#800459} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373291 Reviewed-by: Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/branch-heads/4240@{chromium#43} Cr-Branched-From: f297677-refs/heads/master@{#800218}
blueboxd
referenced
this pull request
in blueboxd/chromium-legacy
Dec 12, 2020
This reverts commit 3da5569. Reason for revert: Suspected to be causing widespread failures in PPAPI/Pepper tests on Win and Linux dbg bots: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/87226 https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/93584 Sample failure output: [ RUN ] OutOfProcessPPAPITest.Instance_ExecuteScript [18698:18698:1211/141847.386588:INFO:content_main_runner_impl.cc(1027)] Chrome is running in full browser mode. DevTools listening on ws://127.0.0.1:37739/devtools/browser/565ba965-de40-4715-8905-11c22e1cfcca [18698:18811:1211/141848.175888:WARNING:render_message_filter.cc(137)] Could not find tid [18698:18811:1211/141848.265958:WARNING:render_message_filter.cc(137)] Could not find tid [18698:18698:1211/141848.839793:INFO:CONSOLE(1)] "Uncaught Error: plugin exception", source: file:///b/s/w/ir/ppapi/tests/test_case.html?testcase=Instance_ExecuteScript (1) [18698:18698:1211/141848.844552:INFO:CONSOLE(1)] "Uncaught TypeError: document.doesntExist is not a function", source: file:///b/s/w/ir/ppapi/tests/test_case.html?testcase=Instance_ExecuteScript (1) [18698:18698:1211/141848.855716:INFO:CONSOLE(176)] "ExecuteScript finished in 0.073 seconds.", source: file:///b/s/w/ir/ppapi/tests/test_case.html?testcase=Instance_ExecuteScript (176) Received signal 11 <unknown> 000000000000 #0 0x7f89c0dca89f base::debug::CollectStackTrace() #1 0x7f89c0b5409a base::debug::StackTrace::StackTrace() #2 0x7f89c0b54055 base::debug::StackTrace::StackTrace() #3 0x7f89c0dca36b base::debug::(anonymous namespace)::StackDumpSignalHandler() #4 0x7f8993ea2390 (/lib/x86_64-linux-gnu/libpthread-2.23.so+0x1138f) #5 0x7f89b142c419 std::__Cr::default_delete<>::operator()() #6 0x7f89b142c3ea std::__Cr::unique_ptr<>::reset() #7 0x7f89b142c379 std::__Cr::unique_ptr<>::~unique_ptr() #8 0x7f89b142c16d mojo::internal::AssociatedInterfacePtrState<>::~AssociatedInterfacePtrState() #9 0x7f89b142cb95 mojo::AssociatedRemote<>::~AssociatedRemote() #10 0x7f89b142afab content::PepperPluginInstance::~PepperPluginInstance() #11 0x7f89b2587d8e content::PepperPluginInstanceImpl::~PepperPluginInstanceImpl() #12 0x7f89b2587e69 content::PepperPluginInstanceImpl::~PepperPluginInstanceImpl() #13 0x7f89b25350f8 base::RefCounted<>::DeleteInternal<>() #14 0x7f89b25350c5 base::DefaultRefCountedTraits<>::Destruct() #15 0x7f89b25350a3 base::RefCounted<>::Release() #16 0x7f89b2535069 scoped_refptr<>::Release() #17 0x7f89b253020a scoped_refptr<>::~scoped_refptr() #18 0x7f89b25ce3f3 scoped_refptr<>::reset() #19 0x7f89b25cd8dd _ZN13scoped_refptrIN7content24PepperPluginInstanceImplEEaSEDn #20 0x7f89b25cbe83 content::PepperWebPluginImpl::Destroy() #21 0x7f89a7414e41 blink::WebPluginContainerImpl::Dispose() #22 0x7f89a593f32d blink::HTMLFrameOwnerElement::PluginDisposeSuspendScope::PerformDeferredPluginDispose() #23 0x7f89a4f5d292 blink::HTMLFrameOwnerElement::PluginDisposeSuspendScope::~PluginDisposeSuspendScope() #24 0x7f89a4f58862 blink::ContainerNode::RemoveChild() #25 0x7f89a5111cbb blink::Node::removeChild() #26 0x7f89a70daabe blink::(anonymous namespace)::RemoveChildOperationCallback() #27 0x7f899e0c0780 v8::internal::FunctionCallbackArguments::Call() #28 0x7f899e0bedcd v8::internal::(anonymous namespace)::HandleApiCallHelper<>() #29 0x7f899e0bcfe5 v8::internal::Builtin_Impl_HandleApiCall() #30 0x7f899e0bcaa9 v8::internal::Builtin_HandleApiCall() #31 0x7f899dae513f Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_BuiltinExit r8: 00000f84ee181f88 r9: 0000000000000000 r10: 0000000000000259 r11: 00007f8996194690 r12: 00007f89a70da600 r13: 0000132400000000 r14: 00007ffc8c8eef10 r15: 00007ffc8c8eef10 di: 00007f89b3e98918 si: 00007f89b3e98918 bp: 00007ffc8c8ee710 bx: 00007f89c0f52440 dx: 00000f84ee181f90 ax: 00007f89b2587db0 cx: 0000000000000000 sp: 00007ffc8c8ee6f0 ip: 00007f89b142c419 efl: 0000000000010206 cgf: 002b000000000033 erf: 0000000000000000 trp: 000000000000000d msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Calling _exit(1). Core file will not be generated. ../../content/public/test/no_renderer_crashes_assertion.cc:101: Failure Failed Unexpected termination of a renderer process; status: 1, exit_code: 256 Stack trace: #0 0x55ec1877d394 content::NoRendererCrashesAssertion::Observe() #1 0x7f3d4cf1ead6 content::NotificationServiceImpl::Notify() #2 0x7f3d4d3a3986 content::RenderProcessHostImpl::ProcessDied() #3 0x7f3d4d3a46be content::RenderProcessHostImpl::OnChannelError() #4 0x7f3d60fa392d IPC::ChannelProxy::Context::OnDispatchError() #5 0x7f3d60fa987f base::internal::FunctorTraits<>::Invoke<>() #6 0x7f3d60fa97c1 base::internal::InvokeHelper<>::MakeItSo<>() #7 0x7f3d60fa9742 _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12ChannelProxy7ContextEFvvEJ13scoped_refptrIS5_EEEEFvvEE7RunImplIS7_NSt4__Cr5tupleIJS9_EEEJLm0EEEEvOT_OT0_NSE_16integer_sequenceImJXspT1_EEEE #8 0x7f3d60fa96ec base::internal::Invoker<>::RunOnce() #9 0x7f3d5ca3c0d1 _ZNO4base12OnceCallbackIFvvEE3RunEv #10 0x7f3d5cc03df2 base::TaskAnnotator::RunTask() #11 0x7f3d5cc49eba base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #12 0x7f3d5cc49685 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #13 0x7f3d5cc4a119 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #14 0x7f3d5caf69f1 base::MessagePumpGlib::HandleDispatch() #15 0x7f3d5caf7141 base::(anonymous namespace)::WorkSourceDispatch() #16 0x7f3d2f683197 g_main_context_dispatch #17 0x7f3d2f6833f0 (/lib/x86_64-linux-gnu/libglib-2.0.so.0.4800.2+0x4a3ef) #18 0x7f3d2f68349c g_main_context_iteration #19 0x7f3d5caf6b00 base::MessagePumpGlib::Run() #20 0x7f3d5cc4a740 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #21 0x7f3d5cb95d75 base::RunLoop::Run() #22 0x55ec187b836a content::RunThisRunLoop() #23 0x55ec187b831f content::RunMessageLoop() #24 0x55ec18760320 content::JavascriptTestObserver::Run() #25 0x55ec16a8b567 content::PPAPITestBase::RunTestURL() #26 0x55ec16a8b48e content::PPAPITestBase::RunTest() #27 0x55ec16a84f2a content::(anonymous namespace)::OutOfProcessPPAPITest_Instance_ExecuteScript_Test::RunTestOnMainThread() #28 0x55ec18719264 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #29 0x55ec1871cf2a base::internal::FunctorTraits<>::Invoke<>() #30 0x55ec1871cea1 base::internal::InvokeHelper<>::MakeItSo<>() #31 0x55ec1871ce37 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #32 0x55ec1871cddc base::internal::Invoker<>::RunOnce() #33 0x55ec157bbac1 _ZNO4base12OnceCallbackIFvvEE3RunEv #34 0x55ec18a331cc content::ShellBrowserMainParts::PreMainMessageLoopRun() #35 0x7f3d4c5f5282 content::BrowserMainLoop::PreMainMessageLoopRun() chromium#36 0x7f3d4c5ff18a base::internal::FunctorTraits<>::Invoke<>() #37 0x7f3d4c5ff0a1 base::internal::InvokeHelper<>::MakeItSo<>() #38 0x7f3d4c5ff027 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEiOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE chromium#39 0x7f3d4c5fefcc base::internal::Invoker<>::RunOnce() #40 0x7f3d4c9d5b31 _ZNO4base12OnceCallbackIFivEE3RunEv #41 0x7f3d4d812b16 content::StartupTaskRunner::RunAllTasksNow() chromium#42 0x7f3d4c5f3b8a content::BrowserMainLoop::CreateStartupTasks() #43 0x7f3d4c602df0 content::BrowserMainRunnerImpl::Initialize() #44 0x7f3d4c5f0d64 content::BrowserMain() #45 0x7f3d4e7bcbc6 content::RunBrowserProcessMain() #46 0x7f3d4e7be1e9 content::ContentMainRunnerImpl::RunBrowser() #47 0x7f3d4e7bdad7 content::ContentMainRunnerImpl::Run() #48 0x7f3d4e7bae05 content::RunContentProcess() #49 0x7f3d4e7bb79d content::ContentMain() #50 0x55ec18718d5a content::BrowserTestBase::SetUp() #51 0x55ec1865a9ac content::ContentBrowserTest::SetUp() #52 0x55ec16a8ba95 content::OutOfProcessPPAPITest::SetUp() #53 0x55ec17363a6b testing::internal::HandleSehExceptionsInMethodIfSupported<>() #54 0x55ec173547f7 testing::internal::HandleExceptionsInMethodIfSupported<>() Note the ~AssociatedRemote from ~PepperPluginInstanceImpl, which I think was introduced in this CL. This also seems to be the only plugin-related change in the blamelist (https://chromium.googlesource.com/chromium/src/+log/6828ef78f2200e4bac3280186c7520ab65b2d7f8%5E..21468f4304510a432e3376d9d72ec67962f39723?pretty=fuller&n=) Original change's description: > Add mojo interfaces for pepper plugins. > > This adds some base plumbing for pepper plugin instance handling. The > pepper renderer code allocates and manages the PepperPluginInstanceImpl, > this creates the correct encapsulation moving code out of RenderFrameImpl. > > On the browser side a PepperPluginInstance is created to handle the > messages and relay them to the WebContentsImpl which use to handle > the processing of Pepper messages. > > BUG=1157519 > > Change-Id: I24941bb7eecef56a90bbf961e6396101c8d3c785 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585627 > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836239} TBR=dcheng@chromium.org,bbudge@chromium.org,dtapuska@chromium.org,arthursonzogni@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Iddd93694ebe0611abef6c74b57667554b51e26fc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1157519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587769 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#836330}
billti
pushed a commit
to billti/chromium
that referenced
this pull request
Dec 22, 2020
This CL adds a MediaLog to VideoEncoder and uses it to surface basic properties. For now, it uses the VideoDecoder MediaLog properties to surface encoder name, because changes to the Devtools code would and the creation of new properties would be required to surface it as an encoder. (cherry picked from commit 77551b4) TBR: eugene@chromium.org Bug: 1148576 Change-Id: Ib9b0188421b08071672f49aead4cc87bd7d55d69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535561 Reviewed-by: Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#827508} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541548 Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/branch-heads/4324@{chromium#43} Cr-Branched-From: c73b5a6-refs/heads/master@{#827102}
blueboxd
referenced
this pull request
in blueboxd/chromium-legacy
Jan 14, 2021
…vice" This reverts commit 85753b0. Reason for revert: I suspect this CL caused failures SubresourceRedirectLoggedInSitesBrowserTest.TestCancelBeforeImageLoadForLoggedInSite https://ci.chromium.org/ui/p/chromium/builders/ci/linux-lacros-tester-rel/6414/overview Fontconfig error: Cannot load default config file: No such file: (null) BrowserTestBase received signal: Terminated. Backtrace: #0 0x5596f4879789 base::debug::CollectStackTrace() #1 0x5596f47e4163 base::debug::StackTrace::StackTrace() #2 0x5596f4dcc0c6 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f128ca544c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x7f12902ec9ff __libc_send #5 0x5596f2a8598f mojo::core::ChannelPosix::WriteNoLock() #6 0x5596f2a854b2 mojo::core::ChannelPosix::Write() #7 0x5596f2a7370e mojo::core::NodeChannel::SendChannelMessage() #8 0x5596f2a7808a mojo::core::NodeController::SendPeerEvent() #9 0x5596f2a78707 mojo::core::NodeController::ForwardEvent() #10 0x5596f6c728d2 mojo::core::ports::Node::SendUserMessageInternal() #11 0x5596f6c72720 mojo::core::ports::Node::SendUserMessage() #12 0x5596f2a768e1 mojo::core::NodeController::SendUserMessage() #13 0x5596f2a71afe mojo::core::MessagePipeDispatcher::WriteMessage() #14 0x5596f2a6744c mojo::core::Core::WriteMessage() #15 0x5596f579b850 mojo::Connector::Accept() #16 0x5596f579d9db mojo::InterfaceEndpointClient::SendMessageWithResponder() #17 0x5596f579dd5f mojo::InterfaceEndpointClient::AcceptWithResponder() #18 0x5596f26f4662 content::mojom::ChildHistogramFetcherProxy::GetChildNonPersistentHistogramData() #19 0x5596f2d9b2aa content::HistogramController::GetHistogramData() #20 0x5596f2d9c905 content::HistogramSynchronizer::RegisterAndNotifyAllProcesses() #21 0x5596f2d9ca56 content::FetchHistogramsAsynchronously() #22 0x5596f4dd4781 content::FetchHistogramsFromChildProcesses() #23 0x5596f52f70fa subresource_redirect::RetryForHistogramUntilCountReached() #24 0x5596f0f9d3d1 subresource_redirect::SubresourceRedirectLoggedInSitesBrowserTest_TestCancelBeforeImageLoadForLoggedInSite_Test::RunTestOnMainThread() #25 0x5596f4dcb6e9 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #26 0x5596f491e0aa ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #27 0x5596f491cea5 ChromeBrowserMainParts::PreMainMessageLoopRun() #28 0x5596f2c33516 content::BrowserMainLoop::PreMainMessageLoopRun() #29 0x5596f30a1833 content::StartupTaskRunner::RunAllTasksNow() #30 0x5596f2c324f9 content::BrowserMainLoop::CreateStartupTasks() #31 0x5596f2c34e78 content::BrowserMainRunnerImpl::Initialize() #32 0x5596f2c30c28 content::BrowserMain() #33 0x5596f373dc93 content::ContentMainRunnerImpl::RunBrowser() #34 0x5596f373d886 content::ContentMainRunnerImpl::Run() #35 0x5596f373ad84 content::RunContentProcess() chromium#36 0x5596f373b70c content::ContentMain() #37 0x5596f4dcac68 content::BrowserTestBase::SetUp() #38 0x5596f47d0edb InProcessBrowserTest::SetUp() chromium#39 0x5596f0f9e065 subresource_redirect::SubresourceRedirectLoggedInSitesBrowserTest::SetUp() #40 0x5596f1cf66e8 testing::Test::Run() #41 0x5596f1cf757f testing::TestInfo::Run() chromium#42 0x5596f1cf7f57 testing::TestSuite::Run() #43 0x5596f1d05777 testing::internal::UnitTestImpl::RunAllTests() #44 0x5596f1d050df testing::UnitTest::Run() #45 0x5596f48d0724 base::TestSuite::Run() #46 0x5596f47b935f ChromeTestSuiteRunner::RunTestSuite() #47 0x5596f4dfaab7 content::LaunchTests() #48 0x5596f47b9632 LaunchChromeTests() #49 0x5596f47b6df4 main #50 0x7f128ca3f840 __libc_start_main #51 0x5596f008526a _start [ RUN ] SubresourceRedirectLoggedInSitesBrowserTest.TestCancelBeforeImageLoadForLoggedInSite Original change's description: > [Safe Browsing] Abstract signin dep from RealTimeUrlLookupService > > This CL continues with the abstraction of dependencies on signin and > sync from //components/safe_browsing's access token fetching flow in > order to enable reuse by WebLayer. The concrete step taken here is to > abstract the dependencies on > //components/safe_browsing/core/browser/sync from > RealTimeUrlLookupService, passing these dependencies in via the > constructor. There are no behavioral changes in this CL: > - //chrome and //ios/chrome's factories glue the relevant parameters > from //components/safe_browsing/core/browser/sync > - //weblayer's factory passes in values for the parameters such that > access token fetching for URL lookups continues to be disabled in > WebLayer > > Followup work will bring up support for access token fetching in > WebLayer. > > Bug: 1080748 > Change-Id: I69fca4b2d04118088bb48596eb192beab7bafb4f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621301 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> > Commit-Queue: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842942} TBR=blundell@chromium.org,sdefresne@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,xinghuilu@chromium.org Change-Id: I9aa193871848c7e07353bb2bb428a2a39ba5cb00 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1080748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627391 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#842980}
blueboxd
referenced
this pull request
in blueboxd/chromium-legacy
Feb 17, 2021
… Text"
This reverts commit 87004c0941db2881991388cd6c72cf4a3d1f31c2.
Reason for revert:
As Sheriff, I'm reverting this change on suspicion of causing the MSan ChromeOS buildbot to think that we are referencing uninitialized memory.
Failing build
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/22528/overview
Flakiness Dashboard
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=All%2FSharesheetBubbleViewBrowserTest.InvokeUi_Default%2F0&testType=browser_tests
Test failure:
[ RUN ] All/SharesheetBubbleViewBrowserTest.InvokeUi_Default/0
2021-02-16T12:29:26.782807Z WARNING browser_tests[26720:26720]: [audio_manager_linux.cc(69)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized.
2021-02-16T12:29:26.796127Z ERROR browser_tests[26720:26720]: [cras_audio_handler.cc(1628)] Failed to retrieve WBS mic deprioritized flag
2021-02-16T12:29:26.796914Z WARNING browser_tests[26720:26813]: [statistics_provider.cc(320)] Finished loading statistics.
2021-02-16T12:29:27.204718Z ERROR browser_tests[26720:26720]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user.
2021-02-16T12:29:27.576009Z WARNING browser_tests[26720:26720]: [remote_commands_service.cc(183)] Client is not registered.
2021-02-16T12:29:27.621032Z WARNING browser_tests[26720:26720]: [wallpaper_controller_client.cc(376)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances.
2021-02-16T12:29:28.217682Z ERROR browser_tests[26720:26720]: [plugin_vm_manager_impl.cc(141)] New session has dispatcher unexpected already running. Perhaps Chrome crashed?
2021-02-16T12:29:28.404958Z ERROR browser_tests[26720:26720]: [account_manager_migrator.cc(268)] Could not find a refresh token for the Device Account.
2021-02-16T12:29:28.421207Z INFO browser_tests[26720:26720]: [android_sms_pairing_state_tracker_impl.cc(72)] No Pairing cookie found
2021-02-16T12:29:28.421880Z INFO browser_tests[26720:26720]: [key_permissions_manager_impl.cc(495)] One-time key permissions migration started for token: 0.
2021-02-16T12:29:28.734078Z ERROR browser_tests[26720:26817]: [als_reader.cc(52)] Missing num of als
2021-02-16T12:29:28.742218Z ERROR browser_tests[26720:26817]: [object_proxy.cc(621)] Failed to call method: org.chromium.U2F.IsUvpaa: object_path= /org/chromium/U2F: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.U2F was not provided by any .service files
2021-02-16T12:29:28.841649Z WARNING browser_tests[26720:26720]: [drivefs_session.cc(62)] DriveFs mount failed with error: 3
2021-02-16T12:29:28.936983Z INFO browser_tests[26720:26720]: [key_permissions_manager_impl.cc(520)] One-time key permissions migration succeeded for token: 0.
==26720==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x5598549f2288 in views::NativeWidgetAura::CenterWindow(gfx::Size const&) ./../../ui/views/widget/native_widget_aura.cc:415:57
#1 0x5598549793f1 in views::Widget::SetInitialBounds(gfx::Rect const&) ./../../ui/views/widget/widget.cc:0:0
#2 0x559854976649 in views::Widget::Init(views::Widget::InitParams) ./../../ui/views/widget/widget.cc:383:5
#3 0x5598546bc0b8 in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:132:18
#4 0x5598546bc0b8 in views::BubbleDialogDelegate::CreateBubble(views::BubbleDialogDelegate*) ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:326:27
#5 0x559863210ab5 in SharesheetBubbleView::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view.cc:230:3
#6 0x559851c5ead2 in sharesheet::SharesheetServiceDelegate::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service_delegate.cc:39:28
#7 0x559851c54d36 in sharesheet::SharesheetService::OnAppIconsLoaded(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >) ./../../chrome/browser/sharesheet/sharesheet_service.cc:245:13
#8 0x559851c5a278 in void base::internal::FunctorTraits<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), void>::Invoke<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> > >(void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>&&, sharesheet::SharesheetServiceDelegate*&&, mojo::StructPtr<apps::mojom::Intent>&&, base::OnceCallback<void (sharesheet::SharesheetResult)>&&, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:498:12
#9 0x559851c59e92 in MakeItSo<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo> > ./../../base/bind_internal.h:657:5
#10 0x559851c59e92 in RunImpl<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), std::tuple<base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, 0, 1, 2, 3> ./../../base/bind_internal.h:710:12
#11 0x559851c59e92 in base::internal::Invoker<base::internal::BindState<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>::RunOnce(base::internal::BindStateBase*, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:679:12
#12 0x559851c52f7a in Run ./../../base/callback.h:101:12
#13 0x559851c52f7a in sharesheet::SharesheetService::LoadAppIcons(std::__1::vector<apps::IntentLaunchInfo, std::__1::allocator<apps::IntentLaunchInfo> >, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, unsigned long, base::OnceCallback<void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:170:25
#14 0x559851c506b5 in sharesheet::SharesheetService::ShowBubbleWithDelegate(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:270:3
#15 0x559851c4f610 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:69:3
#16 0x559851c4f2a5 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:57:3
#17 0x55983e696304 in SharesheetBubbleViewBrowserTest::ShowUi() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:51:25
#18 0x55983e6958d8 in SharesheetBubbleViewBrowserTest_InvokeUi_Default_Test::RunTestOnMainThread() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:91:3
#19 0x5598526fa6e6 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:805:5
#20 0x559850dc31ed in Run ./../../base/callback.h:101:12
#21 0x559850dc31ed in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1688:38
#22 0x559850dc03c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1043:18
#23 0x55983fce3e6f in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:658:32
#24 0x5598460cf517 in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:944:13
#25 0x5598475f80ac in Run ./../../base/callback.h:101:12
#26 0x5598475f80ac in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:29
#27 0x5598460ca995 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:854:25
#28 0x5598460d6b64 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) ./../../content/browser/browser_main_runner_impl.cc:129:15
#29 0x5598460c37f2 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:43:32
#30 0x55984a9b393f in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:517:10
#31 0x55984a9b7a37 in content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:1001:10
#32 0x55984a9b68b0 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:876:12
#33 0x55984a9ae481 in content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*) ./../../content/app/content_main.cc:372:36
#34 0x55984a9aebb0 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:398:10
#35 0x5598526f81ea in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:683:3
#36 0x5598506cda3f in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:348:20
#37 0x5598418d8c23 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
#38 0x5598418d8c23 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2684:3
#39 0x5598418db9f9 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2866:11
#40 0x5598418dda84 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3020:28
#41 0x559841907c54 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5730:44
#42 0x559841906c4e in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10
#43 0x559841906c4e in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5313:10
#44 0x559850c79fd4 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2485:46
#45 0x559850c79fd4 in base::TestSuite::Run() ./../../base/test/test_suite.cc:481:16
#46 0x5598506276e3 in BrowserTestSuiteRunnerChromeOS::RunTestSuite(int, char**) ./../../chrome/test/base/browser_tests_main_chromeos.cc:35:23
#47 0x5598527f8a74 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:376:31
#48 0x559850633db9 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:269:10
#49 0x5598506274ff in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:47:10
#50 0x7f9a676ee83f in __libc_start_main ??:0:0
#51 0x55983729bd49 in _start ??:0:0
Uninitialized value was stored to memory at
#0 0x55985497952f in views::Widget::SetInitialBounds(gfx::Rect const&) ./../../ui/views/widget/widget.cc:1602:40
#1 0x559854976649 in views::Widget::Init(views::Widget::InitParams) ./../../ui/views/widget/widget.cc:383:5
#2 0x5598546bc0b8 in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:132:18
#3 0x5598546bc0b8 in views::BubbleDialogDelegate::CreateBubble(views::BubbleDialogDelegate*) ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:326:27
#4 0x559863210ab5 in SharesheetBubbleView::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view.cc:230:3
#5 0x559851c5ead2 in sharesheet::SharesheetServiceDelegate::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service_delegate.cc:39:28
#6 0x559851c54d36 in sharesheet::SharesheetService::OnAppIconsLoaded(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >) ./../../chrome/browser/sharesheet/sharesheet_service.cc:245:13
#7 0x559851c5a278 in void base::internal::FunctorTraits<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), void>::Invoke<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> > >(void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>&&, sharesheet::SharesheetServiceDelegate*&&, mojo::StructPtr<apps::mojom::Intent>&&, base::OnceCallback<void (sharesheet::SharesheetResult)>&&, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:498:12
#8 0x559851c59e92 in MakeItSo<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo> > ./../../base/bind_internal.h:657:5
#9 0x559851c59e92 in RunImpl<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), std::tuple<base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, 0, 1, 2, 3> ./../../base/bind_internal.h:710:12
#10 0x559851c59e92 in base::internal::Invoker<base::internal::BindState<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>::RunOnce(base::internal::BindStateBase*, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:679:12
#11 0x559851c52f7a in Run ./../../base/callback.h:101:12
#12 0x559851c52f7a in sharesheet::SharesheetService::LoadAppIcons(std::__1::vector<apps::IntentLaunchInfo, std::__1::allocator<apps::IntentLaunchInfo> >, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, unsigned long, base::OnceCallback<void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:170:25
#13 0x559851c506b5 in sharesheet::SharesheetService::ShowBubbleWithDelegate(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:270:3
#14 0x559851c4f610 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:69:3
#15 0x559851c4f2a5 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:57:3
#16 0x55983e696304 in SharesheetBubbleViewBrowserTest::ShowUi() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:51:25
#17 0x55983e6958d8 in SharesheetBubbleViewBrowserTest_InvokeUi_Default_Test::RunTestOnMainThread() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:91:3
#18 0x5598526fa6e6 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:805:5
#19 0x559850dc31ed in Run ./../../base/callback.h:101:12
#20 0x559850dc31ed in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1688:38
#21 0x559850dc03c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1043:18
#22 0x55983fce3e6f in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:658:32
#23 0x5598460cf517 in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:944:13
#24 0x5598475f80ac in Run ./../../base/callback.h:101:12
#25 0x5598475f80ac in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:29
Uninitialized value was stored to memory at
#0 0x5598546b68a3 in Rect ./../../ui/gfx/geometry/rect.h:43:47
#1 0x5598546b68a3 in views::BubbleBorder::GetBounds(gfx::Rect const&, gfx::Size const&) const ./../../ui/views/bubble/bubble_border.cc:90:15
#2 0x5598546d7ad3 in views::BubbleFrameView::GetWindowBoundsForClientBounds(gfx::Rect const&) const ./../../ui/views/bubble/bubble_frame_view.cc:186:26
#3 0x5598549b8119 in GetWindowBoundsForClientBounds ./../../ui/views/window/non_client_view.cc:207:23
#4 0x5598549b8119 in views::NonClientView::CalculatePreferredSize() const ./../../ui/views/window/non_client_view.cc:244:10
#5 0x559854928c1d in views::View::GetPreferredSize() const ./../../ui/views/view.cc:497:10
#6 0x559854979468 in views::Widget::SetInitialBounds(gfx::Rect const&) ./../../ui/views/widget/widget.cc:1602:40
#7 0x559854976649 in views::Widget::Init(views::Widget::InitParams) ./../../ui/views/widget/widget.cc:383:5
#8 0x5598546bc0b8 in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:132:18
#9 0x5598546bc0b8 in views::BubbleDialogDelegate::CreateBubble(views::BubbleDialogDelegate*) ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:326:27
#10 0x559863210ab5 in SharesheetBubbleView::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view.cc:230:3
#11 0x559851c5ead2 in sharesheet::SharesheetServiceDelegate::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service_delegate.cc:39:28
#12 0x559851c54d36 in sharesheet::SharesheetService::OnAppIconsLoaded(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >) ./../../chrome/browser/sharesheet/sharesheet_service.cc:245:13
#13 0x559851c5a278 in void base::internal::FunctorTraits<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), void>::Invoke<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> > >(void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>&&, sharesheet::SharesheetServiceDelegate*&&, mojo::StructPtr<apps::mojom::Intent>&&, base::OnceCallback<void (sharesheet::SharesheetResult)>&&, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:498:12
#14 0x559851c59e92 in MakeItSo<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo> > ./../../base/bind_internal.h:657:5
#15 0x559851c59e92 in RunImpl<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), std::tuple<base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, 0, 1, 2, 3> ./../../base/bind_internal.h:710:12
#16 0x559851c59e92 in base::internal::Invoker<base::internal::BindState<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>::RunOnce(base::internal::BindStateBase*, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:679:12
#17 0x559851c52f7a in Run ./../../base/callback.h:101:12
#18 0x559851c52f7a in sharesheet::SharesheetService::LoadAppIcons(std::__1::vector<apps::IntentLaunchInfo, std::__1::allocator<apps::IntentLaunchInfo> >, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, unsigned long, base::OnceCallback<void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:170:25
#19 0x559851c506b5 in sharesheet::SharesheetService::ShowBubbleWithDelegate(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:270:3
#20 0x559851c4f610 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:69:3
#21 0x559851c4f2a5 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:57:3
#22 0x55983e696304 in SharesheetBubbleViewBrowserTest::ShowUi() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:51:25
#23 0x55983e6958d8 in SharesheetBubbleViewBrowserTest_InvokeUi_Default_Test::RunTestOnMainThread() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:91:3
#24 0x5598526fa6e6 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:805:5
#25 0x559850dc31ed in Run ./../../base/callback.h:101:12
#26 0x559850dc31ed in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1688:38
Uninitialized value was stored to memory at
#0 0x5598546d7ae7 in views::BubbleFrameView::GetWindowBoundsForClientBounds(gfx::Rect const&) const ./../../ui/views/bubble/bubble_frame_view.cc:185:18
#1 0x5598549b8119 in GetWindowBoundsForClientBounds ./../../ui/views/window/non_client_view.cc:207:23
#2 0x5598549b8119 in views::NonClientView::CalculatePreferredSize() const ./../../ui/views/window/non_client_view.cc:244:10
#3 0x559854928c1d in views::View::GetPreferredSize() const ./../../ui/views/view.cc:497:10
#4 0x559854979468 in views::Widget::SetInitialBounds(gfx::Rect const&) ./../../ui/views/widget/widget.cc:1602:40
#5 0x559854976649 in views::Widget::Init(views::Widget::InitParams) ./../../ui/views/widget/widget.cc:383:5
#6 0x5598546bc0b8 in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:132:18
#7 0x5598546bc0b8 in views::BubbleDialogDelegate::CreateBubble(views::BubbleDialogDelegate*) ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:326:27
#8 0x559863210ab5 in SharesheetBubbleView::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view.cc:230:3
#9 0x559851c5ead2 in sharesheet::SharesheetServiceDelegate::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service_delegate.cc:39:28
#10 0x559851c54d36 in sharesheet::SharesheetService::OnAppIconsLoaded(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >) ./../../chrome/browser/sharesheet/sharesheet_service.cc:245:13
#11 0x559851c5a278 in void base::internal::FunctorTraits<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), void>::Invoke<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> > >(void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>&&, sharesheet::SharesheetServiceDelegate*&&, mojo::StructPtr<apps::mojom::Intent>&&, base::OnceCallback<void (sharesheet::SharesheetResult)>&&, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:498:12
#12 0x559851c59e92 in MakeItSo<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo> > ./../../base/bind_internal.h:657:5
#13 0x559851c59e92 in RunImpl<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), std::tuple<base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, 0, 1, 2, 3> ./../../base/bind_internal.h:710:12
#14 0x559851c59e92 in base::internal::Invoker<base::internal::BindState<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>::RunOnce(base::internal::BindStateBase*, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:679:12
#15 0x559851c52f7a in Run ./../../base/callback.h:101:12
#16 0x559851c52f7a in sharesheet::SharesheetService::LoadAppIcons(std::__1::vector<apps::IntentLaunchInfo, std::__1::allocator<apps::IntentLaunchInfo> >, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, unsigned long, base::OnceCallback<void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:170:25
#17 0x559851c506b5 in sharesheet::SharesheetService::ShowBubbleWithDelegate(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:270:3
#18 0x559851c4f610 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:69:3
#19 0x559851c4f2a5 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:57:3
#20 0x55983e696304 in SharesheetBubbleViewBrowserTest::ShowUi() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:51:25
#21 0x55983e6958d8 in SharesheetBubbleViewBrowserTest_InvokeUi_Default_Test::RunTestOnMainThread() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:91:3
#22 0x5598526fa6e6 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:805:5
#23 0x559850dc31ed in Run ./../../base/callback.h:101:12
#24 0x559850dc31ed in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1688:38
#25 0x559850dc03c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1043:18
Uninitialized value was created by an allocation of 'retval' in the stack frame of function '_ZNK5views15BubbleFrameView25GetFrameSizeForClientSizeERKN3gfx4SizeE'
#0 0x5598546d7b2a in views::BubbleFrameView::GetFrameSizeForClientSize(gfx::Size const&) const ./../../ui/views/bubble/bubble_frame_view.cc:834:0
SUMMARY: MemorySanitizer: use-of-uninitialized-value (/b/s/w/ir/out/Release/browser_tests+0x24ac3288)
Exiting
[ RUN ] All/SharesheetBubbleViewBrowserTest.InvokeUi_Default/0
2021-02-16T12:36:26.583543Z WARNING browser_tests[30386:30386]: [audio_manager_linux.cc(69)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized.
2021-02-16T12:36:26.592586Z ERROR browser_tests[30386:30386]: [cras_audio_handler.cc(1628)] Failed to retrieve WBS mic deprioritized flag
2021-02-16T12:36:26.593289Z WARNING browser_tests[30386:30401]: [statistics_provider.cc(320)] Finished loading statistics.
2021-02-16T12:36:26.860265Z ERROR browser_tests[30386:30386]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user.
2021-02-16T12:36:27.035171Z WARNING browser_tests[30386:30386]: [remote_commands_service.cc(183)] Client is not registered.
2021-02-16T12:36:27.064652Z WARNING browser_tests[30386:30386]: [wallpaper_controller_client.cc(376)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances.
2021-02-16T12:36:27.364592Z ERROR browser_tests[30386:30386]: [plugin_vm_manager_impl.cc(141)] New session has dispatcher unexpected already running. Perhaps Chrome crashed?
2021-02-16T12:36:27.421165Z ERROR browser_tests[30386:30386]: [account_manager_migrator.cc(268)] Could not find a refresh token for the Device Account.
2021-02-16T12:36:27.481536Z INFO browser_tests[30386:30386]: [key_permissions_manager_impl.cc(495)] One-time key permissions migration started for token: 0.
2021-02-16T12:36:27.484870Z INFO browser_tests[30386:30386]: [android_sms_pairing_state_tracker_impl.cc(72)] No Pairing cookie found
2021-02-16T12:36:27.638922Z ERROR browser_tests[30386:30401]: [als_reader.cc(52)] Missing num of als
2021-02-16T12:36:27.638945Z WARNING browser_tests[30386:30386]: [drivefs_session.cc(62)] DriveFs mount failed with error: 3
2021-02-16T12:36:27.644456Z ERROR browser_tests[30386:30401]: [object_proxy.cc(621)] Failed to call method: org.chromium.U2F.IsUvpaa: object_path= /org/chromium/U2F: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.U2F was not provided by any .service files
2021-02-16T12:36:27.699898Z INFO browser_tests[30386:30386]: [key_permissions_manager_impl.cc(520)] One-time key permissions migration succeeded for token: 0.
==30386==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x560b2e64a288 in views::NativeWidgetAura::CenterWindow(gfx::Size const&) ./../../ui/views/widget/native_widget_aura.cc:415:57
#1 0x560b2e5d13f1 in views::Widget::SetInitialBounds(gfx::Rect const&) ./../../ui/views/widget/widget.cc:0:0
#2 0x560b2e5ce649 in views::Widget::Init(views::Widget::InitParams) ./../../ui/views/widget/widget.cc:383:5
#3 0x560b2e3140b8 in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:132:18
#4 0x560b2e3140b8 in views::BubbleDialogDelegate::CreateBubble(views::BubbleDialogDelegate*) ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:326:27
#5 0x560b3ce68ab5 in SharesheetBubbleView::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view.cc:230:3
#6 0x560b2b8b6ad2 in sharesheet::SharesheetServiceDelegate::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service_delegate.cc:39:28
#7 0x560b2b8acd36 in sharesheet::SharesheetService::OnAppIconsLoaded(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >) ./../../chrome/browser/sharesheet/sharesheet_service.cc:245:13
#8 0x560b2b8b2278 in void base::internal::FunctorTraits<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), void>::Invoke<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> > >(void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>&&, sharesheet::SharesheetServiceDelegate*&&, mojo::StructPtr<apps::mojom::Intent>&&, base::OnceCallback<void (sharesheet::SharesheetResult)>&&, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:498:12
#9 0x560b2b8b1e92 in MakeItSo<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo> > ./../../base/bind_internal.h:657:5
#10 0x560b2b8b1e92 in RunImpl<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), std::tuple<base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, 0, 1, 2, 3> ./../../base/bind_internal.h:710:12
#11 0x560b2b8b1e92 in base::internal::Invoker<base::internal::BindState<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>::RunOnce(base::internal::BindStateBase*, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:679:12
#12 0x560b2b8aaf7a in Run ./../../base/callback.h:101:12
#13 0x560b2b8aaf7a in sharesheet::SharesheetService::LoadAppIcons(std::__1::vector<apps::IntentLaunchInfo, std::__1::allocator<apps::IntentLaunchInfo> >, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, unsigned long, base::OnceCallback<void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:170:25
#14 0x560b2b8a86b5 in sharesheet::SharesheetService::ShowBubbleWithDelegate(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:270:3
#15 0x560b2b8a7610 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:69:3
#16 0x560b2b8a72a5 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:57:3
#17 0x560b182ee304 in SharesheetBubbleViewBrowserTest::ShowUi() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:51:25
#18 0x560b182ed8d8 in SharesheetBubbleViewBrowserTest_InvokeUi_Default_Test::RunTestOnMainThread() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:91:3
#19 0x560b2c3526e6 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:805:5
#20 0x560b2aa1b1ed in Run ./../../base/callback.h:101:12
#21 0x560b2aa1b1ed in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1688:38
#22 0x560b2aa183c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1043:18
#23 0x560b1993be6f in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:658:32
#24 0x560b1fd27517 in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:944:13
#25 0x560b212500ac in Run ./../../base/callback.h:101:12
#26 0x560b212500ac in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:29
#27 0x560b1fd22995 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:854:25
#28 0x560b1fd2eb64 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) ./../../content/browser/browser_main_runner_impl.cc:129:15
#29 0x560b1fd1b7f2 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:43:32
#30 0x560b2460b93f in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:517:10
#31 0x560b2460fa37 in content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:1001:10
#32 0x560b2460e8b0 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:876:12
#33 0x560b24606481 in content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*) ./../../content/app/content_main.cc:372:36
#34 0x560b24606bb0 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:398:10
#35 0x560b2c3501ea in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:683:3
#36 0x560b2a325a3f in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:348:20
#37 0x560b1b530c23 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
#38 0x560b1b530c23 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2684:3
#39 0x560b1b5339f9 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2866:11
#40 0x560b1b535a84 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3020:28
#41 0x560b1b55fc54 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5730:44
#42 0x560b1b55ec4e in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10
#43 0x560b1b55ec4e in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5313:10
#44 0x560b2a8d1fd4 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2485:46
#45 0x560b2a8d1fd4 in base::TestSuite::Run() ./../../base/test/test_suite.cc:481:16
#46 0x560b2a27f6e3 in BrowserTestSuiteRunnerChromeOS::RunTestSuite(int, char**) ./../../chrome/test/base/browser_tests_main_chromeos.cc:35:23
#47 0x560b2c450a74 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:376:31
#48 0x560b2a28bdb9 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:269:10
#49 0x560b2a27f4ff in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:47:10
#50 0x7f0d2d9dd83f in __libc_start_main ??:0:0
#51 0x560b10ef3d49 in _start ??:0:0
Uninitialized value was stored to memory at
#0 0x560b2e5d152f in views::Widget::SetInitialBounds(gfx::Rect const&) ./../../ui/views/widget/widget.cc:1602:40
#1 0x560b2e5ce649 in views::Widget::Init(views::Widget::InitParams) ./../../ui/views/widget/widget.cc:383:5
#2 0x560b2e3140b8 in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:132:18
#3 0x560b2e3140b8 in views::BubbleDialogDelegate::CreateBubble(views::BubbleDialogDelegate*) ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:326:27
#4 0x560b3ce68ab5 in SharesheetBubbleView::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view.cc:230:3
#5 0x560b2b8b6ad2 in sharesheet::SharesheetServiceDelegate::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service_delegate.cc:39:28
#6 0x560b2b8acd36 in sharesheet::SharesheetService::OnAppIconsLoaded(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >) ./../../chrome/browser/sharesheet/sharesheet_service.cc:245:13
#7 0x560b2b8b2278 in void base::internal::FunctorTraits<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), void>::Invoke<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> > >(void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>&&, sharesheet::SharesheetServiceDelegate*&&, mojo::StructPtr<apps::mojom::Intent>&&, base::OnceCallback<void (sharesheet::SharesheetResult)>&&, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:498:12
#8 0x560b2b8b1e92 in MakeItSo<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo> > ./../../base/bind_internal.h:657:5
#9 0x560b2b8b1e92 in RunImpl<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), std::tuple<base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, 0, 1, 2, 3> ./../../base/bind_internal.h:710:12
#10 0x560b2b8b1e92 in base::internal::Invoker<base::internal::BindState<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>::RunOnce(base::internal::BindStateBase*, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:679:12
#11 0x560b2b8aaf7a in Run ./../../base/callback.h:101:12
#12 0x560b2b8aaf7a in sharesheet::SharesheetService::LoadAppIcons(std::__1::vector<apps::IntentLaunchInfo, std::__1::allocator<apps::IntentLaunchInfo> >, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, unsigned long, base::OnceCallback<void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:170:25
#13 0x560b2b8a86b5 in sharesheet::SharesheetService::ShowBubbleWithDelegate(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:270:3
#14 0x560b2b8a7610 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:69:3
#15 0x560b2b8a72a5 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:57:3
#16 0x560b182ee304 in SharesheetBubbleViewBrowserTest::ShowUi() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:51:25
#17 0x560b182ed8d8 in SharesheetBubbleViewBrowserTest_InvokeUi_Default_Test::RunTestOnMainThread() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:91:3
#18 0x560b2c3526e6 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:805:5
#19 0x560b2aa1b1ed in Run ./../../base/callback.h:101:12
#20 0x560b2aa1b1ed in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1688:38
#21 0x560b2aa183c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1043:18
#22 0x560b1993be6f in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:658:32
#23 0x560b1fd27517 in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:944:13
#24 0x560b212500ac in Run ./../../base/callback.h:101:12
#25 0x560b212500ac in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:29
Uninitialized value was stored to memory at
#0 0x560b2e30e8a3 in Rect ./../../ui/gfx/geometry/rect.h:43:47
#1 0x560b2e30e8a3 in views::BubbleBorder::GetBounds(gfx::Rect const&, gfx::Size const&) const ./../../ui/views/bubble/bubble_border.cc:90:15
#2 0x560b2e32fad3 in views::BubbleFrameView::GetWindowBoundsForClientBounds(gfx::Rect const&) const ./../../ui/views/bubble/bubble_frame_view.cc:186:26
#3 0x560b2e610119 in GetWindowBoundsForClientBounds ./../../ui/views/window/non_client_view.cc:207:23
#4 0x560b2e610119 in views::NonClientView::CalculatePreferredSize() const ./../../ui/views/window/non_client_view.cc:244:10
#5 0x560b2e580c1d in views::View::GetPreferredSize() const ./../../ui/views/view.cc:497:10
#6 0x560b2e5d1468 in views::Widget::SetInitialBounds(gfx::Rect const&) ./../../ui/views/widget/widget.cc:1602:40
#7 0x560b2e5ce649 in views::Widget::Init(views::Widget::InitParams) ./../../ui/views/widget/widget.cc:383:5
#8 0x560b2e3140b8 in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:132:18
#9 0x560b2e3140b8 in views::BubbleDialogDelegate::CreateBubble(views::BubbleDialogDelegate*) ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:326:27
#10 0x560b3ce68ab5 in SharesheetBubbleView::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view.cc:230:3
#11 0x560b2b8b6ad2 in sharesheet::SharesheetServiceDelegate::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service_delegate.cc:39:28
#12 0x560b2b8acd36 in sharesheet::SharesheetService::OnAppIconsLoaded(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >) ./../../chrome/browser/sharesheet/sharesheet_service.cc:245:13
#13 0x560b2b8b2278 in void base::internal::FunctorTraits<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), void>::Invoke<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> > >(void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>&&, sharesheet::SharesheetServiceDelegate*&&, mojo::StructPtr<apps::mojom::Intent>&&, base::OnceCallback<void (sharesheet::SharesheetResult)>&&, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:498:12
#14 0x560b2b8b1e92 in MakeItSo<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo> > ./../../base/bind_internal.h:657:5
#15 0x560b2b8b1e92 in RunImpl<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::vector<sharesheet::TargetInfo>), std::tuple<base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate *, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, 0, 1, 2, 3> ./../../base/bind_internal.h:710:12
#16 0x560b2b8b1e92 in base::internal::Invoker<base::internal::BindState<void (sharesheet::SharesheetService::*)(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >), base::WeakPtr<sharesheet::SharesheetService>, sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)> >, void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>::RunOnce(base::internal::BindStateBase*, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >&&) ./../../base/bind_internal.h:679:12
#17 0x560b2b8aaf7a in Run ./../../base/callback.h:101:12
#18 0x560b2b8aaf7a in sharesheet::SharesheetService::LoadAppIcons(std::__1::vector<apps::IntentLaunchInfo, std::__1::allocator<apps::IntentLaunchInfo> >, std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, unsigned long, base::OnceCallback<void (std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:170:25
#19 0x560b2b8a86b5 in sharesheet::SharesheetService::ShowBubbleWithDelegate(sharesheet::SharesheetServiceDelegate*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:270:3
#20 0x560b2b8a7610 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, bool, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:69:3
#21 0x560b2b8a72a5 in sharesheet::SharesheetService::ShowBubble(content::WebContents*, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service.cc:57:3
#22 0x560b182ee304 in SharesheetBubbleViewBrowserTest::ShowUi() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:51:25
#23 0x560b182ed8d8 in SharesheetBubbleViewBrowserTest_InvokeUi_Default_Test::RunTestOnMainThread() ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc:91:3
#24 0x560b2c3526e6 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:805:5
#25 0x560b2aa1b1ed in Run ./../../base/callback.h:101:12
#26 0x560b2aa1b1ed in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1688:38
Uninitialized value was stored to memory at
#0 0x560b2e32fae7 in views::BubbleFrameView::GetWindowBoundsForClientBounds(gfx::Rect const&) const ./../../ui/views/bubble/bubble_frame_view.cc:185:18
#1 0x560b2e610119 in GetWindowBoundsForClientBounds ./../../ui/views/window/non_client_view.cc:207:23
#2 0x560b2e610119 in views::NonClientView::CalculatePreferredSize() const ./../../ui/views/window/non_client_view.cc:244:10
#3 0x560b2e580c1d in views::View::GetPreferredSize() const ./../../ui/views/view.cc:497:10
#4 0x560b2e5d1468 in views::Widget::SetInitialBounds(gfx::Rect const&) ./../../ui/views/widget/widget.cc:1602:40
#5 0x560b2e5ce649 in views::Widget::Init(views::Widget::InitParams) ./../../ui/views/widget/widget.cc:383:5
#6 0x560b2e3140b8 in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:132:18
#7 0x560b2e3140b8 in views::BubbleDialogDelegate::CreateBubble(views::BubbleDialogDelegate*) ./../../ui/views/bubble/bubble_dialog_delegate_view.cc:326:27
#8 0x560b3ce68ab5 in SharesheetBubbleView::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view.cc:230:3
#9 0x560b2b8b6ad2 in sharesheet::SharesheetServiceDelegate::ShowBubble(std::__1::vector<sharesheet::TargetInfo, std::__1::allocator<sharesheet::TargetInfo> >, mojo::StructPtr<apps::mojom::Intent>, base::OnceCallback<void (sharesheet::SharesheetResult)>) ./../../chrome/browser/sharesheet/sharesheet_service_delegate.cc:39:28
#10 0x560b2b8acd36 in sharesheet::SharesheetService::OnAppIconsLoaded(shareshee…
5455945
pushed a commit
to 5455945/chromium
that referenced
this pull request
Mar 2, 2021
This change modifies `IsPossibleUsernameValid` to require that the possible username is part of an already saved credential for the same site. This will be later extended to only require a match with a local username saved on any site. For robustness the username and the set of allowed usernames are canonicalized, that is case and email providers are irrelevant. The existing requirements to only be ASCII and to not contain whitespace are dropped. (cherry picked from commit b6b21a5) Bug: 959776, 1167042 Change-Id: Ic50c954ddd7a4fd969c56295825ae717c870b915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627278 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Maria Kazinova <kazinova@google.com> Cr-Original-Commit-Position: refs/heads/master@{#844013} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637594 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/branch-heads/4389@{chromium#43} Cr-Branched-From: 9251c5d-refs/heads/master@{#843830}
ls60629
pushed a commit
to ls60629/chromium
that referenced
this pull request
Apr 11, 2021
The sim_locked field in CellularStateProperties is currently mapped directly to device state. This works incorrectly with multi-sim since the sim lock state on device state only corresponds to that of the primary slot. This CL adds an additional check so that this is only set for the primary network. (cherry picked from commit 5ab1f22) Fixed: 1182963 Change-Id: Idbc70a5156a68b0d046a22bd23ba06ee8cda7798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2725792 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#858720} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2728517 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/4430@{chromium#43} Cr-Branched-From: e5ce7dc-refs/heads/master@{#857950}
GrumpyOldTroll
pushed a commit
to GrumpyOldTroll/chromium
that referenced
this pull request
Apr 13, 2021
This change modifies `IsPossibleUsernameValid` to require that the possible username is part of an already saved credential for the same site. This will be later extended to only require a match with a local username saved on any site. For robustness the username and the set of allowed usernames are canonicalized, that is case and email providers are irrelevant. The existing requirements to only be ASCII and to not contain whitespace are dropped. (cherry picked from commit b6b21a5) Bug: 959776, 1167042 Change-Id: Ic50c954ddd7a4fd969c56295825ae717c870b915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627278 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Maria Kazinova <kazinova@google.com> Cr-Original-Commit-Position: refs/heads/master@{#844013} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637594 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/branch-heads/4389@{chromium#43} Cr-Branched-From: 9251c5d-refs/heads/master@{#843830}
blattersturm
pushed a commit
to citizenfx/chromium
that referenced
this pull request
Apr 29, 2021
BookmarkEditorView shows a modal dialog when the user requests to delete a bookmark folder that is non-empty, for the user to confirm. This involves a nested message loop, which means that additional changes can take place, including extensions modifying the bookmark tree. If the bookmark folder being modified by the user happens to be deleted (e.g. by an extension) while the confirmation dialog is open, prior to this patch, the code could dereference freed memory. In this patch, a safeguard is introduced to fix the issue, which is achieved by detecting problematic changes based on bookmark IDs (which are integers and never reused during the lifetime of the browser). (cherry picked from commit a453de0) Change-Id: Ife1d005f1b3d8d17b5b5d7c07b538732cd377e13 Bug: 1195278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2818022 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#871053} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2822158 Reviewed-by: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Prudhvi Kumar Bommana <pbommana@google.com> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Prudhvi Kumar Bommana <pbommana@google.com> Cr-Commit-Position: refs/branch-heads/4472@{chromium#43} Cr-Branched-From: 3d60439-refs/heads/master@{#870763}
blueboxd
referenced
this pull request
in blueboxd/chromium-legacy
Jun 24, 2021
https://chromium.googlesource.com/external/github.com/google/crc32c.git/+log/5998f8451548..fa5ade41ee48 This CL also updates BUILD.gn to reflect a header rename. $ git log 5998f8451..fa5ade41e --date=short --no-merges --format='%ad %ae %s' 2021-06-22 costan Fix compilation warnings on ARM64 with old GCC versions. (#52) 2021-06-20 cmumford Updated Travis-CI configuration. (#51) 2021-06-02 francois Fix GitHub links. (#50) 2020-12-13 costan Update Travis CI config. (#49) 2020-12-13 costan Updated third_party/ and Travis CI config. (#48) 2020-09-17 hjmallon Add support for ARM64 darwin (#43) 2020-08-18 rtobarc Remove unnecessary reinterpret_cast (chromium#42) 2020-06-18 github-sipa Fix (unused) ReadUint64LE for BE machines (#41) 2020-04-11 costan Bump dependencies. (#40) 2019-11-10 pwnall Move CI to Visual Studio 2019. 2019-11-10 pwnall Allow different C/C++ standards when this is used as a subproject. 2019-03-27 chfast CMake: Use configure_package_config_file() 2019-03-27 chfast CMake: Remove redundant usage of PROJECT_SOURCE_DIR 2019-11-04 pwnall Add comment ensuring include(GNUInstallDirs) stays where it should be. 2019-11-04 pwnall Bump dependencies. 2019-11-04 coryan Fix installed target definition. (chromium#39) 2019-03-27 chfast Test CMake installation on Travis. 2019-09-29 costan Update deps and Travis CI config. 2019-06-03 pwnall Fix regexp replacement in CMake config. 2019-05-23 pwnall Update dependencies. (#37) 2019-05-04 pwnall Set version and soversion in CMake. (#33) 2019-05-03 bramp Only set the POSITION_INDEPENDENT_CODE property when building a shard library (#34) 2019-04-29 costan Update Travis CI configuration. (chromium#36) 2019-03-01 costan Bump dependencies (#31) Created with: roll-dep src/third_party/crc32c/src Change-Id: Ia3a302dec4f829f6833e68f25951413febef9f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2981501 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by: Chris Mumford <cmumford@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#895358}
GrumpyOldTroll
pushed a commit
to GrumpyOldTroll/chromium
that referenced
this pull request
Jul 23, 2021
Change-Id: Ife6e7d3294322de61a08629e2f171bf10dc5c205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2917853 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4515@{chromium#43} Cr-Branched-From: 488fc70-refs/heads/master@{#885287}
GrumpyOldTroll
pushed a commit
to GrumpyOldTroll/chromium
that referenced
this pull request
Sep 4, 2021
Roll src/net/third_party/quiche/src/bf2d194d0..80f93811e (9 commits) https://quiche.googlesource.com/quiche.git/+log/bf2d194d095c..80f93811e1e6 $ git log bf2d194d0..80f93811e --date=short --no-merges --format='%ad %ae %s' 2021-07-19 haoyuewang Disable --gfe2_reloadable_flag_quic_ack_cid_frames in Chromium. 2021-07-19 haoyuewang Fix error: unknown type name 'uint' in Chromium merge. 2021-07-16 haoyuewang Fix tests broken by --gfe2_reloadable_flag_quic_ack_cid_frames 2021-07-16 dschinazi Disallow invalid MAX_PUSH_ID frame 2021-07-16 fayang Deprecate gfe2_reloadable_flag_quic_encrypted_control_frames. 2021-07-16 haoyuewang Update ACK timeout for NEW_CONNECTION_ID and RETIRE_CONNECTION_ID frames. 2021-07-16 wub In QUIC TlsServerHandshaker, only run DefaultSignatureCallback at most once. 2021-07-15 quiche-dev Internal change 2021-07-15 fayang Initialize data_buffer in PathChallenge and PathResponse frames to all 0s. Created manually by squashing the following three commits: https://crrev.com/c/3033823 https://crrev.com/c/3035301 https://crrev.com/c/3038819 Bug: 1229665 Change-Id: I8f5c81edd0e1a07a8676c91ab8575399ae19d4f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3039938 Reviewed-by: David Schinazi <dschinazi@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/branch-heads/4577@{chromium#43} Cr-Branched-From: 761ddde-refs/heads/master@{#902210}
nift4
pushed a commit
to nift4/chromium
that referenced
this pull request
Sep 22, 2021
Mark changeable document dialog title with |.dialog-msg-holder| for reflect title change as passing message argument when dialog open. Show NOT_DETECTIVE dialog when taking document photo with no document corners detected in result photo. (cherry picked from commit caaff0c) Bug: b:195905083 Test: Manually Change-Id: I8fcc1b47481ca2e7a25f81408e8b6cfdd5a0139c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3084762 Commit-Queue: Inker Kuo <inker@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Reviewed-by: Wei Lee <wtlee@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#911613} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3098994 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4606@{chromium#43} Cr-Branched-From: 35b0d5a-refs/heads/master@{#911515}
pull bot
referenced
this pull request
in FairyWorld/tool_chromium
Sep 25, 2021
This reverts commit 77e9679. Reason for revert: Likely cause of failure Step "browser_tests on Ubuntu-18.04" failing on builder "linux-chromeos-chrome" The failure is a crash in browser_tests. This failure is fairly but not perfectly consistent. In three of the last four runs on this bot, browser_tests failed with something in the NativeInputMethodEngineTest.EmojiSuggestion* suite. It's not always the same test that fails each time. Nevertheless, this is pretty indicative that nowadays something is wrong in this suite. This is the obvious candidate, submitted right when the test became mostly-failing. Here is the first failure as an example: Retrying 1 test (retry #0) [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUrlOrAppNotAllowed 2021-09-24T11:30:01.258384Z WARNING browser_tests[27592:27592]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. [434.616] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) 2021-09-24T11:30:01.293097Z WARNING browser_tests[27592:27609]: [wallpaper_decoder.cc(29)] Failed reading file 2021-09-24T11:30:01.304548Z ERROR browser_tests[27592:27592]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid 2021-09-24T11:30:01.309314Z ERROR browser_tests[27592:27592]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. 2021-09-24T11:30:01.332070Z WARNING browser_tests[27592:27592]: [remote_commands_service.cc(188)] Client is not registered. 2021-09-24T11:30:01.358975Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.359074Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB 2021-09-24T11:30:01.359110Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB 2021-09-24T11:30:01.359138Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.359147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB 2021-09-24T11:30:01.359429Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB 2021-09-24T11:30:01.359547Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB 2021-09-24T11:30:01.359581Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB 2021-09-24T11:30:01.359621Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB 2021-09-24T11:30:01.360073Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB 2021-09-24T11:30:01.360118Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB 2021-09-24T11:30:01.360147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.360161Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.360173Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.360234Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.360415Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB 2021-09-24T11:30:01.361882Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB 2021-09-24T11:30:01.361936Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB 2021-09-24T11:30:01.361964Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB 2021-09-24T11:30:01.362091Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.412518Z ERROR browser_tests[27592:27592]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? 2021-09-24T11:30:01.433615Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. 2021-09-24T11:30:01.451071Z WARNING browser_tests[27592:27592]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 2021-09-24T11:30:01.458878Z WARNING browser_tests[27592:27592]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data 2021-09-24T11:30:01.464809Z INFO browser_tests[27592:27592]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found 2021-09-24T11:30:01.470495Z INFO browser_tests[27592:27592]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ 2021-09-24T11:30:01.473373Z WARNING browser_tests[27592:27639]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE 2021-09-24T11:30:01.535229Z ERROR browser_tests[27592:27639]: [als_reader.cc(52)] Missing num of als 2021-09-24T11:30:01.535643Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. 2021-09-24T11:30:01.535680Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. 2021-09-24T11:30:01.535688Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. 2021-09-24T11:30:01.535695Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. 2021-09-24T11:30:01.555145Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x556151f72449 base::debug::CollectStackTrace() #1 0x556151ed9d73 base::debug::StackTrace::StackTrace() #2 0x5561525e4683 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f7dd56e2040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) #4 0x5561556c8304 ChromeOmniboxNavigationObserver::DidFinishNavigation() #5 0x5561503c8362 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() #6 0x5561503d05f0 content::WebContentsImpl::DidFinishNavigation() #7 0x5561502a5093 content::NavigationRequest::~NavigationRequest() #8 0x5561502a59dc content::NavigationRequest::~NavigationRequest() #9 0x5561502b8919 content::Navigator::DidNavigate() #10 0x5561502caeed content::RenderFrameHostImpl::DidCommitNavigationInternal() #11 0x5561502ca24a content::RenderFrameHostImpl::DidCommitNavigation() #12 0x5561502e9d60 base::internal::FunctorTraits<>::Invoke<>() #13 0x5561502e9d0f base::internal::Invoker<>::RunOnce() #14 0x55614fd53470 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() #15 0x55615301c6e0 mojo::InterfaceEndpointClient::HandleValidatedMessage() #16 0x5561530201e0 mojo::MessageDispatcher::Accept() #17 0x55615301d435 mojo::InterfaceEndpointClient::HandleIncomingMessage() #18 0x5561531dc3e2 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() #19 0x55615301e323 base::internal::Invoker<>::RunOnce() #20 0x556151f35f23 base::TaskAnnotator::RunTask() #21 0x556151f467b3 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #22 0x556151f46569 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #23 0x556151f46b32 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #24 0x556151fa9c4b base::MessagePumpLibevent::Run() #25 0x556151f46d6d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #26 0x556151f18c1b base::RunLoop::Run() #27 0x556151ec159d InProcessBrowserTest::RunUntilBrowserProcessQuits() #28 0x556151ec207f InProcessBrowserTest::QuitBrowsers() #29 0x556151ec1fce InProcessBrowserTest::PostRunTestOnMainThread() #30 0x5561525e3d34 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #31 0x556152012479 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #32 0x55615201197e ChromeBrowserMainParts::PreMainMessageLoopRun() #33 0x55614efa9b98 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #34 0x5561500381cd content::BrowserMainLoop::PreMainMessageLoopRun() #35 0x5561503a1a9c content::StartupTaskRunner::RunAllTasksNow() #36 0x556150037e4a content::BrowserMainLoop::CreateStartupTasks() #37 0x55615003a147 content::BrowserMainRunnerImpl::Initialize() #38 0x556150036912 content::BrowserMain() #39 0x556150bf6aed content::RunBrowserProcessMain() #40 0x556150bf79bd content::ContentMainRunnerImpl::RunBrowser() #41 0x556150bf752e content::ContentMainRunnerImpl::Run() #42 0x556150bf5b38 content::RunContentProcess() #43 0x556150bf5c08 content::ContentMain() #44 0x5561525e3543 content::BrowserTestBase::SetUp() #45 0x556151ec12c1 InProcessBrowserTest::SetUp() #46 0x55614e1c8786 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() #47 0x55614f308e8f testing::Test::Run() #48 0x55614f3097c5 testing::TestInfo::Run() #49 0x55614f309f21 testing::TestSuite::Run() #50 0x55614f313798 testing::internal::UnitTestImpl::RunAllTests() #51 0x55614f31338b testing::UnitTest::Run() #52 0x556151fd7ff2 base::TestSuite::Run() #53 0x556151e96409 BrowserTestSuiteRunnerChromeOS::RunTestSuite() #54 0x556152613c1f content::LaunchTests() #55 0x556151e98224 LaunchChromeTests() #56 0x556151e9638b main #57 0x7f7dd56c4bf7 __libc_start_main #58 0x55614cca11ea _start from https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17628 Here is the fourth: (different test in the same suite, different stack trace): [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUserSettingsOff 2021-09-24T16:19:05.593039Z WARNING browser_tests[31407:31407]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. [959.207] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) 2021-09-24T16:19:05.646514Z WARNING browser_tests[31407:31423]: [wallpaper_decoder.cc(29)] Failed reading file 2021-09-24T16:19:05.673272Z ERROR browser_tests[31407:31407]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid 2021-09-24T16:19:05.678360Z ERROR browser_tests[31407:31407]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. 2021-09-24T16:19:05.728926Z WARNING browser_tests[31407:31407]: [remote_commands_service.cc(188)] Client is not registered. 2021-09-24T16:19:05.763864Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.763999Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB 2021-09-24T16:19:05.764049Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB 2021-09-24T16:19:05.764094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.764120Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB 2021-09-24T16:19:05.764270Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB 2021-09-24T16:19:05.764446Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB 2021-09-24T16:19:05.765718Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB 2021-09-24T16:19:05.765751Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB 2021-09-24T16:19:05.766067Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB 2021-09-24T16:19:05.766094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB 2021-09-24T16:19:05.766115Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.766123Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.766131Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.766199Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.766336Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LocalStorage: 0MB 2021-09-24T16:19:05.766472Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB 2021-09-24T16:19:05.766498Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB 2021-09-24T16:19:05.766524Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB 2021-09-24T16:19:05.766552Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB 2021-09-24T16:19:05.766909Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.880798Z ERROR browser_tests[31407:31407]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? 2021-09-24T16:19:05.921761Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. 2021-09-24T16:19:05.932877Z WARNING browser_tests[31407:31407]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 2021-09-24T16:19:05.951965Z WARNING browser_tests[31407:31407]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data 2021-09-24T16:19:05.973007Z INFO browser_tests[31407:31407]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found 2021-09-24T16:19:05.977396Z WARNING browser_tests[31407:31428]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE 2021-09-24T16:19:05.981581Z INFO browser_tests[31407:31407]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ 2021-09-24T16:19:06.072941Z ERROR browser_tests[31407:31457]: [als_reader.cc(52)] Missing num of als 2021-09-24T16:19:06.073283Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. 2021-09-24T16:19:06.073310Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. 2021-09-24T16:19:06.073337Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. 2021-09-24T16:19:06.073358Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. 2021-09-24T16:19:06.085536Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x564f24b8af29 base::debug::CollectStackTrace() #1 0x564f24af2843 base::debug::StackTrace::StackTrace() #2 0x564f251fd373 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f03d338d040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) #4 0x564f282e0d94 ChromeOmniboxNavigationObserver::DidFinishNavigation() #5 0x564f22fe1042 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() #6 0x564f22fe92d0 content::WebContentsImpl::DidFinishNavigation() #7 0x564f22ebdd73 content::NavigationRequest::~NavigationRequest() #8 0x564f22ebe6bc content::NavigationRequest::~NavigationRequest() #9 0x564f22ed15f9 content::Navigator::DidNavigate() #10 0x564f22ee3bcd content::RenderFrameHostImpl::DidCommitNavigationInternal() #11 0x564f22ee2f2a content::RenderFrameHostImpl::DidCommitNavigation() #12 0x564f22f02a40 base::internal::FunctorTraits<>::Invoke<>() #13 0x564f22f029ef base::internal::Invoker<>::RunOnce() #14 0x564f2296c430 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() #15 0x564f25c35100 mojo::InterfaceEndpointClient::HandleValidatedMessage() #16 0x564f25c38c00 mojo::MessageDispatcher::Accept() #17 0x564f25c35e55 mojo::InterfaceEndpointClient::HandleIncomingMessage() #18 0x564f25df4e02 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() #19 0x564f25c36d43 base::internal::Invoker<>::RunOnce() #20 0x564f24b4ea03 base::TaskAnnotator::RunTask() #21 0x564f24b5f293 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #22 0x564f24b5f049 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #23 0x564f24b5f612 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #24 0x564f24bc28cb base::MessagePumpLibevent::Run() #25 0x564f24b5f84d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #26 0x564f24b316fb base::RunLoop::Run() #27 0x564f22f433f3 content::BrowserTaskExecutor::RunAllPendingTasksOnThreadForTesting() #28 0x564f2522df45 content::RunAllPendingInMessageLoop() #29 0x564f24adaa96 InProcessBrowserTest::PostRunTestOnMainThread() #30 0x564f251fca24 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #31 0x564f24c2b0f9 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #32 0x564f24c2a5fe ChromeBrowserMainParts::PreMainMessageLoopRun() #33 0x564f21bc1f38 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #34 0x564f22c510ed content::BrowserMainLoop::PreMainMessageLoopRun() #35 0x564f22fba77c content::StartupTaskRunner::RunAllTasksNow() #36 0x564f22c50d6a content::BrowserMainLoop::CreateStartupTasks() #37 0x564f22c53067 content::BrowserMainRunnerImpl::Initialize() #38 0x564f22c4f832 content::BrowserMain() #39 0x564f2380f5bd content::RunBrowserProcessMain() #40 0x564f2381048d content::ContentMainRunnerImpl::RunBrowser() #41 0x564f2380fffe content::ContentMainRunnerImpl::Run() #42 0x564f2380e608 content::RunContentProcess() #43 0x564f2380e6d8 content::ContentMain() #44 0x564f251fc233 content::BrowserTestBase::SetUp() #45 0x564f24ad9d91 InProcessBrowserTest::SetUp() #46 0x564f20de0a86 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() #47 0x564f21f21e4f testing::Test::Run() #48 0x564f21f22785 testing::TestInfo::Run() #49 0x564f21f22ee1 testing::TestSuite::Run() #50 0x564f21f2c758 testing::internal::UnitTestImpl::RunAllTests() #51 0x564f21f2c34b testing::UnitTest::Run() #52 0x564f24bf0c72 base::TestSuite::Run() #53 0x564f24aaeed9 BrowserTestSuiteRunnerChromeOS::RunTestSuite() #54 0x564f2522c62f content::LaunchTests() #55 0x564f24ab0cf4 LaunchChromeTests() #56 0x564f24aaee5b main #57 0x7f03d336fbf7 __libc_start_main #58 0x564f1f8b94ea _start from https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17631 Original change's description: > Privatise unnecessarily public current_input_method in > InputMethodManagerImpl::StateImpl. > > This involves replacing some direct pokes of current_input_method > with public GetCurrentInputMethod() that employs a fallback onto > InputMethodUtil::GetFallbackInputMethodDescriptor() when ID is > blank. This should be more reasonable and consistent. > > Bug: 1134465 > Change-Id: I2c423a58547cc7249efdf8056624623998765aba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3177760 > Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> > Reviewed-by: Keith Lee <keithlee@chromium.org> > Reviewed-by: Curtis McMullan <curtismcmullan@chromium.org> > Cr-Commit-Position: refs/heads/main@{#924702} Bug: 1134465 Change-Id: I6144a0ebd7472f31d4b937d9e99b6a6c8bc0eee1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182806 Auto-Submit: Mark Pearson <mpearson@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Mark Pearson <mpearson@chromium.org> Owners-Override: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/main@{#924810}
pull bot
referenced
this pull request
in luojiguicai/chromium
Sep 27, 2021
This reverts commit 37ea471. Reason for revert: Reverted CL is unrelated to the cited "reason for revert". Original change's description: > Revert "Privatise unnecessarily public current_input_method in" > > This reverts commit 77e9679. > > Reason for revert: > Likely cause of failure > Step "browser_tests on Ubuntu-18.04" failing on builder "linux-chromeos-chrome" > > The failure is a crash in browser_tests. > > This failure is fairly but not perfectly consistent. In three of the last four runs on this bot, browser_tests failed with something in the NativeInputMethodEngineTest.EmojiSuggestion* suite. It's not always the same test that fails each time. Nevertheless, this is pretty indicative that nowadays something is wrong in this suite. This is the obvious candidate, submitted right when the test became mostly-failing. > > Here is the first failure as an example: > Retrying 1 test (retry #0) > [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUrlOrAppNotAllowed > 2021-09-24T11:30:01.258384Z WARNING browser_tests[27592:27592]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. > [434.616] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) > 2021-09-24T11:30:01.293097Z WARNING browser_tests[27592:27609]: [wallpaper_decoder.cc(29)] Failed reading file > 2021-09-24T11:30:01.304548Z ERROR browser_tests[27592:27592]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid > 2021-09-24T11:30:01.309314Z ERROR browser_tests[27592:27592]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. > 2021-09-24T11:30:01.332070Z WARNING browser_tests[27592:27592]: [remote_commands_service.cc(188)] Client is not registered. > 2021-09-24T11:30:01.358975Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.359074Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB > 2021-09-24T11:30:01.359110Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB > 2021-09-24T11:30:01.359138Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.359147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB > 2021-09-24T11:30:01.359429Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB > 2021-09-24T11:30:01.359547Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB > 2021-09-24T11:30:01.359581Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB > 2021-09-24T11:30:01.359621Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB > 2021-09-24T11:30:01.360073Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB > 2021-09-24T11:30:01.360118Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB > 2021-09-24T11:30:01.360147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360161Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360173Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360234Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360415Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB > 2021-09-24T11:30:01.361882Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB > 2021-09-24T11:30:01.361936Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB > 2021-09-24T11:30:01.361964Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB > 2021-09-24T11:30:01.362091Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.412518Z ERROR browser_tests[27592:27592]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? > 2021-09-24T11:30:01.433615Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. > 2021-09-24T11:30:01.451071Z WARNING browser_tests[27592:27592]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 > 2021-09-24T11:30:01.458878Z WARNING browser_tests[27592:27592]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data > 2021-09-24T11:30:01.464809Z INFO browser_tests[27592:27592]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found > 2021-09-24T11:30:01.470495Z INFO browser_tests[27592:27592]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ > 2021-09-24T11:30:01.473373Z WARNING browser_tests[27592:27639]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE > 2021-09-24T11:30:01.535229Z ERROR browser_tests[27592:27639]: [als_reader.cc(52)] Missing num of als > 2021-09-24T11:30:01.535643Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. > 2021-09-24T11:30:01.535680Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. > 2021-09-24T11:30:01.535688Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. > 2021-09-24T11:30:01.535695Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. > 2021-09-24T11:30:01.555145Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. > BrowserTestBase received signal: Segmentation fault. Backtrace: > #0 0x556151f72449 base::debug::CollectStackTrace() > #1 0x556151ed9d73 base::debug::StackTrace::StackTrace() > #2 0x5561525e4683 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #3 0x7f7dd56e2040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) > #4 0x5561556c8304 ChromeOmniboxNavigationObserver::DidFinishNavigation() > #5 0x5561503c8362 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() > #6 0x5561503d05f0 content::WebContentsImpl::DidFinishNavigation() > #7 0x5561502a5093 content::NavigationRequest::~NavigationRequest() > #8 0x5561502a59dc content::NavigationRequest::~NavigationRequest() > #9 0x5561502b8919 content::Navigator::DidNavigate() > #10 0x5561502caeed content::RenderFrameHostImpl::DidCommitNavigationInternal() > #11 0x5561502ca24a content::RenderFrameHostImpl::DidCommitNavigation() > #12 0x5561502e9d60 base::internal::FunctorTraits<>::Invoke<>() > #13 0x5561502e9d0f base::internal::Invoker<>::RunOnce() > #14 0x55614fd53470 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() > #15 0x55615301c6e0 mojo::InterfaceEndpointClient::HandleValidatedMessage() > #16 0x5561530201e0 mojo::MessageDispatcher::Accept() > #17 0x55615301d435 mojo::InterfaceEndpointClient::HandleIncomingMessage() > #18 0x5561531dc3e2 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() > #19 0x55615301e323 base::internal::Invoker<>::RunOnce() > #20 0x556151f35f23 base::TaskAnnotator::RunTask() > #21 0x556151f467b3 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() > #22 0x556151f46569 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #23 0x556151f46b32 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #24 0x556151fa9c4b base::MessagePumpLibevent::Run() > #25 0x556151f46d6d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() > #26 0x556151f18c1b base::RunLoop::Run() > #27 0x556151ec159d InProcessBrowserTest::RunUntilBrowserProcessQuits() > #28 0x556151ec207f InProcessBrowserTest::QuitBrowsers() > #29 0x556151ec1fce InProcessBrowserTest::PostRunTestOnMainThread() > #30 0x5561525e3d34 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() > #31 0x556152012479 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() > #32 0x55615201197e ChromeBrowserMainParts::PreMainMessageLoopRun() > #33 0x55614efa9b98 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() > #34 0x5561500381cd content::BrowserMainLoop::PreMainMessageLoopRun() > #35 0x5561503a1a9c content::StartupTaskRunner::RunAllTasksNow() > #36 0x556150037e4a content::BrowserMainLoop::CreateStartupTasks() > #37 0x55615003a147 content::BrowserMainRunnerImpl::Initialize() > #38 0x556150036912 content::BrowserMain() > #39 0x556150bf6aed content::RunBrowserProcessMain() > #40 0x556150bf79bd content::ContentMainRunnerImpl::RunBrowser() > #41 0x556150bf752e content::ContentMainRunnerImpl::Run() > #42 0x556150bf5b38 content::RunContentProcess() > #43 0x556150bf5c08 content::ContentMain() > #44 0x5561525e3543 content::BrowserTestBase::SetUp() > #45 0x556151ec12c1 InProcessBrowserTest::SetUp() > #46 0x55614e1c8786 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() > #47 0x55614f308e8f testing::Test::Run() > #48 0x55614f3097c5 testing::TestInfo::Run() > #49 0x55614f309f21 testing::TestSuite::Run() > #50 0x55614f313798 testing::internal::UnitTestImpl::RunAllTests() > #51 0x55614f31338b testing::UnitTest::Run() > #52 0x556151fd7ff2 base::TestSuite::Run() > #53 0x556151e96409 BrowserTestSuiteRunnerChromeOS::RunTestSuite() > #54 0x556152613c1f content::LaunchTests() > #55 0x556151e98224 LaunchChromeTests() > #56 0x556151e9638b main > #57 0x7f7dd56c4bf7 __libc_start_main > #58 0x55614cca11ea _start > from > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17628 > > Here is the fourth: (different test in the same suite, different stack trace): > [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUserSettingsOff > 2021-09-24T16:19:05.593039Z WARNING browser_tests[31407:31407]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. > [959.207] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) > 2021-09-24T16:19:05.646514Z WARNING browser_tests[31407:31423]: [wallpaper_decoder.cc(29)] Failed reading file > 2021-09-24T16:19:05.673272Z ERROR browser_tests[31407:31407]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid > 2021-09-24T16:19:05.678360Z ERROR browser_tests[31407:31407]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. > 2021-09-24T16:19:05.728926Z WARNING browser_tests[31407:31407]: [remote_commands_service.cc(188)] Client is not registered. > 2021-09-24T16:19:05.763864Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.763999Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB > 2021-09-24T16:19:05.764049Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB > 2021-09-24T16:19:05.764094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.764120Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB > 2021-09-24T16:19:05.764270Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB > 2021-09-24T16:19:05.764446Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB > 2021-09-24T16:19:05.765718Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB > 2021-09-24T16:19:05.765751Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB > 2021-09-24T16:19:05.766067Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB > 2021-09-24T16:19:05.766094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB > 2021-09-24T16:19:05.766115Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766123Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766131Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766199Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766336Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LocalStorage: 0MB > 2021-09-24T16:19:05.766472Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB > 2021-09-24T16:19:05.766498Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB > 2021-09-24T16:19:05.766524Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB > 2021-09-24T16:19:05.766552Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB > 2021-09-24T16:19:05.766909Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.880798Z ERROR browser_tests[31407:31407]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? > 2021-09-24T16:19:05.921761Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. > 2021-09-24T16:19:05.932877Z WARNING browser_tests[31407:31407]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 > 2021-09-24T16:19:05.951965Z WARNING browser_tests[31407:31407]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data > 2021-09-24T16:19:05.973007Z INFO browser_tests[31407:31407]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found > 2021-09-24T16:19:05.977396Z WARNING browser_tests[31407:31428]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE > 2021-09-24T16:19:05.981581Z INFO browser_tests[31407:31407]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ > 2021-09-24T16:19:06.072941Z ERROR browser_tests[31407:31457]: [als_reader.cc(52)] Missing num of als > 2021-09-24T16:19:06.073283Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. > 2021-09-24T16:19:06.073310Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. > 2021-09-24T16:19:06.073337Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. > 2021-09-24T16:19:06.073358Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. > 2021-09-24T16:19:06.085536Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. > BrowserTestBase received signal: Segmentation fault. Backtrace: > #0 0x564f24b8af29 base::debug::CollectStackTrace() > #1 0x564f24af2843 base::debug::StackTrace::StackTrace() > #2 0x564f251fd373 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #3 0x7f03d338d040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) > #4 0x564f282e0d94 ChromeOmniboxNavigationObserver::DidFinishNavigation() > #5 0x564f22fe1042 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() > #6 0x564f22fe92d0 content::WebContentsImpl::DidFinishNavigation() > #7 0x564f22ebdd73 content::NavigationRequest::~NavigationRequest() > #8 0x564f22ebe6bc content::NavigationRequest::~NavigationRequest() > #9 0x564f22ed15f9 content::Navigator::DidNavigate() > #10 0x564f22ee3bcd content::RenderFrameHostImpl::DidCommitNavigationInternal() > #11 0x564f22ee2f2a content::RenderFrameHostImpl::DidCommitNavigation() > #12 0x564f22f02a40 base::internal::FunctorTraits<>::Invoke<>() > #13 0x564f22f029ef base::internal::Invoker<>::RunOnce() > #14 0x564f2296c430 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() > #15 0x564f25c35100 mojo::InterfaceEndpointClient::HandleValidatedMessage() > #16 0x564f25c38c00 mojo::MessageDispatcher::Accept() > #17 0x564f25c35e55 mojo::InterfaceEndpointClient::HandleIncomingMessage() > #18 0x564f25df4e02 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() > #19 0x564f25c36d43 base::internal::Invoker<>::RunOnce() > #20 0x564f24b4ea03 base::TaskAnnotator::RunTask() > #21 0x564f24b5f293 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() > #22 0x564f24b5f049 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #23 0x564f24b5f612 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #24 0x564f24bc28cb base::MessagePumpLibevent::Run() > #25 0x564f24b5f84d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() > #26 0x564f24b316fb base::RunLoop::Run() > #27 0x564f22f433f3 content::BrowserTaskExecutor::RunAllPendingTasksOnThreadForTesting() > #28 0x564f2522df45 content::RunAllPendingInMessageLoop() > #29 0x564f24adaa96 InProcessBrowserTest::PostRunTestOnMainThread() > #30 0x564f251fca24 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() > #31 0x564f24c2b0f9 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() > #32 0x564f24c2a5fe ChromeBrowserMainParts::PreMainMessageLoopRun() > #33 0x564f21bc1f38 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() > #34 0x564f22c510ed content::BrowserMainLoop::PreMainMessageLoopRun() > #35 0x564f22fba77c content::StartupTaskRunner::RunAllTasksNow() > #36 0x564f22c50d6a content::BrowserMainLoop::CreateStartupTasks() > #37 0x564f22c53067 content::BrowserMainRunnerImpl::Initialize() > #38 0x564f22c4f832 content::BrowserMain() > #39 0x564f2380f5bd content::RunBrowserProcessMain() > #40 0x564f2381048d content::ContentMainRunnerImpl::RunBrowser() > #41 0x564f2380fffe content::ContentMainRunnerImpl::Run() > #42 0x564f2380e608 content::RunContentProcess() > #43 0x564f2380e6d8 content::ContentMain() > #44 0x564f251fc233 content::BrowserTestBase::SetUp() > #45 0x564f24ad9d91 InProcessBrowserTest::SetUp() > #46 0x564f20de0a86 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() > #47 0x564f21f21e4f testing::Test::Run() > #48 0x564f21f22785 testing::TestInfo::Run() > #49 0x564f21f22ee1 testing::TestSuite::Run() > #50 0x564f21f2c758 testing::internal::UnitTestImpl::RunAllTests() > #51 0x564f21f2c34b testing::UnitTest::Run() > #52 0x564f24bf0c72 base::TestSuite::Run() > #53 0x564f24aaeed9 BrowserTestSuiteRunnerChromeOS::RunTestSuite() > #54 0x564f2522c62f content::LaunchTests() > #55 0x564f24ab0cf4 LaunchChromeTests() > #56 0x564f24aaee5b main > #57 0x7f03d336fbf7 __libc_start_main > #58 0x564f1f8b94ea _start > from > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17631 > > Original change's description: > > Privatise unnecessarily public current_input_method in > > InputMethodManagerImpl::StateImpl. > > > > This involves replacing some direct pokes of current_input_method > > with public GetCurrentInputMethod() that employs a fallback onto > > InputMethodUtil::GetFallbackInputMethodDescriptor() when ID is > > blank. This should be more reasonable and consistent. > > > > Bug: 1134465 > > Change-Id: I2c423a58547cc7249efdf8056624623998765aba > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3177760 > > Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> > > Reviewed-by: Keith Lee <keithlee@chromium.org> > > Reviewed-by: Curtis McMullan <curtismcmullan@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#924702} > > Bug: 1134465 > Change-Id: I6144a0ebd7472f31d4b937d9e99b6a6c8bc0eee1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182806 > Auto-Submit: Mark Pearson <mpearson@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Mark Pearson <mpearson@chromium.org> > Owners-Override: Mark Pearson <mpearson@chromium.org> > Cr-Commit-Position: refs/heads/main@{#924810} Bug: 1134465 Change-Id: I358d66835e54d67d8d151e3da38da9a8f33d83bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184801 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/main@{#925158}
farfromgrace
pushed a commit
to farfromgrace/chromium
that referenced
this pull request
Feb 9, 2022
Take a local copy of UserMediaProcessor::local_sources_ when iterating over it in UserMediaProcessor::DetermineExistingAudioSessionId, as the list can be effectively concurrently modified during destruction of MediaStreamTracks triggered by GC during this loop. Without the copy this leads to a container overflow. (cherry picked from commit fb6232f) Bug: 1238209 Change-Id: I048387a51a58eacff87d220e6b67d2d09f610c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320283 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Tony Herre <toprice@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#950499} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336878 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/branch-heads/4758@{chromium#43} Cr-Branched-From: 4a2cf4b-refs/heads/main@{#950365}
GrumpyOldTroll
pushed a commit
to GrumpyOldTroll/chromium
that referenced
this pull request
Mar 3, 2022
(cherry picked from commit 292311b) Bug: 1289378 Change-Id: I4e003f15f9f01e9846a7d7083d9c64b0dca39276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3405565 Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Muyao Xu <muyaoxu@google.com> Cr-Original-Commit-Position: refs/heads/main@{#962558} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3415119 Cr-Commit-Position: refs/branch-heads/4844@{chromium#43} Cr-Branched-From: 007241c-refs/heads/main@{#961656}
darinwf
pushed a commit
to neevaco/chromium
that referenced
this pull request
Apr 19, 2022
Change-Id: Iebf3916783c5c41c50cb42ae17e52f59422b7e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3483838 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4896@{chromium#43} Cr-Branched-From: 1f63ff4-refs/heads/main@{#972766}
fujunwei
pushed a commit
to fujunwei/chromium
that referenced
this pull request
Apr 22, 2022
This CL will update cros image version for skylab tests. CROS_BOARD_LKGM is updated according to chromeos/CHROMEOS_LKGM; CROS_BOARD_DEV, CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha. If this CL caused regressions, please revert and pause the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org, liaoyuke@chromium.org, yjt@google.com. R=rubber-stamper@appspot.gserviceaccount.com Requires-Testing: True Change-Id: I785ff63d5764d4db6fe84f7c5e2c815467b586e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3595360 Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5005@{chromium#43} Cr-Branched-From: 5b4d945-refs/heads/main@{#992738}
pkviet
pushed a commit
to pkviet/chromium
that referenced
this pull request
Jun 4, 2022
Enable CrAS-based System AEC/APM on LaCrOS by porting the existing logic from audio_manager_chromeos to audio_manager_cras. To be specific the functions covered in two prior CLs: (1) https://chromium-review.googlesource.com/c/chromium/src/+/2782443 Allow Chrome to talk to Chrome OS to enable audio processing functionalities (AEC, AGC, NS) in CrAS. Through new flags via finch experimentation. (2) https://chromium-review.googlesource.com/c/chromium/src/+/3475131 Adds the control logic in Chrome to provide finch-control over the AEC, NS and AGC, DSP effects in CrAS, allowing safe fallbacks to the browser counterparts. BUG=b:205074860 (cherry picked from commit e46eb59) Change-Id: I1b5af08d4b763b1fcecd4fda1264d5d667cd8992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3535499 Reviewed-by: Henrik Andreasson <henrika@chromium.org> Reviewed-by: Per Åhgren <peah@chromium.org> Reviewed-by: Olga Sharonova <olka@chromium.org> Reviewed-by: Hsinyu Chao <hychao@chromium.org> Commit-Queue: Hsinyu Chao <hychao@chromium.org> Auto-Submit: Hsinyu Chao <hychao@chromium.org> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#982686} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3539606 Cr-Commit-Position: refs/branch-heads/4951@{chromium#43} Cr-Branched-From: 27de622-refs/heads/main@{#982481}
pkviet
pushed a commit
to pkviet/chromium
that referenced
this pull request
Jun 6, 2022
…ion" This is a reland of commit 31f14a5 Original issue was with the test, production code OK. In some build configs not all events related to close appeared to be queued sync. CL adjusts logic to wait for final close report, and then element logic update. Original change's description: > Privacy Sandbox Settings: Pipe cr-dialog close to close function > > Previously only button closes in the modal dialogs correctly updated > the view state on the Privacy Sandbox settings page. > > This CL adjusts logic so that closes handled by the dialog element, > such as via ESC, also correctly update the logic. > > Bug: 1324926 > Change-Id: Ic155464779814f5fd3b19448acda1c97da096e5f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3644568 > Reviewed-by: Olesia Marukhno <olesiamarukhno@google.com> > Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> > Cr-Commit-Position: refs/heads/main@{#1002654} (cherry picked from commit 86eb5c7) Bug: 1324926 Change-Id: Idda949e93aea430779950a14fcb9e520dd618329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3645074 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by: Olesia Marukhno <olesiamarukhno@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1003090} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3650612 Auto-Submit: Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5060@{chromium#43} Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
darinwf
pushed a commit
to neevaco/chromium
that referenced
this pull request
Aug 10, 2022
Fix the crash caused by incorrectly handling PasswordStore backend error on non-Android platforms. Empty changelist was used to indicate errors here and should not be replaced by the absl::nullopt which is used on Andorid to indicate a success operation with inability to fetch its result. There is a tracking bug for explicit error handling: crbug.com/1321051 (cherry picked from commit 93fc637) Bug: 1335681 Change-Id: Ia06bba841e584c5ce94ac6f80c42769dfbc3cd2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3702374 Commit-Queue: Maxim Anufriev <maxan@google.com> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1013415} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3702436 Auto-Submit: Maxim Anufriev <maxan@google.com> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/branch-heads/5112@{chromium#43} Cr-Branched-From: b13d3fe-refs/heads/main@{#1012729}
beasonxu
pushed a commit
to ipxbro/chromium
that referenced
this pull request
Sep 3, 2022
Previously, we just started from scratch with the current query. This should be more performant and avoids losing scroll state. (cherry picked from commit 62706b7) Bug: 1303171, 1346692 Change-Id: Id736a304f440613bf61435b400526a98c01baa99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3781695 Reviewed-by: Gang Wu <gangwu@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1027863} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3788399 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5195@{chromium#43} Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
MaoHan001
pushed a commit
to riscv-android-src/chromium
that referenced
this pull request
Jan 17, 2023
Previously kHadBiometricsAvailable was recorded when clicking on a suggestion, which is wrong. (cherry picked from commit 3d3c6f0) Fixed: 1382748 Change-Id: I1a05fa50ea25acd90d431fb5c8f99326fcaf79af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4020380 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1070229} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4021047 Cr-Commit-Position: refs/branch-heads/5414@{chromium#43} Cr-Branched-From: 4417ee5-refs/heads/main@{#1070088}
wwwppp0801
pushed a commit
to wwwppp0801/chromium
that referenced
this pull request
Feb 13, 2023
… different display." This is a reland of commit 5dba31b Original change's description: > Don't overwrite NEW_POPUP disposition on Mac when targeting a different display. > > Bug: 1394794 > Change-Id: I8a2b3afe9786e6a5e6a1055b15efa5efdf4b15d5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4117574 > Reviewed-by: Mike Wasserman <msw@chromium.org> > Commit-Queue: Mike Wasserman <msw@chromium.org> > Auto-Submit: Brad Triebwasser <btriebw@chromium.org> > Commit-Queue: Brad Triebwasser <btriebw@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1085536} (cherry picked from commit 16aeb9c) Bug: 1394794, 1402805 Change-Id: I50ca68103d8763bff697a51d00e7dfe39182fa50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119011 Commit-Queue: Mike Wasserman <msw@chromium.org> Commit-Queue: Brad Triebwasser <btriebw@chromium.org> Auto-Submit: Brad Triebwasser <btriebw@chromium.org> Reviewed-by: Mike Wasserman <msw@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1085703} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4121514 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Mike Wasserman <msw@chromium.org> Cr-Commit-Position: refs/branch-heads/5481@{chromium#43} Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
chirayudesai
pushed a commit
to chirayudesai/chromium
that referenced
this pull request
Mar 7, 2023
This CL adds V8.ProduceCodeCache UMA to measure the duration of ProduceCacheInternal. This metric is only recorded when ProduceCacheOptions is kProduceCodeCache. This metric can be useful to estimate the impact of the CacheCodeOnIdle feature. (cherry picked from commit 608248a) Bug: 1410082 Bug: 1260908 Change-Id: Ia90dce325961c2690a5c4bd20fb83ab5d33cc56a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4191623 Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1097708} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4202787 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/branch-heads/5563@{chromium#43} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
calyxos-gerrit
pushed a commit
to CalyxOS/chromium
that referenced
this pull request
Mar 31, 2023
These have hit on DCHECK builds in the wild and precede erasing or dereferencing an iterator that is UB. This CL excludes DCHECK failures that precede non-DCHECK handling of the it != end() failures. Those should probably be rewritten as CHECKs but are less urgent and semi-orthogonal. Known crashes (one per file) are: crash/dc49e3cadab36d4c crash/0ee3427d25937024 crash/b89303e84d123019 crash/cc35183b861a4992 (cherry picked from commit 1aec0b2) Bug: 1418734 Change-Id: I81ed7b45be33769e250c65c8bb7334a34be4380e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4288168 Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Reviewed-by: Dana Fried <dfried@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1109350} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4296062 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Prudhvikumar Bommana <pbommana@google.com> Cr-Commit-Position: refs/branch-heads/5615@{chromium#43} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
l0hn
pushed a commit
to l0hn/chromium_test
that referenced
this pull request
Jun 9, 2023
This CL fixes the current implementation and delays the appearance of the tooltip. (cherry picked from commit 03401f4) Fixed: 1433689 Change-Id: I4412281141cf9a0333bed31fea2893cb970c222e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4477070 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1135943} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4484362 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/branch-heads/5735@{chromium#43} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
msizanoen1
pushed a commit
to qtmlabs/chromium
that referenced
this pull request
Jun 24, 2023
Intent to experiment: https://groups.google.com/u/1/a/chromium.org/g/blink-dev/c/JBTWXSHE8M0?pli=1 The trial has started on the dashboard [1], but we forgot to enable the feature that checks the trial token. [1] https://developer.chrome.com/origintrials/#/view_trial/1827335548805578753 (cherry picked from commit 8aa45c1) Bug: 1221127 Change-Id: Ib25ba0144d0cd324c3323ce3cd6c358749318656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4640221 Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Jonathan Hao <phao@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1161696} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4637891 Auto-Submit: Jonathan Hao <phao@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/branch-heads/5845@{chromium#43} Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
aetota61
pushed a commit
to monkbrowser/monk-browser
that referenced
this pull request
Aug 2, 2023
Land after approval on https://crbug.com/1440324 (cherry picked from commit 67065b6) Change-Id: I5fa45be85f1c6c2fbbf68f1e000ece362dbba780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4563362 Auto-Submit: edchin <edchin@google.com> Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@google.com> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1148863} Bug: 1440324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4565016 Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/5790@{chromium#43} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
vuzix-jeff
pushed a commit
to Vuzix/chromium
that referenced
this pull request
Nov 3, 2023
Change-Id: I66a224aa3f8673d0cd8d9f47556c13cf21f9afc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4914413 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6045@{chromium#43} Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
Aikoyori
referenced
this pull request
in Pissandshittium/pissandshittium
Dec 8, 2023
Change-Id: I2d1f334ffc6533c4cfd92ace9c1eca86ca001d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4994370 Auto-Submit: Ben Mason <benmason@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6099@{#43} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable
pushed a commit
that referenced
this pull request
Jan 6, 2024
…121.0.6167.0-r1 to 121-6154.0-1701689968-benchmark-121.0.6167.5-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium-beta Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I1af9dfccf63eb9ce673feddec2abe439ba69f5f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5096663 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6167@{#43} Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable
pushed a commit
that referenced
this pull request
Jan 24, 2024
This treats links as buttons for simplicity. (cherry picked from commit e1ccd75) Validate-Test-Flakiness: skip Bug: 1513520 Change-Id: I7067157ea22c8add8aaf4d4fee852cdf9268ec16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5225543 Reviewed-by: Yi Gu <yigu@chromium.org> Reviewed-by: Vladimir Nechaev <nechaev@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1250868} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5232803 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#43} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
aarongable
pushed a commit
that referenced
this pull request
Feb 22, 2024
The crash happened when a module add itself to the magic stack after sending a onDataFetchFailed() response. Add an early exit to prevent the crash for now. (cherry picked from commit 0981eb1) Bug: b/325487813, b/326081541 Change-Id: I52795404f903a20d4ab8733de92c8d0f86b1aaee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310536 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by: Xinyi Ji <xinyiji@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1262814} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5317910 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6312@{#43} Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
aarongable
pushed a commit
that referenced
this pull request
Mar 20, 2024
We need to make sure a `TrayBubbleView` with `set_can_activate_on_click_or_tap_` is set as activatable on gesture taps and touch presses along with mouse presses. Bug: 329712701 (cherry picked from commit 44f48f1) Change-Id: Iec1009a9d3f52619b0868a2d39afd4edb8720cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5379168 Reviewed-by: Shuming Hao <shuminghao@google.com> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1274576} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5383666 Cr-Commit-Position: refs/branch-heads/6367@{#43} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
NaaeemMalik
pushed a commit
to SoftwarePrince/Egon-Chromium
that referenced
this pull request
Mar 22, 2024
This CL updates the ash version ['118.0.5940.0', '117.0.5920.0', '116.0.5845.67', '115.0.5790.160'] for Lacros version skew testing. This cl only affect linux-lacros config builders like linux-lacros-tester-rel, linux-lacros-rel. This cl will certainly NOT affect Lacros on-device builders (lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab, etc) or any other platforms. If this CL caused regressions, please revert and stop the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org. R=rubber-stamper@appspot.gserviceaccount.com Bug: None Change-Id: I529c581be08c37d4070840f627861dbf6f88ae59 Requires-Testing: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4771775 Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5938@{chromium#43} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
jiongle1
referenced
this pull request
in jiongle1/chromium
Mar 27, 2024
…oundaries When outputting frames in I420 format, the CAPTURE_UPDATE_RECT set by tab capture must align with subsample boundaries. Before this CL the CAPTURE_UPDATE_RECT was computed with single pixel precision. This CL expands the CAPTURE_UPDATE_RECT such that it aligns with the subsample size of 2. Test: viz_unittests Bug: 930186 Change-Id: I4358fc933ff0cfff41c9265a74e9abb351446ae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507116 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#638888}(cherry picked from commit b4d9475) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518338 Reviewed-by: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#43} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
jiongle1
referenced
this pull request
in jiongle1/chromium
Mar 27, 2024
There are some cases in which the muxer is null, which lead to crashes. Bug: 954494 Change-Id: I571d54d56c71d7a674054979a441e6645bc5ac3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578614 Reviewed-by: Miguel Casas <mcasas@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#653191}(cherry picked from commit bb460bf) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581684 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/branch-heads/3770@{#43} Cr-Branched-From: a9eee1c-refs/heads/master@{#652427}
jiongle1
referenced
this pull request
in jiongle1/chromium
Mar 27, 2024
This was broken by the new window level machinery CL. BUG=988214 TEST=as in bug (cherry picked from commit b2f6e48) Change-Id: Ifd6c132e160d6a2e29aa663ecaf87b2330322c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723749 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#681864} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726790 Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/branch-heads/3865@{#43} Cr-Branched-From: 0cdcc61-refs/heads/master@{#681094}
aarongable
pushed a commit
that referenced
this pull request
Apr 17, 2024
The DUMP_WILL_BE_CHECK()s are not currently needed now that we are reasonably certain of the cause. (cherry picked from commit efa02f2) Bug: 40936639 Fixed: 325717856 Change-Id: I0b62b4bc2b528c371d0e90eec7d596323725c08b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5455580 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by: David Bertoni <dbertoni@chromium.org> Auto-Submit: Justin Lulejian <jlulejian@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1288199} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5462383 Reviewed-by: Daniel Yip <danielyip@google.com> Owners-Override: Daniel Yip <danielyip@google.com> Cr-Commit-Position: refs/branch-heads/6422@{#43} Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
aarongable
pushed a commit
that referenced
this pull request
May 15, 2024
…jection bindings Sites can register 10s of JS objects, and sending a mojo call for each of these on navigation commit can be expensive. This change introduces an interface to lazily send the mojo pipes instead of sending them all during commit. (cherry picked from commit 2629c4b) Bug: 332706093 Change-Id: Ie39df748daff6b5bc7f6498fa4d042a5b5eb6298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5532881 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1300412} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5541862 Commit-Queue: Will Harris <wfh@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#43} Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}
aarongable
pushed a commit
that referenced
this pull request
Jun 13, 2024
This is a known bug of ViewPager2 [1] and it looks like a possible workaround is removing the offscreen page limit [2]. Tested on the emulator and it does seem to work. [1] https://issuetracker.google.com/issues/175796502?pli=1 [2] https://stackoverflow.com/q/65989153 (cherry picked from commit b826399) Bug: 341237891 Change-Id: I38e6a9b5a7a6ea0fb67bb973c25a3e3c50649d47 Fixed: 346487322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5554321 Commit-Queue: Samar Chehade-Lepleux <samarchehade@google.com> Reviewed-by: Menghan Yang <myuu@google.com> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Original-Commit-Position: refs/heads/main@{#1313379} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5625697 Auto-Submit: Samar Chehade-Lepleux <samarchehade@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6533@{#43} Cr-Branched-From: 7e0b87e-refs/heads/main@{#1313161}
aarongable
pushed a commit
that referenced
this pull request
Jul 25, 2024
Roll Chrome Linux PGO profile from chrome-linux-6613-1721767468-e7e0fc1cac2ce9404c2ea31eda6c7bee817f3fe1-365bf86683af3275adf8cdbbbf393fb15b33e646.profdata to chrome-linux-6613-1721820740-061ebfa008070d194ed1ba3be55a80289d348f1d-b51ee2dd9ff96ff1e4f3f55338eb1f4bb8e55501.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m128.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ifb878b4a82c99781a85e04789ed78772864af222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5737010 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6613@{#43} Cr-Branched-From: 03c1799-refs/heads/main@{#1331488}
aarongable
pushed a commit
that referenced
this pull request
Jul 25, 2024
... by adding a missing dependency. (cherry picked from commit 368ee33) Bug: b:353575914, b:335293501 Cq-Include-Trybots: luci.chromium.try:linux-cfm-rel Change-Id: I4d0b038fa82f0deb74a670d17180234669c620ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5719830 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1329360} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5736061 Reviewed-by: Niko Tsirakis <ntsirakis@google.com> Owners-Override: Kyle Williams <kdgwill@chromium.org> Cr-Commit-Position: refs/branch-heads/6478_182@{#43} Cr-Branched-From: 5b5d829-refs/branch-heads/6478@{#1776} Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.