Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renew Origin Trial token #26

Merged
merged 1 commit into from
Oct 3, 2016
Merged

Conversation

beaufortfrancois
Copy link
Contributor

Copy link
Collaborator

@adrifelt adrifelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive by review - lgtm

@lgarron
Copy link
Collaborator

lgarron commented Oct 3, 2016

Thanks! Do you know if we need to update USB or persistent storage, too?

@lgarron lgarron closed this Oct 3, 2016
@lgarron lgarron reopened this Oct 3, 2016
@lgarron lgarron merged commit 6e78ce9 into chromium:master Oct 3, 2016
@beaufortfrancois
Copy link
Contributor Author

Yes, we'll need to do this as well.
Pro-tip: You can use https://jpchase.github.io//OriginTrials/check-token.html and paste token to check its validity.

@beaufortfrancois beaufortfrancois deleted the patch-4 branch October 3, 2016 18:18
@lgarron
Copy link
Collaborator

lgarron commented Oct 3, 2016

Pro-tip: You can use https://jpchase.github.io//OriginTrials/check-token.html and paste token to check its validity.

If I remember correctly, they report a token as valid even if it's expired.

Just checked, and that still seems to be the case. :-/
screen shot 2016-10-03 at 11 35 22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants