-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"render_METHOD" method names violate PEP8 naming conventions #14
Comments
that naming stems from the original txthings, which seems to implement some more generic twisted interface. one could argue that the METHOD verbs of both HTTP and CoAP are always uppercased, which forms a prevailing style, but on the other hand we don't have to care much about compatibility yet (no api-stable release has been made, my concern is mainly about doing changes in a way that allows library users to easily migrate, eg. with search/replace). i'm willing to do that change, but would also accept a pull request; thanks for reporting. |
No problem. Here is the pull request. |
use render_$method callbacks (instead of render_$METHOD), as the uppercase methods violate PEP8 conventions. to follow the change, replace render_GET, render_POST, render_PUT and render_DELETE occurrences with their lower-cased counterparts.
cherry-picked and done, thank you. i've changed two minor things:
|
Sounds reasonable, thank you! |
fixed aiocoap issues: chrysn/aiocoap#14 chrysn/aiocoap#19
"render_METHOD" method names violate PEP8 naming conventions.
may be it is better to use lowercase names, "get", "post", "put", "delete" etc. ?
The text was updated successfully, but these errors were encountered: