Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Size2 sent in block-wise responses #300

Open
tautologyclub opened this issue Feb 23, 2023 · 2 comments
Open

No Size2 sent in block-wise responses #300

tautologyclub opened this issue Feb 23, 2023 · 2 comments
Assignees

Comments

@tautologyclub
Copy link

RFC 7959 states that the size2 option in a request should cause server to provide the full file size. This does not seem to happen when I try it. Not 100% positive aiocoap is to blame, but the client uses a library that supposedly works well with other coap file servers.

Is this expected?

@chrysn
Copy link
Owner

chrysn commented May 29, 2023

It does not yet (similar to how it didn't send block1 until recently).

I don't really plan to provide size2 conditional on the size2 in the request -- I consider that a slightly weird feature, and would rather send size2 unconditionally in the first block unless there are specific reasons not to do that.

@chrysn chrysn self-assigned this May 29, 2023
@chrysn chrysn changed the title does aiocoap-fileserver respect SIZE2 option? No Size2 sent in block-wise responses May 29, 2023
@chrysn
Copy link
Owner

chrysn commented May 29, 2023

Title updated as this is not exclusive to aiocoap-fileserver (and should happen on all block-wise situations when the library knows what's going on).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants