Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape messages in 'zbg stash' #7

Closed
2 tasks
chshersh opened this issue Apr 6, 2023 · 0 comments
Closed
2 tasks

Escape messages in 'zbg stash' #7

chshersh opened this issue Apr 6, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@chshersh
Copy link
Owner

chshersh commented Apr 6, 2023

Currently, messages for the zbg stash command are not escaped. This can result in weird behaviour.

zbg/lib/git.ml

Line 125 in 42bdb5c

Printf.sprintf "--message='%s'" msg (* TODO: proper escaping *)

Probably, the quote_command function from Unix should be used.

  • Escape the message argument
  • Write tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chshersh