Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.4 support #137

Open
remicollet opened this issue May 27, 2019 · 1 comment
Open

PHP 7.4 support #137

remicollet opened this issue May 27, 2019 · 1 comment

Comments

@remicollet
Copy link
Contributor

Build fails for now

At least with new php_pcre_match_impl prototype

@lijiefeng-lee
Copy link

php74 不行hp_pcre_match_impl(cache, subject, strlen(subject), result, subpats, 0, 0, 0, 0 TSRMLS_CC);
^~~~~~~
In file included from /usr/src/php/ext/molten/molten_intercept.h:38,
from /usr/src/php/ext/molten/molten_intercept.c:16:
/usr/local/include/php/ext/pcre/php_pcre.h:45:70: note: expected 'zend_string *' {aka 'struct _zend_string *'} but argument is of type 'char *'
PHPAPI void php_pcre_match_impl(pcre_cache_entry *pce, zend_string *subject_str, zval *return_value,
~~~~~~~~~~~~~^~~~~~~~~~~
/usr/src/php/ext/molten/molten_intercept.c:338:45: warning: passing argument 3 of 'php_pcre_match_impl' makes pointer from integer without a cast [-Wint-conversion]
php_pcre_match_impl(cache, subject, strlen(subject), result, subpats, 0, 0, 0, 0 TSRMLS_CC);
^~~~~~~~~~~~~~~
In file included from /usr/src/php/ext/molten/molten_intercept.h:38,
from /usr/src/php/ext/molten/molten_intercept.c:16:
/usr/local/include/php/ext/pcre/php_pcre.h:45:89: note: expected 'zval *' {aka 'struct _zval_struct *'} but argument is of type 'size_t' {aka 'long unsigned int'}
PHPAPI void php_pcre_match_impl(pcre_cache_entry *pce, zend_string *subject_str, zval *return_value,
~~~~~~^~~~~~~~~~~~
/usr/src/php/ext/molten/molten_intercept.c:338:70: warning: passing argument 5 of 'php_pcre_match_impl' makes integer from pointer without a cast [-Wint-conversion]
php_pcre_match_impl(cache, subject, strlen(subject), result, subpats, 0, 0, 0, 0 TSRMLS_CC);
^~~~~~~
In file included from /usr/src/php/ext/molten/molten_intercept.h:38,
from /usr/src/php/ext/molten/molten_intercept.c:16:
/usr/local/include/php/ext/pcre/php_pcre.h:46:21: note: expected 'int' but argument is of type 'zval *' {aka 'struct _zval_struct *'}
zval *subpats, int global, int use_flags, zend_long flags, zend_off_t start_offset);
~~~~^~~~~~
/usr/src/php/ext/molten/molten_intercept.c:338:9: error: too many arguments to function 'php_pcre_match_impl'
php_pcre_match_impl(cache, subject, strlen(subject), result, subpats, 0, 0, 0, 0 TSRMLS_CC);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants