-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace polyglot with langdetect #259
Comments
It is a good idea. We should test it and see if it detects language reliably enough. I believe, I considered it first, before switching to polyglot, and it detected languages way worse than the latter one |
I am not even sure why language is needed as all https://cheat.sh output seems to be only English. |
It is for input, not for output.
This feature is broken at the moment though, but we will fix it |
@chubin is that supposed to search only for Russian results? |
No, for any language; the feature is currently broken though |
https://github.com/aboSamoor/polyglot depends on pycld2, which depends on PyICU, which needs C compiler and tons of stuff to build, because it doesn't ship wheels.
The only
polyglot
feature what is used it language detection - https://polyglot.readthedocs.io/en/latest/Detection.htmlThis can be done with less sophisticated dependencies, such as https://github.com/Mimino666/langdetect
The text was updated successfully, but these errors were encountered: