Ignore EOL changes when checking whether script has changed #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ther script hashes match
|
Thank you. |
BiggerNoise
added a commit
that referenced
this pull request
Jan 19, 2013
Ignore EOL changes when checking whether script has changed Looks good. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we run into issues from time to time if Git hash changed EOLs between Windows \r\n and Unix \n when running scripts. This change adds checks whether hashes would match if only EOL conversion is made. If only EOL changes are present, the files are considered the same.
Does not change way the hash is calculated to database, only extra checks if original check fails.