New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore EOL changes when checking whether script has changed #104

Merged
merged 1 commit into from Jan 19, 2013

Conversation

Projects
None yet
3 participants
@lahma
Contributor

lahma commented Jan 8, 2013

Currently we run into issues from time to time if Git hash changed EOLs between Windows \r\n and Unix \n when running scripts. This change adds checks whether hashes would match if only EOL conversion is made. If only EOL changes are present, the files are considered the same.

Does not change way the hash is calculated to database, only extra checks if original check fails.

@ferventcoder

This comment has been minimized.

Show comment
Hide comment
@ferventcoder

ferventcoder Jan 14, 2013

Member

Thank you.

Member

ferventcoder commented Jan 14, 2013

Thank you.

BiggerNoise added a commit that referenced this pull request Jan 19, 2013

Merge pull request #104 from lahma/ignore-eol-changes
Ignore EOL changes when checking whether script has changed

Looks good. Thanks.

@BiggerNoise BiggerNoise merged commit 1e9e782 into chucknorris:master Jan 19, 2013

@ferventcoder ferventcoder modified the milestone: 0.8.6 Jun 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment