Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid usage of MSBuild task parameters #199

Merged
merged 1 commit into from
Jul 6, 2015

Conversation

sliekens
Copy link
Contributor

@sliekens sliekens commented Jul 6, 2015

This commit does two things:

  • converts Roundhouse.RecoveryMode to an explicit implementation of ConfigurationPropertyHolder.RecoveryMode
  • adds a property with the same name of type System.String

Both properties get and set the same private field.

Fixes #131

@ferventcoder
Copy link
Member

Pretty sure this won't affect Nant adversely as the condition is now a string. Should be pretty transparent (not that anyone is actually using the Nant task haha).

ferventcoder added a commit that referenced this pull request Jul 6, 2015
Fix invalid usage of MSBuild task parameters
@ferventcoder ferventcoder merged commit 3705b95 into chucknorris:master Jul 6, 2015
@ferventcoder
Copy link
Member

Thanks!

@sliekens
Copy link
Contributor Author

sliekens commented Jul 7, 2015

Oops. I just remembered that throwing an exception is not the best way to raise MSBuild errors.

DBDeploy_MSBuild.proj(21,5): error MSB4018: The "Roundhouse" task failed unexpectedly.\r
DBDeploy_MSBuild.proj(21,5): error MSB4018: System.ArgumentOutOfRangeException: The value of 'RecoveryMode' must be one of these values: 'NoChange', 'Simple' or 'Full'.\r
DBDeploy_MSBuild.proj(21,5): error MSB4018: Parameter name: value\r
DBDeploy_MSBuild.proj(21,5): error MSB4018: Actual value was NoChanges.\r
DBDeploy_MSBuild.proj(21,5): error MSB4018:    at roundhouse.tasks.Roundhouse.set_RecoveryMode(String value)
DBDeploy_MSBuild.proj(56,17): error MSB4026: The "RecoveryMode=NoChanges" parameter for the "Roundhouse" task is invalid.
DBDeploy_MSBuild.proj(21,5): error MSB4063: The "Roundhouse" task could not be initialized with its input parameters.

@ferventcoder
Copy link
Member

open another PR and reference this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants