Add trivial implementation of 3d biomes and 3d blur (off by default) #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leMaik
reviewed
Apr 16, 2022
leMaik
requested changes
Apr 16, 2022
aTom3333
reviewed
Apr 16, 2022
aTom3333
reviewed
Apr 16, 2022
aTom3333
reviewed
Apr 16, 2022
chunky/src/java/se/llbit/math/structures/Position2ReferenceStructure.java
Show resolved
Hide resolved
|
Still need to do #1225 (comment). Do you want me to add it to the json serialisation for the scene? It shouldn't affect anything but the |
|
Currently the only problem with this PR I see is that the biome palette indices are loaded into a structure which isn't yet implementable by anything else. Ideally we'd just have the structures be generic and it'd just work but java generics can't handle primitives :( |
leMaik
reviewed
May 22, 2022
| biomeStructureImplementation.getItems().addAll(biomeStructureNames); | ||
| biomeStructureImplementation.getSelectionModel().selectedItemProperty() | ||
| .addListener((observable, oldvalue, newvalue) -> { | ||
| scene.setBiomeStructureImplementation(newvalue); |
There was a problem hiding this comment.
A prompt (as for the emitter grid implementation) would be nice in a follow-up PR 👍
leMaik
reviewed
May 22, 2022
leMaik
approved these changes
May 22, 2022
In the future it would be great to add a better implementation for performance - this is good enough for now
BiomeStructure now completely replaces WorldTexture, which are now loaded as BiomeStructures if the octree format is outdated Add biomeBlending toggle Add reload chunks confirmation on relevant changes to biome settings (with minor jank due to no snapshotting) Refactoring of the BiomeStructure implementations
…ementations are stored for futures reference
Return a default implementation instead of null for an invalid BiomeStructure registry key similar to how the octree factory works
…dices implementation It defaults to the previous implementation
NotStirred
force-pushed
the
feature/render_3d_biomes
branch
from
01941b8
to
cf6a04a
Compare
leMaik
added
the
minecraft
NotStirred
added a commit
to NotStirred/chunky
that referenced
this pull request
Apr 3, 2023
* Add trivial implementation of 3d biomes and 3d blur (off by default) In the future it would be great to add a better implementation for performance - this is good enough for now * Rename using3dBiomes->use3dBiomes * Fixes and refactoring to trivial implementation datastructures * Complete implementing BiomeStructure BiomeStructure now completely replaces WorldTexture, which are now loaded as BiomeStructures if the octree format is outdated Add biomeBlending toggle Add reload chunks confirmation on relevant changes to biome settings (with minor jank due to no snapshotting) Refactoring of the BiomeStructure implementations * Add additional javadoc describing how the trivial BiomeStructure implementations are stored for futures reference * Remove incorrectly boxed int due to changed implementation * Add better error handling for BiomeStructure registry usage and loading itself * Add selection option for BiomeStructure in the UI Return a default implementation instead of null for an invalid BiomeStructure registry key similar to how the octree factory works * Implement better hashing for xyz positions * Add BiomeStructure.Factory.createIndexStructure, for biome palette indices implementation It defaults to the previous implementation * Simplify initial checkbox disable logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future it would be great to add a better implementation for performance