Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing parent styles in code snippet #3

Closed
lauriejones opened this issue Mar 4, 2018 · 1 comment
Closed

Missing parent styles in code snippet #3

lauriejones opened this issue Mar 4, 2018 · 1 comment

Comments

@lauriejones
Copy link

lauriejones commented Mar 4, 2018

Hi there! Nice work on this. It's a cool tool for a quick reference 🙂

I noticed this one scenario didn't quite make sense:

image

  1. This only works because of the text-align: center; on the parent element. That should probable be included in the code snippet 👍

  2. I've specified block not inline-* so a solution with inline-block doesn't quite make sense. (I know that it kinda has to be inline block for this scenario to work, so maybe the questions should be adjusted).

Just thought I'd let you know 🙂

@chunqiuyiyu
Copy link
Owner

@lauriejones I am glad that you like it an thanks for your advice!

  1. It is correct to add the relevant code of parent element. I will fix it.
  2. How do you think the questions should be adjusted?

I think that CSS is very complicated. Sometimes we can't put element into right position, maybe we should think the problem of layer. This reference is just for beginner, Good practice depends on your own project and actual demand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants