Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix document_ref.set function for SetOption working #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hi-jin
Copy link

@hi-jin hi-jin commented Sep 23, 2023

Hi, I'm a mobile application developer using your localstore library!
This is a pull request for better functionality.

Before this commit

document_ref.set(
    {
        "data": "something",
    },
    SetOption(merge: true),
);

doesn't work.
Because _data doesn't have the document data.
So empty Map + {"data": "something"} just go into the existing doc. (In fact, this is merge: false)

After this commit

SetOption works properly.

Related Issue

Closes #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SetOption(merge: true) not working
1 participant