Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save button transparently hangs #71

Closed
alerque opened this issue Jan 5, 2024 · 1 comment · Fixed by #83
Closed

Save button transparently hangs #71

alerque opened this issue Jan 5, 2024 · 1 comment · Fixed by #83
Labels
bug Something isn't working

Comments

@alerque
Copy link

alerque commented Jan 5, 2024

I just gave NanoLedger v0.8.0 a spin and ran into a fairly confusing UX issue.

When entering a new transaction the "save" button (check box in floating action button bar) would frequently be non-functional.

First a minor detail: the "greyed out" non-active color scheme was not apparent, so even before there was a valid balanced transaction I was confused why it didn't work.

But then after it did activate, pressing it frequently got no response. My first transaction worked fine, but the second one took me a whole bunch of tries and I couldn't figure out why. I still didn't understand the active/non active color scheme, so I thought something was wrong with my transaction and kept fiddling with it.

Eventually it went through with no apparent reason why.

During later attempts a couple times I saw a toast message a few seconds after hitting the non-responsive button a few times about "unable to write file". No details just a brief toast that disappears. Eventually the save works if I press it enough times. I think the save must be hanging while the file backed (Nextcloud in my case) resolves and confirms a file sync.

It might be good that this is a blocker, but there should be some sort of feedback in the UI that a save attempt is underway at the very least and maybe something more prominent than an ephemeral toast when it fails.

@alerque alerque added the bug Something isn't working label Jan 5, 2024
@chvp
Copy link
Owner

chvp commented Jan 5, 2024

Transforming the button into a spinner is probably a good idea. Nextcloud can be somewhat unreliable for saving a file if it was recently edited. I could probably make the toast a snackbar with a button that shows more details, but I don't think there is much more I can do about that.

@alerque alerque changed the title Save button hangs Save button transparently hangs Jan 5, 2024
@chvp chvp closed this as completed in #83 Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants