Parameter sorting and encoding

[novemberborn]

Reading through http://tools.ietf.org/html/rfc5849:

3.4.1.3.2. Parameters Normalization

The parameters collected in Section 3.4.1.3 are normalized into a
single string as follows:

1. First, the name and value of each parameter are encoded
   (Section 3.6).
2. The parameters are sorted by name, using ascending byte value
   ordering. If two or more parameters share the same name, they
   are sorted by their value.

However, in node-oauth:

exports.OAuth.prototype._normaliseRequestParams= function(arguments) {
  var argument_pairs= this._sortRequestParams( arguments );
  var args= "";
  for(var i=0;i<argument_pairs.length;i++) {
      args+= this._encodeData( argument_pairs[i][0] );
      args+= "="
      args+= this._encodeData( argument_pairs[i][1] );
      if( i < argument_pairs.length-1 ) args+= "&";
  }     
  return args;
}

I.e. the params are sorted before they are encoded.

[ciaranj]

Good catch!

[novemberborn]

Wow, Github website isn't showing the second part of your comment.

Regarding #7, it's possible this might result in different base strings and therefore a signature mismatch.

[ciaranj]

Ah, yes thats because I edited it almost immediately when I realised that isn't the issue with #7 as that particular issue is about the parameter values not the parameter names, so the order should remain the same :)

[ciaranj]

One day I'll get the hang of the Github-foo for auto-closing based on my git commits, for now though: caebbc2 resolves this issue :)

Thank you for raising it, I also found some other issues around using repeated parameters whilst writing tests for it :)