Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: Separate Args and Signature #1630

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

johanrd
Copy link
Contributor

@johanrd johanrd commented Jan 6, 2024

IfElement and Blocks is included in the main component interface, Args needs its own property.

I had the following glint 2345 error when consuming the PowerSelect component, as it expected Element and Blocks to be passed in as required arguments:

NamedArgs<PowerSelectArgs> (…) is missing the following properties from type 'PowerSelectArgs': Element, destination, Blocks glint(2345)

@johanrd
Copy link
Contributor Author

johanrd commented Jan 6, 2024

fixes #1585

@mkszepp mkszepp added the bug label Jan 7, 2024
@mkszepp mkszepp merged commit 923863f into cibernox:master Jan 7, 2024
19 checks passed
@mkszepp
Copy link
Collaborator

mkszepp commented Jan 7, 2024

Thank you!

@mkszepp mkszepp mentioned this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants