Merge pull request #1630 from johanrd/separate-args-and-signature

types: Separate Args and Signature
cibernox · Jan 7, 2024 · 923863f · 923863f
2 parents eccfc2d + 074b993
commit 923863f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/ember-power-select/src/components/power-select-multiple.ts b/ember-power-select/src/components/power-select-multiple.ts
@@ -1,13 +1,13 @@
 import Component from '@glimmer/component';
 import { action } from '@ember/object';
 import { isEqual } from '@ember/utils';
-import type { PowerSelectArgs, Select } from './power-select';
+import type { PowerSelectSignature, Select } from './power-select';
 
-interface PowerSelectMultipleArgs extends PowerSelectArgs {
+interface PowerSelectMultipleSignature extends PowerSelectSignature {
   // any extra property for multiple selects?
 }
 
-export default class PowerSelectMultipleComponent extends Component<PowerSelectMultipleArgs> {
+export default class PowerSelectMultipleComponent extends Component<PowerSelectMultipleSignature> {
   get computedTabIndex() {
     if (this.args.triggerComponent === undefined && this.args.searchEnabled) {
       return '-1';

diff --git a/ember-power-select/src/components/power-select.ts b/ember-power-select/src/components/power-select.ts
@@ -59,7 +59,6 @@ interface Performable {
 }
 // Some args are not listed here because they are only accessed from the template. Should I list them?
 export interface PowerSelectArgs {
-  Element: HTMLElement;
   highlightOnHover?: boolean;
   placeholderComponent?: string | ComponentLike<any>;
   searchMessage?: string;
@@ -120,6 +119,11 @@ export interface PowerSelectArgs {
   onBlur?: (select: Select, event: FocusEvent) => void;
   scrollTo?: (option: any, select: Select) => void;
   registerAPI?: (select: Select) => void;
+}
+
+export interface PowerSelectSignature {
+  Element: HTMLElement;
+  Args: PowerSelectArgs;
   Blocks: {
     default: [option: any, select: Select];
   };
@@ -143,7 +147,7 @@ const isCancellablePromise = <T>(
   return typeof thing.cancel === 'function';
 };
 
-export default class PowerSelectComponent extends Component<PowerSelectArgs> {
+export default class PowerSelectComponent extends Component<PowerSelectSignature> {
   // Untracked properties
   _publicAPIActions = {
     search: this._search,