Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to github's length of sha #9

Closed
wants to merge 1 commit into from
Closed

Conversation

hakubo
Copy link

@hakubo hakubo commented Feb 29, 2016

7 sounds almost exactly as arbitrary as 8 :)

I can add configuration in a script that uses this package, but 7 sounds like a better default in a world ruled by github.

7 sounds almost exactly as arbitrary as 8 :)

I can add configuration in a script that uses this package, but 7 sounds like a better default in a world ruled by github.
@luxzeitlos
Copy link

luxzeitlos commented Apr 20, 2018

I disagree. We should stay close to git describe --tags. And this returns 8 chars.

Just my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants