-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove layers of abstraction #64
Comments
whats the downside? |
what about complexity and boilerplate code? I've had a chat in slack with @twokul about #49 and we've encountered this confusion. But I also got confused about which repo is which far to often myself. Also for most changes this means we have to change 2 or maybe even 3 repos. This makes contribution harder. |
@luxferresum i think you misunderstand, I agree with you. I am merely asking if you have identified any downsides? |
@stefanpenner yes, sorry, I totally misunderstood! I only see one downside: We probably will loose maintainers for |
@luxferresum i think thats fine. cc @cibernox thoughts? |
sure, if you find it useful let's cut the middleman |
I'm happy to add more maintainers to rwjblue/git-repo-info also. It has at least @hjdivad and myself, but can also add @stefanpenner and @cibernox if they want... |
Currently we have
ember-cli/ember-cli-app-version
which usescibernox/git-repo-version
which usesrwjblue/git-repo-info
. I think this is too much complexity for this problem.Also I think more and better configuration would be nice for
ember-cli-app-version
.Also it seems (#49, #50, cibernox/git-repo-version#9) that we need some configuration.
Ideally I think would be to have some kind of template string the user can provide, to specify which information in which order should be shown. At least we should have a way to display everything provided by
rwjblue/git-repo-info
.My suggestion is to remove
cibernox/git-repo-version
and directly rely onrwjblue/git-repo-info
. Then we could allow the user to provide a format function that takes the info fromrwjblue/git-repo-info
and have a sane default. Also we could provide theprefix
, which calculation is currently the most complex thinggit-repo-version/index.js
does.something like this looks like a possible solution in my opinion:
any thoughts?
The text was updated successfully, but these errors were encountered: