Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CD) misc. corrections on the "CD" chapter #104

Merged
merged 7 commits into from
Mar 12, 2023

Conversation

dduportal
Copy link
Contributor

Follows up #103 . You can review this one per commit as it is a set of minor fixes on the CD chapter (e.g. no fundamental changes).

I plan a forthcoming refinment on the deployment steps (not sure yet if it is needed) after a step by step review of the exercises

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
…icd-lectures#103)

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal changed the title misc fixed on the "CD" chapter fix(CD) misc. corrections on the "CD" chapter Mar 11, 2023
@dduportal dduportal added the bug Something isn't working label Mar 11, 2023
@dduportal dduportal marked this pull request as ready for review March 11, 2023 15:05
@dduportal dduportal requested a review from jlevesy March 11, 2023 15:05
@jlevesy jlevesy merged commit b568fba into cicd-lectures:2023 Mar 12, 2023
@dduportal dduportal deleted the fix/cd branch March 12, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants