Visualizations post ChiRho #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Visualization tests depend on new version.
Histogram picks up label from series (if present)
Visual refinements for reference points (larger marker, dotted connector). Multi-point example trace added.
SamWitty
reviewed
Feb 6, 2024
| pyciemss_results["parameters"][name] = ( | ||
| sample.data.detach().cpu().numpy().astype(np.float64) | ||
| ) | ||
| else: | ||
| name = name + "_state" | ||
| name = name + "_state" if not (name.endswith("_state")) else name |
There was a problem hiding this comment.
Nice! I was going to look into why _state was being repeated twice, but this addressed it.
There was a problem hiding this comment.
A whole bunch fiddly little things in this world.
I had another one that didn't append _state if it was an _observable but that wasn't obviously the right thing to do (it made labels look a little better which is why I did it) AND broke other tests so I changed that back. Something to consider in the future.
SamWitty
approved these changes
Feb 7, 2024
This was referenced Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-instating the visualization tools.
Includes an overhaul of the visualization tests: