Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test_roundtrip_large_request timeout #91

Merged
merged 3 commits into from
Jul 27, 2019
Merged

Increase test_roundtrip_large_request timeout #91

merged 3 commits into from
Jul 27, 2019

Conversation

twm
Copy link
Collaborator

@twm twm commented Jul 23, 2019

Hopefully closes #66.

@twm twm requested a review from a team July 23, 2019 23:42
@twm
Copy link
Collaborator Author

twm commented Jul 23, 2019

I've run the build a few times now without failure, so this may be all we needed! 🎉

rthille
rthille reviewed Jul 25, 2019
View reviewed changes
afkak/test/int/test_client_integration.py
@@ -39,7 +39,7 @@ class TestAfkakClientIntegration(IntegrationMixin, unittest.TestCase):
message_max_bytes=12 * 1048576, # 12 MB
)
client_kw = dict(
timeout=2500,
timeout=30000, # Large timeout because Travis is slow.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

@twm
Copy link
Collaborator Author

twm commented Jul 27, 2019

Thanks so much @rthille!

@twm twm merged commit 9be205a into master Jul 27, 2019
@twm twm deleted the roundtrip-large-request branch July 27, 2019 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rthille rthille rthille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestAfkakClientIntegration.test_roundtrip_large_request assertion error
2 participants
@twm @rthille