Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test_roundtrip_large_request timeout #91

Merged
merged 3 commits into from
Jul 27, 2019
Merged

Increase test_roundtrip_large_request timeout #91

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6cf0b6d
Add some debug logs
twm Jul 9, 2019
c60ce65
test_roundtrip_large_request: increase fetch timeout
twm Jul 23, 2019
bbd6cff
Bump both timeouts
twm Jul 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions afkak/test/int/test_client_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class TestAfkakClientIntegration(IntegrationMixin, unittest.TestCase):
message_max_bytes=12 * 1048576, # 12 MB
)
client_kw = dict(
timeout=2500,
timeout=30000, # Large timeout because Travis is slow.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

)

@kafka_versions("all")
Expand Down Expand Up @@ -109,9 +109,11 @@ def test_roundtrip_large_request(self):
self.assertEqual(produce_resp.partition, 0)
self.assertEqual(produce_resp.offset, 0)

log.debug('Sending FetchRequest')
# Fetch request with max size of 1 MiB
fetch = FetchRequest(self.topic, 0, 0, 1024 ** 2)
fetch_resp, = yield self.client.send_fetch_request([fetch], max_wait_time=1000)
[fetch_resp] = yield self.client.send_fetch_request([fetch], max_wait_time=10000)
log.debug('Got FetchResponse %r', fetch_resp)
self.assertEqual(fetch_resp.error, 0)
self.assertEqual(fetch_resp.topic, self.topic)
self.assertEqual(fetch_resp.partition, 0)
Expand Down