Package name: cihai[cli] -> cihai-cli
#279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having to use an extra package made it much harder to pin and deploy packages. We may look into this again in the future.
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
=======================================
Coverage 75.44% 75.44%
=======================================
Files 5 5
Lines 224 224
=======================================
Hits 169 169
Misses 55 55 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tony
force-pushed
the
remove-extras-package
branch
2 times, most recently
from
7948273
to
6598b09
Compare
tony
added a commit
to cihai/cihai
that referenced
this pull request
Aug 20, 2022
**#326, cihai/cihai-cli#279 The CLI version of `cihai` installed through `cihai-cli` again Old (cihai 0.9 to 0.14, cihai-cli 0.5 to 0.10): ```console $ pip install cihai[cli] ``` After (cihai 0.15+, cihai-cli 0.11+): ```console $ pip install cihai-cli ``` This made deploying cihai + cihai-cli and pinning packages extremely laborious. We can reinvestigate this model in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cihai/cihai#326, #279
The CLI version of
cihaiinstalled throughcihai-cliagainOld (cihai 0.9 to 0.14, cihai-cli 0.5 to 0.10):
$ pip install cihai[cli]After (cihai 0.15+, cihai-cli 0.11+):
$ pip install cihai-cliThis made deploying cihai + cihai-cli and pinning packages extremely laborious.
We can reinvestigate this model in the future.