Skip to content

Commit

Permalink
Package name: cihai[cli] -> cihai-cli (#326)
Browse files Browse the repository at this point in the history
**#326, cihai/cihai-cli#279

The CLI version of `cihai` installed through `cihai-cli` again

Old (cihai 0.9 to 0.14, cihai-cli 0.5 to 0.10):

```console
$ pip install cihai[cli]
```

After (cihai 0.15+, cihai-cli 0.11+):

```console
$ pip install cihai-cli
```

This made deploying cihai + cihai-cli and pinning packages extremely laborious.

We can reinvestigate this model in the future.
  • Loading branch information
tony committed Aug 20, 2022
2 parents 000e4f8 + b13dab9 commit f68f9f4
Show file tree
Hide file tree
Showing 4 changed files with 33 additions and 28 deletions.
26 changes: 25 additions & 1 deletion CHANGES
@@ -1,9 +1,33 @@
# Changelog

## cihai 0.15.x (unreleased)
## cihai 0.16.x (unreleased)

- _Insert changes/features/fixes for next release here_

## cihai 0.15.0 (2022-08-20)

### Breaking changes

The CLI version of `cihai` installed through `cihai-cli` again

Before (cihai 0.9 to 0.14, cihai-cli 0.5 to 0.10):

```console
$ pip install cihai[cli]
```

After (cihai 0.15+, cihai-cli 0.11+):

```console
$ pip install cihai-cli
```

This made deploying cihai + cihai-cli and pinning packages extremely laborious.

We can reinvestigate this model in the future.

via: **[cihai#326](https://github.com/cihai/cihai/pull/326)**, [cihai-cli#279](https://github.com/cihai/cihai-cli/pull/279)

## cihai 0.14.1 (2022-08-20)

- Bump cihai-cli to 0.10.0
Expand Down
3 changes: 2 additions & 1 deletion README.md
Expand Up @@ -37,7 +37,7 @@ See [API](https://cihai.git-pull.com/api.html) documentation and
### CLI ([cihai-cli](https://cihai-cli.git-pull.com))

```console
$ pip install --user 'cihai[cli]'
$ pip install --user 'cihai-cli'
```

Character lookup:
Expand All @@ -58,6 +58,7 @@ ucn: U+597D
```

Reverse lookup:

```console
$ cihai reverse library
char: 圕
Expand Down
30 changes: 6 additions & 24 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions pyproject.toml
Expand Up @@ -57,7 +57,6 @@ kaptan = "*"
sqlalchemy = "<1.4"
appdirs = "*"
unihan-etl = "~=0.15.0"
cihai-cli = { version = "~=0.10.0", optional = true }

[tool.poetry.dev-dependencies]
### Docs ###
Expand Down Expand Up @@ -96,7 +95,6 @@ types-appdirs = "^1.4.3"
types-colorama = "^0.4.15"

[tool.poetry.extras]
"cli" = ["cihai-cli"]
docs = [
"docutils",
"sphinx",
Expand Down

0 comments on commit f68f9f4

Please sign in to comment.