mypy: --strict type checking
#298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 17, 2022
tony
force-pushed
the
strict-mypy
branch
3 times, most recently
from
1b1cb59
to
b34c592
Compare
tony
added a commit
to cihai/unihan-etl
that referenced
this pull request
Aug 21, 2022
**#257, cihai/unihan-db#298, cihai/cihai#324, cihai/cihai-cli#277 Ramp up type safety / create a typed library
tony
force-pushed
the
strict-mypy
branch
5 times, most recently
from
a6dd915
to
c2a7936
Compare
tony
force-pushed
the
strict-mypy
branch
3 times, most recently
from
cc6dc3e
to
0240365
Compare
tony
force-pushed
the
strict-mypy
branch
2 times, most recently
from
cf640b5
to
5967589
Compare
This was hard to mixin via type annotations
make monkeytype_create monkeytype_apply black isort
tony
added a commit
that referenced
this pull request
Jun 10, 2023
Fixes #310, #312 Closes #298 SQLAlchemy v2: - https://docs.sqlalchemy.org/en/20/changelog/migration_20.html - https://docs.sqlalchemy.org/en/20/changelog/whatsnew_20.html mypy: - --strict: https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-strict
tony
added a commit
to cihai/unihan-etl
that referenced
this pull request
Sep 2, 2023
**#257, cihai/unihan-db#298, cihai/cihai#324, cihai/cihai-cli#277 Ramp up type safety / create a typed library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cihai/unihan-etl#257, #298, cihai/cihai#324, cihai/cihai-cli#277
Ramp up type safety / create a typed library