Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLAlchemy v2 + mypy strict typings / annotations #311

Merged
merged 6 commits into from
Jun 10, 2023

docs(CHANGES): Note SQLAlchemy 2 / mypy strict

8eaa5ea
Select commit
Loading
Failed to load commit list.
Merged

SQLAlchemy v2 + mypy strict typings / annotations #311

docs(CHANGES): Note SQLAlchemy 2 / mypy strict
8eaa5ea
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jun 10, 2023 in 1s

67.57% (-21.55%) compared to 3db49b3

View this Pull Request on Codecov

67.57% (-21.55%) compared to 3db49b3

Details

Codecov Report

Merging #311 (8eaa5ea) into master (3db49b3) will decrease coverage by 21.55%.
The diff coverage is 34.89%.

@@             Coverage Diff             @@
##           master     #311       +/-   ##
===========================================
- Coverage   89.11%   67.57%   -21.55%     
===========================================
  Files           7        7               
  Lines         579      623       +44     
  Branches       79       79               
===========================================
- Hits          516      421       -95     
- Misses         51      197      +146     
+ Partials       12        5        -7     
Impacted Files Coverage Δ
src/unihan_db/importer.py 2.14% <1.80%> (-80.77%) ⬇️
src/unihan_db/bootstrap.py 37.00% <48.38%> (-18.44%) ⬇️
src/unihan_db/tables.py 100.00% <100.00%> (ø)
tests/conftest.py 98.30% <100.00%> (+0.22%) ⬆️
tests/test_bootstrap.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more