add_to_dict(): Fix mapping of to_dict()
#325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #325 +/- ##
==========================================
+ Coverage 69.21% 69.77% +0.55%
==========================================
Files 9 9
Lines 653 655 +2
Branches 87 88 +1
==========================================
+ Hits 452 457 +5
+ Misses 195 192 -3
Partials 6 6 ☔ View full report in Codecov by Sentry. |
tony
force-pushed
the
fix-mapping-callback
branch
from
a425f3e
to
35260bc
Compare
tony
commented
Dec 10, 2023
|
Note: The current iteration raises this issue: https://github.com/cihai/unihan-db/pull/325/files#r1421758684 |
unihan-db-tpeMWywt-py3.12/lib/python3.12/site-packages/sqlalchemy/event/registry.py:291: in listen
dispatch_collection = getattr(target.dispatch, identifier)
E AttributeError: 'registry' object has no attribute 'dispatch'
See also: https://docs.sqlalchemy.org/en/20/orm/events.html#sqlalchemy.orm.MapperEvents.after_configured
!squash
tony
force-pushed
the
fix-mapping-callback
branch
from
35260bc
to
d820781
Compare
tony
force-pushed
the
fix-mapping-callback
branch
from
d820781
to
1a52329
Compare
tony
changed the title
add_to_dict(): Move to Mapperadd_to_dict(): Fix mapping of to_dict()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #322
See also: https://docs.sqlalchemy.org/en/20/orm/events.html#sqlalchemy.orm.MapperEvents.after_configured