Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyproject(ruff): Add pydocstyle rule selector w/ numpy convention #322

Merged
merged 19 commits into from
Dec 10, 2023
Merged

pyproject(ruff): Add pydocstyle rule selector w/ numpy convention #322

merged 19 commits into from
Dec 10, 2023

Conversation

tony
Copy link
Member

@tony tony commented Dec 3, 2023

@tony tony force-pushed the pydocstyle branch 2 times, most recently from c52e2b0 to 7ba4617 Compare December 9, 2023 12:03
@tony tony force-pushed the pydocstyle branch 3 times, most recently from 624d36b to 464e8d1 Compare December 10, 2023 12:06
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8af2570) 68.01% compared to head (8ba3d3e) 69.21%.

Files Patch % Lines
conftest.py 91.17% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
+ Coverage   68.01%   69.21%   +1.20%     
==========================================
  Files           7        9       +2     
  Lines         619      653      +34     
  Branches       78       87       +9     
==========================================
+ Hits          421      452      +31     
- Misses        193      195       +2     
- Partials        5        6       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tony
pyproject(ruff): Add pydocstyle rule selector w/ numpy convention
e0fe081
@tony
ruff(pydocstyle): Run automated fixes
acef765 
`ruff --show-fixes --fix-only .`

Fixed 1 error:
- src/unihan_db/bootstrap.py:
    1 × D202 (no-blank-line-after-function)

Fixed 1 error (2 additional fixes available with `--unsafe-fixes`).
@tony
ruff(pydocstyle): Run automated fixes (unsafe ones)
27025dc 
`ruff --show-fixes --fix-only --unsafe-fixes .`

Fixed 2 errors:
- docs/conf.py:
    1 × D400 (ends-in-period)
- src/unihan_db/tables.py:
    1 × D400 (ends-in-period)

Fixed 2 errors.
@tony
tests(bootstrap): Note pydocstyle updates
55d8efd
@tony
tests: Stub out __init__.py for relative imports
1899a1b
@tony
tests(bootstrap): Import UnihanOptions from conftest
22b24b5
@tony
tests(conftest): pydocstyle manual fixes
efbf5fe
@tony
tests(__init__): Note pydocstyle updates
a64ba93
@tony
tables: Note pydocstyle updates
0a027bb
@tony
importer: Note pydocstyle updates
4fc7f6b
@tony
bootstrap: Note pydocstyle updates
ac23138
@tony
__init__: Note pydocstyle updates
ba73a92
@tony
chore(__about__): pydocstyle manual fixes
3ea1d72
@tony
example(01_bootstrap): pydocstyle manual fixes
512ceae
@tony
docs(conf): pydocstyle manual fixes
193c13c
@tony
Add UnihanOptions to tests.types
2237713
@tony
Types: Use UnihanOptions from tests/types.py
1be414e
@tony
Add root-level conftest.py
b5ae14b
This was referenced Dec 10, 2023
Merged
Merged
@tony tony marked this pull request as ready for review December 10, 2023 13:47
@tony tony merged commit 5f90cea into master Dec 10, 2023
9 checks passed
@tony tony deleted the pydocstyle branch December 10, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tony