-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for image digests in helm charts #15186
Conversation
8f7b667
to
7285ea1
Compare
@@ -193,7 +193,11 @@ spec: | |||
{{- with .Values.extraEnv }} | |||
{{ toYaml . | trim | indent 8 }} | |||
{{- end }} | |||
{{- if .Values.image.useDigest }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason not to use .Values.image.digest here directly (i.e. check if .Values.image.digest is not empty) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sayboras see #15185 (comment) if it makes sense
7285ea1
to
cd32f05
Compare
This commit adds a simple way to add the image digests into the official helm charts. Signed-off-by: André Martins <andre@cilium.io>
Having files with the right format will make it easier to download them locally and use them as part of the release process. Signed-off-by: André Martins <andre@cilium.io>
The SHAs are available in the GH run, so we can use the GH API to retrieve them automatically. Signed-off-by: André Martins <andre@cilium.io>
Dependabot will update those commit SHAs automatically and the version number will quickly outdated. To avoid confusion, we will remove the comments related with the versions a SHA points to from all GH actions. Signed-off-by: André Martins <andre@cilium.io>
cd32f05
to
516234d
Compare
test-backport-1.9 |
test-1.12-netnext |
hit #15244 |
Read per commit