Add support for image digests in helm charts #15186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
backport/1.9
kind/backports
aanm
added
the
release-note/misc
aanm
force-pushed
the
pr/fixing-helm-v1.9
branch
from
8f7b667
to
7285ea1
Compare
sayboras
reviewed
Mar 4, 2021
| @@ -193,7 +193,11 @@ spec: | |||
| {{- with .Values.extraEnv }} | |||
| {{ toYaml . | trim | indent 8 }} | |||
| {{- end }} | |||
| {{- if .Values.image.useDigest }} | |||
There was a problem hiding this comment.
any reason not to use .Values.image.digest here directly (i.e. check if .Values.image.digest is not empty) ?
There was a problem hiding this comment.
@sayboras see #15185 (comment) if it makes sense
joestringer
approved these changes
Mar 5, 2021
joestringer
reviewed
Mar 5, 2021
aanm
force-pushed
the
pr/fixing-helm-v1.9
branch
from
7285ea1
to
cd32f05
Compare
This commit adds a simple way to add the image digests into the official helm charts. Signed-off-by: André Martins <andre@cilium.io>
Having files with the right format will make it easier to download them locally and use them as part of the release process. Signed-off-by: André Martins <andre@cilium.io>
The SHAs are available in the GH run, so we can use the GH API to retrieve them automatically. Signed-off-by: André Martins <andre@cilium.io>
Dependabot will update those commit SHAs automatically and the version number will quickly outdated. To avoid confusion, we will remove the comments related with the versions a SHA points to from all GH actions. Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/fixing-helm-v1.9
branch
from
cd32f05
to
516234d
Compare
|
test-backport-1.9 |
|
test-1.12-netnext |
|
hit #15244 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read per commit