Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-doctor: Bump minimum hub version requirement for backporting #16734

Merged
merged 1 commit into from
Jul 8, 2021
Merged

dev-doctor: Bump minimum hub version requirement for backporting #16734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion tools/dev-doctor/rootcmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,8 @@ func rootCmdRun(cmd *cobra.Command, args []string) {
ifNotFound: checkError,
versionArgs: []string{"--version"},
versionRegexp: regexp.MustCompile(`hub\s+version\s+(\d+.\d+\.\d+)`),
minVersion: &semver.Version{Major: 2, Minor: 0, Patch: 0},
minVersion: &semver.Version{Major: 2, Minor: 14, Patch: 0},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While at it, shall we also suggest steps to install this particular version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea - added hint.

hint: `Download the latest version from https://github.com/github/hub/releases.`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to have installation steps. Perhaps this link - https://github.com/github/hub? I'll leave it to you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The https://github.com/github/hub link actually contains incorrect installation steps for us. It recommends installing hub with your distro's package manager, which will generally get you a version of hub that's too old.

},
&envVarCheck{
name: "GITHUB_TOKEN",
Expand Down